Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)
Merged #1740. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1740#event-1422855689
Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)
OK. @elextr 4 is not a real reason, GP is voluntarily forgiving on non-critical things because it's more of an aggregate itself () then a single project. @codebrainz warnings are mostly useless in CI builds unless the CI can report them directly, nobody actually read a successful build's log. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1740#issuecomment-357394540
Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)
:+1:, at most this should be a warning. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1740#issuecomment-357366468
[Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because: 1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer. 2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower. 3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1740 -- Commit Summary -- * Remove requirement to fail build on aggregate return -- File Changes -- M .travis.yml (2) -- Patch Links -- https://github.com/geany/geany/pull/1740.patch https://github.com/geany/geany/pull/1740.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1740
