Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-13 Thread Thomas Martitz
That's fine with me

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691659329

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-13 Thread Enrico Tröger
> On the other hand, nobody knows for sure when 5 will be released, so why 
> artificially wait?

I don't mind if we wait for 5 or just upgrade to 4.
But we should still update Scintilla 3.x in current master and get it released. 
Afterwards, an upgrade to 4 or 5 is perfectly fine. I just want to get a new 
release with the current 3.x release for users with old compilers (if there are 
any at all).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691658763

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-13 Thread Thomas Martitz
Not sure why we should skip 4 just because 5 comes soon. That doesn't mean we 
have to make a release containing 4 though, but we can gather experience in 
preparation for 5.

In my local branch scintilla 4 required no changes to Geany itself so it's a 
no-brainer.

On the other hand, nobody knows for sure when 5 will be released, so why 
artificially wait?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691657617

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-13 Thread elextr
> FWIW i have a local branch with scintilla 4, looking good

Since Scintilla 5 with API changes is likely the next release, it is probably 
best for Geany itself to skip version 4 and go straight to version 5 since 
(IIUC) there will be no changes of dependencies or required compiler versions 
between those two.  And any changes you have made for version 4 will hopefully 
be useful for Scintilla version 5.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691619454

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-12 Thread Thomas Martitz
FWIW i have a local branch with scintilla 4, looking good

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691612341

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-12 Thread elextr
Oh, 3.21.1 just released and is probably the last 3.x, maybe just jump straight 
to it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691593549

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-09-12 Thread elextr
WFM LM20 GTK3.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-691592822

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-08-28 Thread Skif-off
Thanks! I tried yesterday, works fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-682724954

Re: [Github-comments] [geany/geany] Update Scintilla to version 3.21.0 (#2506)

2020-08-25 Thread Enrico Tröger
Updated this PR to contain the update to Scintilla 3.21.0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2506#issuecomment-680279978