Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)

[Matthew Brush]

Closing due to previous comments.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/317#issuecomment-537767292

Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)

[Matthew Brush]

Closed #317.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/317#event-2682650519

Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)

[elextr]

Since it has conflicts and the plugin is orphaned and nobody has done anything 
for some years I'd say its fair enough to just close.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/317#issuecomment-537718101

Re: [Github-comments] [geany/geany-plugins] Changes from Wolfgang Schwarz (#317)

[LarsGit223]

> -fixed a bug when one selects text from right to left and then shifts it
> (see comment "in case selection_start was after selection_end" in my code)

This seems to already have been fixed by @b4n in 
dc0af51b96d4b98ada550d464b0cd17b24268419. I cannot reproduce any issue on 
selecting text from the right and shifting it. Works fine.

> -When no text is selected, now the current word is exchanged with the
> next/previous, which I find quite useful.

IMHO this does not fit into this plugin. If someone needs it then a new PR to a 
different plugin where it fits in or a new plugin is welcome.

I vote for closing this un-merged. What do the others think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/317#issuecomment-537664876