Let's try to make cppcheck work again, and even report useful stuff.
During the journey it found a few actual issues, which is good. It also found some false-positives, which isn't so good. We probably could reduce the false positives by not using `--library=gtk`, but that also would reduce the actual issues it can find. There are a few issues that should be reported upstream, but it's harder than it looks… if I could only remember my password on their tracker :confused: Anyway, what do you guys think? Is it good? Are there too many false-positives? Should the suppressions be moved back to `AM_CPPCHECKFLAG`s not to alter the code, although it makes it harder to maintain? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1346 -- Commit Summary -- * cppcheck: Enable parallelism to match Make call * cppcheck: Properly define GETTEXT_PACKAGE globally * cppcheck: Undefine GEANY_PRIVATE * cppcheck: Use cppcheck's own gtk support * cppcheck: Define the common plugin defines to their actual values * ci: Enable exhaustive cppcheck checking * cppcheck: Enable inline suppression hints * addons: Fix memory leak detected by cppcheck * geanyprj: Fix memory leak detected by cppcheck * workbench: Fix memory leak detected by cppcheck * geniuspaste: Fix memory leak detected by cppcheck * markdown: Slightly rewrite two tests for cppcheck's sake * cppcheck: Add inline suppressions for false-positives * Remove obsolete cppcheck suppressions * treebrowser: Move cppcheck suppressions inline -- File Changes -- M .github/workflows/build.yml (2) M addons/src/ao_tasks.c (11) M build/cppcheck-geany-plugins.cfg (4) M build/cppcheck.mk (6) M geanyctags/src/geanyctags.c (2) M geanygendoc/src/ggd-options.c (1) M geanyprj/src/Makefile.am (3) M geanyprj/src/utils.c (3) M geniuspaste/src/geniuspaste.c (5) M git-changebar/src/gcb-plugin.c (1) M markdown/src/conf.c (4) M scope/src/Makefile.am (2) M scope/src/debug.c (4) M treebrowser/src/Makefile.am (3) M treebrowser/src/treebrowser.c (2) M vimode/src/cmd-runner.c (2) M workbench/src/sidebar.c (6) M workbench/src/wb_project.c (4) M workbench/src/workbench.c (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1346.patch https://github.com/geany/geany-plugins/pull/1346.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany-plugins/pull/1...@github.com>
