[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
> I closed this PR because I think using the official ctags file format is "the 
> future" and that we should ship those with Geany and encourage users to use 
> it. 

Which brings me to one more thing - we should document which format is the 
recommended one. So in #3049 I added one more commit for your red pen:

https://github.com/geany/geany/pull/3049/commits/bc49cd2750dacf0bb5f82b7f30d328df79f23e9e

(I re-shuffled some sections so the diff is bigger than the actual changes, the 
commit message should say what was changed.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-1764512720
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread elextr via Github-comments
Oh, I misunderstood, if its only being added to tagmanager tags files then 
thats fine, although not sure why to bother if the tmtags is going away.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-176745
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
I closed this PR because I think using the official ctags file format is "the 
future" and that we should ship those with Geany and encourage users to use it. 
The TM tag file format is good for our unit tests so we know to what internal 
value the mapping happened.

> Its ok having the original kind in the file, but how do we know what it 
> originally mapped to so we can invisibly fix changes?

The idea was that if we found the original ctags kind in the file, we would use 
that one and perform the mapping based on the current mapping tables used in 
Geany - the same thing we do already for ctags files. If not found, we'd use 
the "legacy" `tm_tag_...` value stored in the file.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-1764438728
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread elextr via Github-comments
> What I was thinking is that if we had the original ctags kind in the file, we 
> could fix such mappings invisibly to the user in the future and users 
> wouldn't need to regenerate such files by themselves.

Its ok having the original kind in the file, but how do we know what it 
originally mapped to so we can invisibly fix changes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#issuecomment-1764415627
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add ctags kind letter to tag manager tag files (PR #3208)

2023-10-16 Thread Jiří Techet via Github-comments
Closed #3208.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3208#event-10664842109
You are receiving this because you are subscribed to this thread.

Message ID: