[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
Merged #3759 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#event-12773542349 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@eht16 @b4n This is squashed and ready to go. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#issuecomment-2104724781 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@b4n approved this pull request. Looks good and works fine. Could you please just squash the commits together? (or I can do it if you prefer) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#pullrequestreview-2015703603 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 pushed 1 commit. aab90a0d052ced3c6e2775688c2dcaaa153ffd83 Start off with strings -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/ad3e7753f9de9956e706aed00b784ee58e6bdff5..aab90a0d052ced3c6e2775688c2dcaaa153ffd83 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@eli-schwartz commented on this pull request.
> runner = find_program('ctags/runner.sh')
foreach t : ctags_tests
- test('@0@'.format(t), runner,
+ test(join_paths(fs.parent(t), fs.name(t)), runner,
You could start off with strings. :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#discussion_r1484447549
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 commented on this pull request.
> runner = find_program('ctags/runner.sh')
foreach t : ctags_tests
- test('@0@'.format(t), runner,
+ test(join_paths(fs.parent(t), fs.name(t)), runner,
@eli-schwartz Isn't there a proper way to convert a file object to a string in
<=0.53? (I suppose that's why the warning isn't a hard error, and the fs and
full_path() features have been introduced).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#discussion_r1484412389
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 commented on this pull request.
> runner = find_program('ctags/runner.sh')
foreach t : ctags_tests
- test('@0@'.format(t), runner,
+ test(join_paths(fs.parent(t), fs.name(t)), runner,
One other potentially noteworthy feature of 0.59 is that when using 'ninja
uninstall`, the gmo/mo files get uninstalled as they should.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#discussion_r1484409052
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 commented on this pull request.
> runner = find_program('ctags/runner.sh')
foreach t : ctags_tests
- test('@0@'.format(t), runner,
+ test(join_paths(fs.parent(t), fs.name(t)), runner,
The required meson version is 0.53 and this feature is not available until 0.59
Looks like they've added full_path but that feature requires meson 1.4.1
https://stackoverflow.com/a/77647927/6838037
https://mesonbuild.com/Reference-manual_returned_file.html
https://github.com/mesonbuild/meson/issues/12259
Anyway, a pretty trivial issue. It works as-is. I assume you don't wanna set
the required meson version to 0.59 yet. Feel free to close this PR unless you
wanna discuss it further.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#pullrequestreview-1872536298
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 pushed 1 commit. ad3e7753f9de9956e706aed00b784ee58e6bdff5 Fix deprecation warning about str.format() during meson setup -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/bfce17935451f8e2d95b0e8c02839351c4214375..ad3e7753f9de9956e706aed00b784ee58e6bdff5 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
@andy5995 commented on this pull request.
> @@ -355,7 +355,7 @@ ctags_tests = files([
runner = find_program('ctags/runner.sh')
foreach t : ctags_tests
- test('@0@'.format(t), runner,
+ test('@0@'.format(f[0][0]), runner,
Oops, that's not right. Let me have a closer look at how to do this right...
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#pullrequestreview-187255
You are receiving this because you are subscribed to this thread.
Message ID:
