[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread elextr via Github-comments
Yeah, makes sense, the markers are per line, and lines exist in the document, 
not the view.  

So per line data has to exist in the document, and per line data is where the 
marker number is stored, which shows as a white circle for any marker not 
properly set up in the view, for example in the split window view.

I don't think there is much we can do about any artefacts of interfering 
plugins, there have been cases of plugins using overlapping hard coded marker 
numbers etc.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764374998
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread Jiří Techet via Github-comments
> It would appear that the marker is added to the shared buffer

Oh, I misread the code - I thought it was using `SCI_GETCHARACTERPOINTER` and 
that would be sharing just `gchar *`. But it's `SCI_GETDOCPOINTER` so it's the 
Scintilla's "document" which is shared and it probably stores the information 
about markers too.

So yeah, it's less mysterious now and also probably not something we can fix 
easily.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764363796
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread elextr via Github-comments
Scintilla docs, "By default, all 32 markers are set to SC_MARK_CIRCLE with a 
black foreground and a white background."

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764337776
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread Jiří Techet via Github-comments
> Do the change markers have to be set up in each Scintilla individually? If so 
> it probably isn't being done on the split because the plugins don't know 
> about its existence (as its a plugin itself).

This is what I would expect - but then the markers shouldn't appear at all. I 
would expect no markers at all in the splitview plugin.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764314699
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Split window plugin shows circle markers for markers created by plugins in the main window (Issue #3603)

2023-10-16 Thread elextr via Github-comments
Do the change markers have to be set up in each Scintilla individually? If so 
it probably isn't being done on the split because the plugins don't know about 
its existence (as its a plugin itself).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3603#issuecomment-1764307870
You are receiving this because you are subscribed to this thread.

Message ID: