[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
IMO meson is still experimental and we don't need to support Ubuntu 20.04. Pick whatever meson makes the least problems for us. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068841524 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
We already have deprecation warnings in 0.56, so if we want to support earlier jus use the older option I mentioned -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068837991 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson 0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to change what it uses at 0.56 to get rid of the message. Kind of annoying that a Windows only feature causes a message on Linux, maybe the targeted version can be changed just for Windows? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068394877 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@b4n requested changes on this pull request.
```console
../meson.build:887: WARNING: Project targets '>= 0.53' but uses feature
introduced in '0.56.0': win_subsystem arg in executable.
[…]
WARNING: Project specifies a minimum meson_version '>= 0.53' but uses features
which were added in newer versions:
* 0.56.0: {'win_subsystem arg in executable'}
NOTICE: Future-deprecated features used:
* 0.56.0: {'meson.build_root', 'meson.source_root'}
```
So there are two ways to go I think:
* Depend on 0.56.0 (and possibly fix the deprecation warnings)
* Use
[`gui_app`](https://mesonbuild.com/Reference-manual_functions.html#executable_gui_app)
instead for a 0.53-compatible alternative (but that is deprecated in 0.56)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#pullrequestreview-2013511509
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
@eht16 This doesn't seem to have any impact on Linux, so looks fine on that end. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068186588 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Well, the CI just builds the code and runs some simple tests. This is already a good indicator, yes. Still, it is different from executing the full application with full loading of GTK and such. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054114331 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Did not CI already do that in "CI Build / Linux Meson Build (pull_request)" ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054065400 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Could anyone who uses Meson on Linux check if this is fine and properly ignored? @b4n or @kugel- maybe? I tested it on Windows and it does what it should. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054064747 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> > I would suggest to provide Windows installer. Most of the users will still > > use official installer who are not familiar with msys2 and its packaging > > system. > > But as I said above, none of the major contributors use Geany on Windows, > even the nice guy who makes the build (and yes with installer) so its > virtually untested. Hmm, I first thought: this probably won't work as it would require users to install MSYS2 in order to install Geany within. On the other hand: maybe there is a way to use MSYS2 packages directly without installing a full Linux like environment. And it would save me from moaning about Windows build and installer issues :smile:. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054050951 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> I would suggest to provide Windows installer. Most of the users will still > use official installer who are not familiar with msys2 and its packaging > system. But as I said above, none of the major contributors use Geany on Windows, even the nice guy who makes the build (and yes with installer) so its virtually untested. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036208896 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> Maybe we can stop making a build for Windows (hopeful). I would suggest to provide Windows installer. Most of the users will still use official installer who are not familiar with msys2 and its packaging system. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036203592 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> geany 2.0 is built with meson in msys2 project Maybe we can stop making a build for Windows (hopeful). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036200273 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> Is that harmless on Linux builds? The `win_subsystem` option is valid for Windows target only. geany 2.0 is built with meson in msys2 project, see https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-geany/PKGBUILD -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036181922 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Is that harmless on Linux builds? If not it needs to be conditioned appropriately the same as `win_src` and `vte_src` are, probably best if its done anyway, even if harmless at this point, since Meson has a habit of increasing strictness and creating errors of previously acceptable things. I am not sure that the meson build has been tested on Windows, the Windows builds for Geany are usually cross built from Linux. Basically there are no Windows users amongst the regular Geany contributors, so a Grumpy olde guy like me says drop the Windows build until somebody(s) using Windows support it, but the really nice guy who makes the builds keeps doing it even though he doesn't use it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2035799889 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
This would be similar as `-mwindows` flag in src/Makefile.am https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/src/Makefile.am#L157 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2034823993 You are receiving this because you are subscribed to this thread. Message ID:
