[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@eht16 commented on this pull request. On screenshots/dark-spook.png: Do you mind to replace the screenshot as described above? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#discussion_r1510333217 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@eht16 commented on this pull request. > +description=Based on the InkPot theme of the same name. +# incremented automatically, do not change manually +version=1 +author=Vukić Srđan +url=https://hardcoder.xyz +# list of each compatible Geany release version +compat=1.22;1.23;1.23.1;1.24;1.25;1.26;1.27;1.28;1.29;1.33;1.38;2.0 + +[named_styles] +default=#626CAD;#15181D;false;false +error=#542929;#121C2B;false;false + +# Editor styles +#--- + +selection=;#4e4e8f;false;false ```suggestion selection=;#4e4e8f;false;true ``` This eliminates the warning and makes selected text look much better as the background color is used. See https://geany.org/manual/#styling-section-1 for reference. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#pullrequestreview-1913044168 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@eht16 commented on this pull request. > +keyword_4=#7F7F7F;;false;true + +identifier=#3CCA62;;false;true +identifier_1=#507875;;false;true +identifier_2=#457C54;;false;true +identifier_3=#256536;;false;true +identifier_4=#8BBC98;;false;true + +string=#ffcd8b;;false;false +string_1=#BFAC91;#1C1F26;false;false +string_2=#BA9665;#1C1F26;false;false +string_3=#CDA7A1;;false;false +string_4=#A1CDCA;;false;false +string_eol=#A1C1CD;;false;false +character=#A86027;;false;false +backticks=#008C39l;;false;false > > Geany complains about the invalid color value: > > Ouch! Thanks. > > That 7th `l` character (not including `#` ) is actually `;`, but my finger > apparently slipped. Will remove it. :) > > Note also the selection style warning. > > Yes, that I am aware of. Tried various combinations, it looks quite ok like > this. It would be nice if we could avoid the warning. > I noticed that the name of the file is `dark-spook.conf`, but Titled Name is > `DarkSpook`. Should I correct that as well ? From `DarkSpook` to `Dark Spook` > into config or I leave as is ? I think this is OK, some other themes do this as well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#discussion_r1439397914 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@hngts pushed 1 commit. 9e30127aeae0eaa477452e8ac8f31a9c7aa4a854 Update dark-spook.conf -- View it on GitHub: https://github.com/geany/geany-themes/pull/68/files/fd96464838ae68b86838e9e8c126d069cfd87a6a..9e30127aeae0eaa477452e8ac8f31a9c7aa4a854 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@hngts commented on this pull request. > +keyword_4=#7F7F7F;;false;true + +identifier=#3CCA62;;false;true +identifier_1=#507875;;false;true +identifier_2=#457C54;;false;true +identifier_3=#256536;;false;true +identifier_4=#8BBC98;;false;true + +string=#ffcd8b;;false;false +string_1=#BFAC91;#1C1F26;false;false +string_2=#BA9665;#1C1F26;false;false +string_3=#CDA7A1;;false;false +string_4=#A1CDCA;;false;false +string_eol=#A1C1CD;;false;false +character=#A86027;;false;false +backticks=#008C39l;;false;false > Geany complains about the invalid color value: Ouch! Thanks. That 7th `l` character (not including `#` ) is actually ';', but my finger apparently slipped. Will remove it. > Note also the selection style warning. Yes, that I am aware of. Tried various combinations, it is quite ok like this. Now, I noticed that the name of the file is dark-spook.conf, but Titled Name is DarkSpook. Should I correct that as well ? Into `Dark Spook` from `DarkSpook` or I leave as is ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#discussion_r1436720519 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@eht16 commented on this pull request. > +keyword_4=#7F7F7F;;false;true + +identifier=#3CCA62;;false;true +identifier_1=#507875;;false;true +identifier_2=#457C54;;false;true +identifier_3=#256536;;false;true +identifier_4=#8BBC98;;false;true + +string=#ffcd8b;;false;false +string_1=#BFAC91;#1C1F26;false;false +string_2=#BA9665;#1C1F26;false;false +string_3=#CDA7A1;;false;false +string_4=#A1CDCA;;false;false +string_eol=#A1C1CD;;false;false +character=#A86027;;false;false +backticks=#008C39l;;false;false Geany complains about the invalid color value: ``` Geany-INFO: 00:00:55.142: Bad color '#008C39l' Geany-INFO: 00:00:55.145: selection style is set to invisible - ignoring! ``` Note also the selection style warning. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#pullrequestreview-1795505965 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@eht16 commented on this pull request. On screenshots/dark-spook.png: It would be great if you could make a screenshot like described in https://github.com/geany/geany-themes/blob/master/ADDING-A-THEME.md#adding-a-screenshot. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#pullrequestreview-1795505896 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
@hngts pushed 1 commit. fd96464838ae68b86838e9e8c126d069cfd87a6a DarkSpook snapshot added -- View it on GitHub: https://github.com/geany/geany-themes/pull/68/files/ae371394930d149154b93725f97232f33f82fb28..fd96464838ae68b86838e9e8c126d069cfd87a6a You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)
I don't know whether it is necessary to add screenshot again, as I already uploaded one via request issues. Anyways, be it like this or that, here it is attached. Beside that, I have left licence header from the original author on purpose. **[theme_info]** section points on me. I hope that's ok.  -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/68#issuecomment-1865424783 You are receiving this because you are subscribed to this thread. Message ID:
