Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
@codebrainz If removing the ellipsizing works reliably I'm fine with it, but if that needs more extensive testing maybe we can put that into a new PR? This will improve it quick and safe for the time being. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-538702317
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
IMO, we should just remove the ellipsizing from the window title altogether. It used to be an arbitrary 30 chars, now an arbitrary 80, and there's still the directory path and project name which could be really long, it's totally dependent on window size and user's font size, and sane window managers already handle this. Moreover, the original issue on SF was an extreme edge case where the user's filename somehow had embedded in it all of the query string parameters which shouldn't even be part of a filename. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-538167465
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
@elextr: > There may be lots of complicated things that could be done here, but hey if a > fixed 30 has worked for most people to date then a fixed 80 is no worse. @elextr Thanks, my sentiments exactly. Eventually the hardcoded value could/should probably be moved to a defined constant. Maybe a refactoring beautification PR? FYI: this value is hardcoded twice, it's also in document.c: ``` 419 if (length < 0) 420 length = 30; ``` I left it 30 since a filename length less than zero probably doesn't need 80. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537978528
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
God, please don't add prefs for stuff like this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537887424
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
298 is about tab, dialogs and title bar (at least according to my comment in the issue :D). I think my point would be valid even if not. Just let's add a (probably hidden) preference for this. The OP prefers 80 characters, the original requestor needed less, the next will need some value in between. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537885679
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
@eht16 if I read it right 298 is for tabs, this is title bar. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537864908
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
As 80 characters is as arbitary as 30, this change would break the behaviour which was requested in https://sourceforge.net/p/geany/bugs/298/. I think if at all, we should make it configurable (and maybe enlarge the default a it). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537814835
Re: [Github-comments] [geany/geany] Changed default title length from 30 to 80. (#2335)
LGTM There may be lots of complicated things that could be done here, but hey if a fixed 30 has worked for most people to date then a fixed 80 is no worse. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2335#issuecomment-537731527
