Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I will leave it here in case it helps someone. I am using the following style
in my _geany.css_:
```css
#geany-compiler-error {
color: #FF7987;
}
#geany-compiler-message {
color: #DFDBFF;
}
#geany-compiler-context {
color: #FEC0E0;
}
```
It has been easy to read the compiler messages on the dark themes I tested it
with.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2644#issuecomment-808731976
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Real CSS has a property like this: ```css filter: invert(1) hue-rotate(180deg); ``` But since GTK+ CSS is not real/complete CSS, I doubt it works. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-750106373
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
> I guess that still has the problem that we have no idea what GTK+ theme the > user will choose, so it's not really possible to pick properly contrasting > colours. Its true, but we can pick bright colours instead of the dark ones currently implemented. Its very likely that it will give a contrast that is acceptable to use with dark themes (if it is beautiful or not, I don't judge). As a last resort, the user can still edit the CSS file. To complicate a little more, we can mount these ready-to-use themes to give more options too. If one isn't suitable, comment it and uncomment the next in the CSS file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-724376588
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
> My solution would be to add comments to the CSS file so that the users of > dark themes only have to uncomment to have a functional contrast. I guess that still has the problem that we have no idea what GTK+ theme the user will choose, so it's not really possible to pick properly contrasting colours. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-724371291
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I thought of something. I guess people in this community are really geek and like to tweak a CSS file. But I believe most users of dark themes don't really want to think of colours to customize _geany.css_ so the contrast between the letters and background is reasonable. My solution would be to add comments to the CSS file so that the users of dark themes only have to uncomment to have a functional contrast. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-724143653
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
@b4n, ok, so long as whatever mechanism is simple for users to override if the theme is inappropriate, not all themes are done well, and when it comes to colours peoples vision differs markedly. And the override is documented in the Geany manual!!! [getting in ahead of time] -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723498973
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
@elextr well, yes and no; in theory you can't really get any color from CSS, as there might not be any -- could be image, gradient or whatnot, although it's less true for text. What you would normally do is use the appropriate CSS class and it'd be styled the right way whatever that is. In this case maybe we could indeed do so with reasonable expectations, not sure. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723497140
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
> I wonder if it's possible to access the colours based on GtkMessageType like > GtkInfoBar does, so they come from the theme? This is sort of like web CSS > frameworks that provide basic colours for ex. warning, danger, primary, etc. Good idea for the default if not user custom colour is defined in geany.css -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723495772
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I think there are style classes for that yes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723493984
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I wonder if it's possible to access the colours based on `GtkMessageType` like `GtkInfoBar` does, so they come from the theme? This is sort of like web CSS frameworks that provide basic colours for ex. warning, danger, primary, etc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723481445
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I had a idea. It would involve a little bit code. As my original idea, we would do some basic calculations to detect light and dark themes through _GtkStyleContext_, then load _geany.css_ or _geany-dark.css_ accordingly. I think this solution is more maintainable than caring for every theme. It wouldn't add colors that are beautiful in the current theme, just colors that are easy to read. If the user wants, he would still tweak the _css_ in a similar fashion as current implemented. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723465048
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
One workaround that has been implemented in e.g. MATE's file manager Caja is the ability to load custom CSS based on theme name. E.g., we could imagine try and load geany-$THEME.css, if it exists. That would clearly not be perfect, but could allows us (or the user) to provide support for some specific themes. Ideally themes would support Geany's custom classes (given we did that properly, but I think we did), but that's probably a tiny bit unlikely. This said, you could also possibly make a custom theme in your user's dir, import the original CSS, and add a couple of rules for Geany's own stuff, that might work as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723426094
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Duplicate of at least #1376, #1737, #2293, etc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723363552
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Thanks for the offer, I guess advanced GTK versions can be required so long as the CSS is properly guarded so olde versions ignore it and don't give errors. I'm no expert on GTK CSS and I don't know if it can determine if a theme is "dark" to only apply in that case, but perhaps its possible. Clearly applying dark colours when the theme is light might not work either. Note that Geany loads its own CSS file so it overrides the system CSS and so users don't have to wrangle the system CSS files. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723345712
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Even when I use stable dark themes, the colors aren't that good to be read for me. I have looked some other mechanisms, but it would involve advanced GTK versions and a little bit of code tweak. I thought i would be able to contribute to Geany project, but it may have to be a next time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723341307
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Yes, you need to check what your particular GTK version supports. The basic premise is that (apart from the editor window) all theming should use the normal GTK mechanism, so having code play with colours is a "bad idea"™. Anything that doesn't is a bug. Of course that leaves Geany users at the "mercy" of the desktop theme creators, some of which are fine (Linux Mint dark themes work for me), and some of which are clearly mad :). But thats the way the project has decided to go. Improvements to Geany GTK CSS are welcome so long as they work with many common themes (particularly those used by the Geany contributors) and don't need bleeding edge GTK versions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723321341
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
I have tried to use **@media (prefers-color-scheme: dark)**, but it says ``` (geany:17276): Geany-WARNING **: 18:47:50.165: Failed to load custom CSS: geany.css:1:0unknown @ rule ``` Maybe it is a gtk version thing. Since it must be configured through CSS, i don't think it is a good idea change the source code to implement dark defaults. Would someone have a idea? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723316531
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Wouldn't it be nice to implement an functional default for dark themes? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723298249
Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)
Colours are configurable, see [the manual](https://www.geany.org/manual/current/index.html#customizing-geany-s-appearance-using-gtk-3-css) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723296319
