Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
Merged #1024 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#event-3971178480
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525827142
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@frlan pushed 1 commit. 2a8969f0f69ba5dba96298a314004d3adfff6300 PrettyPrinter: Fix declaration of input_buffer -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/1024/files/31285dc8b337198bcf36629df1e52f1d1eb7ad23..2a8969f0f69ba5dba96298a314004d3adfff6300
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n True. Will update it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#issuecomment-723589309
Re: [Github-comments] [geany/geany-plugins] PrettyPrinter: Don't try to free const gchar* input_buffer (#1024)
@b4n requested changes on this pull request. The problem is not freeing `input_buffer` which *should* be freed, but that the `input_buffer` variable shouldn't be `const` (since 3fad1285599766a7932667688871c04610bd8651). The change you propose would lead to leaking quite a lot of memory. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525815271
