Re: [gitorious] Re: Gitorious 2.4.5 has been released
On Friday, 18 January 2013 06:42:30 UTC-7, Marius Mårnes Mathiesen wrote: > > > Thomas Kjeldahl Nilsson writes: > > > Seems to be a regression introduced in one of the last releases (during > the 2.4.x run?). > > > > Issue here if you want to keep track of it: > > https://issues.gitorious.org/issues/149 > > I have pushed a change to the master and 2.x-stable branches that should > resolve this issue. Try merging master into your server, restart, and > let us know if the problem still persists. > > Cheers, > - Marius > Thanks Marius, This has fixed the issue for me, everything is working perfectly! Thanks for the quick fix! Bert -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
[gitorious] Re: Gitorious 2.4.5 has been released
On Wednesday, 9 January 2013 01:29:28 UTC-7, Marius Mårnes Mathiesen wrote: > > Hi all, > Last night a serious vulnerability in Ruby on Rails was discovered, and > anyone running Gitorious on their server should upgrade Gitorious > *immediately*. > > This blog post has more details: > http://blog.gitorious.org/2013/01/09/gitorious-2-4-5-has-been-released/ > > Cheers, > - Marius > Updating to this version of Gitorious has caused favourites to stop working. There is another thread in this group named "Trying to enable email notification causes logging off", see https://groups.google.com/forum/?fromgroups=#!topic/gitorious/lCQcP_ZN0Dg for more information. -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
[gitorious] Re: Trying to enable email notification causes logging off...
On Tuesday, 15 January 2013 06:47:00 UTC-7, othiman wrote:
>
> Hi,
>
> I want to enable email notification on gitorious.org by going to Dashboard
> - Your favorites and click on the "off" in the Email notifications column.But
> the only thing that happens isthat I am
> logged off the site.
>
> Does anyone have the same Problem? I also installed gitorious 2.4.5 to my
> own server and have the same problem there, too.
>
> Best regards,
> othiman
I'm seeing the same issue, except I am trying to unwatch a particular
repository, set my production to :debug and got the following:
Processing FavoritesController#destroy (for x.x.x.x at 2013-01-16 11:25:08)
[DELETE]
Parameters: {"_method"=>"delete", "controller"=>"favorites",
"action"=>"destroy", "id"=>"2400"}
Filter chain halted as [:public_and_logged_in] rendered_or_redirected.
Completed in 6ms (View: 1, DB: 0) | 406 Not Acceptable
[http://git-scm.company.local/favorites/2400]
This then destroys my session. I'm running the latest git commit on master:
5ce56a5259e288042a4a458520773dd7f7d32587
###
This is when I try to enable/disable email notifications:
Processing FavoritesController#update (for x at 2013-01-16 11:28:58) [PUT]
Parameters: {"favorite"=>{"notify_by_email"=>"0"}, "_method"=>"put",
"controller"=>"favorites", "action"=>"update", "id"=>"2400"}
Filter chain halted as [:public_and_logged_in] rendered_or_redirected.
Completed in 3ms (View: 1, DB: 0) | 406 Not Acceptable
[http://git-scm.company.local/favorites/2400]
--
To post to this group, send email to gitorious@googlegroups.com
To unsubscribe from this group, send email to
gitorious+unsubscr...@googlegroups.com
[gitorious] Re: Grit::Git::GitTimeout
In this commit http://gitorious.org/gitorious/mainline/commit/5fd9a19f30aa8aac64ac3f02462c93e3b5ca1da6/diffs a change was made to add the commit diff to the body of the email, along with a link to view the commit online. This works perfectly for cases where the patchset isn't larger than 5 MB or it doesn't hit the Grit timeout, but unfortunately that doesn't seem to be the case with some of the changes that my users are pushing. I think it would be appropriate to wrap the function diff_body() as it is in http://gitorious.org/gitorious/mainline/blobs/master/lib/event_rendering/text.rb#line321 with a catch for the Grit timeout, and return an appropriate message stating that the diff is too large for email or could not be processed (much like when trying to view a diff that is too large via the web). This way the poller wouldn't fail and send two messages to the sys-admin when in reality there is not a whole lot that can be done about this issue. My ruby-foo isn't strong enough to go make the modifications myself, but if someone could supply a patch I would be more than happy to throw it into use on my production instance and see if it at least helps solve the issue somewhat. Thanks, Bert JW Regeer On Thursday, 2 August 2012 17:56:24 UTC-6, Bert JW Regeer wrote: > > This exception keeps getting thrown, now I don't understand why, and I > have no idea how to even start debugging the situation. Let me describe the > hardware I am running on and some basic stats about the repository, if you > guys have any ideas as to where I can start looking i'd appreciate that. > > Hardware: > > 2 CPU's with 2 cores is a total of 4 cores. > 16 GB of RAM > 4 x SATA drive (2 drives in an MD raid 1, and 2 more drives in an MD raid > 1) > > The git repositories are sitting on the second md raid 1. > > The repository stats: > > Commits: 3402 > .git size on fresh clone: 33M > Files in repo: 835 > Directories: 343 > > Worst case I will most likely increase the Grit timeout to 20 or even 30 > seconds in an attempt to stave off this issue for a little while, although > I have a bad feeling this will continue... > > Thanks, > Bert > > An exception occured in # @repository= > #", project_id: 2, user_id: 7, > created_at: "2011-07-20 23:31:31", updated_at: "2012-08-02 02:02:31", > parent_id: 17, ready: true, kind: 3, owner_type: "User", owner_id: 7, > hashed_path: "", description: nil, last_pushed_at: "2012-08-02 > 02:02:31", wiki_permissions: 0, deny_force_pushing: false, > notify_committers_on_new_merge_request: true, last_gc_at: nil, > merge_requests_enabled: true, disk_usage: 46292359, push_count_since_gc: > 706>, > @spec= > #@from_sha= > # @sha="95e177ae088c5d365d1c7f88e8f8ac7aac50db3b">, >@ref= > #, >@to_sha= > # @sha="0c1d189d13a38d53e17bc7b80bb68c0a2294d7b4">>, > @user= > #> > ! > > Grit::Git::GitTimeout: Grit::Git::GitTimeout > > storage/git/gitorious/vendor/grit/lib/grit/git.rb:101:in `sh' > /storage/git/gitorious/vendor/grit/lib/grit/git.rb:71:in `run' > /usr/lib/ruby/1.8/benchmark.rb:293:in `measure' > /storage/git/gitorious/vendor/grit/lib/grit/git.rb:70:in `run' > /storage/git/gitorious/vendor/grit/lib/grit/git.rb:57:in > `method_missing' > /storage/git/gitorious/lib/event_rendering/text.rb:322:in > `diff_body' > /storage/git/gitorious/lib/event_rendering/text.rb:318:in > `add_diff_content' > /storage/git/gitorious/lib/event_rendering/text.rb:243:in > `render_push_summary' > /storage/git/gitorious/lib/event_rendering/text.rb:104:in `render' > /storage/git/gitorious/lib/event_rendering/text.rb:31:in `render' > /storage/git/gitorious/app/models/favorite.rb:63:in > `notify_about_event' > /storage/git/gitorious/app/models/event.rb:166:in > `notify_subscribers' > /storage/git/gitorious/app/models/event.rb:165:in `each' > /storage/git/gitorious/app/models/event.rb:165:in > `notify_subscribers' > > /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in > > `send' > > /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in > > `evaluate_method' > > /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:166:in > > `call' > > /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:93:in > > `run' >
[gitorious] Grit::Git::GitTimeout
I keep getting this exception when people push to their repositories, it says that the push count since gc is 706 ... which is strange because I ran the repo_housekeeping script and it told me that it gc'ed this repository. This is running on a stand-alone server, 2 dual core CPU's (4 cores total) with 16 GB of RAM and the repositories are on a md based mirror with 2 SATA drives and no other IO on it (MySQL and OS are on a different md backed mirror). I moved this off a VMWare based virtual server because of IO issues, this server has plenty of IO power. Is there anything I can do to figure out why these are failing? Where should I start looking? Here are some stats for the repository: Commits: 3402 Repo size at fresh clone: 53M Files in repo: 835 Directories: 343 I'm at a loss here. Worst case I will most likely simply modify Grit to set the timeout to something longer than 10 seconds and hope that it doesn't re-appear for a while. An exception occured in #", project_id: 1, user_id: 1, created_at: "2011-07-01 00:00:00", updated_at: "2012-08-02 00:00:00", parent_id: 1, ready: true, kind: 3, owner_type: "User", owner_id: 1, hashed_path: "", description: nil, last_pushed_at: "2012-08-02 00:00:00", wiki_permissions: 0, deny_force_pushing: false, notify_committers_on_new_merge_request: true, last_gc_at: nil, merge_requests_enabled: true, disk_usage: 46292359, push_count_since_gc: 706>, @spec= #, @ref= #, @to_sha= #>, @user= # ! Grit::Git::GitTimeout: Grit::Git::GitTimeout -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
[gitorious] Grit::Git::GitTimeout
This exception keeps getting thrown, now I don't understand why, and I have no idea how to even start debugging the situation. Let me describe the hardware I am running on and some basic stats about the repository, if you guys have any ideas as to where I can start looking i'd appreciate that. Hardware: 2 CPU's with 2 cores is a total of 4 cores. 16 GB of RAM 4 x SATA drive (2 drives in an MD raid 1, and 2 more drives in an MD raid 1) The git repositories are sitting on the second md raid 1. The repository stats: Commits: 3402 .git size on fresh clone: 33M Files in repo: 835 Directories: 343 Worst case I will most likely increase the Grit timeout to 20 or even 30 seconds in an attempt to stave off this issue for a little while, although I have a bad feeling this will continue... Thanks, Bert An exception occured in #", project_id: 2, user_id: 7, created_at: "2011-07-20 23:31:31", updated_at: "2012-08-02 02:02:31", parent_id: 17, ready: true, kind: 3, owner_type: "User", owner_id: 7, hashed_path: "", description: nil, last_pushed_at: "2012-08-02 02:02:31", wiki_permissions: 0, deny_force_pushing: false, notify_committers_on_new_merge_request: true, last_gc_at: nil, merge_requests_enabled: true, disk_usage: 46292359, push_count_since_gc: 706>, @spec= #, @ref= #, @to_sha= #>, @user= #> ! Grit::Git::GitTimeout: Grit::Git::GitTimeout storage/git/gitorious/vendor/grit/lib/grit/git.rb:101:in `sh' /storage/git/gitorious/vendor/grit/lib/grit/git.rb:71:in `run' /usr/lib/ruby/1.8/benchmark.rb:293:in `measure' /storage/git/gitorious/vendor/grit/lib/grit/git.rb:70:in `run' /storage/git/gitorious/vendor/grit/lib/grit/git.rb:57:in `method_missing' /storage/git/gitorious/lib/event_rendering/text.rb:322:in `diff_body' /storage/git/gitorious/lib/event_rendering/text.rb:318:in `add_diff_content' /storage/git/gitorious/lib/event_rendering/text.rb:243:in `render_push_summary' /storage/git/gitorious/lib/event_rendering/text.rb:104:in `render' /storage/git/gitorious/lib/event_rendering/text.rb:31:in `render' /storage/git/gitorious/app/models/favorite.rb:63:in `notify_about_event' /storage/git/gitorious/app/models/event.rb:166:in `notify_subscribers' /storage/git/gitorious/app/models/event.rb:165:in `each' /storage/git/gitorious/app/models/event.rb:165:in `notify_subscribers' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in `send' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:178:in `evaluate_method' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:166:in `call' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:93:in `run' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:92:in `each' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:92:in `send' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:92:in `run' /storage/git/gitorious/vendor/rails/activesupport/lib/active_support/callbacks.rb:276:in `run_callbacks' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/callbacks.rb:344:in `callback' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/callbacks.rb:267:in `create' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/base.rb:2876:in `create_or_update_without_callbacks' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/callbacks.rb:250:in `create_or_update' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/base.rb:2540:in `save_without_validation' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/validations.rb:1078:in `save_without_dirty' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/dirty.rb:79:in `save_without_transactions' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:229:in `send' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:229:in `with_transaction_returning_status' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:136:in `transaction' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:182:in `transaction' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:228:in `with_transaction_returning_status' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:196:in `save' /storage/git/gitorious/vendor/rails/activerecord/lib/active_record/transactions.rb:208:in
