Re: [gitorious] fixing tests in "next"
> Finally found it! When running through "bundler exec rake", the test > suite was running through rake_test_loader, which finds all the tests > and calls "Require" on each one. I modified this program to show which > specific test was causing the crash. It was > test/functional/searches_controller_test.rb. Examining the code, this > particular test loads test_helper in a unique way, which is what must > be tripping up Ruby 1.8.7. > > I've fixed this, and the remaining failures at > https://gitorious.org/gitorious/mainline/merge_requests/240 > <3 <3 <3 Pulled. Thanks again Ken! Christian -- -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com --- You received this message because you are subscribed to the Google Groups "Gitorious" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitorious+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gitorious] fixing tests in "next"
On Fri, Jun 28, 2013 at 8:10 AM, Christian Johansen wrote: >>> There is also a problem related to the way that execute() gets called >>> on anonymous classes on Ruby 1.8.7. I tried to wrap my mind around the >>> use_case gem so I could understand how to fix it, but it is beyond me. >>> I've filed the details at https://issues.gitorious.org/issues/177 >> >> I'm leaving this one for Christian... > > Fixed it. Rails wanted to inflect model names, and failed. Now there's > still test errors on 1.8.7, because in the controller tests, the app is > attempted to be initialized more than once. As far as I can tell, > running each controller test individually works fine, but running the > test suite (bundle exec rake test:functionals) causes it to crash the > second time it attempts to load the Rails app in config/environment.rb. > Any ideas? Finally found it! When running through "bundler exec rake", the test suite was running through rake_test_loader, which finds all the tests and calls "Require" on each one. I modified this program to show which specific test was causing the crash. It was test/functional/searches_controller_test.rb. Examining the code, this particular test loads test_helper in a unique way, which is what must be tripping up Ruby 1.8.7. I've fixed this, and the remaining failures at https://gitorious.org/gitorious/mainline/merge_requests/240 - Ken -- -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com --- You received this message because you are subscribed to the Google Groups "Gitorious" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitorious+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gitorious] fixing tests in "next"
>> There is also a problem related to the way that execute() gets called >> on anonymous classes on Ruby 1.8.7. I tried to wrap my mind around the >> use_case gem so I could understand how to fix it, but it is beyond me. >> I've filed the details at https://issues.gitorious.org/issues/177 > > I'm leaving this one for Christian... Fixed it. Rails wanted to inflect model names, and failed. Now there's still test errors on 1.8.7, because in the controller tests, the app is attempted to be initialized more than once. As far as I can tell, running each controller test individually works fine, but running the test suite (bundle exec rake test:functionals) causes it to crash the second time it attempts to load the Rails app in config/environment.rb. Any ideas? Christian -- -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com --- You received this message because you are subscribed to the Google Groups "Gitorious" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitorious+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gitorious] fixing tests in "next"
Ken Dreyer writes: > I recently investigated some test suite failures on the "next" branch. ♥ > For Fedora 19 (Ruby 2.0.0), there's a really simple adjustment that is > needed. The details are at > https://gitorious.org/gitorious/mainline/merge_requests/235 Great - thanks! I just merged this, and I love the output of Ruby 2.0's test runner. Awesome! > For CentOS 6 (Ruby 1.8.7), the failures are more complex. The > "refute_" suite of functions are missing from ActiveSupport::TestCase, > so we have to re-implement them. The fix is at > https://www.gitorious.org/gitorious/mainline/merge_requests/236 Merged as well. I had to make a tiny change to #refute, simply by borrowing MiniTest's own implementation. > There is also a problem related to the way that execute() gets called > on anonymous classes on Ruby 1.8.7. I tried to wrap my mind around the > use_case gem so I could understand how to fix it, but it is beyond me. > I've filed the details at https://issues.gitorious.org/issues/177 I'm leaving this one for Christian... Cheers, - Marius -- -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com --- You received this message because you are subscribed to the Google Groups "Gitorious" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitorious+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
