Re: [Gluster-devel] NetBSD autobuild and cmockery2
This is The Right Way in my opinion. I think the current implementation should not have been merged, but I do not track changes close enough to had the opportunity to cast a -2 code review in time. Note that a voting NetBSD build would have catched it. This changes restores the build, we could re-enable NetBSD autobuild vote one it is merged: http://review.gluster.org/#/c/8340/ +1 - lets vote it hard then! -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] NetBSD autobuild and cmockery2
Hi, On Thursday 24 July 2014 07:04:11 Justin Clift wrote: On 24/07/2014, at 5:05 AM, Emmanuel Dreyfus wrote: Harshavardhana har...@harshavardhana.net wrote: The change just disable cluster/ec when MMX is not there. If you have MMX you have cluster/ec. Unsure - there is assembly code which depends on it but really not sure why! I understand this is an optimized computation: * Multiplications in a GF(2^8) with modulus 0x11D using XOR's Optimization are desirable, but relying on a CPU-specific assembly seems wrong to me, as it kills portability (what about if you want to run on ARM?) That's a good point. There is definitely Fedora ARM and other non-x86 architectures around that we shouldn't be ruling out. Surely there's some way we can make this work, such that the optimised assembler code is only used for cpu's the support it. With non-optimised C or something used for the others. I'm just working on it. The use of intel's SSE2 extensions were for testing purposes on initial development. It proved to compute encoding and decoding very fast, but I've always had in mind that this should be changed. However I have been more focused on finding bugs and stabilizing the code than changing this. Now I'm working on a pure C solution. I can't predict how it will really perform, but an estimate will be half of the speed of SSE2 (basically because SSE2 uses 128 bits operations and the new implementation will use 64 bits). However this will still be pretty fast. I'll let you know when it's finished. Xavi ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] New bug 1122834 to track coverity scan issues for release-3.6 branch
Hi, following indications from Lalatendu I've just created a clone of the bug 789278 (Issues reported by Coverity static analysis tool) to track all coverity issues that need to be merged to release-3.6 branch. The new bug id is 1122834. https://bugzilla.redhat.com/show_bug.cgi?id=1122834 Xavi ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Static analysis, cpp-check, clang-analyze, coverity, etc., of community glusterfs source
Hi Kaleb, Nice initiative !! Thanks for this single window system. --Humble On Thu, Jul 24, 2014 at 6:27 PM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: We now have daily runs of various static source code analysis tools on the glusterfs sources. There are daily analyses of the master, release-3.6, and release-3.5 branches. Results are posted at http://download.gluster.org/ pub/gluster/glusterfs/static-analysis/ If you're interested in contributing to Gluster, but don't know where to start, look here for some easy (and hard) bugs to fix. To fix a bug, start by opening a BZ at https://bugzilla.redhat.com/ enter_bug.cgi?product=GlusterFS Submit the fix in gerrit, instructions are at http://www.gluster.org/ community/documentation/index.php/Development_Work_Flow -- Kaleb ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Static analysis, cpp-check, clang-analyze, coverity, etc., of community glusterfs source
On 07/24/2014 09:47 PM, Justin Clift wrote: Where's a good place to add this to the Wiki? Main Developer page? I think it is http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis#Coverity On Thu, 24 Jul 2014 18:42:11 +0530 Humble Devassy Chirammal humble.deva...@gmail.com wrote: Hi Kaleb, Nice initiative !! Thanks for this single window system. --Humble On Thu, Jul 24, 2014 at 6:27 PM, Kaleb S. KEITHLEY kkeit...@redhat.com wrote: We now have daily runs of various static source code analysis tools on the glusterfs sources. There are daily analyses of the master, release-3.6, and release-3.5 branches. Results are posted at http://download.gluster.org/ pub/gluster/glusterfs/static-analysis/ If you're interested in contributing to Gluster, but don't know where to start, look here for some easy (and hard) bugs to fix. To fix a bug, start by opening a BZ at https://bugzilla.redhat.com/ enter_bug.cgi?product=GlusterFS Submit the fix in gerrit, instructions are at http://www.gluster.org/ community/documentation/index.php/Development_Work_Flow -- Kaleb ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] NetBSD autobuild and cmockery2
On Thursday 24 July 2014 07:04:11 Justin Clift wrote: snip Surely there's some way we can make this work, such that the optimised assembler code is only used for cpu's the support it. With non-optimised C or something used for the others. I'm just working on it. The use of intel's SSE2 extensions were for testing purposes on initial development. It proved to compute encoding and decoding very fast, but I've always had in mind that this should be changed. However I have been more focused on finding bugs and stabilizing the code than changing this. Now I'm working on a pure C solution. I can't predict how it will really perform, but an estimate will be half of the speed of SSE2 (basically because SSE2 uses 128 bits operations and the new implementation will use 64 bits). However this will still be pretty fast. I'll let you know when it's finished. As a thought is this hours or days or etc away? Wondering if we should merge the CR Manu mentioned in the meantime, so NetBSD building works... ;) Thoughts? + Justin ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] [Gluster-users] glusterfs-3.4.5 RPMs now available
On Fri, Jul 25, 2014 at 02:18:01AM +0530, Lalatendu Mohanty wrote: On 07/23/2014 10:48 PM, Kaleb KEITHLEY wrote: On 07/23/2014 01:08 PM, Gluster Build System wrote: SRC: http://bits.gluster.org/pub/gluster/glusterfs/src/glusterfs-3.4.5.tar.gz This release is made off jenkins-release-85 Release Notes for 3.4.5 GA GlusterFS 3.4.5 consists entirely of bug fixes. The following changes are included in 3.4.5: * 2b78933 cluster/dht: Don't do extra unref in dht-migration checks * 33b6134 doc: Fix peer probe deficiencies * ecc2194 fuse: fix memory leak in fuse_getxattr() * b3bf2cf performance/quick-read: Check for iobuf and iobref before unref. * e311014 nfs: prevent assertion error with MOUNT over UDP RPMs for el5-7 (RHEL, CentOS, etc.), Fedora (19,20,21,22) are available at download.gluster.org [1]. [1] http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/ Thanks, Lala Hi, There seems to be a small problem insomuch as I'm seeing this on all my RHEL6 boxes when attempting to yum update: ... (6/23): glusterfs-3.4.5-1.el6.x86_64.rpm | 984 kB 00:00 http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/EPEL.repo/epel-6Server/x86_64/glusterfs-3.4.5-1.el6.x86_64.rpm: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=glusterfs-epel clean metadata Trying other mirror. (7/23): glusterfs-cli-3.4.5-1.el6.x86_64.rpm | 106 kB 00:00 http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/EPEL.repo/epel-6Server/x86_64/glusterfs-cli-3.4.5-1.el6.x86_64.rpm: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=glusterfs-epel clean metadata Trying other mirror. (8/23): glusterfs-fuse-3.4.5-1.el6.x86_64.rpm | 89 kB 00:00 http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/EPEL.repo/epel-6Server/x86_64/glusterfs-fuse-3.4.5-1.el6.x86_64.rpm: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=glusterfs-epel clean metadata Trying other mirror. (9/23): glusterfs-libs-3.4.5-1.el6.x86_64.rpm | 222 kB 00:00 http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/EPEL.repo/epel-6Server/x86_64/glusterfs-libs-3.4.5-1.el6.x86_64.rpm: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=glusterfs-epel clean metadata Trying other mirror. (10/23): glusterfs-server-3.4.5-1.el6.x86_64.rpm | 492 kB 00:00 http://download.gluster.org/pub/gluster/glusterfs/3.4/LATEST/EPEL.repo/epel-6Server/x86_64/glusterfs-server-3.4.5-1.el6.x86_64.rpm: [Errno -1] Package does not match intended download. Suggestion: run yum --enablerepo=glusterfs-epel clean metadata Trying other mirror. ... Across all my GlusterFS servers. I'm assuming this is a repo-side problem on download.gluster.org? (And yes I tried both yum clean metadata and yum clean all.) Thanks, -Chad ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] NetBSD autobuild and cmockery2
Justin Clift jcl...@redhat.com wrote: As a thought is this hours or days or etc away? As we way in french Un tiens vaut mieux que deux tu l'auras, which translated into less now is better than perhaps more later -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
