[Gluster-devel] New coding standard

[Jeff Darcy]

Let's open the *big* can of worms.  :)

We have a coding standard in our source tree.  It's incredibly outdated.
 It's missing many things we actually do enforce, either through that
commit script we inappropriately borrowed from a very different project
or via code reviews.  It does contain many things we don't enforce, and
a few where we enforce the exact opposite.  Its presence in this state
is an obstacle for new contributors.  If we're going to keep it at all,
we should update it to reflect what we really expect to see when
somebody submits a patch.  I've made a start on this with the following
patch.

https://review.gluster.org/#/c/17651/

Please join in with your own comments, especially additions.
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Glusto failures with dispersed volumes + Samba

[Pranith Kumar Karampuri]

On Thu, Jun 29, 2017 at 6:49 PM, Anoop C S  wrote:

> On Thu, 2017-06-29 at 16:35 +0530, Nigel Babu wrote:
> > Hi Pranith and Xavi,
> >
> > We seem to be running into a problem with glusto tests when we try to
> run them against dispersed
> > volumes over a CIFS mount[1].
>
> Is this a new test case? If not was it running successfully before?
>
> > You can find the logs attached to the job [2].
>
> VFS stat call failures are seen in Samba logs:
>
> [2017/06/29 11:01:55.959374,  0] ../source3/modules/vfs_
> glusterfs.c:870(vfs_gluster_stat)
>   glfs_stat(.) failed: Invalid argument
>
> I could also see the following errors(repeatedly..) in glusterfs client
> logs:
>
> [2017-06-29 10:33:43.031198] W [MSGID: 122019]
> [ec-helpers.c:412:ec_loc_gfid_check] 0-
> testvol_distributed-dispersed-disperse-0: Mismatching GFID's in loc
> [2017-06-29 10:33:43.031303] I [MSGID: 109094] 
> [dht-common.c:1016:dht_revalidate_cbk]
> 0-
> testvol_distributed-dispersed-dht: Revalidate: subvolume
> testvol_distributed-dispersed-disperse-0
> for /user11 (gfid = 665c515b-3940-480f-af7c-6aaf37731eaa) returned -1
> [Invalid argument]
>

This log basically says that EC received loc which has different gfids in
loc->inode->gfid and loc->gfid.


>
> > I've triggered a fresh job[3] to confirm that it only fails in these
> particular conditions and
> > certainly seems to be the case. The job is currently ongoing, so you may
> want to take a look when
> > you get some time how this job went.
> >
> > Let me know if you have any questions or need more debugging
> information.
> >
> > [1]: https://ci.centos.org/job/gluster_glusto/325/testReport/
> > [2]: https://ci.centos.org/job/gluster_glusto/325/artifact/
> > [3]: https://ci.centos.org/job/gluster_glusto/326/console
> >
> >
> > ___
> > Gluster-devel mailing list
> > Gluster-devel@gluster.org
> > http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Pranith
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Glusto failures with dispersed volumes + Samba

[Nigel Babu]

On Thu, Jun 29, 2017 at 6:49 PM, Anoop C S  wrote:

> Is this a new test case? If not was it running successfully before?
>

This test case is not new, but we weren't hitting this for quite a while
because we were failing because of a GNFS packaging issue. Now that I've
recently fixed it up, we're hitting more problems.
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Glusto failures with dispersed volumes + Samba

[Anoop C S]

On Thu, 2017-06-29 at 16:35 +0530, Nigel Babu wrote:
> Hi Pranith and Xavi,
> 
> We seem to be running into a problem with glusto tests when we try to run 
> them against dispersed
> volumes over a CIFS mount[1].

Is this a new test case? If not was it running successfully before?

> You can find the logs attached to the job [2].

VFS stat call failures are seen in Samba logs:

[2017/06/29 11:01:55.959374,  0] 
../source3/modules/vfs_glusterfs.c:870(vfs_gluster_stat)
  glfs_stat(.) failed: Invalid argument

I could also see the following errors(repeatedly..) in glusterfs client logs:

[2017-06-29 10:33:43.031198] W [MSGID: 122019] 
[ec-helpers.c:412:ec_loc_gfid_check] 0-
testvol_distributed-dispersed-disperse-0: Mismatching GFID's in loc
[2017-06-29 10:33:43.031303] I [MSGID: 109094] 
[dht-common.c:1016:dht_revalidate_cbk] 0-
testvol_distributed-dispersed-dht: Revalidate: subvolume 
testvol_distributed-dispersed-disperse-0
for /user11 (gfid = 665c515b-3940-480f-af7c-6aaf37731eaa) returned -1 [Invalid 
argument]

> I've triggered a fresh job[3] to confirm that it only fails in these 
> particular conditions and
> certainly seems to be the case. The job is currently ongoing, so you may want 
> to take a look when
> you get some time how this job went.
> 
> Let me know if you have any questions or need more debugging information. 
> 
> [1]: https://ci.centos.org/job/gluster_glusto/325/testReport/
> [2]: https://ci.centos.org/job/gluster_glusto/325/artifact/
> [3]: https://ci.centos.org/job/gluster_glusto/326/console
> 
> 
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Coverity covscan for 2017-06-29-c0f1db29 (master branch)

[staticanalysis]

GlusterFS Coverity covscan results are available from
http://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-06-29-c0f1db29
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Glusto failures with dispersed volumes + Samba

[Nigel Babu]

Hi Pranith and Xavi,

We seem to be running into a problem with glusto tests when we try to run
them against dispersed volumes over a CIFS mount[1]. You can find the logs
attached to the job [2].

I've triggered a fresh job[3] to confirm that it only fails in these
particular conditions and certainly seems to be the case. The job is
currently ongoing, so you may want to take a look when you get some time
how this job went.

Let me know if you have any questions or need more debugging information.

[1]: https://ci.centos.org/job/gluster_glusto/325/testReport/
[2]: https://ci.centos.org/job/gluster_glusto/325/artifact/
[3]: https://ci.centos.org/job/gluster_glusto/326/console


-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Questions] why shard feature doesn't support quota

[Xie Changlong]

Hi Krutika

Thanks for your quick response!

在 6/29/2017 3:24 PM, Krutika Dhananjay 写道:
This is based on my high-level understanding of quota in gluster - 
supporting quota on sharded volumes will require us to make quota xlator 
account for shards residing under the hidden ".shard" directory per file 
and adding this to the quota-xattr representing aggregated consumed size 
on the parent directory of the original file.


This isn't hard to do. But at the moment we support sharding only for VM 
image store use case.


Why sharding only support VM large images? It's interesting. More, are 
there other limits for sharding usage? We want to reduce data 
reconstruction time with sharding, as you know it takes too long time to 
recover data with raid, and sharding is a good choice to us.


There are plans to make shard useful for more generic use cases in the 
near term. When we get there, we will support quota too on sharded files.


That's a *good* news. BTW we also have a plan to implement this part. 
Any suggestions?




-Krutika



--
Thanks
-Xie
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Questions] why shard feature doesn't support quota

[Krutika Dhananjay]

This is based on my high-level understanding of quota in gluster -
supporting quota on sharded volumes will require us to make quota xlator
account for shards residing under the hidden ".shard" directory per file
and adding this to the quota-xattr representing aggregated consumed size on
the parent directory of the original file.

This isn't hard to do. But at the moment we support sharding only for VM
image store use case.
There are plans to make shard useful for more generic use cases in the near
term. When we get there, we will support quota too on sharded files.

-Krutika

On Thu, Jun 29, 2017 at 11:20 AM, Xie Changlong 
wrote:

> Hi all
>
> I did a small test on gluster 3.8.4, and found shard feature does not
> support quota.  Here is the step:
> $ gluster volume set s1 features.shard on
> $ gluster volume quota s1 enable
> $ gluster volume quota s1 limit-usage /ttt 1GB
> $ gluster volume quota s1 list
> $ cd /mnt/s1/ttt; fallocate -l 2GB testfile
> Then, i found testfile created sucessully.
>
> So, It seems shard doesn't support quota. It's a technical issue or there
> is a ongoing plan?
>
> --
> Thanks
> -Xie
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel