Re: [Gluster-devel] Release 3.12.6: Scheduled for the 12th of February

2018-02-02 Thread Nithya Balachandran 
On 2 February 2018 at 11:16, Jiffin Tony Thottan 
wrote:

> Hi,
>
> It's time to prepare the 3.12.6 release, which falls on the 10th of
> each month, and hence would be 12-02-2018 this time around.
>
> This mail is to call out the following,
>
> 1) Are there any pending **blocker** bugs that need to be tracked for
> 3.12.6? If so mark them against the provided tracker [1] as blockers
> for the release, or at the very least post them as a response to this
> mail
>
> 2) Pending reviews in the 3.12 dashboard will be part of the release,
> **iff** they pass regressions and have the review votes, so use the
> dashboard [2] to check on the status of your patches to 3.12 and get
> these going
>
> 3) I have made checks on what went into 3.10 post 3.12 release and if
> these fixes are already included in 3.12 branch, then status on this is
> **green**
> as all fixes ported to 3.10, are ported to 3.12 as well.
>

Hi Jiffin,

We will need to get https://review.gluster.org/19468 in. It is currently
pending regressions and should
make it well in time but this is a heads up.

Regards,
Nithya

> Thanks,
> Jiffin
>
> [1] Release bug tracker:
> https://bugzilla.redhat.com/show_bug.cgi?id=glusterfs-3.12.6
>
> [2] 3.12 review dashboard:
> https://review.gluster.org/#/projects/glusterfs,dashboards/
> dashboard:3-12-dashboard
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Release 4.0: Release notes (please read and contribute)

2018-02-02 Thread Ravishankar N 



On 02/01/2018 11:02 PM, Shyam Ranganathan wrote:

On 01/29/2018 05:10 PM, Shyam Ranganathan wrote:

Hi,

I have posted an initial draft version of the release notes here [1].

I would like to *suggest* the following contributors to help improve and
finish the release notes by 06th Feb, 2017. As you read this mail, if
you feel you cannot contribute, do let us know, so that we can find the
appropriate contributors for the same.

Reminder (1)

Request a response if you would be able to provide the release notes.
Release notes itself can come in later.

Helps plan for contingency in case you are unable to generate the
required notes.

Thanks!


NOTE: Please use the release tracker to post patches that modify the
release notes, the bug ID is *1539842* (see [2]).

1) Aravinda/Kotresh: Geo-replication section in the release notes

2) Kaushal/Aravinda/ppai: GD2 section in the release notes

3) Du/Poornima/Pranith: Performance section in the release notes

4) Amar: monitoring section in the release notes

Following are individual call outs for certain features:

1) "Ability to force permissions while creating files/directories on a
volume" - Niels

2) "Replace MD5 usage to enable FIPS support" - Ravi, Amar


+ Kotresh who has done most (all to be precise) of the patches listed in 
https://github.com/gluster/glusterfs/issues/230 in case he would like to 
add anything.


There is a pending work for this w.r.t rolling upgrade support.  I hope 
to work on this next week, but I cannot commit anything looking at other 
things in my queue :(.
To add more clarity, for fresh setup (clients + servers) in 4.0, 
enabling FIPS works fine. But we need to handle case of old servers and 
new clients and vice versa. If this can be considered a bug fix, then 
here is my attempt at the release notes for this fix:


"Previously, if gluster was run on a FIPS enabled system, it used to 
crash because gluster used MD5 checksum in various places like self-heal 
and geo-rep. This has been fixed by replacing MD5 with SHA256 which is 
FIPS compliant."


I'm happy to update the above text in doc/release-notes/4.0.0.md and 
send it on gerrit for review.



Regards,
Ravi






3) "Dentry fop serializer xlator on brick stack" - Du

4) "Add option to disable nftw() based deletes when purging the landfill
directory" - Amar

5) "Enhancements for directory listing in readdirp" - Nithya

6) "xlators should not provide init(), fini() and others directly, but
have class_methods" - Amar

7) "New on-wire protocol (XDR) needed to support iattx and cleaner
dictionary structure" - Amar

8) "The protocol xlators should prevent sending binary values in a dict
over the networks" - Amar

9) "Translator to handle 'global' options" - Amar

Thanks,
Shyam

[1] github link to draft release notes:
https://github.com/gluster/glusterfs/blob/release-4.0/doc/release-notes/4.0.0.md

[2] Initial gerrit patch for the release notes:
https://review.gluster.org/#/c/19370/
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Coverity covscan for 2018-02-02-641e5be8 (master branch)

2018-02-02 Thread staticanalysis 
GlusterFS Coverity covscan results are available from
http://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-02-02-641e5be8
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't let NFS cache stat after writes"

2018-02-02 Thread Storage, Dev (Nokia - Global) 
Hi, GlusterFS expert,

Our fix is as the patch, after test in our ENV, the issue seems gone, but I 
can’t confirm whether it will lead to other issue or not, And we suppose our 
change is not so fine.

So please share your comments , and hope you can give a good solution.

Thanks & Best Regards,
Storage DEV from Nokia

From: gluster-devel-boun...@gluster.org 
[mailto:gluster-devel-boun...@gluster.org] On Behalf Of Pranith Kumar Karampuri
Sent: Monday, January 29, 2018 8:23 AM
To: Lian, George (NSB - CN/Hangzhou) 
Cc: Li, Deqian (NSB - CN/Hangzhou) ; 
Gluster-devel@gluster.org; Zhou, Cynthia (NSB - CN/Hangzhou) 
; Sun, Ping (NSB - CN/Hangzhou) 

Subject: Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't 
let NFS cache stat after writes"

+Ravi, +Raghavendra G

On 25 Jan 2018 8:49 am, "Pranith Kumar Karampuri" 
> wrote:


On 25 Jan 2018 8:43 am, "Lian, George (NSB - CN/Hangzhou)" 
> wrote:
Hi,

I suppose the zero filled attr is for performance consider to NFS, but for 
fuse, it will lead issue such like hard LINK FOP,
So I suggest could we add 2 attr field in the endof "struct iatt {", such like 
ia_fuse_nlink, ia_fuse_ctime,
And in function gf_zero_fill_stat , saved the ia_nlink, ia_ctime to 
ia_fuse_nlink,ia_fuse_ctime before set its to zero,
And restore it to valued nlink and ctime in function gf_fuse_stat2attr,
So that kernel could get the correct nlink and ctime.

Is it a considerable solution? Any risk?

Please share your comments, thanks in advance!

Adding csaba for helping with this.


Best Regards,
George

-Original Message-
From: 
gluster-devel-boun...@gluster.org 
[mailto:gluster-devel-boun...@gluster.org]
 On Behalf Of Niels de Vos
Sent: Wednesday, January 24, 2018 7:43 PM
To: Pranith Kumar Karampuri >
Cc: Lian, George (NSB - CN/Hangzhou) 
>; Zhou, 
Cynthia (NSB - CN/Hangzhou) 
>; Li, Deqian 
(NSB - CN/Hangzhou) 
>; 
Gluster-devel@gluster.org; Sun, Ping (NSB - 
CN/Hangzhou) >
Subject: Re: [Gluster-devel] a link issue maybe introduced in a bug fix " Don't 
let NFS cache stat after writes"

On Wed, Jan 24, 2018 at 02:24:06PM +0530, Pranith Kumar Karampuri wrote:
> hi,
>In the same commit you mentioned earlier, there was this code
> earlier:
> -/* Returns 1 if the stat seems to be filled with zeroes. */ -int
> -nfs_zero_filled_stat (struct iatt *buf) -{
> -if (!buf)
> -return 1;
> -
> -/* Do not use st_dev because it is transformed to store the xlator
> id
> - * in place of the device number. Do not use st_ino because by
> this time
> - * we've already mapped the root ino to 1 so it is not guaranteed
> to be
> - * 0.
> - */
> -if ((buf->ia_nlink == 0) && (buf->ia_ctime == 0))
> -return 1;
> -
> -return 0;
> -}
> -
> -
>
> I moved this to a common library function that can be used in afr as well.
> Why was it there in NFS? +Niels for answering that question.

Sorry, I dont know why that was done. It was introduced with the initial gNFS 
implementation, long before I started to work with Gluster. The only reference 
I have is this from
xlators/nfs/server/src/nfs3-helpers.c:nfs3_stat_to_post_op_attr()

 371 /* Some performance translators return zero-filled stats when they
 372  * do not have up-to-date attributes. Need to handle this by not
 373  * returning these zeroed out attrs.
 374  */

This may not be true for the current situation anymore.

HTH,
Niels


>
> If I give you a patch which will assert the error condition, would it
> be possible for you to figure out the first xlator which is unwinding
> the iatt with nlink count as zero but ctime as non-zero?
>
> On Wed, Jan 24, 2018 at 1:03 PM, Lian, George (NSB - CN/Hangzhou) <
> george.l...@nokia-sbell.com> wrote:
>
> > Hi,  Pranith Kumar,
> >
> >
> >
> > Can you tell me while need set buf->ia_nlink to “0”in function
> > gf_zero_fill_stat(), which API or Application will care it?
> >
> > If I remove this line and also update corresponding in function
> > gf_is_zero_filled_stat,
> >
> > The issue seems gone, but I can’t confirm will lead to other issues.
> >
> >
> >
> > So could you please double check it and give your comments?
> >
> >
> >
> > My change is as the below:
> >
> >
> >
> > gf_boolean_t
> >
> >