Re: [Gluster-devel] Initiative to increase developer participation

2014-05-30 Thread Vikhyat Umrao

Thanks Pranith/Niels,
It is a great initiative, it will help us a lot :)

On 05/30/2014 01:16 PM, Niels de Vos wrote:

On Thu, May 29, 2014 at 11:08:34PM -0400, Pranith Kumar Karampuri wrote:

hi,
 We are taking an initiative to come up with some easy bugs where
 we can help volunteers in the community to send patches for.

Goals of this initiative:
  - Each maintainer needs to come up with a list of bugs that are easy
to fix in their components.
  - All the developers who are already active in the community to help
the new comers by answering the questions.
  - Improve developer documentation to address FAQ

Documentation in the wiki, mainly these pages:
- http://www.gluster.org/community/documentation/index.php/Main_Page#Developers
- http://www.gluster.org/community/documentation/index.php/Developers


  - Over time make these new comers as experienced developers in
glusterfs :-)

Maintainers,
  Could you please come up with the initial list of bugs by next
  Wednesday before community meeting?

If we mark bugs with the EasyFix keyword (see below), all bugs can get
listed with a simple Bugzilla query:
- 
https://bugzilla.redhat.com/buglist.cgi?bug_status=NEWkeywords=EasyFixproduct=GlusterFS


Niels,
Could you send out the guideline to mark the bugs as easy fix. Also
the wiki link for backports.

To mark a bug as Easy to Fix, open the Bug, and add in 'EasyFix' in the
'Keywords' field. Of course, it would help any newcomer if there is
a comment on where (i.e. which source file, function) the changes are
needed. For example, https://bugzilla.redhat.com/1100204 contains
a clear description what is needed, and where.

For the stable branches (release-3.4 and release-3.5 in the git
repository), it often is needed to 'backport' a change from the current
development branch (master). Backporting is for many changes relatively
easy and we have started to document the steps here:
- http://www.gluster.org/community/documentation/index.php/Backport_Guidelines

The Backport Wishlist is a list of patches/bugs that are proposed
candidates for backporting. When a backport request has been filed,
a bug for this backport and the release-version should be created.
Depending on the change, the EasyFix keyword could be set by the person
creating the bug (or by a developer or sub-maintainer after a review).


PS: This is not just for new comers to the community but also for
existing developers to explore other components.

Please feel free to suggest and give feedback to improve this process
:-).

And, as a reminder, anyone that is interested in trying to write
a patch, do not hesitate to ask questions. If something in the
documentation is unclear, we do need to know so that we can improve it.
Furthermore, I am of the opinion that there hardly exist stupid
questions, and it's more stupid to not ask questions that others can
easily answer. Always assume that if you have a question, someone else
would like to hear the answer too :-)
Reach out to the developers in #gluster or #gluster-dev on Freenode IRC,
or on one of the mailinglists, try to keep the discussions public so
that anyone can learn from it.

Thanks,
Niels
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] [wireshark] TODO features

2014-05-28 Thread Vikhyat Umrao
Hi Niels, 

Thanks for all your inputs and help, I have submitted a patch: 


https://code.wireshark.org/review/1833 





glusterfs: show filenames in the summary for common procedures 

With this patch we will have filename on the summary for procedures MKDIR, 
CREATE and LOOKUP. 




Example output: 

173 18.309307 192.168.100.3 - 192.168.100.4 GlusterFS 224 MKDIR V330 MKDIR 
Call, Filename: testdir 
2606 36.767766 192.168.100.3 - 192.168.100.4 GlusterFS 376 LOOKUP V330 LOOKUP 
Call, Filename: 1.txt 
2612 36.768242 192.168.100.3 - 192.168.100.4 GlusterFS 228 CREATE V330 CREATE 
Call, Filename: 1.txt 

Thanks, 
Vikhyat 

- Original Message -

From: Niels de Vos nde...@redhat.com 
To: Vikhyat Umrao vum...@redhat.com 
Cc: gluster-devel@gluster.org 
Sent: Tuesday, April 29, 2014 11:16:20 PM 
Subject: Re: [Gluster-devel] [wireshark] TODO features 

On Tue, Apr 29, 2014 at 06:25:15AM -0400, Vikhyat Umrao wrote: 
 Hi, 
 
 I am interested in TODO wireshark features for GlusterFS : 
 I can start from below given feature for one procedure: 
 = display the filename or filehandle on the summary for common procedures 

Things to get you and others prepared: 

1. go to https://forge.gluster.org/wireshark/pages/Todo 
2. login and edit the wiki page, add your name to the topic 
3. clone the wireshark repository: 
$ git clone g...@forge.gluster.org:wireshark/wireshark.git 
(you have been added to the 'wireshark' group, so you should have 
push access over ssh) 
4. create a new branch for your testing 
$ git checkout -t -b wip/master/visible-filenames upstream/master 
5. make sure you have all the dependencies for compiling Wireshark 
(quite a lot are needed) 
$ ./autogen.sh 
$ ./configure --disable-wireshark 
(I tend to build only the commandline tools like 'tshark') 
$ make 
6. you should now have a ./tshark executable that you can use for 
testing 


The changes you want to make are in epan/dissectors/packet-glusterfs.c. 
For example, start with adding the name of the file/dir that is passed 
to LOOKUP. The work to dissect the data in the network packet is done in 
glusterfs_gfs3_3_op_lookup_call(). It does not really matter on how that 
function gets executed, that is more a thing for an other task (add 
support for new procedures). 

In the NFS-dissector, you can see how this is done. Check the 
implementation of the dissect_nfs3_lookup_call() function in 
epan/dissectors/packet-nfs.c. The col_append_fstr() function achieves 
what you want to do. 

Of course, you really should share your changes! Now, 'git commit' your 
change with a suitable commit message and do 

$ git push origin wip/master/visible-filenames 

Your branch should now be visible under 
https://forge.gluster.org/wireshark/wireshark. Let me know, and I'll 
give it a whirl. 

Now you've done the filename for LOOKUP, I'm sure you can think of other 
things that make sense to get displayed. 

Do ask questions and send corrections if something is missing, or not 
working as explained here. This email should probably get included in 
the projects wiki https://forge.gluster.org/wireshark/pages/Home some 
where. 

Good luck, 
Niels 

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel