Re: [Gluster-devel] Patch merged in master branch for coding policy and patch submission
On Fri, Sep 19, 2014 at 6:06 PM, Emmanuel Dreyfus m...@netbsd.org wrote: Harshavardhana har...@harshavardhana.net wrote: This is to bring in adherence to coding policy, prior to patch submission for review. - no tabs - no whitespace - indentation (linux style) etc. What do we do whan the code surrounding the change has tabs? Should we adapt to the local style, or change everything? It ignores changes in certain types of files, but .c and .h shouldn't have tabs -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Patch merged in master branch for coding policy and patch submission
What do we do whan the code surrounding the change has tabs? Should we adapt to the local style, or change everything? It ignores changes in certain types of files, but .c and .h shouldn't have tabs So there are two possibilities - Whitespace - erroneous spaces between functions - Malformed sign-off - Wrong jenkins URL are hard errors and you wouldn't be allowed to submit. NOTE: yes it makes sure to ignore Markdown files which require white-space as their return character. Majority of them are treated as Warning, like tabs so which can be safely ignored or feel to fix them, a choice is given (y/n) -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
