[Gluster-devel] Regarding the coding guidelines script
Hi, I just ran ./rfc.sh to push my patch our for review and it failed the checkpatch.pl test. One of the warnings says the following: WARNING: quoted string split across lines #93: FILE: xlators/cluster/afr/src/afr-self-heal-entry.c:237: + gf_log (this-name, GF_LOG_DEBUG, Gfid mismatch + detected for %s/%s, %s on %s and %s on %s. I am not sure how we can get around this. Most of our gf_log() message strings (especially the ones inside nested blocks) will easily exceed 80 columns if this rule is going to be enforced. Do we really need this check? -Krutika ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regarding the coding guidelines script
Ah! Warnings are not the same as errors. :) Got it. -Krutika - Original Message - From: Krutika Dhananjay kdhan...@redhat.com To: FNU Harshavardhana fhars...@redhat.com Cc: Gluster Devel gluster-devel@gluster.org Sent: Monday, September 22, 2014 4:56:43 PM Subject: [Gluster-devel] Regarding the coding guidelines script Hi, I just ran ./rfc.sh to push my patch our for review and it failed the checkpatch.pl test. One of the warnings says the following: WARNING: quoted string split across lines #93: FILE: xlators/cluster/afr/src/afr-self-heal-entry.c:237: + gf_log (this-name, GF_LOG_DEBUG, Gfid mismatch + detected for %s/%s, %s on %s and %s on %s. I am not sure how we can get around this. Most of our gf_log() message strings (especially the ones inside nested blocks) will easily exceed 80 columns if this rule is going to be enforced. Do we really need this check? -Krutika ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regarding the coding guidelines script
I keep getting this warning(or maybe not) for checkpatch.pl itself
when I run rfc.sh.
`Useless use of greediness modifier '+' in regex; marked by -- HERE
in m/(^\+.*) {8,8}+ -- HERE \t/ at ./extras/checkpatch.pl line 2131.`
Anyone else seeing this?
~kaushal
On Mon, Sep 22, 2014 at 7:00 PM, Jeff Darcy jda...@redhat.com wrote:
Ah! Warnings are not the same as errors. :)
Got it.
We should probably disable those warnings anyway, as excessive
warnings can hide new/real problems. Since this is an
innocuous pattern that occurs frequently in our code, we don't
need the check for it.
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regarding the coding guidelines script
I'm using Perl 5.20.1. I was wondering how no one caught a mistake in
the checker.
~kaushal
On Mon, Sep 22, 2014 at 11:22 PM, Harshavardhana
har...@harshavardhana.net wrote:
On Mon, Sep 22, 2014 at 6:58 AM, Kaushal M kshlms...@gmail.com wrote:
I keep getting this warning(or maybe not) for checkpatch.pl itself
when I run rfc.sh.
`Useless use of greediness modifier '+' in regex; marked by -- HERE
in m/(^\+.*) {8,8}+ -- HERE \t/ at ./extras/checkpatch.pl line 2131.`
Anyone else seeing this?
Nope never seen it, what version of perl are you using?
There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness modifier '+' message each
time it's hit.
Let me remove it
-- Harsha
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Regarding the coding guidelines script
On Mon, Sep 22, 2014 at 10:57 AM, Kaushal M kshlms...@gmail.com wrote: I'm using Perl 5.20.1. I was wondering how no one caught a mistake in the checker. ~kaushal http://review.gluster.com/#/c/8811/ - here you go, please verify. -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
