Re: [Gluster-devel] Release 3.10 testing update: Older client unable to mount post upgrade

2017-02-16 Thread Poornima Gurusiddaiah
I think this is because of the commit 96fb3562. In this 3 options, which were
already in readdir-ahead but not exposed as volume set, were exposed as
volume set options(allowed to be set with op-version GD_OP_VERSION_3_9_1):
rda-request-size, rda-low-wmark, rda-cache-limit, rda-high-wmark 
Along with this, the type of rda-request-size was changed from INT to SIZE_t.
I think the new volfiles contain 'rda-request-size 128KB' but the old client
can only understand INT.

This cannot be documented and left, it has to be fixed. One way would be to
retain the type of rda-request-size as INT, but may be there is a better way
need to check.

Regards,
Poornima

- Original Message -
> From: "Shyam" 
> To: "Gluster Devel" , "Raghavendra Gowdappa" 
> , "Poornima
> Gurusiddaiah" , "Atin Mukherjee" 
> Sent: Friday, February 17, 2017 5:36:07 AM
> Subject: Release 3.10 testing update: Older client unable to mount post 
> upgrade
> 
> Hi,
> 
> Post upgrading brick nodes from 3.8.8 to 3.10rc0 (sort of), I tried a to
> mount from a 3.8.8 client (as I had not upgraded the client till then).
> The mount failed with the following in the logs (at the end of the mail).
> 
> The issue was that I did an rpm -U to get the latest version, so all vol
> files were upgraded (from the spec file, glusterd --xlator-option
> *.upgrade=on -N), this resulted in client vol files being upgraded as
> well, and now the client does not understand the option as below,
> 
> 0-testvolssd-readdir-ahead: invalid number format "128KB" in option
> "rda-request-size"
> 0-testvolssd-readdir-ahead: validate of rda-request-size returned -1
> 0-testvolssd-readdir-ahead: validation failed: invalid number format
> "128KB" in option "rda-request-size"
> 
> So is this a bug? Or something to document? or, am I missing something?
> Poornima/Du/Atin?
> 
> Thanks,
> Shyam
> 
> ::Full logs::
> # mount -t glusterfs 10.21.76.10:/testvolssd /mnt/testvol1
> Mount failed. Please check the log file for more details.
> 
> # cat /var/log/glusterfs/mnt-testvol1.log
> [2017-02-16 17:37:12.703983] I [MSGID: 100030] [glusterfsd.c:2454:main]
> 0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 3.8.8
> (args: /usr/sbin/glusterfs --volfile-server=10.21.76.10
> --volfile-id=/testvolssd /mnt/testvol1)
> [2017-02-16 17:37:12.726213] I [MSGID: 101190]
> [event-epoll.c:628:event_dispatch_epoll_worker] 0-epoll: Started thread
> with index 1
> [2017-02-16 17:37:12.744187] E [MSGID: 101002]
> [options.c:69:xlator_option_validate_int] 0-testvolssd-readdir-ahead:
> invalid number format "128KB" in option "rda-request-size"
> [2017-02-16 17:37:12.744221] W [MSGID: 101029]
> [options.c:945:xl_opt_validate] 0-testvolssd-readdir-ahead: validate of
> rda-request-size returned -1
> [2017-02-16 17:37:12.744235] E [MSGID: 101090]
> [graph.c:301:glusterfs_graph_validate_options]
> 0-testvolssd-readdir-ahead: validation failed: invalid number format
> "128KB" in option "rda-request-size"
> [2017-02-16 17:37:12.744248] E [MSGID: 101090]
> [graph.c:665:glusterfs_graph_activate] 0-graph: validate options failed
> [2017-02-16 17:37:12.753368] W [glusterfsd.c:1327:cleanup_and_exit]
> (-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x3c1) [0x7fbf4eb38eb1]
> -->/usr/sbin/glusterfs(glusterfs_process_volfp+0x172) [0x7fbf4eb335d2]
> -->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-:
> received signum (1), shutting down
> [2017-02-16 17:37:12.753420] I [fuse-bridge.c:5794:fini] 0-fuse:
> Unmounting '/mnt/testvol1'.
> [2017-02-16 17:37:12.753957] W [glusterfsd.c:1327:cleanup_and_exit]
> (-->/lib64/libpthread.so.0(+0x7dc5) [0x7fbf4d49edc5]
> -->/usr/sbin/glusterfs(glusterfs_sigwaiter+0xe5) [0x7fbf4eb32cd5]
> -->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-:
> received signum (15), shutting down
> 
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Release 3.10 testing update: Older client unable to mount post upgrade

2017-02-16 Thread Atin Mukherjee
This is definitely a bug and we have broken the older client support. [1]
is the one which has caused it.

We have changed the type of rda-request-size from int to size_t because of
which the older clients are unable to understand the KB format. I remember
when this patch was in its implementation this change had to be done to
avoid a crash [2] . We'd have to revert back the data type to int to ensure
backward compatibility, now how do we solve the crash which we were seeing
earlier is something to be looked at.

[1] https://review.gluster.org/#/c/16137/
[2] https://build.gluster.org/job/centos6-regression/2388/consoleFull




On Fri, Feb 17, 2017 at 5:36 AM, Shyam  wrote:

> Hi,
>
> Post upgrading brick nodes from 3.8.8 to 3.10rc0 (sort of), I tried a to
> mount from a 3.8.8 client (as I had not upgraded the client till then). The
> mount failed with the following in the logs (at the end of the mail).
>
> The issue was that I did an rpm -U to get the latest version, so all vol
> files were upgraded (from the spec file, glusterd --xlator-option
> *.upgrade=on -N), this resulted in client vol files being upgraded as well,
> and now the client does not understand the option as below,
>
> 0-testvolssd-readdir-ahead: invalid number format "128KB" in option
> "rda-request-size"
> 0-testvolssd-readdir-ahead: validate of rda-request-size returned -1
> 0-testvolssd-readdir-ahead: validation failed: invalid number format
> "128KB" in option "rda-request-size"
>
> So is this a bug? Or something to document? or, am I missing something?
> Poornima/Du/Atin?
>
> Thanks,
> Shyam
>
> ::Full logs::
> # mount -t glusterfs 10.21.76.10:/testvolssd /mnt/testvol1
> Mount failed. Please check the log file for more details.
>
> # cat /var/log/glusterfs/mnt-testvol1.log
> [2017-02-16 17:37:12.703983] I [MSGID: 100030] [glusterfsd.c:2454:main]
> 0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 3.8.8
> (args: /usr/sbin/glusterfs --volfile-server=10.21.76.10
> --volfile-id=/testvolssd /mnt/testvol1)
> [2017-02-16 17:37:12.726213] I [MSGID: 101190]
> [event-epoll.c:628:event_dispatch_epoll_worker] 0-epoll: Started thread
> with index 1
> [2017-02-16 17:37:12.744187] E [MSGID: 101002]
> [options.c:69:xlator_option_validate_int] 0-testvolssd-readdir-ahead:
> invalid number format "128KB" in option "rda-request-size"
> [2017-02-16 17:37:12.744221] W [MSGID: 101029]
> [options.c:945:xl_opt_validate] 0-testvolssd-readdir-ahead: validate of
> rda-request-size returned -1
> [2017-02-16 17:37:12.744235] E [MSGID: 101090]
> [graph.c:301:glusterfs_graph_validate_options]
> 0-testvolssd-readdir-ahead: validation failed: invalid number format
> "128KB" in option "rda-request-size"
> [2017-02-16 17:37:12.744248] E [MSGID: 101090]
> [graph.c:665:glusterfs_graph_activate] 0-graph: validate options failed
> [2017-02-16 17:37:12.753368] W [glusterfsd.c:1327:cleanup_and_exit]
> (-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x3c1) [0x7fbf4eb38eb1]
> -->/usr/sbin/glusterfs(glusterfs_process_volfp+0x172) [0x7fbf4eb335d2]
> -->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-:
> received signum (1), shutting down
> [2017-02-16 17:37:12.753420] I [fuse-bridge.c:5794:fini] 0-fuse:
> Unmounting '/mnt/testvol1'.
> [2017-02-16 17:37:12.753957] W [glusterfsd.c:1327:cleanup_and_exit]
> (-->/lib64/libpthread.so.0(+0x7dc5) [0x7fbf4d49edc5]
> -->/usr/sbin/glusterfs(glusterfs_sigwaiter+0xe5) [0x7fbf4eb32cd5]
> -->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-:
> received signum (15), shutting down
>



-- 

~ Atin (atinm)
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Release 3.10 testing update: Older client unable to mount post upgrade

2017-02-16 Thread Shyam

Hi,

Post upgrading brick nodes from 3.8.8 to 3.10rc0 (sort of), I tried a to 
mount from a 3.8.8 client (as I had not upgraded the client till then). 
The mount failed with the following in the logs (at the end of the mail).


The issue was that I did an rpm -U to get the latest version, so all vol 
files were upgraded (from the spec file, glusterd --xlator-option 
*.upgrade=on -N), this resulted in client vol files being upgraded as 
well, and now the client does not understand the option as below,


0-testvolssd-readdir-ahead: invalid number format "128KB" in option 
"rda-request-size"

0-testvolssd-readdir-ahead: validate of rda-request-size returned -1
0-testvolssd-readdir-ahead: validation failed: invalid number format 
"128KB" in option "rda-request-size"


So is this a bug? Or something to document? or, am I missing something? 
Poornima/Du/Atin?


Thanks,
Shyam

::Full logs::
# mount -t glusterfs 10.21.76.10:/testvolssd /mnt/testvol1
Mount failed. Please check the log file for more details.

# cat /var/log/glusterfs/mnt-testvol1.log
[2017-02-16 17:37:12.703983] I [MSGID: 100030] [glusterfsd.c:2454:main] 
0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 3.8.8 
(args: /usr/sbin/glusterfs --volfile-server=10.21.76.10 
--volfile-id=/testvolssd /mnt/testvol1)
[2017-02-16 17:37:12.726213] I [MSGID: 101190] 
[event-epoll.c:628:event_dispatch_epoll_worker] 0-epoll: Started thread 
with index 1
[2017-02-16 17:37:12.744187] E [MSGID: 101002] 
[options.c:69:xlator_option_validate_int] 0-testvolssd-readdir-ahead: 
invalid number format "128KB" in option "rda-request-size"
[2017-02-16 17:37:12.744221] W [MSGID: 101029] 
[options.c:945:xl_opt_validate] 0-testvolssd-readdir-ahead: validate of 
rda-request-size returned -1
[2017-02-16 17:37:12.744235] E [MSGID: 101090] 
[graph.c:301:glusterfs_graph_validate_options] 
0-testvolssd-readdir-ahead: validation failed: invalid number format 
"128KB" in option "rda-request-size"
[2017-02-16 17:37:12.744248] E [MSGID: 101090] 
[graph.c:665:glusterfs_graph_activate] 0-graph: validate options failed
[2017-02-16 17:37:12.753368] W [glusterfsd.c:1327:cleanup_and_exit] 
(-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x3c1) [0x7fbf4eb38eb1] 
-->/usr/sbin/glusterfs(glusterfs_process_volfp+0x172) [0x7fbf4eb335d2] 
-->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-: 
received signum (1), shutting down
[2017-02-16 17:37:12.753420] I [fuse-bridge.c:5794:fini] 0-fuse: 
Unmounting '/mnt/testvol1'.
[2017-02-16 17:37:12.753957] W [glusterfsd.c:1327:cleanup_and_exit] 
(-->/lib64/libpthread.so.0(+0x7dc5) [0x7fbf4d49edc5] 
-->/usr/sbin/glusterfs(glusterfs_sigwaiter+0xe5) [0x7fbf4eb32cd5] 
-->/usr/sbin/glusterfs(cleanup_and_exit+0x6b) [0x7fbf4eb32b4b] ) 0-: 
received signum (15), shutting down

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel