Re: [Gluster-devel] With what code/tree should the regression tests be run?
On Sun, 16 Nov 2014 10:45:50 +0530 Humble Devassy Chirammal humble.deva...@gmail.com wrote: I do believe (a) looks to be the correct way to go. --Humble --Humble On Sat, Nov 15, 2014 at 4:52 PM, Niels de Vos nde...@redhat.com wrote: On Sat, Nov 15, 2014 at 11:46:46AM +0530, RAGHAVENDRA TALUR wrote: I could not reply to this thread yesterday. Earlier, test system used to take care of the rebase. However, it worked here only after I did a manual rebase on my machine and updated gerrit. Indeed, and I have noticed that too. I remember being able to just resubmit the failed regression tests, and the change would be rebased on top of HEAD of the branch. To me, that also looks a safer way of going things, (relatively) old patches can be tested easier that way. I suspect that this change came with the triggered regression testing, but I have not checked that. Do others have an opionion on with what code the regression tests should be executed? Currently I am aware of two possible ways: a. checkout the HEAD of the branch and cherry-pick the change on top b. checkout the change (use the tree from the time the change was posted) (b) seems to be the current way, my preference would go to (a). Please voice your opinions. Thanks, Niels This makes more sense to me in general too, except for when there are several patches dependant on each other. eg 3 patches in a series, which need to be applied in a specific order Conceptually, I'm not sure how to make that work if every patch is just automatically applied to HEAD. I guess it'll be a good idea to look into Gerrit stuff again next week. ;) + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] With what code/tree should the regression tests be run?
On Sat, Nov 15, 2014 at 11:46:46AM +0530, RAGHAVENDRA TALUR wrote: I could not reply to this thread yesterday. Earlier, test system used to take care of the rebase. However, it worked here only after I did a manual rebase on my machine and updated gerrit. Indeed, and I have noticed that too. I remember being able to just resubmit the failed regression tests, and the change would be rebased on top of HEAD of the branch. To me, that also looks a safer way of going things, (relatively) old patches can be tested easier that way. I suspect that this change came with the triggered regression testing, but I have not checked that. Do others have an opionion on with what code the regression tests should be executed? Currently I am aware of two possible ways: a. checkout the HEAD of the branch and cherry-pick the change on top b. checkout the change (use the tree from the time the change was posted) (b) seems to be the current way, my preference would go to (a). Please voice your opinions. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] With what code/tree should the regression tests be run?
I do believe (a) looks to be the correct way to go. --Humble --Humble On Sat, Nov 15, 2014 at 4:52 PM, Niels de Vos nde...@redhat.com wrote: On Sat, Nov 15, 2014 at 11:46:46AM +0530, RAGHAVENDRA TALUR wrote: I could not reply to this thread yesterday. Earlier, test system used to take care of the rebase. However, it worked here only after I did a manual rebase on my machine and updated gerrit. Indeed, and I have noticed that too. I remember being able to just resubmit the failed regression tests, and the change would be rebased on top of HEAD of the branch. To me, that also looks a safer way of going things, (relatively) old patches can be tested easier that way. I suspect that this change came with the triggered regression testing, but I have not checked that. Do others have an opionion on with what code the regression tests should be executed? Currently I am aware of two possible ways: a. checkout the HEAD of the branch and cherry-pick the change on top b. checkout the change (use the tree from the time the change was posted) (b) seems to be the current way, my preference would go to (a). Please voice your opinions. Thanks, Niels ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
