Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Saravanakumar Arumugam]

Hi Raghavendra,

Can we have this documented (with a example workflow) here:
http://gluster.readthedocs.org/en/latest/Developer-guide/Development-Workflow/

Thanks,
Saravana

On 03/07/2016 10:57 AM, Raghavendra Talur wrote:



On Fri, Mar 4, 2016 at 6:13 PM, Raghavendra Talur > wrote:




On Thu, Feb 4, 2016 at 7:13 PM, Niels de Vos > wrote:

On Thu, Feb 04, 2016 at 04:15:16PM +0530, Raghavendra Talur wrote:
> On Thu, Feb 4, 2016 at 4:13 PM, Niels de Vos
> wrote:
>
> > On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra
Talur wrote:
> > > Hi,
> > >
> > > We recently changed the jenkins builds to be triggered
on the following
> > > triggers.
> > >
> > > 1. Verified+1
> > > 2. Code-review+2
> > > 3. recheck (netbsd|centos|smoke)
> > >
> > > There is a bug in 1 and 2.
> > >
> > > Multiple triggers of 1 or 2 would result in re-runs even
when not
> > intended.
> > >
> > > I would like to replace 1 and 2 with a comment
"run-all-regression" or
> > > something like that.
> > > Thoughts?
> >
> > Maybe starting regressions on Code-Review +1 (or +2) only?
> >
>
> Multiple code-reviews would do multiple triggers. Won't work.

How can we make this to work, without the need of providing magic
comments?


I investigated but couldn't find a way to make it work. Discussed
with Kaushal and we feel it should be ok to go with a "check all"
comment for initial regression run and deprecate Code-Review+2 and
Verified+1 triggers.

I would like to go ahead and do it as the build queue is
increasing again just because of Code-Review+2's given just before
a patch is merged; they don't serve any purpose.


I have for now just removed trigger for code-review.
Trigger for verified+1 remains as is.
No new trigger on comments have been added.


Niels





___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Raghavendra Talur]

On Fri, Mar 4, 2016 at 6:13 PM, Raghavendra Talur  wrote:

>
>
> On Thu, Feb 4, 2016 at 7:13 PM, Niels de Vos  wrote:
>
>> On Thu, Feb 04, 2016 at 04:15:16PM +0530, Raghavendra Talur wrote:
>> > On Thu, Feb 4, 2016 at 4:13 PM, Niels de Vos  wrote:
>> >
>> > > On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra Talur wrote:
>> > > > Hi,
>> > > >
>> > > > We recently changed the jenkins builds to be triggered on the
>> following
>> > > > triggers.
>> > > >
>> > > > 1. Verified+1
>> > > > 2. Code-review+2
>> > > > 3. recheck (netbsd|centos|smoke)
>> > > >
>> > > > There is a bug in 1 and 2.
>> > > >
>> > > > Multiple triggers of 1 or 2 would result in re-runs even when not
>> > > intended.
>> > > >
>> > > > I would like to replace 1 and 2 with a comment "run-all-regression"
>> or
>> > > > something like that.
>> > > > Thoughts?
>> > >
>> > > Maybe starting regressions on Code-Review +1 (or +2) only?
>> > >
>> >
>> > Multiple code-reviews would do multiple triggers. Won't work.
>>
>> How can we make this to work, without the need of providing magic
>> comments?
>>
>
> I investigated but couldn't find a way to make it work. Discussed with
> Kaushal and we feel it should be ok to go with a "check all" comment for
> initial regression run and deprecate Code-Review+2 and Verified+1 triggers.
>
> I would like to go ahead and do it as the build queue is increasing again
> just because of Code-Review+2's given just before a patch is merged; they
> don't serve any purpose.
>

I have for now just removed trigger for code-review.
Trigger for verified+1 remains as is.
No new trigger on comments have been added.


>> Niels
>>
>
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Raghavendra Talur]

On Thu, Feb 4, 2016 at 7:13 PM, Niels de Vos  wrote:

> On Thu, Feb 04, 2016 at 04:15:16PM +0530, Raghavendra Talur wrote:
> > On Thu, Feb 4, 2016 at 4:13 PM, Niels de Vos  wrote:
> >
> > > On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra Talur wrote:
> > > > Hi,
> > > >
> > > > We recently changed the jenkins builds to be triggered on the
> following
> > > > triggers.
> > > >
> > > > 1. Verified+1
> > > > 2. Code-review+2
> > > > 3. recheck (netbsd|centos|smoke)
> > > >
> > > > There is a bug in 1 and 2.
> > > >
> > > > Multiple triggers of 1 or 2 would result in re-runs even when not
> > > intended.
> > > >
> > > > I would like to replace 1 and 2 with a comment "run-all-regression"
> or
> > > > something like that.
> > > > Thoughts?
> > >
> > > Maybe starting regressions on Code-Review +1 (or +2) only?
> > >
> >
> > Multiple code-reviews would do multiple triggers. Won't work.
>
> How can we make this to work, without the need of providing magic
> comments?
>

I investigated but couldn't find a way to make it work. Discussed with
Kaushal and we feel it should be ok to go with a "check all" comment for
initial regression run and deprecate Code-Review+2 and Verified+1 triggers.

I would like to go ahead and do it as the build queue is increasing again
just because of Code-Review+2's given just before a patch is merged; they
don't serve any purpose.


>
> Niels
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Pranith Kumar Karampuri]

On 02/04/2016 03:39 PM, Kaushal M wrote:

I'm okay with this.

+1



On Thu, Feb 4, 2016 at 3:34 PM, Raghavendra Talur  wrote:

Hi,

We recently changed the jenkins builds to be triggered on the following
triggers.

1. Verified+1
2. Code-review+2
3. recheck (netbsd|centos|smoke)

There is a bug in 1 and 2.

Multiple triggers of 1 or 2 would result in re-runs even when not intended.

I would like to replace 1 and 2 with a comment "run-all-regression" or
something like that.
Thoughts?


Thanks
Raghavendra Talur


___
Gluster-infra mailing list
gluster-in...@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-infra

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Kaushal M]

I'm okay with this.


On Thu, Feb 4, 2016 at 3:34 PM, Raghavendra Talur  wrote:
> Hi,
>
> We recently changed the jenkins builds to be triggered on the following
> triggers.
>
> 1. Verified+1
> 2. Code-review+2
> 3. recheck (netbsd|centos|smoke)
>
> There is a bug in 1 and 2.
>
> Multiple triggers of 1 or 2 would result in re-runs even when not intended.
>
> I would like to replace 1 and 2 with a comment "run-all-regression" or
> something like that.
> Thoughts?
>
>
> Thanks
> Raghavendra Talur
>
>
> ___
> Gluster-infra mailing list
> gluster-in...@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-infra
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Niels de Vos]

On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra Talur wrote:
> Hi,
> 
> We recently changed the jenkins builds to be triggered on the following
> triggers.
> 
> 1. Verified+1
> 2. Code-review+2
> 3. recheck (netbsd|centos|smoke)
> 
> There is a bug in 1 and 2.
> 
> Multiple triggers of 1 or 2 would result in re-runs even when not intended.
> 
> I would like to replace 1 and 2 with a comment "run-all-regression" or
> something like that.
> Thoughts?

Maybe starting regressions on Code-Review +1 (or +2) only?

Niels


signature.asc
Description: PGP signature
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Raghavendra Talur]

On Thu, Feb 4, 2016 at 4:13 PM, Niels de Vos  wrote:

> On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra Talur wrote:
> > Hi,
> >
> > We recently changed the jenkins builds to be triggered on the following
> > triggers.
> >
> > 1. Verified+1
> > 2. Code-review+2
> > 3. recheck (netbsd|centos|smoke)
> >
> > There is a bug in 1 and 2.
> >
> > Multiple triggers of 1 or 2 would result in re-runs even when not
> intended.
> >
> > I would like to replace 1 and 2 with a comment "run-all-regression" or
> > something like that.
> > Thoughts?
>
> Maybe starting regressions on Code-Review +1 (or +2) only?
>

Multiple code-reviews would do multiple triggers. Won't work.


>
> Niels
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-infra] Code-Review+2 and Verified+1 cause multiple retriggers on Jenkins

[Niels de Vos]

On Thu, Feb 04, 2016 at 04:15:16PM +0530, Raghavendra Talur wrote:
> On Thu, Feb 4, 2016 at 4:13 PM, Niels de Vos  wrote:
> 
> > On Thu, Feb 04, 2016 at 03:34:05PM +0530, Raghavendra Talur wrote:
> > > Hi,
> > >
> > > We recently changed the jenkins builds to be triggered on the following
> > > triggers.
> > >
> > > 1. Verified+1
> > > 2. Code-review+2
> > > 3. recheck (netbsd|centos|smoke)
> > >
> > > There is a bug in 1 and 2.
> > >
> > > Multiple triggers of 1 or 2 would result in re-runs even when not
> > intended.
> > >
> > > I would like to replace 1 and 2 with a comment "run-all-regression" or
> > > something like that.
> > > Thoughts?
> >
> > Maybe starting regressions on Code-Review +1 (or +2) only?
> >
> 
> Multiple code-reviews would do multiple triggers. Won't work.

How can we make this to work, without the need of providing magic
comments?

Niels


signature.asc
Description: PGP signature
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel