Re: [Gluster-devel] Is it OK to pick Code-Reviewer(s)

2014-07-14 Thread Jeff Darcy
 When submitting patches where there is an/some obvious person(s) to blame,
 is it OK/desirable to request them as Code-Reviewers in gerrit?

Inviting reviewers with clear interest or knowledge in a piece of code is
not only OK but recommended.  I think blame might not be a good idea,
though.
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Is it OK to pick Code-Reviewer(s)

2014-07-14 Thread Harshavardhana
On Mon, Jul 14, 2014 at 9:31 AM, Anders Blomdell
anders.blomd...@control.lth.se wrote:
 When submitting patches where there is an/some obvious person(s) to blame,
 is it OK/desirable to request them as Code-Reviewers in gerrit?

Gist of adding Core-Reviewers is to find faults in oneself - not the
other way around :-)

-- 
Religious confuse piety with mere ritual, the virtuous confuse
regulation with outcomes
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://supercolony.gluster.org/mailman/listinfo/gluster-devel