Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-31 Thread Venky Shankar
On Tue, Mar 31, 2015 at 12:14 PM, Vijay Bellur vbel...@redhat.com wrote:
 On 03/28/2015 02:08 PM, Emmanuel Dreyfus wrote:

 Pranith Kumar Karampuri pkara...@redhat.com wrote:

 Emmanuel,
   What can we do to make it vote -2 when it fails? Things will
 automatically fall in place if it gives -2.


 I will do this once I will have recovered. The changelog change broke
 regression for weeks, and now we have a fix for it I discover many other
 poblems have crop.

 While there, to anyone:
 - dd bs=1M is not portable. Use
dd bs=1024k
 - echo 3  /proc/sys/vm/drop_caches is not portable. use instead this
 command that fails but flushes inodes first.
( cd $M0  umount $M0 )
 - umount $N0 brings many problems, use instead
EXPECT_WITHIN $UMOUNT_TIMEOUT Y umount_nfs $N0



 I wonder if we can add these as checks to flag errors in checkpatch.pl so
 that we nip these problems off even before they appear for review?

Makes sense. Over the time we would have a good list of portability checks.


 Thanks,
 Vijay


 ___
 Gluster-devel mailing list
 Gluster-devel@gluster.org
 http://www.gluster.org/mailman/listinfo/gluster-devel
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-28 Thread Emmanuel Dreyfus
Justin Clift jus...@gluster.org wrote:

 Atin has an initial fix for the breakage here:
   http://review.gluster.org/#/c/10032/
 Does that help? :)

I saw that. Tests running...

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
m...@netbsd.org
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-28 Thread Pranith Kumar Karampuri


On 03/28/2015 02:08 PM, Emmanuel Dreyfus wrote:

Pranith Kumar Karampuri pkara...@redhat.com wrote:


Emmanuel,
  What can we do to make it vote -2 when it fails? Things will
automatically fall in place if it gives -2.

I will do this once I will have recovered. The changelog change broke
regression for weeks, and now we have a fix for it I discover many other
poblems have crop.
By which time some more problems may creep in, it will be chicken and 
egg problem. Force a -2. Everybody will work just on Netbsd for a while 
but after that things should be just similar to Linux. It would probably 
be a good idea to decide a date on which this forcing would happen.


Pranith


While there, to anyone:
- dd bs=1M is not portable. Use
   dd bs=1024k
- echo 3  /proc/sys/vm/drop_caches is not portable. use instead this
command that fails but flushes inodes first.
   ( cd $M0  umount $M0 )
- umount $N0 brings many problems, use instead
   EXPECT_WITHIN $UMOUNT_TIMEOUT Y umount_nfs $N0




___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-28 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri pkara...@redhat.com wrote:

 By which time some more problems may creep in, it will be chicken and
 egg problem. Force a -2. Everybody will work just on Netbsd for a while
 but after that things should be just similar to Linux. It would probably
 be a good idea to decide a date on which this forcing would happen.

I will submit a batch of fixes within the next hours. Once they are
merged we will have a sane situation again.

Except that http://review.gluster.org/10019 causes a few spurious bugs
to become reliable. Once that one is merged, NetBSD regression will be
broken again. 
-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
m...@netbsd.org
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-28 Thread Justin Clift
On 28 Mar 2015, at 13:12, Emmanuel Dreyfus m...@netbsd.org wrote:
 Pranith Kumar Karampuri pkara...@redhat.com wrote:
 
 By which time some more problems may creep in, it will be chicken and
 egg problem. Force a -2. Everybody will work just on Netbsd for a while
 but after that things should be just similar to Linux. It would probably
 be a good idea to decide a date on which this forcing would happen.
 
 I will submit a batch of fixes within the next hours. Once they are
 merged we will have a sane situation again.
 
 Except that http://review.gluster.org/10019 causes a few spurious bugs
 to become reliable. Once that one is merged, NetBSD regression will be
 broken again.

Atin has an initial fix for the breakage here:

  http://review.gluster.org/#/c/10032/

Does that help? :)

+ Justin

--
GlusterFS - http://www.gluster.org

An open source, distributed file system scaling to several
petabytes, and handling thousands of clients.

My personal twitter: twitter.com/realjustinclift

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-28 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri pkara...@redhat.com wrote:

 Emmanuel,
  What can we do to make it vote -2 when it fails? Things will
 automatically fall in place if it gives -2.

I will do this once I will have recovered. The changelog change broke
regression for weeks, and now we have a fix for it I discover many other
poblems have crop.

While there, to anyone: 
- dd bs=1M is not portable. Use 
  dd bs=1024k
- echo 3  /proc/sys/vm/drop_caches is not portable. use instead this
command that fails but flushes inodes first.
  ( cd $M0  umount $M0 )
- umount $N0 brings many problems, use instead
  EXPECT_WITHIN $UMOUNT_TIMEOUT Y umount_nfs $N0


-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
m...@netbsd.org
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-27 Thread Pranith Kumar Karampuri


On 03/25/2015 07:18 PM, Emmanuel Dreyfus wrote:

On Wed, Mar 25, 2015 at 02:04:10PM +0100, Niels de Vos wrote:

1. Who is going to maintain the new features?
2. Maintainers should be active in responding to users
3. What about reported bugs, there is the Bug Triaging in place?
4. Maintainers should keep an eye on open bugs affecting their component
5. Maintainers are expected to be responsive on patch reviews
6. Maintainers should try to attend IRC meetings

May I suggest a personnal item:
  7. Check your feature does not break NetBSD regression

NetBSD regression does not vote but is reported in gerrit. Please seek
help resolving breakage before merging.

Emmanuel,
What can we do to make it vote -2 when it fails? Things will 
automatically fall in place if it gives -2.


Pranith




___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel


Re: [Gluster-devel] Responsibilities and expectations of our maintainers

2015-03-25 Thread Emmanuel Dreyfus
On Wed, Mar 25, 2015 at 02:04:10PM +0100, Niels de Vos wrote:
 1. Who is going to maintain the new features?
 2. Maintainers should be active in responding to users
 3. What about reported bugs, there is the Bug Triaging in place?
 4. Maintainers should keep an eye on open bugs affecting their component
 5. Maintainers are expected to be responsive on patch reviews
 6. Maintainers should try to attend IRC meetings

May I suggest a personnal item:
 7. Check your feature does not break NetBSD regression

NetBSD regression does not vote but is reported in gerrit. Please seek
help resolving breakage before merging.

-- 
Emmanuel Dreyfus
m...@netbsd.org
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel