[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184 Niels de Vos changed: What|Removed |Added CC||nde...@redhat.com --- Comment #6 from Niels de Vos --- (In reply to Aravinda VK from comment #5) > Maintainers can watch the files/directories which they maintain. If any > patch touches watched file/directory then it sends mail. Indeed, and maintainers are expected to configure their Gerrit account like that. This is even one of the things we document relatively well: http://gluster.readthedocs.io/en/latest/Contributors-Guide/Guidelines-For-Maintainers/#patches-in-gerrit -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1P6foK2PnI&a=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184 Aravinda VK changed: What|Removed |Added CC||avish...@redhat.com --- Comment #5 from Aravinda VK --- Maintainers can watch the files/directories which they maintain. If any patch touches watched file/directory then it sends mail. - Go to project settings->Watched Projects https://review.gluster.org/#/settings/projects - Enter project name and then set filters Example: Project: glusterfs Only If: file:"^geo-replication/*" Project: glusterfs Only If: file:^glusterfs.spec.in -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SB8w3WStZt&a=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184 Shyamsundar changed: What|Removed |Added CC||srang...@redhat.com --- Comment #4 from Shyamsundar --- This falls under keeping a tab on the review queue, and appropriately taking action to assign to self, or others as the need maybe. I see this as a maintainer activity primarily, and others can pitch in based on interest, but maintainers cannot/should not miss this. Considering this, I would prefer that default assignment falls to maintainers, who can then choose to add more folks to the review. IOW, what Niels states in comment#3. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cNb5maBiCK&a=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184
--- Comment #3 from Niels de Vos ---
QEMU, the Linux kernel and other projects use a script called
'get_maintainer.pl'
(https://github.com/qemu/qemu/blob/master/scripts/get_maintainer.pl). We should
be able to add a simple Jenkins job as part of smoke that finds the best
suitable persons to review a change.
The Gerrit cli is pretty usable for adding reviewers:
$ ssh u...@review.gluster.org \
gerrit set-reviewers ${COMMIT} -a ${REVIEWER_EMAIL}
Because our MAINTAINERS file uses the same format as QEMU and the kernel, it
should be trivial to use the get_maintainers.pl script. I do not know how the
Gerrit extension works, but I prefer to have the configuration for the
maintainers of files in the MAINTAINERS file in the repository itself.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=P0JD53kD9g&a=cc_unsubscribe
___
Gluster-infra mailing list
Gluster-infra@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184 Prashanth Pai changed: What|Removed |Added CC||p...@redhat.com --- Comment #2 from Prashanth Pai --- Sometimes, there are changes from new contributors which go unnoticed because no reviewers were added. I've seen Jeff and Amar diligently going through these new changes without reviewers. There should be a better mechanism for maintainers to subscribe or notice new incoming changes and this will greatly help. Some thoughts on this: * Github 'suggests' reviewers for PRs based on git blame. The PR author can choose or ignore to add them as reviewers. If Gerrit can suggest reviewers in the UI, it'd be great. * If Gerrit allows, you could check if the potential reviewer (based on git blame) has had reviewing activity in recent past (to filter out non active contributors), and then add them as reviewer. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=13q3rARj3d&a=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1451184] Assign reviewers based on who touched the file last
https://bugzilla.redhat.com/show_bug.cgi?id=1451184 Jeff Darcy changed: What|Removed |Added CC||j...@pl.atyp.us --- Comment #1 from Jeff Darcy --- How tunable is the Gerrit extension? I can think of at least two cases where this would be more annoying than useful. (a) For frequently contended files (e.g. glusterd-volume-set.c). (b) For sweeping but superficial changes (e.g. copyright). Overall it seems like a good idea, but I'd be wary of the details. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pvdAXnX5PD&a=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
