Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Debarshi Ray]

On Fri, Sep 11, 2015 at 01:51:10PM +, Debarshi Ray wrote:
> I would like to merge the Last.fm provider for gnome-online-accounts:
> https://bugzilla.gnome.org/show_bug.cgi?id=728621

Thanks for the ACKs so far. I still need one more from the release team.

To respond to Javier's concerns, the patch doesn't affect any existing
users of gnome-online-accounts because the code is entirely optional
unless you choose to use Last.fm.

Plus it is not enabled by default in upstream builds, so unless a
distributor chooses to turn it on, it won't be visible to
users. However, merging it would make it easier to proceed with the
grilo and gnome-music work, so I don't want to wait for another six
months.

Thanks,
Debarshi

pgp7lMA82FthE.pgp
Description: PGP signature
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Frederic Peters]

Javier Jardón wrote:

> > The code is optional and not enabled by default, but having it merged
> > would make it easier to proceed with the required work on grilo and
> > gnome-music.
> [...]
> Its a bit late to add new features, but I trust you and Bastien this
> has been properly tested:
> 
> 1/2 for release team

As it's hardly a feature if it's not enabled this doesn't even require
an approval by the release team (imo).

Still, 2/2.


Fred
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Javier Jardón]

On 11 September 2015 at 14:51, Debarshi Ray  wrote:
> Hello everybody,
>
> I would like to merge the Last.fm provider for gnome-online-accounts:
> https://bugzilla.gnome.org/show_bug.cgi?id=728621
>
> You can find a screenshot on the bug, and the two new strings added
> are:
>   * "Last.fm"
>   * "Error connecting to Last.fm"
>
> The code is optional and not enabled by default, but having it merged
> would make it easier to proceed with the required work on grilo and
> gnome-music.
>
> Thanks,
> Debarshi

Its a bit late to add new features, but I trust you and Bastien this
has been properly tested:

1/2 for release team

-- 
Javier Jardón Cabezas
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Bastien Nocera]

On Fri, 2015-09-11 at 13:51 +, Debarshi Ray wrote:
> Hello everybody,
> 
> I would like to merge the Last.fm provider for gnome-online-accounts:
> https://bugzilla.gnome.org/show_bug.cgi?id=728621
> 
> You can find a screenshot on the bug, and the two new strings added
> are:
>   * "Last.fm"
>   * "Error connecting to Last.fm"
> 
> The code is optional and not enabled by default, but having it merged
> would make it easier to proceed with the required work on grilo and
> gnome-music.

Note that for grilo, we would hack around the problem by hard-coding
the same access key that gnome-online-accounts is using into the
plugin. So it wouldn't be required for grilo, but would certainly be
useful for other types of integration in third-party apps that do not
follow GNOME's schedule (Rhythmbox for example).

Cheers
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Piotr Drąg]

2015-09-11 15:51 GMT+02:00 Debarshi Ray :
> Hello everybody,
>
> I would like to merge the Last.fm provider for gnome-online-accounts:
> https://bugzilla.gnome.org/show_bug.cgi?id=728621
>
> You can find a screenshot on the bug, and the two new strings added
> are:
>   * "Last.fm"
>   * "Error connecting to Last.fm"
>
> The code is optional and not enabled by default, but having it merged
> would make it easier to proceed with the required work on grilo and
> gnome-music.
>

I'm personally looking forward to that feature. It's also isolated,
and we have another week to update translations. 1/2 from i18n.

Best regards,

-- 
Piotr Drąg
http://raven.fedorapeople.org/
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list

Re: gnome-online-accounts: Permission to merge the Last.fm provider

[Daniel Mustieles García]

2/2 from i18n

Cheers!
El 11/09/2015 17:52, "Piotr Drąg"  escribió:

> 2015-09-11 15:51 GMT+02:00 Debarshi Ray :
> > Hello everybody,
> >
> > I would like to merge the Last.fm provider for gnome-online-accounts:
> > https://bugzilla.gnome.org/show_bug.cgi?id=728621
> >
> > You can find a screenshot on the bug, and the two new strings added
> > are:
> >   * "Last.fm"
> >   * "Error connecting to Last.fm"
> >
> > The code is optional and not enabled by default, but having it merged
> > would make it easier to proceed with the required work on grilo and
> > gnome-music.
> >
>
> I'm personally looking forward to that feature. It's also isolated,
> and we have another week to update translations. 1/2 from i18n.
>
> Best regards,
>
> --
> Piotr Drąg
> http://raven.fedorapeople.org/
> ___
> release-t...@gnome.org
> https://mail.gnome.org/mailman/listinfo/release-team
> Release-team lurker? Do NOT participate in discussions.
___
gnome-doc-list mailing list
gnome-doc-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gnome-doc-list