Re: Code freeze break request for gnome-shell
Le vendredi 25 mars 2011, à 10:11 -0400, Matthias Clasen a écrit : On Fri, Mar 25, 2011 at 8:50 AM, Lucian Adrian Grijincu lucian.griji...@gmail.com wrote: On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); The string is from https://live.gnome.org/GnomeShell/Design/Whiteboards/AuthorizationDialog From the screenshots Incorrect password. Please try again seems sufficient. If something more generic is needed wouldn't Authentication failed. Please try again suffice? I recommend staying with the current design and just adding a translator comment if it is required. I went ahead and added a translator comment; didn't request any freeze break as it's just a comment. Vincent -- Les gens heureux ne sont pas pressés. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
Hi, On Thu, 2011-03-24 at 18:05 -0400, Owen Taylor wrote: On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this message is really really really hard to translate. That what?? Could you please at least add a translator comment, in order to help us to provide an optimal translation/adaptation? David Zeuthen would have the best idea whether some useful comment is possible, since this is from the PolicyKit authentication dialogs. David? The string is from https://live.gnome.org/GnomeShell/Design/Whiteboards/AuthorizationDialog and showed when authentication fails. Jon McCann came up with it, so if you need to change it probably best to talk to him (added as Cc). Feel free to add a translator comment saying this or let me know if you want me to do that. Thanks, David ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); The string is from https://live.gnome.org/GnomeShell/Design/Whiteboards/AuthorizationDialog From the screenshots Incorrect password. Please try again seems sufficient. If something more generic is needed wouldn't Authentication failed. Please try again suffice? -- . ..: Lucian ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Fri, Mar 25, 2011 at 8:50 AM, Lucian Adrian Grijincu lucian.griji...@gmail.com wrote: On Fri, Mar 25, 2011 at 9:43 AM, David Zeuthen dav...@redhat.com wrote: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); The string is from https://live.gnome.org/GnomeShell/Design/Whiteboards/AuthorizationDialog From the screenshots Incorrect password. Please try again seems sufficient. If something more generic is needed wouldn't Authentication failed. Please try again suffice? I recommend staying with the current design and just adding a translator comment if it is required. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
Hi! No freeze break for i18n - I guess nobody would object code changes are minimal but I am not the release-team. Regards, Johannes signature.asc Description: This is a digitally signed message part ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this message is really really really hard to translate. That what?? Could you please at least add a translator comment, in order to help us to provide an optimal translation/adaptation? Thanks, Luca ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this message is really really really hard to translate. That what?? Could you please at least add a translator comment, in order to help us to provide an optimal translation/adaptation? David Zeuthen would have the best idea whether some useful comment is possible, since this is from the PolicyKit authentication dialogs. David? - Owen ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Thu, 2011-03-24 at 22:54 +0100, Luca Ferretti wrote: Il giorno mer, 23/03/2011 alle 21.55 +0100, Kjartan Maraas ha scritto: this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.)); Sorry for the late reply, I've seen this change was yet committed, but this message is really really really hard to translate. That what?? For the time being, translators could probably use Action failed instead. andre -- mailto:ak...@gmx.net | failed http://blogs.gnome.org/aklapper | http://www.openismus.com ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Apart from that see http://live.gnome.org/TranslationProject/HandlingStringFreezes : The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: * Marking a message for translation that was previously not marked for translation by accident. andre -- mailto:ak...@gmx.net | failed http://blogs.gnome.org/aklapper | http://www.openismus.com ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Wed, 2011-03-23 at 21:58 +0100, Andre Klapper wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Actually it's even wrong: http://live.gnome.org/TranslationProject/DevGuidelines/Don%27t%20mark%20empty%20strings%20for%20translation Apart from that see http://live.gnome.org/TranslationProject/HandlingStringFreezes : The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: * Marking a message for translation that was previously not marked for translation by accident. andre -- mailto:ak...@gmx.net | failed http://blogs.gnome.org/aklapper | http://www.openismus.com ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Wed, Mar 23, 2011 at 4:58 PM, Andre Klapper ak...@gmx.net wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Yeah, that will bring in the translation metadata... Apart from that see http://live.gnome.org/TranslationProject/HandlingStringFreezes : The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: * Marking a message for translation that was previously not marked for translation by accident. Its still a code change, so +1/2 for that, assuming you unmark that empty string. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote:
Hi.
Found some strings that weren't marked for translation in the correct
way in gnome-shell.
Patch attached...ok to commit?
OK with me to commit, except for the pointed out _('') which should be
changed to and not translated at all.
- Owen
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: Code freeze break request for gnome-shell
Le mercredi 23 mars 2011, à 17:06 -0400, Matthias Clasen a écrit : On Wed, Mar 23, 2011 at 4:58 PM, Andre Klapper ak...@gmx.net wrote: On Wed, 2011-03-23 at 21:55 +0100, Kjartan Maraas wrote: + text: _(), I don't think that line makes sense. Yeah, that will bring in the translation metadata... Apart from that see http://live.gnome.org/TranslationProject/HandlingStringFreezes : The following types of changes do not need explicit approval, however we would still very much like them to be announced so that we know about them: * Marking a message for translation that was previously not marked for translation by accident. Its still a code change, so +1/2 for that, assuming you unmark that empty string. Approval 2 of 2. Vincent -- Les gens heureux ne sont pas pressés. ___ gnome-i18n mailing list gnome-i18n@gnome.org http://mail.gnome.org/mailman/listinfo/gnome-i18n
Code freeze break request for gnome-shell
Hi.
Found some strings that weren't marked for translation in the correct
way in gnome-shell.
Patch attached...ok to commit?
Cheers
Kjartan
From 509bc59467900eaf2b13d3d1e87c9e9b1687fe4c Mon Sep 17 00:00:00 2001
From: Kjartan Maraas kmar...@gnome.org
Date: Wed, 23 Mar 2011 21:49:24 +0100
Subject: [PATCH 1/1] Mark strings for translation in the right way
---
js/ui/polkitAuthenticationAgent.js | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/js/ui/polkitAuthenticationAgent.js b/js/ui/polkitAuthenticationAgent.js
index 22535b7..9c682cf 100644
--- a/js/ui/polkitAuthenticationAgent.js
+++ b/js/ui/polkitAuthenticationAgent.js
@@ -71,7 +71,7 @@ AuthenticationDialog.prototype = {
{ y_align: St.Align.START });
this._subjectLabel = new St.Label({ style_class: 'polkit-dialog-headline',
-text: _('Authentication Required') });
+text: _(Authentication Required) });
messageBox.add(this._subjectLabel,
{ y_fill: false,
@@ -105,7 +105,7 @@ AuthenticationDialog.prototype = {
let userIsRoot = false;
if (userName == 'root') {
userIsRoot = true;
-userRealName = _('Administrator');
+userRealName = _(Administrator);
}
if (userIsRoot) {
@@ -139,7 +139,7 @@ AuthenticationDialog.prototype = {
this._passwordLabel = new St.Label(({ style_class: 'polkit-dialog-password-label' }));
this._passwordBox.add(this._passwordLabel);
this._passwordEntry = new St.Entry({ style_class: 'polkit-dialog-password-entry',
- text: _(''),
+ text: _(),
can_focus: true});
this._passwordEntry.clutter_text.connect('activate', Lang.bind(this, this._onEntryActivate));
this._passwordBox.add(this._passwordEntry,
@@ -169,11 +169,11 @@ AuthenticationDialog.prototype = {
messageBox.add(this._nullMessageLabel);
this._nullMessageLabel.show();
-this.setButtons([{ label: _('Cancel'),
+this.setButtons([{ label: _(Cancel),
action: Lang.bind(this, this.cancel),
key:Clutter.Escape
},
- { label: _('Authenticate'),
+ { label: _(Authenticate),
action: Lang.bind(this, this._onAuthenticateButtonPressed)
}]);
@@ -257,7 +257,7 @@ AuthenticationDialog.prototype = {
* show Sorry, that didn't work. Please try again.
*/
if (!this._errorMessageLabel.visible !this._wasDismissed) {
-this._errorMessageLabel.set_text(_('Sorry, that didn\'t work. Please try again.'));
+this._errorMessageLabel.set_text(_(Sorry, that didn\'t work. Please try again.));
this._errorMessageLabel.show();
this._infoMessageLabel.hide();
this._nullMessageLabel.hide();
@@ -269,7 +269,7 @@ AuthenticationDialog.prototype = {
_onSessionRequest: function(session, request, echo_on) {
// Cheap localization trick
if (request == 'Password:')
-this._passwordLabel.set_text(_('Password:'));
+this._passwordLabel.set_text(_(Password:));
else
this._passwordLabel.set_text(request);
--
1.7.4.1
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n
