Re: keywords in desktop files, again
(One year later, anyway:) On Fri, 2013-03-22 at 10:24 -0400, Matthias Clasen wrote: I sent a mail about this in January already[1], but we are still seeing a steady stream of broken syntax in translations for the Keywords field in desktop files. A pre-commit check for po files could refuse broken translations. I have filed https://bugzilla.gnome.org/show_bug.cgi?id=723138 . Anybody who knows shell scripts regexes: Feel free to create a patch. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Hi Ask, You can use this script to get all the PO files for the most relevant languages. The script also has the ability to get all the language codes from DL, sou you can get all the PO files from all the languages. Cheers! 2013/3/23 Ask Hjorth Larsen asklar...@gmail.com Hi What is the easiest way to download all the translations in all languages? Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: It works great!! I've detected (and fixed) an error in gnome-control-center. Thanks!! This weekend ill try to clean the output to be less verbose and I'll create a report with it. Stay tuned!! Again, many thanks! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com It can be used like this: askhl@mime:~/translate$ find -name *.po | xargs desktopfilecheck.py ./gdm-and-friends/gnome-control-center.gnome-3-8.da.po ERROR, bad syntax line 6684: #. Translators: those are keywords for the wacom tablet control-center panel #: ../panels/wacom/gnome-wacom-panel.desktop.in.in.h:4 msgid Tablet;Wacom;Stylus;Eraser;Mouse; msgstr Tegneplade;Wacom;Pen;Viskelæder;Mus Regards Ask 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com: Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n get_po_files.sh Description: Bourne shell script ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
El vie, 22-03-2013 a las 15:46 +0100, Olav Vitters escribió: On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: We already have validation of .po files in a pre-receive git hook[1]. Might it be an idea to add validation of .desktop files? Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. So this doesn’t get forgotten about, I’ve filed https://bugzilla.gnome.org/show_bug.cgi?id=696489 about adding a pre-receive hook. I don’t have time to work on it myself, but hopefully someone else does. Philip signature.asc Description: This is a digitally signed message part ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Thanks, the one in Danish has been corrected :) 2013/3/24 Daniel Mustieles García daniel.mustie...@gmail.com: Hi all, Here is the report I've generated about the missing «;» in the Keywords translated string. Translation team coordinator: As this is an important fix we should do before the new release, please let me know if you won't be able to fix it, so I'll review and fix it for you. Best regards 2013/3/24 Daniel Mustieles García daniel.mustie...@gmail.com Hi Ask, You can use this script to get all the PO files for the most relevant languages. The script also has the ability to get all the language codes from DL, sou you can get all the PO files from all the languages. Cheers! 2013/3/23 Ask Hjorth Larsen asklar...@gmail.com Hi What is the easiest way to download all the translations in all languages? Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: It works great!! I've detected (and fixed) an error in gnome-control-center. Thanks!! This weekend ill try to clean the output to be less verbose and I'll create a report with it. Stay tuned!! Again, many thanks! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com It can be used like this: askhl@mime:~/translate$ find -name *.po | xargs desktopfilecheck.py ./gdm-and-friends/gnome-control-center.gnome-3-8.da.po ERROR, bad syntax line 6684: #. Translators: those are keywords for the wacom tablet control-center panel #: ../panels/wacom/gnome-wacom-panel.desktop.in.in.h:4 msgid Tablet;Wacom;Stylus;Eraser;Mouse; msgstr Tegneplade;Wacom;Pen;Viskelæder;Mus Regards Ask 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com: Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Hi What is the easiest way to download all the translations in all languages? Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: It works great!! I've detected (and fixed) an error in gnome-control-center. Thanks!! This weekend ill try to clean the output to be less verbose and I'll create a report with it. Stay tuned!! Again, many thanks! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com It can be used like this: askhl@mime:~/translate$ find -name *.po | xargs desktopfilecheck.py ./gdm-and-friends/gnome-control-center.gnome-3-8.da.po ERROR, bad syntax line 6684: #. Translators: those are keywords for the wacom tablet control-center panel #: ../panels/wacom/gnome-wacom-panel.desktop.in.in.h:4 msgid Tablet;Wacom;Stylus;Eraser;Mouse; msgstr Tegneplade;Wacom;Pen;Viskelæder;Mus Regards Ask 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com: Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Is there a easy way to track down this bug in every module, except for going in and out of each one? I'd love to make sure it doesn't happen to my language. Rafael Ferreira 2013/3/22 Matthias Clasen matthias.cla...@gmail.com: I sent a mail about this in January already[1], but we are still seeing a steady stream of broken syntax in translations for the Keywords field in desktop files. Please, try to educate your fellow translators about this issue, it is really making building GNOME package updates cumbersome, since the desktop-file-validate call in the spec file is normally the first place where this breakage becomes apparent. Matthias [1] https://mail.gnome.org/archives/gnome-i18n/2013-January/msg00030.html ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
El vie, 22-03-2013 a las 10:24 -0400, Matthias Clasen escribió: I sent a mail about this in January already[1], but we are still seeing a steady stream of broken syntax in translations for the Keywords field in desktop files. Please, try to educate your fellow translators about this issue, it is really making building GNOME package updates cumbersome, since the desktop-file-validate call in the spec file is normally the first place where this breakage becomes apparent. We already have validation of .po files in a pre-receive git hook[1]. Might it be an idea to add validation of .desktop files? Philip [1]: https://git.gnome.org/browse/sysadmin-bin/tree/git/pre-receive-check-po signature.asc Description: This is a digitally signed message part ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: We already have validation of .po files in a pre-receive git hook[1]. Might it be an idea to add validation of .desktop files? Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. -- Regards, Olav ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
If you have a jhbuild build, you can run desktop-file-validate on the desktop files in the module. You'll have to rebuild after making translation changes to regenerate those files. Sent from my Samsung Galaxy Note™, an ATT LTE smartphonerafael ff1 rafael.f...@gmail.com wrote:Is there a easy way to track down this bug in every module, except for going in and out of each one? I'd love to make sure it doesn't happen to my language. Rafael Ferreira 2013/3/22 Matthias Clasen matthias.cla...@gmail.com: I sent a mail about this in January already[1], but we are still seeing a steady stream of broken syntax in translations for the Keywords field in desktop files. Please, try to educate your fellow translators about this issue, it is really making building GNOME package updates cumbersome, since the desktop-file-validate call in the spec file is normally the first place where this breakage becomes apparent. Matthias [1] https://mail.gnome.org/archives/gnome-i18n/2013-January/msg00030.html ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
El vie, 22-03-2013 a las 15:46 +0100, Olav Vitters escribió: On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: We already have validation of .po files in a pre-receive git hook[1]. Might it be an idea to add validation of .desktop files? Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Well, Matthias mentioned desktop-file-validate[1], which appears to do exactly what’s needed, according to its web page. I’ve never used it, though, so I can’t be sure. Philip [1]: http://freedesktop.org/wiki/Software/desktop-file-utils signature.asc Description: This is a digitally signed message part ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
Re: keywords in desktop files, again
It works great!! I've detected (and fixed) an error in gnome-control-center. Thanks!! This weekend ill try to clean the output to be less verbose and I'll create a report with it. Stay tuned!! Again, many thanks! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com It can be used like this: askhl@mime:~/translate$ find -name *.po | xargs desktopfilecheck.py ./gdm-and-friends/gnome-control-center.gnome-3-8.da.po ERROR, bad syntax line 6684: #. Translators: those are keywords for the wacom tablet control-center panel #: ../panels/wacom/gnome-wacom-panel.desktop.in.in.h:4 msgid Tablet;Wacom;Stylus;Eraser;Mouse; msgstr Tegneplade;Wacom;Pen;Viskelæder;Mus Regards Ask 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com: Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: Hi Ask, The Keywords string just has to end with ; to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen asklar...@gmail.com Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mustieles García daniel.mustie...@gmail.com: In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper ak...@gmx.net On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figure out exactly which line is the Keywords line, etc. Grep for a line that starts with #: ../ and includes the string .desktop.in.in.h: then find the next line that starts with msgid and ends with ; then count the number of ; in that specific line, compare that number with the next line that starts with msgstr and which is not msgstr which would mean not translated yet. Trigger a warning if the number is not the same. Or something like that. Cough. Sounds error-prone. andre -- Andre Klapper | ak...@gmx.net http://blogs.gnome.org/aklapper/ ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n ___ gnome-i18n mailing list gnome-i18n@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-i18n
