Re: String freeze break request for seahorse

2012-03-21 Thread Gabor Kelemen

2012-03-20 18:06 keltezéssel, Johannes Schmid írta:

Hi!

Am Montag, den 19.03.2012, 17:54 + schrieb Javier Jardón:

On 19 March 2012 15:55, Stef Walterst...@gnome.org  wrote:

It also seems like several translators committed updated translations to the
master branch instead of the gnome-3-4 branch. So in general I would posit
that the seahorse master branch is in better shape for a GNOME 3.4 release,
despite the string changes.

As you said the master branch has more translations, and the UI/string
changes between master and gnome-3-4 are minimal.

1/2 from the release team

1/2 from i18n team, but please delete the gnome-3-4 branch now and
recreate it once the release is out of the master branch. Damned-lies
should be updated, too.

i18n approval 2/2, as the damage is already done. Please do as 
Johannes asked.


Regards
Gabor Kelemen
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-21 Thread Stef Walter

On 2012-03-21 13:10, Gabor Kelemen wrote:

2012-03-20 18:06 keltezéssel, Johannes Schmid írta:

Hi!

Am Montag, den 19.03.2012, 17:54 + schrieb Javier Jardón:

On 19 March 2012 15:55, Stef Walterst...@gnome.org wrote:

It also seems like several translators committed updated
translations to the
master branch instead of the gnome-3-4 branch. So in general I would
posit
that the seahorse master branch is in better shape for a GNOME 3.4
release,
despite the string changes.

As you said the master branch has more translations, and the UI/string
changes between master and gnome-3-4 are minimal.

1/2 from the release team

1/2 from i18n team, but please delete the gnome-3-4 branch now and
recreate it once the release is out of the master branch. Damned-lies
should be updated, too.


i18n approval 2/2, as the damage is already done. Please do as
Johannes asked.


Thanks. Done now.

Cherry picked commits from gnome-3-4 branch into master, then deleted 
gnome-3-4 and recreated it. Does Damned-lies get updated automatically, 
or is there something I can do?


Cheers,

Stef
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-21 Thread Gabor Kelemen

2012-03-21 13:53 keltezéssel, Stef Walter írta:
Cherry picked commits from gnome-3-4 branch into master, then deleted 
gnome-3-4 and recreated it. Does Damned-lies get updated 
automatically, or is there something I can do?



No, you only need to tell us about it, like you just did :).

Regards
Gabor Kelemen
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-20 Thread Johannes Schmid
Hi!

Am Montag, den 19.03.2012, 17:54 + schrieb Javier Jardón:
 On 19 March 2012 15:55, Stef Walter st...@gnome.org wrote:
 
  It also seems like several translators committed updated translations to the
  master branch instead of the gnome-3-4 branch. So in general I would posit
  that the seahorse master branch is in better shape for a GNOME 3.4 release,
  despite the string changes.
 
 As you said the master branch has more translations, and the UI/string
 changes between master and gnome-3-4 are minimal.
 
 1/2 from the release team

1/2 from i18n team, but please delete the gnome-3-4 branch now and
recreate it once the release is out of the master branch. Damned-lies
should be updated, too.

Regards,
Johannes



signature.asc
Description: This is a digitally signed message part
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-20 Thread Stef Walter

On 2012-03-20 18:06, Johannes Schmid wrote:

Hi!

Am Montag, den 19.03.2012, 17:54 + schrieb Javier Jardón:

On 19 March 2012 15:55, Stef Walterst...@gnome.org  wrote:


It also seems like several translators committed updated translations to the
master branch instead of the gnome-3-4 branch. So in general I would posit
that the seahorse master branch is in better shape for a GNOME 3.4 release,
despite the string changes.


As you said the master branch has more translations, and the UI/string
changes between master and gnome-3-4 are minimal.

1/2 from the release team


1/2 from i18n team, but please delete the gnome-3-4 branch now and
recreate it once the release is out of the master branch. Damned-lies
should be updated, too.


Yes, I'll certainly do that.

I guess I need to wait for two more approvals then? Or is this good enough?

Cheers,

Stef
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


String freeze break request for seahorse

2012-03-19 Thread Stef Walter
I accidentally released seahorse 3.3.92 from git master instead of the 
seahorse gnome-3-4 branch. We had merged several translation fixes to 
the master branch, including three minor string changes.


In order to remedy my mistake. I'd like to ask for a string freeze break.

It also seems like several translators committed updated translations to 
the master branch instead of the gnome-3-4 branch. So in general I would 
posit that the seahorse master branch is in better shape for a GNOME 3.4 
release, despite the string changes.


Attached is a patch with the differences between the gnome-3-4 branch 
and master.


Cheers,

Stef


The string changes are:

-		prompt = g_strdup_printf (ngettext (_(Are you sure you want to 
delete %d secure shell keys?),
+		prompt = g_strdup_printf (ngettext (_(Are you sure you want to 
delete %d secure shell key?),



-property name=label 
translatable=yeslt;igt;Casually:lt;/igt; means you have done a 
casual verification that the key is owned by the person who claims to 
own it. For example, you could read the key fingerprint to the owner 
over the phone. /property
+property name=label 
translatable=yeslt;igt;Casually:lt;/igt; means you have done a 
casual verification that the key is owned by the person who claims to 
own it. For example, you could read the key fingerprint to the owner 
over the phone./property


-property name=label 
translatable=yesEncrypt files and email to the key's owner /property
+property name=label 
translatable=yesEncrypt files and email to the key's owner/property


diff --git a/pgp/seahorse-add-uid.xml b/pgp/seahorse-add-uid.xml
index 43ea2b5..08cc4ed 100644
--- a/pgp/seahorse-add-uid.xml
+++ b/pgp/seahorse-add-uid.xml
@@ -70,7 +70,7 @@
   object class=GtkLabel id=label1
 property name=visibleTrue/property
 property name=xalign0/property
-property name=label translatable=yesFull _Name:/property
+property name=label translatable=yes comments=Full name of the key, usually the name of the user.Full _Name:/property
 property name=use_underlineTrue/property
 property name=mnemonic_widgetname/property
   /object
diff --git a/pgp/seahorse-keyserver-results.c b/pgp/seahorse-keyserver-results.c
index 4489c3b..ab698dd 100644
--- a/pgp/seahorse-keyserver-results.c
+++ b/pgp/seahorse-keyserver-results.c
@@ -240,6 +240,7 @@ on_delete_event (GtkWidget* widget, GdkEvent* event, SeahorseKeyserverResults* s
 }
 
 static const GtkActionEntry GENERAL_ENTRIES[] = {
+	/* TRANSLATORS: The Remote menu contains key operations on remote systems. */
 	{ remote-menu, NULL, N_(_Remote) },
 	{ app-close, GTK_STOCK_CLOSE, NULL, controlW,
 	  N_(Close this window), G_CALLBACK (on_app_close) },
diff --git a/pgp/seahorse-pgp-generate.xml b/pgp/seahorse-pgp-generate.xml
index 2017396..262b1d0 100644
--- a/pgp/seahorse-pgp-generate.xml
+++ b/pgp/seahorse-pgp-generate.xml
@@ -19,7 +19,7 @@
 /columns
 data
   row
-col id=0 translatable=yesAlgorithms here/col
+col id=0/col
   /row
 /data
   /object
@@ -205,7 +205,7 @@
 property name=can_focusFalse/property
 property name=xalign0/property
 property name=yalign0/property
-property name=label translatable=yesFull _Name:/property
+property name=label translatable=yes comments=Full name of the key, usually the name of the user.Full _Name:/property
 property name=use_underlineTrue/property
 property name=mnemonic_widgetname-entry/property
   /object
diff --git a/pgp/seahorse-pgp-key-properties.c b/pgp/seahorse-pgp-key-properties.c
index 94c7e1b..dafd3bf 100644
--- a/pgp/seahorse-pgp-key-properties.c
+++ b/pgp/seahorse-pgp-key-properties.c
@@ -421,7 +421,8 @@ names_update_row (SeahorseObjectModel *skmodel, SeahorseObject *object,
 	   SEAHORSE_ICON_SIGN : GTK_STOCK_DIALOG_QUESTION);
 	name = seahorse_object_get_markup (object);
 	id = seahorse_object_get_identifier (object);
-	
+
+	/* TRANSLATORS: [Unknown] signature name */
 	gtk_tree_store_set (GTK_TREE_STORE (skmodel), iter,
 	UIDSIG_OBJECT, NULL,
 	UIDSIG_ICON, icon,
@@ -530,7 +531,7 @@ do_names (SeahorseWidget *swidget)
  -1, , renderer,
  gicon, UIDSIG_ICON, NULL);
 
-/* The name column */
+/* TRANSLATORS: The name and email set on the PGP key */
 gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (widget), 
  -1, _(Name/Email), 

Re: String freeze break request for seahorse

2012-03-19 Thread Abderrahim Kitouni
Hello,

2012/3/19 Stef Walter st...@gnome.org
 The string changes are:

 -               prompt = g_strdup_printf (ngettext (_(Are you sure you want 
 to delete %d secure shell keys?),
 +               prompt = g_strdup_printf (ngettext (_(Are you sure you want 
 to delete %d secure shell key?),
   _(Are you sure you want to 
 delete %d secure shell keys?),
   num),

This looks wrong to me, you're essentially not using ngettext plural
handling. You should remove the gettext _ calls and keep only
ngettext.

Regards,
Abderrahim
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-19 Thread Stef Walter

On 2012-03-19 17:56, Abderrahim Kitouni wrote:
 Hello,

 2012/3/19 Stef Walterst...@gnome.org
 The string changes are:

 -   prompt = g_strdup_printf (ngettext (_(Are you sure 
you want to delete %d secure shell keys?),
 +   prompt = g_strdup_printf (ngettext (_(Are you sure 
you want to delete %d secure shell key?),
   		_(Are you sure you want to 
delete %d secure shell keys?),

num),

 This looks wrong to me, you're essentially not using ngettext plural
 handling. You should remove the gettext _ calls and keep only
 ngettext.

Thanks for catching that. Done.

Stef
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n


Re: String freeze break request for seahorse

2012-03-19 Thread Javier Jardón
On 19 March 2012 15:55, Stef Walter st...@gnome.org wrote:

 It also seems like several translators committed updated translations to the
 master branch instead of the gnome-3-4 branch. So in general I would posit
 that the seahorse master branch is in better shape for a GNOME 3.4 release,
 despite the string changes.

As you said the master branch has more translations, and the UI/string
changes between master and gnome-3-4 are minimal.

1/2 from the release team


-- 
Javier Jardón Cabezas
___
gnome-i18n mailing list
gnome-i18n@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-i18n