Re: r21577 - gnucash/trunk/src/backend/xml - Fix xml backend to load and save invoice kvp values.
Am Donnerstag, 8. Dezember 2011, 07:12:37 schrieb John Ralls: Actually, just checking for the existence of any keys starting with feature in the Book's KVP and raising a GNC_BACKEND_TOO_NEW could be done pretty quickly in both. Yes. However, I wonder how in the long run the error message could be slightly more helpful. As an error message should tell about features that are in the data file, but not yet known to the older program version trying to load the data file, such a feature list should contain at least one string that can be shown to the user. It will be english only (no translations), but at least the error message will say something like this: Cannot load the data file. It is from a newer version of gnucash and it uses the feature Invoices for a cup of coffee. As the newer version of gnucash has stored some data for this new feature, you cannot use the data file with this older version anymore. Then, users wanting to avoid this error can go to the FAQ and/or gnucash-user and ask how to avoid this particular feature in the newer gnucash, so that they will still be able to use the file in older gnucash. Regards, Christian ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: r21577 - gnucash/trunk/src/backend/xml - Fix xml backend to load and save invoice kvp values.
Christian Stimming christ...@cstimming.de writes: Am Donnerstag, 8. Dezember 2011, 07:12:37 schrieb John Ralls: Actually, just checking for the existence of any keys starting with feature in the Book's KVP and raising a GNC_BACKEND_TOO_NEW could be done pretty quickly in both. Yes. However, I wonder how in the long run the error message could be slightly more helpful. As an error message should tell about features that are in the data file, but not yet known to the older program version trying to load the data file, such a feature list should contain at least one string that can be shown to the user. It will be english only (no translations), but at least the error message will say something like this: Cannot load the data file. It is from a newer version of gnucash and it uses the feature Invoices for a cup of coffee. As the newer version of gnucash has stored some data for this new feature, you cannot use the data file with this older version anymore. Then, users wanting to avoid this error can go to the FAQ and/or gnucash-user and ask how to avoid this particular feature in the newer gnucash, so that they will still be able to use the file in older gnucash. Sure. So how about a KVP that looks like: /features/ name string = description So, the 'features' subtree would only exist once there is a named feature, so we can still look (in 2.4) for the existence of the 'features' subtree to decide whether to error out. And the named features' value would be the printable description which can be used for the error message. So in this case: /features/credit-notesstring = Business Credit Notes Regards, Christian -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.
Mike, Mike Evans mi...@code.gnucash.org writes: Author: mikee Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011) New Revision: 21694 Trac: http://svn.gnucash.org/trac/changeset/21694 Modified: gnucash/trunk/src/report/standard-reports/net-barchart.scm Log: Fix table number alignment. BP This patch was a combination of white-space changes and your table-number alignment change. It was very hard to follow the patch to figure out what the actual change was due to all the whitespace changes. I *THINK* it looks like a single-line change, but I'm not sure. In the future can you try to keep white-space changes separate from syntax changes? -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.
On Fri, 09 Dec 2011 09:56:20 -0500 Derek Atkins warl...@mit.edu wrote: Mike, Mike Evans mi...@code.gnucash.org writes: Author: mikee Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011) New Revision: 21694 Trac: http://svn.gnucash.org/trac/changeset/21694 Modified: gnucash/trunk/src/report/standard-reports/net-barchart.scm Log: Fix table number alignment. BP This patch was a combination of white-space changes and your table-number alignment change. It was very hard to follow the patch to figure out what the actual change was due to all the whitespace changes. I *THINK* it looks like a single-line change, but I'm not sure. In the future can you try to keep white-space changes separate from syntax changes? -derek Indeed it is single line change. Curious though, as I didn't deliberately make any white space changes. I'll check my editor settings... Ah! I see I've set it to strip trailing spaces which may have the problem. Will try to avoid in future. Thanks. Mike Evans ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.
Op vrijdag 9 december 2011 15:13:21 schreef Mike Evans: On Fri, 09 Dec 2011 09:56:20 -0500 Derek Atkins warl...@mit.edu wrote: Mike, Mike Evans mi...@code.gnucash.org writes: Author: mikee Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011) New Revision: 21694 Trac: http://svn.gnucash.org/trac/changeset/21694 Modified: gnucash/trunk/src/report/standard-reports/net-barchart.scm Log: Fix table number alignment. BP This patch was a combination of white-space changes and your table-number alignment change. It was very hard to follow the patch to figure out what the actual change was due to all the whitespace changes. I *THINK* it looks like a single-line change, but I'm not sure. In the future can you try to keep white-space changes separate from syntax changes? -derek Indeed it is single line change. Curious though, as I didn't deliberately make any white space changes. I'll check my editor settings... Ah! I see I've set it to strip trailing spaces which may have the problem. Will try to avoid in future. Thanks. I actually like the fact that trailing whitespace is stripped. The whitespace changes should just be committed separately. Geert Mike Evans ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.
On Fri, 09 Dec 2011 16:26:49 +0100 Geert Janssens janssens-ge...@telenet.be wrote: Op vrijdag 9 december 2011 15:13:21 schreef Mike Evans: On Fri, 09 Dec 2011 09:56:20 -0500 Derek Atkins warl...@mit.edu wrote: Mike, Mike Evans mi...@code.gnucash.org writes: Author: mikee Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011) New Revision: 21694 Trac: http://svn.gnucash.org/trac/changeset/21694 Modified: gnucash/trunk/src/report/standard-reports/net-barchart.scm Log: Fix table number alignment. BP This patch was a combination of white-space changes and your table-number alignment change. It was very hard to follow the patch to figure out what the actual change was due to all the whitespace changes. I *THINK* it looks like a single-line change, but I'm not sure. In the future can you try to keep white-space changes separate from syntax changes? -derek Indeed it is single line change. Curious though, as I didn't deliberately make any white space changes. I'll check my editor settings... Ah! I see I've set it to strip trailing spaces which may have the problem. Will try to avoid in future. Thanks. I actually like the fact that trailing whitespace is stripped. The whitespace changes should just be committed separately. Geert I'd forgotten I'd set the editor (geany) to that though so it was a complete accident. OK to backport to 2.4? Mike Mike Evans ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: AUDIT: r21694 - gnucash/trunk/src/report/standard-reports - Fix table number alignment.
Op vrijdag 9 december 2011 15:36:38 schreef Mike Evans: On Fri, 09 Dec 2011 16:26:49 +0100 Geert Janssens janssens-ge...@telenet.be wrote: Op vrijdag 9 december 2011 15:13:21 schreef Mike Evans: On Fri, 09 Dec 2011 09:56:20 -0500 Derek Atkins warl...@mit.edu wrote: Mike, Mike Evans mi...@code.gnucash.org writes: Author: mikee Date: 2011-12-09 07:31:39 -0500 (Fri, 09 Dec 2011) New Revision: 21694 Trac: http://svn.gnucash.org/trac/changeset/21694 Modified: gnucash/trunk/src/report/standard-reports/net-barchart .scm Log: Fix table number alignment. BP This patch was a combination of white-space changes and your table-number alignment change. It was very hard to follow the patch to figure out what the actual change was due to all the whitespace changes. I *THINK* it looks like a single-line change, but I'm not sure. In the future can you try to keep white-space changes separate from syntax changes? -derek Indeed it is single line change. Curious though, as I didn't deliberately make any white space changes. I'll check my editor settings... Ah! I see I've set it to strip trailing spaces which may have the problem. Will try to avoid in future. Thanks. I actually like the fact that trailing whitespace is stripped. The whitespace changes should just be committed separately. Geert I'd forgotten I'd set the editor (geany) to that though so it was a complete accident. OK to backport to 2.4? Ok with me. The actual change is trivial, so it should be no problem. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Guile 2
Is anyone working on the Guile 2 issues? tedc ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Guile 2
Op vrijdag 9 december 2011 10:59:31 schreef Ted Creedon: Is anyone working on the Guile 2 issues? Not right now, but it's on my to do list. I plan to work on it somewhere in the next couple of weeks. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: r21577 - gnucash/trunk/src/backend/xml - Fix xml backend to load and save invoice kvp values.
On Dec 9, 2011, at 6:53 AM, Derek Atkins wrote: Christian Stimming christ...@cstimming.de writes: Am Donnerstag, 8. Dezember 2011, 07:12:37 schrieb John Ralls: Actually, just checking for the existence of any keys starting with feature in the Book's KVP and raising a GNC_BACKEND_TOO_NEW could be done pretty quickly in both. Yes. However, I wonder how in the long run the error message could be slightly more helpful. As an error message should tell about features that are in the data file, but not yet known to the older program version trying to load the data file, such a feature list should contain at least one string that can be shown to the user. It will be english only (no translations), but at least the error message will say something like this: Cannot load the data file. It is from a newer version of gnucash and it uses the feature Invoices for a cup of coffee. As the newer version of gnucash has stored some data for this new feature, you cannot use the data file with this older version anymore. Then, users wanting to avoid this error can go to the FAQ and/or gnucash-user and ask how to avoid this particular feature in the newer gnucash, so that they will still be able to use the file in older gnucash. Sure. So how about a KVP that looks like: /features/ name string = description So, the 'features' subtree would only exist once there is a named feature, so we can still look (in 2.4) for the existence of the 'features' subtree to decide whether to error out. And the named features' value would be the printable description which can be used for the error message. So in this case: /features/credit-notesstring = Business Credit Notes OK, that will work. I've just made sure that make distcheck passes on the 2.4 branch, but I guess we want to hold the release until this is in. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
