Re: Source directory restructuring complete

[Sumit Bhardwaj]

On Fri, Aug 18, 2017 at 12:30 AM, Geert Janssens  wrote:

> On vrijdag 18 augustus 2017 07:07:02 CEST Sumit Bhardwaj wrote:
> > Hi Geert,
> >
> > Coming back to this thread, I found some time today to see if I can build
> > using autotools. After pulling the latest master, "make" and "make check"
> > both worked. So, I am good building with autotools.
> >
> Good. Just to be clear - does this imply you were attempting a cmake build
> before when you reported your errors ?
>
​Couple of days ago, I was having problems with make check using autotools
as well. I haven't been able to get a clean build with cmake yet.​



> > For now, I will try to work on CSV importer if and when I find time -
> it's
> > going to be a challenge with a vacation coming soon.
> >
> > Thanks,
> > Sumit
> >
> Very well. Do report your progress regularly though to avoid double work.
>
Will do.​



> Enjoy your holidays!
>
Geert
>
​Thanks,
Sumit​

> On Tue, Aug 15, 2017 at 7:54 AM, Geert Janssens <
> geert.gnuc...@kobaltwit.be>
> > wrote:
> > > Hmm,
> > >
> > > And I meant to add, can you post the contents of the test logs for the
> > > failing
> > > tests ?
> > >
> > > You will find them in ../build_gnucash/libgnucash/engine/test/
> > > The logs are named after the tests so you'll be looking for
> > > test-test-extras.log
> > > test-account.log
> > > test-split.log
> > >
> > > Geert
> > >
> > > On dinsdag 15 augustus 2017 16:48:16 CEST Geert Janssens wrote:
> > > > Hi Sumit,
> > > >
> > > > Thanks for running the tests and reporting your issues. These are not
> > >
> > > known
> > >
> > > > problems. I have run both cmake and autotools builds before
> submitting
> > > > my
> > > > work and for both build systems I had all the tests succeeding. The
> > > > autotools build also completes fine on travis. So there is something
> > > > different in your environment. That can be either because you are on
> > >
> > > Fedora
> > >
> > > > 26 (I'm on 25 still) which comes with newer versions of several
> tools,
> > > > or
> > > > an unclean build environment.
> > > >
> > > > Last week Aaron Laws reported having issues on Arch linux due to it
> > >
> > > having
> > >
> > > > both guile 2.0 and 2.2. Perhaps that's biting you as well ?
> > > >
> > > > Geert
> > > >
> > > > On dinsdag 15 augustus 2017 08:22:04 CEST Sumit Bhardwaj wrote:
> > > > > Hi Geert,
> > > > >
> > > > > Pulled master and tried to build using autotoosls. As per your
> > >
> > > suggestion,
> > >
> > > > > I built in ../build_gnucash which is parallel to the top-level
> gnucash
> > > > > directory.
> > > > >
> > > > > make succeeded.
> > > > > make install succeeded as well.
> > > > > make check failed with 3 tests - error message below. Is this a
> known
> > > > > problem?
> > > > >
> > > > > I haven't tried building using cmake. My system configuration is
> also
> > > > > below
> > > > > (Fedora 26).
> > > > >
> > > > > Thanks,
> > > > > Sumit
> > > > >
> > > > > System config:
> > > > > --
> > > > >
> > > > >  gnucash version .. : 2.6.99
> > > > >  Build for host ... : x86_64-pc-linux-gnu
> > > > >  Optional components... :  dbi
> > > > >  Extra Warnings ... :  -Werror -Wdeclaration-after-statement
> > > > >
> > > > > -Wno-pointer-sign -D_FORTIFY_SOURCE=2
> > > > >
> > > > >  CPPFLAGS . :
> > > > >  CFLAGS ... : -g -O2 -std=gnu11
> > > > >  CXXFLAGS . : -g -O2
> > > > >  LDFLAGS .. :
> > > > >  prefix : /usr/local
> > > > >
> > > > > Test error
> > > > > ...
> > > > > mkdir -p  gnucash/engine/test
> > > > > ( cd gnucash/engine/test; for A in test-extras.scm ; do ln -s -f
> > > > > /home/bhardwajs/ac/devel/build_gnucash/../gnucash/
> libgnucash/engine/t
> > > > > est/$A . ; done )
> > > > > touch .scm-links
> > > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";'
> >
> > > > > test-test-extras
> > > > > echo 'export GNC_UNINSTALLED=yes;' >> test-test-extras
> > > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > > ../../../../gnucash/libgnucash/engine/test/test-test-extras.scm
> -c "
> > > > > (exit (run-test))"' >> test-test-extras
> > > > > chmod a+x test-test-extras
> > > > > FAIL: test-test-extras
> > > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";'
> >
> > > > > test-account
> > > > > echo 'export GNC_UNINSTALLED=yes;' >> test-account
> > > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > > ../../../../gnucash/libgnucash/engine/test/test-account.scm -c
> "(exi
> > > > > t (run-test))"' >> test-account
> > > > > chmod a+x test-account
> > > > > FAIL: test-account
> > > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";'
> >
> > > > > test-split
> > > > > echo 'export GNC_UNINSTALLED=yes;' >> test-split
> > > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > > 

Re: Source directory restructuring complete

[Geert Janssens]

On vrijdag 18 augustus 2017 07:07:02 CEST Sumit Bhardwaj wrote:
> Hi Geert,
> 
> Coming back to this thread, I found some time today to see if I can build
> using autotools. After pulling the latest master, "make" and "make check"
> both worked. So, I am good building with autotools.
> 
Good. Just to be clear - does this imply you were attempting a cmake build 
before when you reported your errors ?

> For now, I will try to work on CSV importer if and when I find time - it's
> going to be a challenge with a vacation coming soon.
> 
> Thanks,
> Sumit
> 
Very well. Do report your progress regularly though to avoid double work.

Enjoy your holidays!

Geert

> On Tue, Aug 15, 2017 at 7:54 AM, Geert Janssens 
> wrote:
> > Hmm,
> > 
> > And I meant to add, can you post the contents of the test logs for the
> > failing
> > tests ?
> > 
> > You will find them in ../build_gnucash/libgnucash/engine/test/
> > The logs are named after the tests so you'll be looking for
> > test-test-extras.log
> > test-account.log
> > test-split.log
> > 
> > Geert
> > 
> > On dinsdag 15 augustus 2017 16:48:16 CEST Geert Janssens wrote:
> > > Hi Sumit,
> > > 
> > > Thanks for running the tests and reporting your issues. These are not
> > 
> > known
> > 
> > > problems. I have run both cmake and autotools builds before submitting
> > > my
> > > work and for both build systems I had all the tests succeeding. The
> > > autotools build also completes fine on travis. So there is something
> > > different in your environment. That can be either because you are on
> > 
> > Fedora
> > 
> > > 26 (I'm on 25 still) which comes with newer versions of several tools,
> > > or
> > > an unclean build environment.
> > > 
> > > Last week Aaron Laws reported having issues on Arch linux due to it
> > 
> > having
> > 
> > > both guile 2.0 and 2.2. Perhaps that's biting you as well ?
> > > 
> > > Geert
> > > 
> > > On dinsdag 15 augustus 2017 08:22:04 CEST Sumit Bhardwaj wrote:
> > > > Hi Geert,
> > > > 
> > > > Pulled master and tried to build using autotoosls. As per your
> > 
> > suggestion,
> > 
> > > > I built in ../build_gnucash which is parallel to the top-level gnucash
> > > > directory.
> > > > 
> > > > make succeeded.
> > > > make install succeeded as well.
> > > > make check failed with 3 tests - error message below. Is this a known
> > > > problem?
> > > > 
> > > > I haven't tried building using cmake. My system configuration is also
> > > > below
> > > > (Fedora 26).
> > > > 
> > > > Thanks,
> > > > Sumit
> > > > 
> > > > System config:
> > > > --
> > > > 
> > > >  gnucash version .. : 2.6.99
> > > >  Build for host ... : x86_64-pc-linux-gnu
> > > >  Optional components... :  dbi
> > > >  Extra Warnings ... :  -Werror -Wdeclaration-after-statement
> > > > 
> > > > -Wno-pointer-sign -D_FORTIFY_SOURCE=2
> > > > 
> > > >  CPPFLAGS . :
> > > >  CFLAGS ... : -g -O2 -std=gnu11
> > > >  CXXFLAGS . : -g -O2
> > > >  LDFLAGS .. :
> > > >  prefix : /usr/local
> > > > 
> > > > Test error
> > > > ...
> > > > mkdir -p  gnucash/engine/test
> > > > ( cd gnucash/engine/test; for A in test-extras.scm ; do ln -s -f
> > > > /home/bhardwajs/ac/devel/build_gnucash/../gnucash/libgnucash/engine/t
> > > > est/$A . ; done )
> > > > touch .scm-links
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-test-extras
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-test-extras
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-test-extras.scm -c "
> > > > (exit (run-test))"' >> test-test-extras
> > > > chmod a+x test-test-extras
> > > > FAIL: test-test-extras
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-account
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-account
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-account.scm -c "(exi
> > > > t (run-test))"' >> test-account
> > > > chmod a+x test-account
> > > > FAIL: test-account
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-split
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-split
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-split.scm -c "(exit
> > > > (run-test))"' >> test-split
> > > > chmod a+x test-split
> > > > FAIL: test-split
> > 
> > 
> > 
> > 
> > > > Testsuite summary for GnuCash 2.6.99
> > 
> > 
> > 
> > 
> > > > ...
> > > > 
> > > > On Mon, Aug 14, 2017 at 9:57 AM, Geert Janssens
> > > > >
> > > > 
> > > > wrote:
> > > > > Hi,
> > 

Re: Source directory restructuring

[Geert Janssens]

On donderdag 17 augustus 2017 23:59:56 CEST Alex Aycinena wrote:
> I can also verify, from an earlier build, that test-import-pending-matches
> is run on my system with autotools. It didn't run after the latest git pull
> because of the test-backend-dbi failure in autotools as well.
> 
> That's a nice feature of the cmake route: if there is a failure in a test
> subsequent tests are run whereas in autotools make check stops and if there
> are other test failures you won't see them.
> 
You can get closer to this in autotools by adding the -k switch to make. In 
that case it will continue even after failure. It's not quite as nice as the 
cmake way because
- it will also continue in case of a compilation failure
- there's still lots of noise in between the test results so you have pages 
and pages of info to scroll through.

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: Source directory restructuring

[John Ralls]

> On Aug 17, 2017, at 11:59 PM, Alex Aycinena  wrote:
> 
>> -- Forwarded message --
>> From: Geert Janssens 
>> To: gnucash-devel 
>> Cc:
>> Bcc:
>> Date: Wed, 16 Aug 2017 12:44:52 +0200
>> Subject: Re: Source directory restructuring
>> On maandag 14 augustus 2017 02:59:58 CEST Alex Aycinena wrote:
>>> I did a test by test comparison using Testing/Temporary/LastTest.log also
>>> and I find there are three tests in autotools that are missing in cmake:
>>> 
>>> - src/engine/test/test-import-map
>>> - src/engine/test/test-engine
>>> - src/app-utils/test/test-app-utils
>>> 
>>> I couldn't map test # 77,
>>> src/import-export/test/test-import-pending-matches, to any in autotools.
>>> 
>>> Alex
>> 
>> Hi Alex,
>> 
>> I have added test-import-map and test-app-utils. On my system test-engine
>> is
>> running. Perhaps I fixed that already while restructuring the sources. I
>> don't
>> remember.
>> 
>> And test-import-pending matches is run via autotools on my system. It was
>> not
>> listed in the colored test output but it was run right after that. I have
>> tweaked the Makefile slightly so it now is part of the colored output and
>> hence more visible.
>> 
>> Can you verify this on your system as well ?
>> 
>> Geert
>> 
>> 
> 
> Geert,
> 
> I can verify that with cmake/ninja, the three tests are there. There was a
> test failure, however, in 21 - test-backend-dbi:
> 
> 21/103 Testing: test-backend-dbi
> 21/103 Test: test-backend-dbi
> Command:
> "/home/gnucash-dev/gitcheckouts/gnucash-clean-build/bin/test-backend-dbi"
> Directory:
> /home/gnucash-dev/gitcheckouts/gnucash-clean-build/libgnucash/backend/dbi/test
> "test-backend-dbi" start time: Aug 17 14:16 PDT
> Output:
> --
> /backend/dbi/adjust sql options string localtime: OK
> /backend/dbi/sqlite3/store_and_reload: test-backend-dbi:
> /usr/include/boost/variant/detail/forced_return.hpp:39: T
> boost::detail::variant::forced_return() [with T = const std::type_info&]:
> Assertion `false' failed.
> 
> Test time =   0.73 sec
> --
> Test Failed.
> "test-backend-dbi" end time: Aug 17 14:16 PDT
> "test-backend-dbi" time elapsed: 00:00:00
> 
> I can also verify, from an earlier build, that test-import-pending-matches
> is run on my system with autotools. It didn't run after the latest git pull
> because of the test-backend-dbi failure in autotools as well.
> 
> That's a nice feature of the cmake route: if there is a failure in a test
> subsequent tests are run whereas in autotools make check stops and if there
> are other test failures you won't see them.

Alex,

We know about the test-backend-dbi failure. Aaron Laws and I have been working 
on it for the last couple of days.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel