Re: [GNC-dev] Ideas for account type-ahead modification
Jean, Am 11.03.20 um 22:03 schrieb Jean Laroche: : > PREFERENCES: > If someone can point me in the right direction for preferences, it would > be great. I essentially replicated the code for "Enter moves to blank > transaction" (by searching all references of the defines for that pref, > and adding the ones needed for the new option) but I must be missing > something because the code says the preference key is invalid. The new > option shows in the preferences, but the rest isn't working. you saw https://wiki.gnucash.org/wiki/Adding_Preferences? BTW, it would be nice, if you would improve the wiki at places, where you had problems like https://wiki.gnucash.org/wiki/MacOS/Quartz#Building. Regards Frank ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Noob: setup and build master
Thanks John, What about building the xcode project, are there differences between the cmake command to do that between the two branches? Jean On 3/11/2020 8:13 PM, John Ralls wrote: On Mar 11, 2020, at 2:35 PM, jeanl wrote: Hi People, Thanks to John I was able to setup and build maint on my mac. I'm now trying to setup and build master which I've pulled into src/gnucash-git Can someone clarify these points: - I imagine I need to edit jhbuildrc-cusom and change the branch to master. Do I do that before any of the following? - Do I need to re-run jhbuild bootstrap? - Do I need to re-run jhbuild bootstrap-gtk-osx? - Do I need to re-run jhbuild build? (assuming yes). Jean, You only need to reconfigure and rebuild gnucash. At this point all dependencies are the same between master and maint. I do that in a jhbuild shell because as I said elsewhere I build from the terminal prompt, so I want to make an edit and then run ninja && ninja check (or more often ninja test-target && bin/test-program, TDD and all that). There's one cmake change between the two branches. In maint you set -DGTEST_ROOT=path/to/googletest/googletest -DGMOCK_ROOT=path/to/googletest/googlemock and in master you set only -DGTEST_ROOT=path/to/googletest. It works best to have a separate build directory and rm -rf * && cmake ... to switch branches. One other thing, make sure you uninstall GnuCash beforehand, the maint and master libraries are incompatible and Guile will dlopen the installed libraries in preference to the ones in the build directory. ninja uninstall doesn't always work, so if it fails try xargs rm < install_manifest.txt. If *that* fails the `rm -r $PREFIX/lib/libgnc* $PREFIX/lib/gnucash` should be sufficient. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Noob: setup and build master
> On Mar 11, 2020, at 2:35 PM, jeanl wrote: > > Hi People, > Thanks to John I was able to setup and build maint on my mac. I'm now trying > to setup and build master which I've pulled into src/gnucash-git > > Can someone clarify these points: > - I imagine I need to edit jhbuildrc-cusom and change the branch to master. > Do I do that before any of the following? > - Do I need to re-run jhbuild bootstrap? > - Do I need to re-run jhbuild bootstrap-gtk-osx? > - Do I need to re-run jhbuild build? (assuming yes). > Jean, You only need to reconfigure and rebuild gnucash. At this point all dependencies are the same between master and maint. I do that in a jhbuild shell because as I said elsewhere I build from the terminal prompt, so I want to make an edit and then run ninja && ninja check (or more often ninja test-target && bin/test-program, TDD and all that). There's one cmake change between the two branches. In maint you set -DGTEST_ROOT=path/to/googletest/googletest -DGMOCK_ROOT=path/to/googletest/googlemock and in master you set only -DGTEST_ROOT=path/to/googletest. It works best to have a separate build directory and rm -rf * && cmake ... to switch branches. One other thing, make sure you uninstall GnuCash beforehand, the maint and master libraries are incompatible and Guile will dlopen the installed libraries in preference to the ones in the build directory. ninja uninstall doesn't always work, so if it fails try xargs rm < install_manifest.txt. If *that* fails the `rm -r $PREFIX/lib/libgnc* $PREFIX/lib/gnucash` should be sufficient. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
[GNC-dev] Noob: setup and build master
Hi People, Thanks to John I was able to setup and build maint on my mac. I'm now trying to setup and build master which I've pulled into src/gnucash-git Can someone clarify these points: - I imagine I need to edit jhbuildrc-cusom and change the branch to master. Do I do that before any of the following? - Do I need to re-run jhbuild bootstrap? - Do I need to re-run jhbuild bootstrap-gtk-osx? - Do I need to re-run jhbuild build? (assuming yes). Thanks for any help. Jean -- Sent from: http://gnucash.1415818.n4.nabble.com/GnuCash-Dev-f1435356.html ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: [GNC-dev] Ideas for account type-ahead modification
People, I have a version you can test here: https://github.com/jeanlaroche/gnucash.git , fix_autocompletion branch. A couple notes: - I worked off of maint, which I shouldn't have since this is probably a new feature. I'll fix that eventually. - The feature is fully functional, as far as I can tell. - I added an option in the preferences to use type-ahead-search (register), but at this point, it's not working right (it does not hold, so I must be missing some code). - I tested on accounts with large number of accounts (> 8000), and as far as I can tell it works OK. When you start typing there are potentially thousands of matching accounts but I only display the first 30 to avoid making the UI horribly sluggish, I think that's a good compromise. Give that a shot and let me know what you think. The code is not ready for a PR as I still have lots of comments that would need to go. PREFERENCES: If someone can point me in the right direction for preferences, it would be great. I essentially replicated the code for "Enter moves to blank transaction" (by searching all references of the defines for that pref, and adding the ones needed for the new option) but I must be missing something because the code says the preference key is invalid. The new option shows in the preferences, but the rest isn't working. On 3/10/20 11:14 AM, Robert Fewell wrote: Jean, That patch was for register2 which is stalled, it has no bearing on the current version. Bob On Tue, 10 Mar 2020 at 16:53, Frank H. Ellenberger mailto:frank.h.ellenber...@gmail.com>> wrote: Jean, Am 10.03.20 um 17:41 schrieb Jean Laroche: > Frank, > I tried reviving this patch, but git patch failed. I recreated the patch > manually (which wasn't very hard given that it contains few changes) but > I don't see any effect (not breakpoint is hit). So I'm wondering whether > this patch is still useful. I believe, Bob will faster understand, what is happening there. ~Frank ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
