Re: Patch for AqBanking Windows bug 586122
Am Samstag, 12. Dezember 2009 schrieb Geert Janssens: My patch is not correct I'm afraid. The build failed because I'm trying to access a file That defines the path specific component (AQBANKING_SO_EFFECTIVE). My patch tries to access the Version.h file for this, but apparently in the wrong location. I've reviewed the patch in detail now. The error is simple: You assumed the aqbanking compile tarball were still existing in the TMPDIR. But on the build server I usually remove the tarballs from the TMPDIR rather soon because otherwise they will clash with a new one which should be compiled there. Hence, there is no TMPDIR/aqbanking-1.2.3/ folder anymore. Instead, you need to use files solely from its installation directory. In the win build scripts, this is AQBANKING_UDIR and there you have the standard usr/, lib/, include/ etc. Hence, the header file you were looking for should be at AQBANKING_UDIR/include/aqbanking/version.h; alternatively, the path in question could be extracted from the pkgconfig file which is at AQBANKING_UDIR/lib/pkgconfig/aqbanking.pc, but that's just a matter of which command you use to extract the variables. Your original fix for gnucash.iss was completely correct, though, and during the review I saw I have to fix this for the gwenhywfar installation as well, which I've done as well. Thanks for spotting this! Christian ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
On Friday 11 December 2009, Christian Stimming wrote: Am Freitag, 11. Dezember 2009 schrieb Geert Janssens: I have attached a patch to this bug https://bugzilla.gnome.org/show_bug.cgi?id=586122 I think this patch should solve the bug, but I can't test it myself as I don't have access to a Windows environment. I see two possible options: * This is a patch for the build scripts. If I commit it, the nightly build can be used to test it. * Someone with access to Windows has a look at it. I have looked at it and from my experience with the build scripts this should be fine. You can go ahead and commit, and see the results in the nightly build. (Also, I don't have access to a Windows build machine directly; I could remotely log into the nightly build machine, but the GUI response delays prohibit any useful work there.) Regards, Christian My patch is not correct I'm afraid. The build failed because I'm trying to access a file That defines the path specific component (AQBANKING_SO_EFFECTIVE). My patch tries to access the Version.h file for this, but apparently in the wrong location. I don't have the time right now, but I'll try to fix it properly (hopefully this afternoon). Perhaps it's best to revert the change in the meantime ? Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
Geert Janssens janssens-ge...@telenet.be writes: My patch is not correct I'm afraid. The build failed because I'm trying to access a file That defines the path specific component (AQBANKING_SO_EFFECTIVE). My patch tries to access the Version.h file for this, but apparently in the wrong location. I don't have the time right now, but I'll try to fix it properly (hopefully this afternoon). Perhaps it's best to revert the change in the meantime ? If you feel that you'll fix it today then there's no reason to revert the change. Geert -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
Christian Stimming stimm...@tuhh.de writes: Am Freitag, 11. Dezember 2009 schrieb Geert Janssens: Ok, I have applied the patch. Does the nightly build automatically pick up changes in the build scripts ? No, indeed it doesn't pick up changes in the build script. There's one technical issue: On windows a program or shell script calling svn up cannot have itself updated, because the svn up command has no write access to the file as long as the bash interpreter has it opened. But I have just logged into the vmware machine and have updated that directory so that your changes are now active. Actually, it depends on which script needs to be updated. The daily_build script DOES perform an svn update right away, so pretty much everything *is* updated except for the daily_build script itself. Changes to dist.sh etc should be automatically pulled. Also, are the build logs public ? If so, I could check tomorrow if there were errors. http://code.gnucash.org/builds/win32/trunk -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing Board (SIPB) URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH warl...@mit.eduPGP key available ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Patch for AqBanking Windows bug 586122
I have attached a patch to this bug https://bugzilla.gnome.org/show_bug.cgi?id=586122 I think this patch should solve the bug, but I can't test it myself as I don't have access to a Windows environment. I see two possible options: * This is a patch for the build scripts. If I commit it, the nightly build can be used to test it. * Someone with access to Windows has a look at it. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
Am Freitag, 11. Dezember 2009 schrieb Geert Janssens: I have attached a patch to this bug https://bugzilla.gnome.org/show_bug.cgi?id=586122 I think this patch should solve the bug, but I can't test it myself as I don't have access to a Windows environment. I see two possible options: * This is a patch for the build scripts. If I commit it, the nightly build can be used to test it. * Someone with access to Windows has a look at it. I have looked at it and from my experience with the build scripts this should be fine. You can go ahead and commit, and see the results in the nightly build. (Also, I don't have access to a Windows build machine directly; I could remotely log into the nightly build machine, but the GUI response delays prohibit any useful work there.) Regards, Christian ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
On Friday 11 December 2009, Christian Stimming wrote: Am Freitag, 11. Dezember 2009 schrieb Geert Janssens: I have attached a patch to this bug https://bugzilla.gnome.org/show_bug.cgi?id=586122 I think this patch should solve the bug, but I can't test it myself as I don't have access to a Windows environment. I see two possible options: * This is a patch for the build scripts. If I commit it, the nightly build can be used to test it. * Someone with access to Windows has a look at it. I have looked at it and from my experience with the build scripts this should be fine. You can go ahead and commit, and see the results in the nightly build. (Also, I don't have access to a Windows build machine directly; I could remotely log into the nightly build machine, but the GUI response delays prohibit any useful work there.) Regards, Christian Ok, I have applied the patch. Does the nightly build automatically pick up changes in the build scripts ? Also, are the build logs public ? If so, I could check tomorrow if there were errors. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Patch for AqBanking Windows bug 586122
Am Freitag, 11. Dezember 2009 schrieb Geert Janssens: Ok, I have applied the patch. Does the nightly build automatically pick up changes in the build scripts ? No, indeed it doesn't pick up changes in the build script. There's one technical issue: On windows a program or shell script calling svn up cannot have itself updated, because the svn up command has no write access to the file as long as the bash interpreter has it opened. But I have just logged into the vmware machine and have updated that directory so that your changes are now active. Also, are the build logs public ? If so, I could check tomorrow if there were errors. http://code.gnucash.org/builds/win32/trunk Regards, Christian ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
