Re: [GNC-dev] Build issues and some free testing

[Robert Merkel]

Win!

By the way, 90% code coverage seems to be better, if anything, than what
industry does.

Cheers,

Robert.

On Wed, Jun 13, 2018 at 2:32 PM, Christopher Lam 
wrote:

> Dear rgmerk
> Finally understood the use for combinatorics :)
> https://github.com/Gnucash/gnucash/commit/da1d1b9a47939ad08ac645024f448a
> 4820103ad8#diff-1625b4f2db9166674389d58f2f585131R497
> SRFI-64 is now firmly established as the testing framework to be used in
> Gnucash from now on.
> I think transaction.scm and invoice.scm now have about 90% code coverage.
> I'll add more as time goes on...
> Chris
>
> On 24 January 2018 at 11:59, John Ralls  wrote:
>
>> Robert,
>>
>> Cool. If they should wind up writing some nice unit tests for areas where
>> our coverage is poor (pretty much everywhere) we’ll happily and gratefully
>> take them.
>>
>> Regards,
>> John Ralls
>>
>> > On Jan 23, 2018, at 4:26 PM, Robert Merkel 
>> wrote:
>> >
>> > Thanks all.
>> >
>> > I realised the VM I was working with was an LTS version, and upgraded
>> to the most recent Ubuntu release.  Gnucash built without problems in the
>> upgraded VM.
>> >
>> > It seems like the fixes were a good piece of housekeeping anyway.
>> >
>> > Just to let you know it's looking increasingly likely I'm going to have
>> a bunch of students poking and prodding at gnucash some time in April.
>> I'll make sure to file bug reports for any real bugs they find.  I'll ask
>> them to route any questions they have through me, so it shouldn't result in
>> masses of mailing list traffic.
>> >
>> > Regards,
>> >
>> > Robert.
>> >
>> > On Wed, 24 Jan 2018 at 11:19 John Ralls > jra...@ceridwen.us>> wrote:
>> >
>> >
>> > > On Jan 22, 2018, at 6:56 PM, Robert Merkel <
>> robert.mer...@benambra.org > wrote:
>> > >
>> > > Hello all.
>> > >
>> > > If you dig far enough into the mailing list archives or the
>> changelogs, you
>> > > might find me :)
>> > >
>> > > I spoke to Christopher Lam recently, who told me about the work he's
>> been
>> > > doing on the transaction report which I worked on many many years ago.
>> > >
>> > > These days, my day job is teaching students about software
>> engineering and,
>> > > this upcoming semester, I'm teaching a unit on testing and quality
>> > > assurance.  For one of the assignments, we need some software for
>> students
>> > > to test, and I thought I might get them to test Gnucash.
>> > >
>> > > So, for the first time for quite a while, I have tried to download and
>> > > build gnucash from the git repository using cmake.  I've found the
>> > > following build issues:
>> > >
>> > > * The build process requires xsltproc and makeinfo, which are not
>> mentioned
>> > > in the dependency list and cmake doesn't seem to check for them.
>> > >
>> > > * The build failed on my Ubuntu machine with the stock version of
>> > > libwebkit2-gtk available on that distribution (2.4.11).  It appears
>> that
>> > > Gnucash requires version
>> > > 2.6 of this library, as "WebKitNavigationAction" was apparently added
>> in
>> > > version 2.6.  Again, the minimum version isn't listed and cmake
>> doesn't
>> > > have a check for it.
>> >
>> > Hi, Robert.
>> >
>> > Welcome back! Chris mentioned his meeting with you on IRC.
>> >
>> > Thanks for bringing those to our attention. I've pushed a fix.
>> >
>> > You will need to install xsltproc. In some distros it's part of the
>> libxslt package, which may be why it wasn't mentioned separately in
>> README.dependencies. You won't need makeinfo, I've made that optional. It's
>> only for an obsolete design information document that is now mostly
>> superseded by Doxygen comments.
>> >
>> > The webkit2gtk-3.0 package provided by Ubuntu 14.04LTS is fine, and
>> CMake did correctly detect it and set the compile accordingly--the first
>> time through. If you then subsequently ran cmake again it would see that
>> WEBKIT_FOUND was true and set up for the preferred webkit2gtk-4.0. I've
>> corrected that by having separate WEBKIT2_3_FOUND and WEBKIT2_4_FOUND
>> variables.
>> >
>> > Regards,
>> > John Ralls
>> >
>> >
>>
>> ___
>> gnucash-devel mailing list
>> gnucash-devel@gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
>
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Build issues and some free testing

[Christopher Lam]

Dear rgmerk
Finally understood the use for combinatorics :)
https://github.com/Gnucash/gnucash/commit/da1d1b9a47939ad08ac645024f448a4820103ad8#diff-1625b4f2db9166674389d58f2f585131R497
SRFI-64 is now firmly established as the testing framework to be used in
Gnucash from now on.
I think transaction.scm and invoice.scm now have about 90% code coverage.
I'll add more as time goes on...
Chris

On 24 January 2018 at 11:59, John Ralls  wrote:

> Robert,
>
> Cool. If they should wind up writing some nice unit tests for areas where
> our coverage is poor (pretty much everywhere) we’ll happily and gratefully
> take them.
>
> Regards,
> John Ralls
>
> > On Jan 23, 2018, at 4:26 PM, Robert Merkel 
> wrote:
> >
> > Thanks all.
> >
> > I realised the VM I was working with was an LTS version, and upgraded to
> the most recent Ubuntu release.  Gnucash built without problems in the
> upgraded VM.
> >
> > It seems like the fixes were a good piece of housekeeping anyway.
> >
> > Just to let you know it's looking increasingly likely I'm going to have
> a bunch of students poking and prodding at gnucash some time in April.
> I'll make sure to file bug reports for any real bugs they find.  I'll ask
> them to route any questions they have through me, so it shouldn't result in
> masses of mailing list traffic.
> >
> > Regards,
> >
> > Robert.
> >
> > On Wed, 24 Jan 2018 at 11:19 John Ralls  jra...@ceridwen.us>> wrote:
> >
> >
> > > On Jan 22, 2018, at 6:56 PM, Robert Merkel  > wrote:
> > >
> > > Hello all.
> > >
> > > If you dig far enough into the mailing list archives or the
> changelogs, you
> > > might find me :)
> > >
> > > I spoke to Christopher Lam recently, who told me about the work he's
> been
> > > doing on the transaction report which I worked on many many years ago.
> > >
> > > These days, my day job is teaching students about software engineering
> and,
> > > this upcoming semester, I'm teaching a unit on testing and quality
> > > assurance.  For one of the assignments, we need some software for
> students
> > > to test, and I thought I might get them to test Gnucash.
> > >
> > > So, for the first time for quite a while, I have tried to download and
> > > build gnucash from the git repository using cmake.  I've found the
> > > following build issues:
> > >
> > > * The build process requires xsltproc and makeinfo, which are not
> mentioned
> > > in the dependency list and cmake doesn't seem to check for them.
> > >
> > > * The build failed on my Ubuntu machine with the stock version of
> > > libwebkit2-gtk available on that distribution (2.4.11).  It appears
> that
> > > Gnucash requires version
> > > 2.6 of this library, as "WebKitNavigationAction" was apparently added
> in
> > > version 2.6.  Again, the minimum version isn't listed and cmake doesn't
> > > have a check for it.
> >
> > Hi, Robert.
> >
> > Welcome back! Chris mentioned his meeting with you on IRC.
> >
> > Thanks for bringing those to our attention. I've pushed a fix.
> >
> > You will need to install xsltproc. In some distros it's part of the
> libxslt package, which may be why it wasn't mentioned separately in
> README.dependencies. You won't need makeinfo, I've made that optional. It's
> only for an obsolete design information document that is now mostly
> superseded by Doxygen comments.
> >
> > The webkit2gtk-3.0 package provided by Ubuntu 14.04LTS is fine, and
> CMake did correctly detect it and set the compile accordingly--the first
> time through. If you then subsequently ran cmake again it would see that
> WEBKIT_FOUND was true and set up for the preferred webkit2gtk-4.0. I've
> corrected that by having separate WEBKIT2_3_FOUND and WEBKIT2_4_FOUND
> variables.
> >
> > Regards,
> > John Ralls
> >
> >
>
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel