Re: mysql check always fails
Thanks! Schanzenbach, Martin transcribed 3.7K bytes: > Hi, > > I pushed this fix. > > BR > > > > On 9. Apr 2022, at 11:33, Nikita Ronja Gillmann wrote: > > > > Hi, > > > > for some reason I can't open an account at the bug tracker. > > The issue is a one character problem: > > https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/patches/patch-configure;h=ff56f7067812362ff4f0de0b8276e02119aa5479;hb=HEAD > > > > where #include > > should be, configure.ac has > > include > > > > So in a packaging environment where you pass > > --with-mysql=/mysql/prefix/ you get a detected > > mysql, but the version check fails. Which leads > > to <= 4.x being assumed, and therefore mysql isn't > > picked up by configure. > > > > https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/options.mk;h=821017177ceb47baaee6f41378b81e8da55ce278;hb=HEAD#l80 > > > > This happens with mysql-client 8.0.24. > > > > The patch I use fixes the version detection for me. > > > > Schanzenbach, Martin transcribed 2.6K bytes: > >> Can anyone of you open a bug report for this with a description. > >> From the mails I do not understand the problem beyond "the check does not > >> work". > >> I can look at it next week. > >> > >> BR > >> Martin > >> > >>> On 8. Apr 2022, at 10:04, Nikita Ronja Gillmann wrote: > >>> > >>> Daniel Golle transcribed 0.7K bytes: > Hi Nikita, > > On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: > > Hi, > > > > I have no time to work on a patch for this, but even with the right > > version of mysql(-client) (version => 8.0.24), > > configure.ac generates a configure file which leads to broken C code > > for what applies for my builds (--with-mysql=PRFX). > > I have attached the files. > > Just to confirm your findings: > I've also encountered this problem when building recent GNUnet releases > for OpenWrt and have decided to simply drop the version check (as in > this case I just know the version is recent enough): > >>> > >>> thanks. I still think that fixing 1 character would be better. > >>> last time moved/touched in 2021, and I've seen this error for > >>> some versions now as well in pkgsrc: > >>> 20ffa0aa54 (Alessio Vanni2021-11-11 00:56:30 +0100 1032) > >>> [[include ]], > >>> > https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch > > > Cheers > > > Daniel > >> > > > > > > >
Re: mysql check always fails
Hi, I pushed this fix. BR > On 9. Apr 2022, at 11:33, Nikita Ronja Gillmann wrote: > > Hi, > > for some reason I can't open an account at the bug tracker. > The issue is a one character problem: > https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/patches/patch-configure;h=ff56f7067812362ff4f0de0b8276e02119aa5479;hb=HEAD > > where #include > should be, configure.ac has > include > > So in a packaging environment where you pass > --with-mysql=/mysql/prefix/ you get a detected > mysql, but the version check fails. Which leads > to <= 4.x being assumed, and therefore mysql isn't > picked up by configure. > > https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/options.mk;h=821017177ceb47baaee6f41378b81e8da55ce278;hb=HEAD#l80 > > This happens with mysql-client 8.0.24. > > The patch I use fixes the version detection for me. > > Schanzenbach, Martin transcribed 2.6K bytes: >> Can anyone of you open a bug report for this with a description. >> From the mails I do not understand the problem beyond "the check does not >> work". >> I can look at it next week. >> >> BR >> Martin >> >>> On 8. Apr 2022, at 10:04, Nikita Ronja Gillmann wrote: >>> >>> Daniel Golle transcribed 0.7K bytes: Hi Nikita, On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: > Hi, > > I have no time to work on a patch for this, but even with the right > version of mysql(-client) (version => 8.0.24), > configure.ac generates a configure file which leads to broken C code for > what applies for my builds (--with-mysql=PRFX). > I have attached the files. Just to confirm your findings: I've also encountered this problem when building recent GNUnet releases for OpenWrt and have decided to simply drop the version check (as in this case I just know the version is recent enough): >>> >>> thanks. I still think that fixing 1 character would be better. >>> last time moved/touched in 2021, and I've seen this error for >>> some versions now as well in pkgsrc: >>> 20ffa0aa54 (Alessio Vanni2021-11-11 00:56:30 +0100 1032) >>> [[include ]], >>> https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch Cheers Daniel >> > > > signature.asc Description: Message signed with OpenPGP
Re: mysql check always fails
Hi, for some reason I can't open an account at the bug tracker. The issue is a one character problem: https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/patches/patch-configure;h=ff56f7067812362ff4f0de0b8276e02119aa5479;hb=HEAD where #include should be, configure.ac has include So in a packaging environment where you pass --with-mysql=/mysql/prefix/ you get a detected mysql, but the version check fails. Which leads to <= 4.x being assumed, and therefore mysql isn't picked up by configure. https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=gnunet/options.mk;h=821017177ceb47baaee6f41378b81e8da55ce278;hb=HEAD#l80 This happens with mysql-client 8.0.24. The patch I use fixes the version detection for me. Schanzenbach, Martin transcribed 2.6K bytes: > Can anyone of you open a bug report for this with a description. > From the mails I do not understand the problem beyond "the check does not > work". > I can look at it next week. > > BR > Martin > > > On 8. Apr 2022, at 10:04, Nikita Ronja Gillmann wrote: > > > > Daniel Golle transcribed 0.7K bytes: > >> Hi Nikita, > >> > >> On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: > >>> Hi, > >>> > >>> I have no time to work on a patch for this, but even with the right > >>> version of mysql(-client) (version => 8.0.24), > >>> configure.ac generates a configure file which leads to broken C code for > >>> what applies for my builds (--with-mysql=PRFX). > >>> I have attached the files. > >> > >> Just to confirm your findings: > >> I've also encountered this problem when building recent GNUnet releases > >> for OpenWrt and have decided to simply drop the version check (as in > >> this case I just know the version is recent enough): > > > > thanks. I still think that fixing 1 character would be better. > > last time moved/touched in 2021, and I've seen this error for > > some versions now as well in pkgsrc: > > 20ffa0aa54 (Alessio Vanni2021-11-11 00:56:30 +0100 1032) > > [[include ]], > > > >> https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch > >> > >> > >> Cheers > >> > >> > >> Daniel >
Re: mysql check always fails
Can anyone of you open a bug report for this with a description. From the mails I do not understand the problem beyond "the check does not work". I can look at it next week. BR Martin > On 8. Apr 2022, at 10:04, Nikita Ronja Gillmann wrote: > > Daniel Golle transcribed 0.7K bytes: >> Hi Nikita, >> >> On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: >>> Hi, >>> >>> I have no time to work on a patch for this, but even with the right version >>> of mysql(-client) (version => 8.0.24), >>> configure.ac generates a configure file which leads to broken C code for >>> what applies for my builds (--with-mysql=PRFX). >>> I have attached the files. >> >> Just to confirm your findings: >> I've also encountered this problem when building recent GNUnet releases >> for OpenWrt and have decided to simply drop the version check (as in >> this case I just know the version is recent enough): > > thanks. I still think that fixing 1 character would be better. > last time moved/touched in 2021, and I've seen this error for > some versions now as well in pkgsrc: > 20ffa0aa54 (Alessio Vanni2021-11-11 00:56:30 +0100 1032) > [[include ]], > >> https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch >> >> >> Cheers >> >> >> Daniel signature.asc Description: Message signed with OpenPGP
Re: mysql check always fails
Daniel Golle transcribed 0.7K bytes: > Hi Nikita, > > On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: > > Hi, > > > > I have no time to work on a patch for this, but even with the right version > > of mysql(-client) (version => 8.0.24), > > configure.ac generates a configure file which leads to broken C code for > > what applies for my builds (--with-mysql=PRFX). > > I have attached the files. > > Just to confirm your findings: > I've also encountered this problem when building recent GNUnet releases > for OpenWrt and have decided to simply drop the version check (as in > this case I just know the version is recent enough): thanks. I still think that fixing 1 character would be better. last time moved/touched in 2021, and I've seen this error for some versions now as well in pkgsrc: 20ffa0aa54 (Alessio Vanni2021-11-11 00:56:30 +0100 1032) [[include ]], > https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch > > > Cheers > > > Daniel >
Re: mysql check always fails
Hi Nikita, On Fri, Apr 08, 2022 at 09:12:29AM +0200, Nikita Ronja Gillmann wrote: > Hi, > > I have no time to work on a patch for this, but even with the right version > of mysql(-client) (version => 8.0.24), > configure.ac generates a configure file which leads to broken C code for what > applies for my builds (--with-mysql=PRFX). > I have attached the files. Just to confirm your findings: I've also encountered this problem when building recent GNUnet releases for OpenWrt and have decided to simply drop the version check (as in this case I just know the version is recent enough): https://github.com/openwrt/packages/blob/master/net/gnunet/patches/100-remove-mysql-version-check.patch Cheers Daniel
