[golist] Issue #12: golist should be buildroot prefix aware

[Nicolas Mailhot]

The status of the issue: `golist should be buildroot prefix aware` of project: 
`golist` has been updated to: Closed by nim.

https://pagure.io/golist/issue/12
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #9: Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671

[Nicolas Mailhot]

nim opened a new pull-request against the project: `go-rpm-macros` that you are 
following:
``
Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 
 https://github.com/rpm-software-management/rpm/issues/671
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #23: WIP: Add output templating

[Elliott Sales de Andrade]

qulogic commented on the pull-request: `WIP: Add output templating` that you 
are following:
``
@nim ?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Elliott Sales de Andrade]

qulogic merged a pull-request against the project: `golist` that you are 
following.

Merged pull-request:

``
Add ignored Go files install list
``

https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #9: Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671

[Nicolas Mailhot]

nim merged a pull-request against the project: `go-rpm-macros` that you are 
following.

Merged pull-request:

``
Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 
 https://github.com/rpm-software-management/rpm/issues/671
``

https://pagure.io/go-rpm-macros/pull-request/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #12: golist should be buildroot prefix aware

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Ok, I found a workaround. Let’s focus on still broken things for now
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #23: WIP: Add output templating

[Nicolas Mailhot]

nim commented on the pull-request: `WIP: Add output templating` that you are 
following:
``
@qulogic Looks good (not tested). Not sure the `\n` is necessary for 
`BuildRequires` but having the option to put everything on one line may be 
useful for `go test`
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #21: Overhaul CLI

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
@eclipseo Please play a little with `modist` and tell us if it is better. I 
tried to fix the CLI interface.

`cobra` is difficult to use in a core utility like `golist`. It has lots of 
requirements, so bootsrapping a Go stack that required cobra to work would be 
quite difficult.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/21
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #3: golist needs a switch to process a codebase and its tests in a single pass

[Elliott Sales de Andrade]

The issue: `golist needs a switch to process a codebase and its tests in a 
single pass` of project: `golist` has been assigned to `qulogic` by qulogic.

https://pagure.io/golist/issue/3
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Nicolas Mailhot]

nim commented on the pull-request: `Add ignored Go files install list` that you 
are following:
``
Indeed, it is very nice to see `golist` being improved at last!
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #23: WIP: Add output templating

[Elliott Sales de Andrade]

qulogic opened a new pull-request against the project: `golist` that you are 
following:
``
WIP: Add output templating
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #21: Overhaul CLI

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
True, `cobra` uses quite a bit; `pflag` has no dependencies though, which would 
be even better than `urfave/cli`.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/21
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Jakub Čajka]

jcajka commented on the pull-request: `Add ignored Go files install list` that 
you are following:
``
@qulogic Looks great to me. It seems that it is picking up all the files. For 
other arches and other OSes(win,*bsd,macos).
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Elliott Sales de Andrade]

qulogic commented on the pull-request: `Add ignored Go files install list` that 
you are following:
``
It's a super-ugly hack of a test, but I tried this out on 
`golang-github-kr-pty` with a scratch build on koji:

* First add `BuildArch: noarch` to existing package, which 
[fails](https://koji.fedoraproject.org/koji/taskinfo?taskID=34237392) due to 
inconsistent files, as expected.
* Add `golist` from this PR, build it, and then modify the `PATH` before 
`%goinstall`. This triggers the new code instead. It now [passes the 
build](https://koji.fedoraproject.org/koji/taskinfo?taskID=34237869) and any 
noarch-checks.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #22: Allow specifying multiple package paths at a time.

[Elliott Sales de Andrade]

qulogic opened a new pull-request against the project: `golist` that you are 
following:
``
Allow specifying multiple package paths at a time.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/22
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #18: Golist should work without $GOPATH from any directory

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
The download is a no-go since it will be blocked by CI/CD systems like `mock`.

It should be possible to avoid setting a build-specific `GOPATH` in golist, by 
importing directly the directories golist operates on, and taking other code 
from a static system `GOPATH`.

Setting the build-specific `GOPATH` is where most of the problems lie: you have 
to create a specific directory structure, before golist will even parse your 
files. The system `GOPATH` OTOH is harmless and fine.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/18
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #13: golist should permit specifying its output format

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Do you need format string for file lists (or just the provided/installed)?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Elliott Sales de Andrade]

qulogic opened a new pull-request against the project: `golist` that you are 
following:
``
 Add ignored Go files install list
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #12: golist should be buildroot prefix aware

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Is this not all handled when in `BUILD`? Or is something changing as to when 
`golist` is called?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[fgergo]

On 3/27/19, Nicolas Mailhot  wrote:
> Le 2019-03-27 10:25, fge...@gmail.com a écrit :
>> On 3/27/19, 'Nicolas Mailhot' via golang-dev
>>  wrote:
>> ...
 Anyway here is the code, not finished, not feature-complete, very
 lightly tested, but already doing some useful things
 https://pagure.io/modist/
>> ...
>>> And I should have added, the readme is sparse but the tool should be
>>> self documenting, just build cmd/modist and run it, it will output
>>> help
>>> about available subcommands and their parameters
>>
>> godoc.org/pagure.io/modist/ doesn't seem to work.
>> As far as I can tell, most published go code works automagically with
>> godoc.org.
>> If you plan to look into this, godoc.org/github.com/golang/gddo can be
>> one useful starting point.
>
> Thanks for pointing out this. This is something that will probably need
> looking at, if the code graduates from experiment, and is not deprecated
> by improvements in upstream go tools.
>
> Right now the priority was just publishing something that builds, to
> have a concrete application example, and not just abstract exchanges on
> the mailing list.

(This is still only about sharing go code.)
I wasn't sure if I should add or not, but since you reiterated that
you intend to make others check out the published code: you'll most
probably have a wider audience if or when the reason for the code is
in the documentation and it's available via a familiar mechanism.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #2: golist processing is arch and tag-specific

[Elliott Sales de Andrade]

The issue: `golist processing is arch and tag-specific` of project: `golist` 
has been assigned to `qulogic` by qulogic.

https://pagure.io/golist/issue/2
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #13: golist should permit specifying its output format

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
> Do you need format string for file lists (or just the provided/installed)?

There's no need to format file lists, as long as the installation is left to 
something else.

If golist was to take over installation (as is done by modist install) it would 
need to output directories with `%dir` in rpm mode.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #21: Overhaul CLI

[Elliott Sales de Andrade]

qulogic reported a new issue against the project: `golist` that you are 
following:
``
I don't really like the way the command-line arguments are specified right now. 
Everything is an optional flag which requires writing out a redundant argument 
name. This would be even worse with #4. Also, urfave/cli doesn't seem to follow 
POSIX semantics, which is a bit annoying.

I'd rather the CLI look something like: `golist   
[ ...]` where `` is one of the original flags that 
specified output modes. All the other flags could remain optional.

This could maybe be done with `pflag` instead for optional things and just 
switching commands ourselves. Or maybe using `cobra`. Probably depends on how 
heavy these things are.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/21
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #13: golist should permit specifying its output format

[Elliott Sales de Andrade]

The issue: `golist should permit specifying its output format` of project: 
`golist` has been assigned to `qulogic` by qulogic.

https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Elliott Sales de Andrade]

qulogic commented on the pull-request: ` Add ignored Go files install list` 
that you are following:
``
There are 43 specs without noarch:
```
$ rg --files-without-match 'BuildArch: *noarch' golang* | sort
golang-bazil-fuse.spec
golang-github-aead-chacha20.spec
golang-github-aead-poly1305.spec
golang-github-boltdb-bolt.spec
golang-github-bugsnag-panicwrap.spec
golang-github-cespare-xxhash.spec
golang-github-codahale-aesnicheck.spec
golang-github-cosmos72-gomacro.spec
golang-github-dchest-safefile.spec
golang-github-denisenkom-go-mssqldb.spec
golang-github-ema-qdisc.spec
golang-github-gofrs-flock.spec
golang-github-golang-image.spec
golang-github-golang-sys.spec
golang-github-gonum-blas.spec
golang-github-gonum-internal.spec
golang-github-google-go-github.spec
golang-github-grpc-grpc-go.spec
golang-github-influxdb-go-cache.spec
golang-github-influxdb-gomdb.spec
golang-github-keybase-go-crypto.spec
golang-github-klauspost-compress.spec
golang-github-klauspost-crc32.spec
golang-github-kr-pty.spec
golang-github-masterminds-semver-1.spec
golang-github-mattn-go-isatty.spec
golang-github-mdlayher-netlink.spec
golang-github-mdlayher-raw.spec
golang-github-minio-sha256-simd.spec
golang-github-onsi-ginkgo.spec
golang-github-petermattis-goid.spec
golang-github-pierrec-lz4.spec
golang-github-roaringbitmap-roaring.spec
golang-github-ryanuber-go-glob.spec
golang-github-samalba-dockerclient.spec
golang-github-sevlyar-daemon.spec
golang-github-shirou-gopsutil.spec
golang-github-zyedidia-pty.spec
golang-go4.spec
golang-googlecode-go-crypto.spec
golang-googlecode-net.spec
golang-googlecode-tools.spec
golang-x-build.spec
```
but only 4 of them build any executables, and so the rest probably can be 
noarch. I will test these out with this patch to see if they produce consistent 
file lists.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #18: Golist should work without $GOPATH from any directory

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Might be possible with 
[tools/go/packages](https://godoc.org/golang.org/x/tools/go/packages), but I've 
read that it's much much slower since it tries to do a full module download. 
This might be mitigated by setting up a GOPROXY.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/18
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0

[Elliott Sales de Andrade]

The status of the issue: `Crash when processing github.com/kr/pretty 0.1.0` of 
project: `golist` has been updated to: Closed by qulogic.

https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Elliott Sales de Andrade]

qulogic commented on the pull-request: ` Add ignored Go files install list` 
that you are following:
``
Here's what we get with the new version compared to currently packaged:
```
--- before  2019-04-16 22:43:37.852194764 -0400
+++ after   2019-04-16 22:43:39.333180958 -0400
@@ -99,6 +99,8 @@ Package: bazil.org/fuse
pr20/go/src/bazil.org/fuse
pr20/go/src/bazil.org/fuse/buffer.go
pr20/go/src/bazil.org/fuse/debug.go
+   pr20/go/src/bazil.org/fuse/error_darwin.go
+   pr20/go/src/bazil.org/fuse/error_freebsd.go
pr20/go/src/bazil.org/fuse/error_linux.go
pr20/go/src/bazil.org/fuse/error_std.go
pr20/go/src/bazil.org/fuse/examples/clockfs
@@ -117,6 +119,8 @@ Package: bazil.org/fuse
pr20/go/src/bazil.org/fuse/fs/fstestutil/doc.go
pr20/go/src/bazil.org/fuse/fs/fstestutil/mounted.go
pr20/go/src/bazil.org/fuse/fs/fstestutil/mountinfo.go
+   pr20/go/src/bazil.org/fuse/fs/fstestutil/mountinfo_darwin.go
+   pr20/go/src/bazil.org/fuse/fs/fstestutil/mountinfo_freebsd.go
pr20/go/src/bazil.org/fuse/fs/fstestutil/mountinfo_linux.go
pr20/go/src/bazil.org/fuse/fs/fstestutil/record
pr20/go/src/bazil.org/fuse/fs/fstestutil/record/buffer.go
@@ -125,10 +129,15 @@ Package: bazil.org/fuse
pr20/go/src/bazil.org/fuse/fs/fstestutil/testfs.go
pr20/go/src/bazil.org/fuse/fs/helpers_test.go
pr20/go/src/bazil.org/fuse/fs/serve.go
+   pr20/go/src/bazil.org/fuse/fs/serve_darwin_test.go
pr20/go/src/bazil.org/fuse/fs/serve_test.go
pr20/go/src/bazil.org/fuse/fs/tree.go
pr20/go/src/bazil.org/fuse/fuse.go
+   pr20/go/src/bazil.org/fuse/fuse_darwin.go
+   pr20/go/src/bazil.org/fuse/fuse_freebsd.go
pr20/go/src/bazil.org/fuse/fuse_kernel.go
+   pr20/go/src/bazil.org/fuse/fuse_kernel_darwin.go
+   pr20/go/src/bazil.org/fuse/fuse_kernel_freebsd.go
pr20/go/src/bazil.org/fuse/fuse_kernel_linux.go
pr20/go/src/bazil.org/fuse/fuse_kernel_std.go
pr20/go/src/bazil.org/fuse/fuse_kernel_test.go
@@ -136,20 +145,31 @@ Package: bazil.org/fuse
pr20/go/src/bazil.org/fuse/fuseutil
pr20/go/src/bazil.org/fuse/fuseutil/fuseutil.go
pr20/go/src/bazil.org/fuse/mount.go
+   pr20/go/src/bazil.org/fuse/mount_darwin.go
+   pr20/go/src/bazil.org/fuse/mount_freebsd.go
pr20/go/src/bazil.org/fuse/mount_linux.go
pr20/go/src/bazil.org/fuse/options.go
+   pr20/go/src/bazil.org/fuse/options_daemon_timeout_test.go
+   pr20/go/src/bazil.org/fuse/options_darwin.go
+   pr20/go/src/bazil.org/fuse/options_freebsd.go
pr20/go/src/bazil.org/fuse/options_helper_test.go
pr20/go/src/bazil.org/fuse/options_linux.go
+   pr20/go/src/bazil.org/fuse/options_nocomma_test.go
pr20/go/src/bazil.org/fuse/options_test.go
pr20/go/src/bazil.org/fuse/protocol.go
pr20/go/src/bazil.org/fuse/syscallx
pr20/go/src/bazil.org/fuse/syscallx/doc.go
pr20/go/src/bazil.org/fuse/syscallx/msync.go
+   pr20/go/src/bazil.org/fuse/syscallx/msync_386.go
pr20/go/src/bazil.org/fuse/syscallx/msync_amd64.go
pr20/go/src/bazil.org/fuse/syscallx/syscallx.go
pr20/go/src/bazil.org/fuse/syscallx/syscallx_std.go
+   pr20/go/src/bazil.org/fuse/syscallx/xattr_darwin.go
+   pr20/go/src/bazil.org/fuse/syscallx/xattr_darwin_386.go
+   pr20/go/src/bazil.org/fuse/syscallx/xattr_darwin_amd64.go
pr20/go/src/bazil.org/fuse/unmount.go
pr20/go/src/bazil.org/fuse/unmount_linux.go
+   pr20/go/src/bazil.org/fuse/unmount_std.go
--json:
 Package: github.com/Masterminds/semver
@@ -337,9 +357,11 @@ Package: github.com/RoaringBitmap/roarin

pr20/go/src/github.com/RoaringBitmap/roaring/bitmapcontainer_gen_test.go

pr20/go/src/github.com/RoaringBitmap/roaring/bitmapcontainer_test.go
pr20/go/src/github.com/RoaringBitmap/roaring/clz.go
+   pr20/go/src/github.com/RoaringBitmap/roaring/clz_compat.go
pr20/go/src/github.com/RoaringBitmap/roaring/clz_test.go
pr20/go/src/github.com/RoaringBitmap/roaring/container_test.go
pr20/go/src/github.com/RoaringBitmap/roaring/ctz.go
+   pr20/go/src/github.com/RoaringBitmap/roaring/ctz_compat.go
pr20/go/src/github.com/RoaringBitmap/roaring/ctz_test.go

[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Closing as a duplicate of #7.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1

[Elliott Sales de Andrade]

The status of the issue: `golist should be ported to a current release of 
gopkg.in/urfave/cli.v1` of project: `golist` has been updated to: Closed by 
qulogic.

https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Fixed by #16.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Elliott Sales de Andrade]

qulogic commented on the pull-request: `Replace Go internals with go/build` 
that you are following:
``
I'm going to merge this, as those two packages are failing due to the way they 
use Go modules, and getting testing working everywhere is more important. They 
can just be patched to work right in the meantime. Of course, as more things 
move to modules, this will be harder to do, but I guess you're working on that 
or we can get to it later.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #12: golist should be buildroot prefix aware

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
I don't remember where the files end up (under `BUILD` or `BUILDROOT`) and I 
may have mixed up the rpm variable representing rpm's last stage staging 
directory.

The basic point is that for `Requires`/`Provides` we are not calling `golist` 
explicitly, rpm is doing it in 
[generator](https://rpm.org/user_doc/dependency_generators.html) mode. And the 
filesystem tree rpm is operating in generator mode is a mirror of the target 
FHS structure, except `/` is replaced by a prefix directory.

That breaks absolute symlinks (they are already pointing to `/` not the prefix 
directory), so anything that walks the directory structure like golist needs to 
have special code for computing the correct symlink target in 
`Requires`/`Provides` generator mode. ie “the symlink is pointing to `/foo/bar` 
but I’m in prefix mode so the actual target is probably `/prefix/foo/bar/`”

This could probably be made better rpm upstream side by making 
`Requires`/`Provides` on a container that fakes the root properly, but rpm was 
designed before containers existed and getting the containing logic right is 
hard .
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #16: Fix compile against latest urfave/cli.

[Elliott Sales de Andrade]

qulogic merged a pull-request against the project: `golist` that you are 
following.

Merged pull-request:

``
Fix compile against latest urfave/cli.
``

https://pagure.io/golist/pull-request/16
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[fgergo]

On 3/27/19, 'Nicolas Mailhot' via golang-dev
 wrote:
...
>> Anyway here is the code, not finished, not feature-complete, very
>> lightly tested, but already doing some useful things
>> https://pagure.io/modist/
...
> And I should have added, the readme is sparse but the tool should be
> self documenting, just build cmd/modist and run it, it will output help
> about available subcommands and their parameters

godoc.org/pagure.io/modist/ doesn't seem to work.
As far as I can tell, most published go code works automagically with godoc.org.
If you plan to look into this, godoc.org/github.com/golang/gddo can be
one useful starting point.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #20: Add ignored Go files install list

[Robert-André Mauchin]

eclipseo commented on the pull-request: `Add ignored Go files install list` 
that you are following:
``
Lookr good! Thanks for all the work!
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #8: Fix missing variable in license detection

[Robert-André Mauchin]

eclipseo opened a new pull-request against the project: `go-rpm-macros` that 
you are following:
``
Fix missing variable in license detection
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #19: Initialize load.Mod* variables in ListPackage...

[Robert-André Mauchin]

eclipseo opened a new pull-request against the project: `golist` that you are 
following:
``
Initialize load.Mod* variables in ListPackage...
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/19
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Robert-André Mauchin]

eclipseo added a new comment to an issue you are following:
``
If I initialize the variables to be non nil, 
```
load.ModImportPaths = modload.ImportPaths
load.ModBinDir = modload.BinDir
load.ModLookup = modload.Lookup
load.ModDirImportPath = modload.DirImportPath
load.ModPackageModuleInfo = modload.PackageModuleInfo
load.ModPackageBuildInfo = modload.PackageBuildInfo
load.ModImportFromFiles = modload.ImportFromFiles
```
I then get a different error:
```
go: finding github.com/sirupsen/logrus/hooks latest
panic: package github.com/sirupsen/logrus/hooks: unknown import path 
"github.com/sirupsen/logrus/hooks": cannot find module providing package 
github.com/sirupsen/logrus/hooks [recovered]
panic: package github.com/sirupsen/logrus/hooks: unknown import path 
"github.com/sirupsen/logrus/hooks": cannot find module providing package 
github.com/sirupsen/logrus/hooks```

It tries to d/l a subfolder as if it was a module. Works fine outside the 
source tree as mentioned before.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Robert-André Mauchin]

eclipseo added a new comment to an issue you are following:
``
Add a rimilar error with latest golang-github-sirupsen-logrus:

```
Testing in: 
/home/bob/packaging/golang/golang-github-Sirupsen-logrus/logrus-1.4.0/_build/src
  PATH: 
/home/bob/packaging/golang/golang-github-Sirupsen-logrus/logrus-1.4.0/_build/bin:/home/bob/.local/bin:/usr/local/bin:/usr/bin:/bin
GOPATH: 
/home/bob/packaging/golang/golang-github-Sirupsen-logrus/logrus-1.4.0/_build:/usr/lib64/gocode
   command: go test -buildmode pie -compiler gc -ldflags "-X 
github.com/sirupsen/logrus/version=1.4.0 -extldflags '-Wl,-z,relro 
-Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
   testing: github.com/sirupsen/logrus
panic: runtime error: invalid memory address or nil pointer dereference 
[recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x564cf5030c9f]

goroutine 1 [running]:
panic(0x564cf54e7200, 0x564cf586dd40)
/usr/lib/golang/src/runtime/panic.go:556 +0x2cf fp=0xc000136e20 
sp=0xc000136d90 pc=0x564cf4ead2bf
github.com/urfave/cli.HandleAction.func1(0xc000137a30)
/usr/lib64/gocode/src/github.com/urfave/cli/app.go:473 +0x27a 
fp=0xc000136ec8 sp=0xc000136e20 pc=0x564cf532d5aa
runtime.call32(0x0, 0x564cf5569f88, 0xcb8230, 0x80008)
/usr/lib/golang/src/runtime/asm_amd64.s:522 +0x3d fp=0xc000136ef8 
sp=0xc000136ec8 pc=0x564cf4ed89fd
panic(0x564cf54e7200, 0x564cf586dd40)
/usr/lib/golang/src/runtime/panic.go:513 +0x1bd fp=0xc000136f88 
sp=0xc000136ef8 pc=0x564cf4ead1ad
runtime.panicmem()
/usr/lib/golang/src/runtime/panic.go:82 +0x60 fp=0xc000136fa8 
sp=0xc000136f88 pc=0x564cf4eac2c0
runtime.sigpanic()
/usr/lib/golang/src/runtime/signal_unix.go:390 +0x186 fp=0xc000136ff8 
sp=0xc000136fa8 pc=0x564cf4ec2736
pagure.io/golist/pkg/util/internal/load.ImportPaths(0xc00030c510, 0x1, 0x1, 
0x0, 0x1, 0xc0001370f0)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/pkg/util/internal/load/pkg.go:1888
 +0x5f fp=0xc000137038 sp=0xc000136ff8 pc=0x564cf5030c9f
pagure.io/golist/pkg/util/internal/load.PackagesAndErrors(0xc00030c510, 0x1, 
0x1, 0x564cf55743a0, 0xc0002bb640, 0xf)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/pkg/util/internal/load/pkg.go:1842
 +0xa5 fp=0xc0001371b0 sp=0xc000137038 pc=0x564cf5030545
pagure.io/golist/pkg/util.ListPackage(0xc0002ee2f1, 0x1a, 0x1a, 0x0, 
0xc0001372b8)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/pkg/util/util.go:420
 +0x91 fp=0xc000137220 sp=0xc0001371b0 pc=0x564cf531c1a1
pagure.io/golist/pkg/util.(*PackageInfoCollector).CollectPackageInfos.func1(0xc0002ee2a0,
 0x6c, 0x564cf5576180, 0xc000268f70, 0x0, 0x0, 0x0, 0xc000137350)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/pkg/util/util.go:181
 +0x6ea fp=0xc0001372c8 sp=0xc000137220 pc=0x564cf531cada
path/filepath.walk(0xc0002ee2a0, 0x6c, 0x564cf5576180, 0xc000268f70, 
0xc0002bb620, 0x0, 0x2)
/usr/lib/golang/src/path/filepath/path.go:362 +0xf8 fp=0xc0001373a0 
sp=0xc0001372c8 pc=0x564cf4fa91b8
path/filepath.Walk(0xc0002ee2a0, 0x6c, 0xc0002bb620, 0x564cf533402e, 0x1)
/usr/lib/golang/src/path/filepath/path.go:404 +0x107 fp=0xc000137400 
sp=0xc0001373a0 pc=0x564cf4fa9627
pagure.io/golist/pkg/util.(*PackageInfoCollector).CollectPackageInfos(0xc000295db0,
 0x7ffe0d6433f8, 0x1a, 0x7ffe0d6433f8, 0x1a)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/pkg/util/util.go:139
 +0x15a fp=0xc000137478 sp=0xc000137400 pc=0x564cf531890a
main.main.func1(0xc00031c500, 0x0, 0x0)

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/cmd/golist/golist.go:73
 +0x5d4 fp=0xc000137610 sp=0xc000137478 pc=0x564cf53316e4
runtime.call32(0xc0002ec7b0, 0x564cf556a060, 0xc0002bb5c0, 0x80018)
/usr/lib/golang/src/runtime/asm_amd64.s:522 +0x3d fp=0xc000137640 
sp=0xc000137610 pc=0x564cf4ed89fd
reflect.Value.call(0x564cf54cba60, 0x564cf556a060, 0x13, 0x564cf53348ed, 0x4, 
0xc0001379f0, 0x1, 0x1, 0xcb8200, 0xc00031c500, ...)
/usr/lib/golang/src/reflect/value.go:447 +0x44b fp=0xc000137908 
sp=0xc000137640 pc=0x564cf4f0937b
reflect.Value.Call(0x564cf54cba60, 0x564cf556a060, 0x13, 0xc0001379f0, 0x1, 
0x1, 0x2, 0x2, 0x1)
/usr/lib/golang/src/reflect/value.go:308 +0xa6 fp=0xc000137970 
sp=0xc000137908 pc=0x564cf4f08df6
github.com/urfave/cli.HandleAction(0x564cf54cba60, 0x564cf556a060, 
0xc00031c500, 0x0, 0x0)
/usr/lib64/gocode/src/github.com/urfave/cli/app.go:482 +0x1fa 
fp=0xc000137a18 sp=0xc000137970 pc=0x564cf5321f7a
github.com/urfave/cli.(*App).Run(0xc88d80, 0xcba000, 0x7, 0x7, 0x0, 0x0)
/usr/lib64/gocode/src/github.com/urfave/cli/app.go:240 +0x481 
fp=0xc000137bc8 sp=0xc000137a18 pc=0x564cf53200f1
main.main()

/builddir/build/BUILD/golist-0.9.0/_build/src/pagure.io/golist/cmd/golist/golist.go:125
 +0x793 

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Robert-André Mauchin]

eclipseo added a new comment to an issue you are following:
``
PR that works: https://pagure.io/golist/pull-request/19
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #8: Fix missing variable in license detection

[Nicolas Mailhot]

nim merged a pull-request against the project: `go-rpm-macros` that you are 
following.

Merged pull-request:

``
Fix missing variable in license detection
``

https://pagure.io/go-rpm-macros/pull-request/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #8: Fix missing variable in license detection

[Nicolas Mailhot]

nim commented on the pull-request: `Fix missing variable in license detection` 
that you are following:
``
Good catch, thanks, the variable was dropped in a recent code cleanup.
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Matthew Dempsky]

On Mon, Mar 11, 2019 at 8:01 AM Nicolas Mailhot 
wrote:

> And as I have explained in the detailed description Matthew requested,
>

To be clear, I was asking for details to reproduce the technical issues
you're running into. I may have missed them, but I don't believe you've
provided these.

our construction of the CI/CD environment is incremental, so the
> assumption in the go tool code that "everything is there and it it is
> not it can be downloaded directly" does not work for us


If your build system provides the Go source/packages, then Go won't try to
download them directly itself. This is how Go works within Google's build
system (which, again, has the same no-network-access limitation as the
build system you're describing, and yet supports building Go
programs/packages).

It sounds like you're having trouble with providing the Go source/packages
in the format expected by cmd/go. If you would provide reproduction steps
of what you're doing and the problems you're running into, we can help
advise what changes you need to make, and maybe identify tooling
improvements to make that easier.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Ian Denhardt]

Quoting Matthew Dempsky (2019-03-11 13:54:07)
>On Mon, Mar 11, 2019 at 8:01 AM Nicolas Mailhot
><[1]nicolas.mail...@laposte.net> wrote:
>
>  And as I have explained in the detailed description Matthew
>  requested,
>
>To be clear, I was asking for details to reproduce the technical issues
>you're running into. I may have missed them, but I don't believe you've
>provided these.
>
>  our construction of the CI/CD environment is incremental, so the
>  assumption in the go tool code that "everything is there and it it
>  is
>  not it can be downloaded directly" does not work for us
>
>If your build system provides the Go source/packages, then Go won't try
>to download them directly itself. This is how Go works within Google's
>build system (which, again, has the same no-network-access limitation
>as the build system you're describing, and yet supports building Go
>programs/packages).
>It sounds like you're having trouble with providing the Go
>source/packages in the format expected by cmd/go. If you would provide
>reproduction steps of what you're doing and the problems you're running
>into, we can help advise what changes you need to make, and maybe
>identify tooling improvements to make that easier.

In a parallel thread, a Nix developer was asking about basically the
same use case, and was pointed at `go build -mod=vendor`. It seems like
this does exactly what is wanted here -- just use the code we have
locally. Nicolas, does that address your use case?

-Ian
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Tristan Colgate]

Don't google use Blaze/Bazel for builds internally? I don't think go
get and modules are hugely relevant in that context (see
https://github.com/bazelbuild/rules_go#does-this-work-with-go-modules).

On Tue, 12 Mar 2019 at 09:49, Jakub Cajka  wrote:
>
>
>
>
>
> - Original Message -
> > From: "Ian Denhardt" 
> > To: "Matthew Dempsky" , "Nicolas Mailhot" 
> > 
> > Cc: "Russ Cox" , "'Matthew Dempsky' via golang-dev" 
> > ,
> > golang@lists.fedoraproject.org
> > Sent: Monday, March 11, 2019 7:18:49 PM
> > Subject: Re: [golang-dev] proposal: public module authentication with the 
> > Go notary
> >
> > Quoting Matthew Dempsky (2019-03-11 13:54:07)
> > >On Mon, Mar 11, 2019 at 8:01 AM Nicolas Mailhot
> > ><[1]nicolas.mail...@laposte.net> wrote:
> > >
> > >  And as I have explained in the detailed description Matthew
> > >  requested,
> > >
> > >To be clear, I was asking for details to reproduce the technical issues
> > >you're running into. I may have missed them, but I don't believe you've
> > >provided these.
> > >
> > >  our construction of the CI/CD environment is incremental, so the
> > >  assumption in the go tool code that "everything is there and it it
> > >  is
> > >  not it can be downloaded directly" does not work for us
> > >
> > >If your build system provides the Go source/packages, then Go won't try
> > >to download them directly itself. This is how Go works within Google's
> > >build system (which, again, has the same no-network-access limitation
> > >as the build system you're describing, and yet supports building Go
> > >programs/packages).
> > >It sounds like you're having trouble with providing the Go
> > >source/packages in the format expected by cmd/go. If you would provide
> > >reproduction steps of what you're doing and the problems you're running
> > >into, we can help advise what changes you need to make, and maybe
> > >identify tooling improvements to make that easier.
> >
> > In a parallel thread, a Nix developer was asking about basically the
> > same use case, and was pointed at `go build -mod=vendor`. It seems like
> > this does exactly what is wanted here -- just use the code we have
> > locally. Nicolas, does that address your use case?
> >
> > -Ian
> >
>
> I think that our issue in Fedora is that we would like to continue using 
> something that resembles current "GOPATH/vendor" approach where the tooling 
> is not trying to kind of out smart us. As we have in distribution environment 
> full control about the build environment and dependencies and we want/will 
> have to retain it. I believe that having some "dumb mode" for operating all 
> the go commands/tools(without the hard need for a modules (verification), 
> even with reduced features) would be much appreciated(so you can use it as 
> any other compiler/interpreter by just throwing code at it).
>
> IMHO we will tap the metadata that the Go modules carry to simplify our 
> processes and automations, but for example having to run our own notary(even 
> just in build environment) just to be able to use go build/go list/go vet... 
> might be really costly and we will be most probably looking for any 
> alternative.
>
> It has been mentioned several times, in this bunch of treads, that Google's 
> internal build infrastructure has same requirements and is facing similar 
> challenges. It would be great to hear how do they plan to "workaround" up 
> coming module changes.
>
> JC
>
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-dev+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups 
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to golang-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Tristan Colgate-McFarlane

  "You can get all your daily vitamins from 52 pints of guiness, and a
glass of milk"
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #18: Golist should work without $GOPATH from any directory

[Robert-André Mauchin]

eclipseo reported a new issue against the project: `golist` that you are 
following:
``
$GOPATH is deprecated, we shouldn't use it anymore.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/18
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Matthew Dempsky]

On Mon, Mar 11, 2019 at 11:09 AM Florian Weimer  wrote:

> How do you plan to bypass the notary requirement?


I don't work on the Go-inside-Google integration work, so someone else may
have to weigh in if it's appropriate to share those plans. My point with
mentioning Google's hermetic build system is more to emphasize that the Go
developers are very familiar with that build model and care about keeping
it working. The claims that the Go module system is being built without
consideration of those requirements seem very mistaken.

That said, the notary is only involved when adding new lines to the go.sum
file to handle adding or updating dependencies. There's no requirement to
contact the Go notary when the go.sum file is already complete.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Ian Denhardt]

Quoting Russ Cox (2019-03-11 10:43:28)

>[One of the things go list computes is the dependency graph
>(visible if you use go list -json or go list -f '{{.Deps}}').]

Ah, that makes more sense.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Russ Cox]

On Sat, Mar 9, 2019 at 2:55 PM Ian Denhardt  wrote:

> Here's a reproducer:
>
> > $ go mod init example.org/my-project
> > go: creating new go.mod: module example.org/my-project
> > $ cat >> main.go << "EOF"
> > package main
> > import _ "example.com/other-module"
> > func main() {}
> > EOF
> > $ go list -mod=readonly ./...
> > build example.org/my-project: cannot load example.com/other-module:
> > import lookup disabled by -mod=readonly
>
> I think we'd both mis-understood Nicolas's complaint the first time --
> it's not that it still tries to access the network with -mod=readonly,
> but that even for basic commands for which a read-only mod file/no
> network access really *shouldn't* be a problem, it will still just bomb
> out.
>

The go command is "bombing out" here because the code in question
is trying to import "example.com/other-module", yet no dependency listed
in go.mod provides that package (there are no dependencies in go.mod at
all!).
[One of the things go list computes is the dependency graph
(visible if you use go list -json or go list -f '{{.Deps}}').]

It's true that if you have a CI/CD system, then for a successful build
you need to push complete code to it, and that includes a go.mod with
listed dependencies sufficient to cover the relevant imports,
as I described in my original reply to Nicolas. If go.mod were up to date
(for example, if 'go mod tidy' found no work to do) and the local
Go module cache already contained the listed dependencies,
then the 'go list -mod=readonly' command you showed would complete
just fine. You can't push code with an incomplete dependency list to the
CI/CD system and expect it to build, any more than you can push
code with missing function definitions and expect it to build.

Best,
Russ
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Benny Siegert]

Last time this discussion came up in person, someone from the Go team
suggested replacing all the go.mod files with new ones that are
entirely based on package metadata -- i.e. declared dependencies,
their installed location etc.

This seems like a reasonable solution, and it would be a pity if the
notary made this impossible.

On Sat, Mar 9, 2019 at 3:01 AM 'Matthew Dempsky' via golang-dev
 wrote:
>
> On Fri, Mar 8, 2019 at 4:52 PM 'Nicolas Mailhot' via golang-dev 
>  wrote:
>>
>> It would be nice if it where true. Unfortunately even a simple command
>> like tell me what you know about the local code tree
>>   go list -json -mod=readonly ./...
>>
>> will abort if the CI/CD system cuts network access to make sure builds
>> do not depend on Internet state.
>
>
> The behavior you described sounds like an issue to me. However, I wasn't able 
> to easily reproduce it locally: I tried running "strace -f go list -json 
> -mod=readonly ./... |& grep connect" under a few scenarios (e.g., missing 
> go.sum, or incomplete go.mod file), and none of them seemed to result in 
> network access.
>
> Can you provide more detailed reproduction steps?
>
>> The no-modification no-internet CI/CD constrain was not taken into
>> account into the original design. It was bolted on later, and the
>> bolting is imperfect.
>
>
> I don't think this is true. Google's internal build system has used this same 
> "no-modification no-internet" constraint for around a decade:
>
> http://google-engtools.blogspot.com/2011/09/build-in-cloud-distributing-build-steps.html
> https://mike-bland.com/2012/10/01/tools.html#blaze-forge-srcfs-objfs
>
> Supporting this usage pattern has been and remains very important to Go.
>
>> > I would have expected that if Fedora modified a library, they
>> > would give it a different version number, so that for example
>> > modifying v1.2.2 would produce v1.2.3-fedora.1
>>
>> And that's not the case neither for Fedora, nor RHEL, nor Debian, nor
>> pretty much any large scale integrator,
>
>
> When I run "gcc --version" on my work Debian machine, I see:
>
> gcc (Debian 7.3.0-5) 7.3.0
>
> If Debian is okay naming their version of GCC "Debian 7.3.0-5", I'd think 
> they're okay releasing a patched Go package as v1.2.3-debian.1.
>
> You even seem to suggest this later when talking about "mymodule@v1.2.2 
> release 1" and "mymodule@v1.2.2 release 2." Russ is just talking about a 
> different way of encoding those version strings.
>
>> because when you integrate
>> masses of third-party code you will eventually hit bugs in pretty much
>> every component, so having to run patched code at every layer is the
>> norm not the exception.
>
>
> The need to make changes to open source packages is familiar to Google. E.g., 
> Google's internal build system incorporates a lot of open source packages, 
> and many need to be modified to accommodate Google's internal development 
> idiosyncracies. Even the Go toolchain and standard library themselves are 
> patched internally.
>
> I think it would help if you could highlight the specific technical hurdles 
> you're running into trying to bundle Go packages into RPMs. I expect the 
> mechanisms are in place to do what you need, but I can believe the tooling 
> could use improvements to handle Linux-distribution-scale integration efforts 
> better, and I think the Go project is interested in supporting those efforts.
>
>> And you want us to renumber all this, and patch all the other module
>> files that use those with the new numbers, and redo it all every time
>> something changes, all year round, just because the go command can’t
>> accept that the code state Fedora builds from, may differ from the one
>> observed on the Internet?
>>
>> Really?
>>
>> REALLY ?
>>
>> Do you really REALLY think any sane integrator will play this dance long
>> instead of patching out notary checks from its go command, and be done
>> with it?
>
>
> I would expect the amount of manual integration work needed would scale with 
> the amount of local changes required, not with the amount of dependencies. 
> E.g., if you have to modify a core Go module to work better on Fedora, I 
> would think you make that one change, and your build system and tooling would 
> handle automatically rebuilding dependencies as appropriate. I wouldn't 
> expect you to have to manually renumber/rename every downstream dependency.
>
> If you're finding that's not the case, please share the issues you're running 
> into so they can be discussed concretely and addressed.
>
>> The utopia is thinking that everything is released in a perfect state by
>> upstream, so changes downstream need not happen,
>
>
> As pointed out above, Google and Go's build systems are not built for this 
> utopia, but for the real world where downstream changes are needed.
>
>
> Finally, you included a detailed description of your package build system 
> (which sounds very similar to Google's internal build system), but didn't 
> seem to highlight how 

Re: [golang-dev] proposal: public module authentication with the Go notary

[Ian Denhardt]

Quoting 'Matthew Dempsky' via golang-dev (2019-03-08 21:01:32)

>Can you provide more detailed reproduction steps?

Here's a reproducer:

> $ go mod init example.org/my-project
> go: creating new go.mod: module example.org/my-project
> $ cat >> main.go << "EOF"
> package main
> import _ "example.com/other-module"
> func main() {}
> EOF
> $ go list -mod=readonly ./...
> build example.org/my-project: cannot load example.com/other-module:
> import lookup disabled by -mod=readonly

I think we'd both mis-understood Nicolas's complaint the first time --
it's not that it still tries to access the network with -mod=readonly,
but that even for basic commands for which a read-only mod file/no
network access really *shouldn't* be a problem, it will still just bomb
out.

I'm not familiar with the code, but this sounds like early in the common
program logic there's a check as to whether any of the module data needs
updating, then abort if it can't be done -- before even looking at what
the user has asked us to do.

I agree this is kinda sad; it seems like it would be better if the go
tool still tried to fulfill the user's request to the extent possible
when -mod=readonly is set.

-Ian
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Matthew Dempsky]

On Fri, Mar 8, 2019 at 4:52 PM 'Nicolas Mailhot' via golang-dev <
golang-...@googlegroups.com> wrote:

> It would be nice if it where true. Unfortunately even a simple command
> like tell me what you know about the local code tree
>   go list -json -mod=readonly ./...
>
> will abort if the CI/CD system cuts network access to make sure builds
> do not depend on Internet state.
>

The behavior you described sounds like an issue to me. However, I wasn't
able to easily reproduce it locally: I tried running "strace -f go list
-json -mod=readonly ./... |& grep connect" under a few scenarios (e.g.,
missing go.sum, or incomplete go.mod file), and none of them seemed to
result in network access.

Can you provide more detailed reproduction steps?

The no-modification no-internet CI/CD constrain was not taken into
> account into the original design. It was bolted on later, and the
> bolting is imperfect.


I don't think this is true. Google's internal build system has used this
same "no-modification no-internet" constraint for around a decade:

http://google-engtools.blogspot.com/2011/09/build-in-cloud-distributing-build-steps.html
https://mike-bland.com/2012/10/01/tools.html#blaze-forge-srcfs-objfs

Supporting this usage pattern has been and remains very important to Go.

> I would have expected that if Fedora modified a library, they
> > would give it a different version number, so that for example
> > modifying v1.2.2 would produce v1.2.3-fedora.1
>
> And that's not the case neither for Fedora, nor RHEL, nor Debian, nor
> pretty much any large scale integrator,


When I run "gcc --version" on my work Debian machine, I see:

gcc (Debian 7.3.0-5) 7.3.0

If Debian is okay naming their version of GCC "Debian 7.3.0-5", I'd think
they're okay releasing a patched Go package as v1.2.3-debian.1.

You even seem to suggest this later when talking about "mymodule@v1.2.2
release 1" and "mymodule@v1.2.2 release 2." Russ is just talking about a
different way of encoding those version strings.

because when you integrate
> masses of third-party code you will eventually hit bugs in pretty much
> every component, so having to run patched code at every layer is the
> norm not the exception.
>

The need to make changes to open source packages is familiar to Google.
E.g., Google's internal build system incorporates a lot of open source
packages, and many need to be modified to accommodate Google's internal
development idiosyncracies. Even the Go toolchain and standard library
themselves are patched internally.

I think it would help if you could highlight the specific technical hurdles
you're running into trying to bundle Go packages into RPMs. I expect the
mechanisms are in place to do what you need, but I can believe the tooling
could use improvements to handle Linux-distribution-scale integration
efforts better, and I think the Go project is interested in supporting
those efforts.

And you want us to renumber all this, and patch all the other module
> files that use those with the new numbers, and redo it all every time
> something changes, all year round, just because the go command can’t
> accept that the code state Fedora builds from, may differ from the one
> observed on the Internet?
>
> Really?
>
> REALLY ?
>
> Do you really REALLY think any sane integrator will play this dance long
> instead of patching out notary checks from its go command, and be done
> with it?
>

I would expect the amount of manual integration work needed would scale
with the amount of local changes required, not with the amount of
dependencies. E.g., if you have to modify a core Go module to work better
on Fedora, I would think you make that one change, and your build system
and tooling would handle automatically rebuilding dependencies as
appropriate. I wouldn't expect you to have to manually renumber/rename
every downstream dependency.

If you're finding that's not the case, please share the issues you're
running into so they can be discussed concretely and addressed.

The utopia is thinking that everything is released in a perfect state by
> upstream, so changes downstream need not happen,


As pointed out above, Google and Go's build systems are not built for this
utopia, but for the real world where downstream changes are needed.


Finally, you included a detailed description of your package build system
(which sounds very similar to Google's internal build system), but didn't
seem to highlight how the Go module system or proposed Go notary system
cause problems.

E.g., you mention that in step A.3 that you download and install the Fedora
version of any package dependencies. I would think these packages can
contain any extra metadata for step C to be able to rename/renumber the
current package (if even necessary) without Internet access.
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 

Re: [golang-dev] proposal: public module authentication with the Go notary

[Russ Cox]

On Thu, Mar 7, 2019 at 5:52 AM Jakub Cajka  wrote:

> As I will carefully evaluate all the details of the final implementation,
> but from this first look I'm currently leaning to "patch out" or
> de-configure by default this feature in Fedora when/if it lands in upstream
> GC, to preserve the privacy of the users.
>

Thanks for this feedback. I would only ask that you remember that
publishing the design proposal is the *first* step in the public
discussion, not the last. Please remember to check back in for the final
result before you decide to apply local patches in Fedora.

Russ
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

Re: [golang-dev] proposal: public module authentication with the Go notary

[Russ Cox]

On Fri, Mar 8, 2019 at 8:09 AM 'Nicolas Mailhot' via golang-dev <
golang-...@googlegroups.com> wrote:

> The notary part of Go modules, like the rest of the module
> implementation, suffers from a lack of understanding of integration and
> QA workflows, and a simplistic dev-centric worldview.
>

This is not an auspicious beginning.
This mail came across as trying more to be antagonistic than constructive.
Even so, I really would like to understand your concerns
and either help address misunderstandings or adjust the
design appropriately.

CONTINUOUS TRANSPARENT INTERNET LOOKUPS ARE NOT ACCEPTABLE POST−DEV
>
> [snip]
>
> But, that QA reproducibility constrain was not understood by Go
> developers, and pretty much all the Go tools that were ported to module
> mode, will attempt Internet accesses at the slightest occasion, and
> change the project state based on those access results, with no ability
> to control or disable it, and nasty failure modes if the internet access
> fails.
>

This really couldn't be farther from the truth.

You can turn off module changes using -mod=readonly in CI/CD systems.
We added it explicitly for that use case. Quoting golang.org/issue/26361 (July
2018):

CI systems need a way to test what's in the go.mod and fail if
something is missing instead of looking to satisfy dependencies
automatically. We meant for -getmode=local to mean this, but it
really means something a little bit different. We should add a
-getmode that does mean "you can't change go.mod". Maybe
-getmode=noauto.

The eventual spelling was -mod=readonly, and it shipped in Go 1.11
with the initial module preview.

More generally, we understand the importance of reproducibility.
For example, see this post  and this
talk .

The Go issue tracker is filling up with reports of people expressing
> their incredulity (or more) after hitting a variation of this problem on
> their QA systems.
>

If you could point to specific examples, that would help me understand
your concerns a bit better. I did try to find some but failed:

$ issue cmd/go QA
26746 proposal: doc/install: define minimum supported VCS versions
14812 runtime: GC causes latency spikes
$ issue is:closed cmd/go QA
24301 cmd/go: add package version support to Go toolchain
22491 proposal: cmd/link: support BUILD_PATH_PREFIX_MAP for reproducible
binaries when built under varying path
27160 x/build: set up AIX builder
12660 x/mobile: support Xcode 7
$

QA−ED CODE IS NOT PRISTINE DEV CODE
>
> No code is ever perfect.
>
> When you integrate large volumes of code, targeting multiple hardware
> architectures, you *will* hit problems missed by the original upstream
> dev team. And you *will* have to patch them up, and you *will* have to
> build the result without waiting for upstream to look at it because, in
> production, the show must go on, some of those will eventually have
> zero-day security implications, and the upstreaming lag is not
> acceptable (assuming upstream is available and friendly, which is not
> necessarily the case).
>
> So no serious shop is ever going to build its information system from
> pristine upstream dev code or pristine upstream Go modules. Pristine
> upstream code building is a nice ideal, but in the real world, it’s
> utopia.
>
> If you don’t believe me, take your favorite app, and try to build a
> system containing it from genuine unadultered upstream code (that means,
> without relying on Fedora, Debian or whatever, since we all know they
> are full of “nasty” patched code).
>
> Again, that technical real-world-is-not-perfect was not understood by Go
> developers. Sure they gave us the replace directive in Go module. But
> that is opt-in. So it only works on a small scale, when fixing third
> party code is an exception, and you only have a handful of projects that
> use this third-party code.
>
> On a large scale everyone will just preventively rename everything by
> default just to retain the ability to perform fixes easily. You'll end
> up with blanket replacement of every "upstream" module name with
> "qaed/upstream" forks. And probably easier to rewrite all the imports to
> point to qaed/upstream by default in the source code.
>
> That will result in a huge mess, much larger than the current GOPATH
> vendoring mess.
>
> All because the design does not take into account the last mile QA
> patching that occurs before putting code in production.
>
> Blindly enforcing renaming rules because you don't understand or accept
> the existence of QA middlemen produced things like Iceweasel. And I
> don't think Mozilla or Debian were ever happy about it.
>

I've read this a couple times and found it a little hard to follow,
but I think what you are saying is that the go.sum and notary checks
are going to cause serious problems because Fedora and other
distributions want to create modified copies of module versions and
use them for building the software they 

Re: [golang-dev] proposal: public module authentication with the Go notary

[Ian Lance Taylor]

On Fri, Mar 8, 2019 at 4:52 PM 'Nicolas Mailhot' via golang-dev
 wrote:
>
> Le vendredi 08 mars 2019 à 10:28 -0500, Russ Cox a écrit :
> > On Fri, Mar 8, 2019 at 8:09 AM 'Nicolas Mailhot' via golang-dev <
> > golang-...@googlegroups.com> wrote:
> > > The notary part of Go modules, like the rest of the module
> > > implementation, suffers from a lack of understanding of integration
> > > and QA workflows, and a simplistic dev-centric worldview.
> >
> > This is not an auspicious beginning.
> > This mail came across as trying more to be antagonistic than
> > constructive
>
> I'm sorry, my level of English is not sufficient to convey information
> you want to ignore, and dress it up so you feel good about it. I've
> tried to stick to plain facts. If you object to plain facts I can't do
> anything about it.

You say that this is information that we want to ignore.  Why leads
you to say such a thing?  What makes you think that we want to ignore
it?  We have never claimed to know everything.  Adding modules to the
go tool is a work in progress.

Problems can be identified and solved but a necessary step is that
everyone treat each other with respect.  When you accuse others of
wanting to ignore you, that makes your message seem like an attack,
and indeed makes people more likely to ignore it.  Your message would
be a lot easier to read if you did just stick to plain facts.

Thanks.

Ian
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Ok I've checked the current code and the problem also exists here.

I have a fix, will commit it once I'm somewhere that allows ssh access to 
pagure (since pagure does not allow https commits)
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
(BTW did you check what happens with the current macro version? This part has 
been refactored for more robustness, even though this is definitely a case I 
didn't check so if it's fixed it's fixed as a side effect of something else ;))
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist

[Elliott Sales de Andrade]

qulogic reported a new issue against the project: `go-rpm-macros` that you are 
following:
``
In the old version of 
[golang-github-pkg-errors](https://src.fedoraproject.org/rpms/golang-github-pkg-errors/blob/f28/f/golang-github-pkg-errors.spec),
 there was a typo, and `glide.yaml` was listed twice in the sources. This meant 
that `glide.lock` was never copied to the source directory.

When `%goinstall glide.yaml glide.lock` was called later, it created a 
`glide.lock` _directory_. Now that I'm trying to fix it, it causes [an upgrade 
error](https://bodhi.fedoraproject.org/updates/FEDORA-2019-f01a015bb7#comment-893294)
 since rpm can't handle a directory->file change. So now I need to go throw in 
a scriptlet to fix the directory.

`%goinstall` should not accept an explicit path argument that does not exist, 
and should fail the build. If it really needs to be able to create arbitrary 
directories like that, it should be behind an explicit flag (like `install -d` 
is).
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Nicolas Mailhot]

nim commented on the pull-request: `Replace Go internals with go/build` that 
you are following:
``
The v2 is module versioning. That's something we need to support to have 
working Go packaging. It's good that your PR starts picking it up when the 
previous code does not.

However you are right that just doing it that way is going to break things. It 
needs changes in other parts of `golist` *and* in the macro code (and the 
current go-rpm-macro code should be in a good enough shape to allow those 
changes but that ’s not what it in Fedora).

Looking at how `github.com/cespare/xxhash` handled the module transition, 
assuming it is representative of the conversion of a real-world codebase to 
modules, here is the list of the things I see needing doing (paper analysis, 
real work implementation and testing is needed)

- we have the new module descriptors. That means `golist` needs to include the 
`go.mod` file as part of the project files, otherwise it will not end up in the 
-devel package and rpm will (rightfully) ignore it when generating deps

- then once the `go.mod` file is in the devel package we need to check the 
golist call that generates the package provides actually sees it (should 
probably just work with the code in go-rpm-macros and will almost certainly 
fail in some case with the code in Fedora because some of the approximations I 
fixed this year and which are still in the Fedora macro code will definitely 
hurt module parsing)

- then we have the fact that modules break the identity between the URL and the 
import path. The code is still at `https://github.com/cespare/xxhash` but the 
logical name is now `github.com/cespare/xxhash/v2`. No matter this is a case 
that is handled nicely by go-rpm-macros, that just means you need to declare 
`github.com/cespare/xxhash/v2` as  `goipath` and  
`https://github.com/cespare/xxhash` as `forgeurl`

- the module says v2 depends on v1 which means you need a separate v1 spec and 
package with just  `github.com/cespare/xxhash/` `goipath` (and be careful to 
pull from the V1 banch not the v2 one)

- but, what happens when a single git repo ships several `go.mod` files with a 
logical name that has nothing to do with the URL path ? I suspect things will 
break badly. the latest go-rpm-macros code is a lot more flexible, but it still 
assumes some form of identity between the filesystem layout and the import 
layout. How badly will this identity break with modules? I have no idea.

- and then you have the version qualifiers in the module files, we need to map 
them rpm side one way or another


``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Yes goinstall error checking should be improved (even though the target will be 
modules soonish that should hopefully remove the need for custom install hacks)
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Nicolas Mailhot]

nim commented on the pull-request: `Replace Go internals with go/build` that 
you are following:
``
Ok, after more work evolving to module support seems a bit simpler than I 
though, because go mod need requires people to clean up their mess and that's 
also the assumption of the current go-rpm-macros.

Though it will definitely require the coding of a helper in go, since the json 
structure go mod edit outputs is pretty much unworkable in shell, lua is not 
available at this stage of the rpm build, and I don't think we need to inject a 
fourth language in our go tooling (after lua+shell due to how rpm works, and 
golang for golist).

The 1000-dollar question is how much this new helper can subsume current golist 
functions, or if we end up with 2 helpers because go module is almost  there 
for our needs but not completely.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #6: didn't find "github.com/google/go-cmp/cmp"

[Nicolas Mailhot]

The issue: `didn't find "github.com/google/go-cmp/cmp"` of project: `golist` 
has been assigned to `nim` by nim.

https://pagure.io/golist/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #4: golist needs to be able to process multiple import paths in one pass

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
I think most of the code is already written to handle this; it just needs to 
fix the CLI flags to work correctly.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #6: didn't find "github.com/google/go-cmp/cmp"

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
I will recheck. cloud.google.com/go is a full bag of nastiness, that even other 
Google projects have problems with (most of them still import it under a legacy 
name, which means they are afraid of using the latest code. The current 
cloud.google.com/go asserts its new name which means anything still using the 
legacy name never tried to use the current codebase).
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #9: incomplete import detection for tests

[Nicolas Mailhot]

The issue: `incomplete import detection for tests ` of project: `golist` has 
been assigned to `nim` by nim.

https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Elliott Sales de Andrade]

qulogic commented on the pull-request: `Replace Go internals with go/build` 
that you are following:
``
As a note, the original code ran a resolve on the test imports, but not the 
regular imports. I tried adding a resolve on the regular imports as well, but 
it doesn't help. I also tried setting `GO111MODULE=on`, and while it does stop 
it from erroring, it still returns the same `/v2` import path back.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Elliott Sales de Andrade]

qulogic commented on the pull-request: `Replace Go internals with go/build` 
that you are following:
``
So for tests, I searched the specs for all that define`goipath` and cloned all 
of them (note this is _not_ all Go packages.) Then ran `golist` as packaged and 
`golist` from this PR and compared the results for all possible arguments.

Current `golist` crashes on:

* github.com/gengo/grpc-gateway
* github.com/shurcooL/githubql

but this PR works again.

There are only 2 differences out of 510 packages with `goipath` (out of 
approximately 642 that mention golang at all):

* github.com/cespare/xxhash
* github.com/google/go-github

Both of these report themselves in the `--imported` section, but the new one 
includes the version (i.e., `github.com/cespare/xxhash` -> 
`github.com/cespare/xxhash/v2`). I assume this might be a problem, since we 
don't add it in the provides, but I don't know for sure. Can you confirm @nim?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #9: incomplete import detection for tests

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
golist does not uses this kind or regexes it plugs directly in the Go compiler 
inner code to match the Go compiler view of what's in a project. This was a 
deliberate choice by Fedora Go maintainers last year, my initial macro 
implementation just performed regexes in shell scripts.

So golist results should be more correct that what you would expect naïvely 
from a human file path analysis.

Unfortunately that also assumes the integration with Go compiler rules is 
correct and complete. For example golist would initially parse files starting 
with '_', even though the Go spec says it should not, I suppose because Google 
implemented '_' in some other place of its codebase.

So basically, it's not as clear cut as that, this issue needs investigating why 
the Go compiler code thinks this file is a test file, and whether this is 
correct WRT the Go language spec, and not superseeded by some other exception 
golist does not implement.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #4: golist needs to be able to process multiple import paths in one pass

[Elliott Sales de Andrade]

The issue: `golist needs to be able to process multiple import paths in one 
pass` of project: `golist` has been assigned to `qulogic` by qulogic.

https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #9: incomplete import detection for tests

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Aren't Go tests in files that end with `_test.go`? Since 
`terminal_check_notappengine.go` is not one of those, it shouldn't be output 
with `--tests`. It _is_ output in the normal (no `--tests`) results.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
BTW:

* thanks an *awful* lot for looking at golist code maintenance
* if you can figure how to make golist process module info, and spit out the 
version constrains that only exists in those modules, that would be much nicer 
than inhibiting the module code path. Mid term, it would be more efficient for 
Fedora to process modules info by default, and contribute module descriptors to 
projects that miss then, rather than having packagers deal with the complexity 
of not using module info when upstreams already migrated to modules, or (worse) 
having to deal with some Go components in module mode and others in legacy 
something else mode

That's more or less liked to issue #13. A lot of the un-necessary complexity in 
the macro code is due to reprocessing the golist output format into something 
that rpm can use.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Elliott Sales de Andrade]

The issue: `runtime panic, nil dereference when running %gochecks` of project: 
`golist` has been assigned to `qulogic` by qulogic.

https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #10: unexpected directory layout (whatever that means)

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Yes, I suppose an alternative would be to track the things that depends on this 
bit of code and ask them to drop it.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/10
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
This looks the same as #7, no?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] PR #17: Replace Go internals with go/build

[Elliott Sales de Andrade]

qulogic opened a new pull-request against the project: `golist` that you are 
following:
``
Replace Go internals with go/build
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #9: incomplete import detection for tests

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
What I'm saying is that golist does _not_ think it's a test file, and I'm 
confused why you think it should be.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #9: incomplete import detection for tests

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Ah ok. I think that's because we only hit it when executing tests. Will look at 
it once more, maybe the logrus code was refactored since this was filed
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
The backtraces point to line 1888 here:
```go
1886 func ImportPaths(args []string) []*search.Match {
1887 if ModInit(); cfg.ModulesEnabled {
1888>return ModImportPaths(args)
1889 }
1890 return search.ImportPaths(args)
1891 }
```
Both `cfg.ModulesEnabled` and `ModImportPaths` are semi-global variables that 
are set to something in the `ModInit` call in `internal/modload/init.go`:
```
170 cfg.ModulesEnabled = true
171 load.ModBinDir = BinDir
172 load.ModLookup = Lookup
173 load.ModPackageModuleInfo = PackageModuleInfo
174 load.ModImportPaths = ImportPaths
175 load.ModPackageBuildInfo = PackageBuildInfo
176 load.ModInfoProg = ModInfoProg
177 load.ModImportFromFiles = ImportFromFiles
178 load.ModDirImportPath = DirImportPath
179 
180 search.SetModRoot(ModRoot)
181 }
```

I took a look in delve, and something seems up with the variables:

* Great, only one copy:
```
(dlv) vars ModulesEnabled
cmd/go/internal/cfg.ModulesEnabled = true
```
* Multiple versions, but at least they're in sync:
```
(dlv) vars ModInit
pagure.io/golist/pkg/util/internal/load.ModInit = 
pagure.io/golist/pkg/util/internal/modload.Init
cmd/go/internal/load.ModInit = pagure.io/golist/pkg/util/internal/modload.Init
```
* Multiple versions, but not in sync:
```
(dlv) vars ModImportPaths
pagure.io/golist/pkg/util/internal/load.ModImportPaths = nil
cmd/go/internal/load.ModImportPaths = 
pagure.io/golist/pkg/util/internal/modload.ImportPaths
```

I don't exactly know why this occurs, but finding the root of this would 
obviously fix the problem.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #6: didn't find "github.com/google/go-cmp/cmp"

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Is this still a problem?
```
$ golist --imported --package-path cloud.google.com/go --skip-self | rg go-cmp
github.com/google/go-cmp/cmp

$ golist --imported --package-path cloud.google.com/go --skip-self --tests | rg 
go-cmp
github.com/google/go-cmp/cmp
github.com/google/go-cmp/cmp/cmpopts
```
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #10: unexpected directory layout (whatever that means)

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
This package also fails `go build` with the same message, so I'm not sure we 
can really blame `golist`. It seems to be an outdated and broken-on-latest-Go 
package.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/10
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] PR #5: Update bootstrapping link

[Jakub Čajka]

jcajka merged a pull-request against the project: `go-rpm-macros` that you are 
following.

Merged pull-request:

``
Update bootstrapping link
``

https://pagure.io/go-rpm-macros/pull-request/5
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Sure it does, however till someone analyses both issues and concludes they are 
the same, it's dangerous to track only one of them.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Well, the null pointer is here:
```

/builddir/build/BUILD/symbols-extractor-9f4330a0f4437ca61ba92f9f30e34424c6742ad6/_build/src/github.com/gofed/symbols-extractor/pkg/util/internal/load/pkg.go:1888
 +0x5f fp=0xc000123038 sp=0xc000122ff8 pc=0x5637f95433af
```
which is the same line and file as #7.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1

[Elliott Sales de Andrade]

The issue: `golist should be ported to a current release of 
gopkg.in/urfave/cli.v1` of project: `golist` has been assigned to `qulogic` by 
qulogic.

https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #6: golist needs to be run outside the source tree to avoid panics

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Based on [further debugging](https://pagure.io/golist/issue/7#comment-551104), 
this appears related to Go modules. As such, an alternate workaround is to set 
`GO111MODULES=off` before calling `golist`. Of course, you need to be sure your 
package doesn't actually _use_ Go modules to specify an alternate path or 
whatever.
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
Should I push a fix directly (I think I can at least) or open a PR?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #6: golist needs to be run outside the source tree to avoid panics

[Nicolas Mailhot]

The issue: `golist needs to be run outside the source tree to avoid panics` of 
project: `go-rpm-macros` has been assigned to `nim` by nim.

https://pagure.io/go-rpm-macros/issue/6
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
For readers that don't understand the latest exchange, the participants wrote 
their piece here https://pagure.io/GoSIG/go-sig/issue/3
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
A workaround I've found that appears to work is:
```rpm
%check
builddir="$PWD/_build"
cd ..
%gochecks -b "$builddir"
```
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
@jcajka: how do you expect anyone to understand your position? Months over 
months of not accepting macro fixes, months over months of finding new reasons 
not to look at them, refusal to discuss it in SIG meetings, no activity in the 
pagure tickets that were opened at your request to follow things, etc

You complain you're asked to look at a fork. But it's only a fork because you 
don't take steps to review and merge the result (or merge some other better 
implementation). Every time I fix a new problem (like the one reported here) 
that takes the code further from what got into Fedora and makes you less 
willing to look at the result.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
That sucks  since other projects *expect* to be in the source dir when run. So 
I  guess the shell wrapper will need to be changed to run golist outside this 
dir and switch to it afterwards: (

I've filled it as https://pagure.io/go-rpm-macros/issue/6

Note that even if I write the workaround soonish, Fedora go-rpm-macros import 
is stuck on https://pagure.io/GoSIG/go-sig/issue/22 and I'm sick of all the 
unrealistic conditions jcajka invents to relay the review (for example, macro 
unit tests, when we even a core well supported language like python does not 
have those and no one know how to do it)
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
@qulogic this is all originally @jchaloup 's code. He asked to split it in a 
separate repository, but I don't know what's the level of involvement he wants 
(and can) provide here. Ask him politely how he wants to do things (of course 
if he can not or does not want to answer over a reasonable time that would be 
an answer in itself)
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Jakub Čajka]

jcajka added a new comment to an issue you are following:
``
@nim I would much appreciate if you woudn't put words in to my mouth, thanks
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #14: golist should handle naming assertions cleanly

[Nicolas Mailhot]

nim reported a new issue against the project: `golist` that you are following:
``
Because the naming of Go projects is a mess many of them (including core Google 
modules) have started asserting how they should be named.

This results in golist panics.

Because golist is often called by other scripts (for example, rpm dependency 
scripts) the panic messages are unhelpful, because the recipient of those 
messages has not called golist directly and does not know what exact golist 
call resulted in this panic.

golist should handle this case by default and:
1. output useful info to stderr, including what exactly it was doing at the 
panic time
2. abort with an error code
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/14
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #4: Issues building golang source package on EL7

[Nicolas Mailhot]

nim added a new comment to an issue you are following:
``
Yes that's what I meant by a little tricky. The changes are not big or scary 
but they are spread over several packages that call one another, it's easier to 
publish a copr with all the small changes than try to walk you  through it 
manually.

Now the result works as well in EL7 and in devel, there are no backport 
regressions, but I can't promise it will be in EPEL soonish, there's a lot of 
Fedora admin work before that can happen.

Even the Fedora  part requires buy-in to execute the [cleanup 
plan](https://pagure.io/GoSIG/go-sig/issue/20). Mainly, lots of changes and 
fixes that accumulated in the last year that need someone to step in to review 
the result.
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #7: runtime panic, nil dereference when running %gochecks

[Elliott Sales de Andrade]

qulogic added a new comment to an issue you are following:
``
So is this or is this not a problem? Are tests actually being run or are they 
being ignored just like this panic?
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #15: Missing pkg/util/internal directory

[Elliott Sales de Andrade]

The status of the issue: `Missing pkg/util/internal directory` of project: 
`golist` has been updated to: Closed by qulogic.

https://pagure.io/golist/issue/15
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[golist] Issue #15: Missing pkg/util/internal directory

[Elliott Sales de Andrade]

qulogic reported a new issue against the project: `golist` that you are 
following:
``
```
$ go get pagure.io/golist/...
package pagure.io/golist/pkg/util/internal/load: unrecognized import path 
"pagure.io/golist/pkg/util/internal/load" (parse 
https://pagure.io/golist/pkg/util/internal/load?go-get=1: no go-import meta 
tags ())
package pagure.io/golist/pkg/util/internal/modload: unrecognized import path 
"pagure.io/golist/pkg/util/internal/modload" (parse 
https://pagure.io/golist/pkg/util/internal/modload?go-get=1: no go-import meta 
tags ())
package pagure.io/golist/pkg/util/internal/work: unrecognized import path 
"pagure.io/golist/pkg/util/internal/work" (parse 
https://pagure.io/golist/pkg/util/internal/work?go-get=1: no go-import meta 
tags ())
```
There is no `pkg/util/internal` in the repository.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/15
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org

[go-rpm-macros] Issue #4: Issues building golang source package on EL7

[Gary Mann]

mooz added a new comment to an issue you are following:
``
rpmbuild doesn't appear to want to give me any verbosity, I ran it with the 
--showrc flag and it looks to be stopping at the forgesource if statement below:

```
-- All the Go packaging automation relies on goipath being set
local goipath = rpm.expand("%{?goipath}")
if (goipath == "") then
  rpm.expand("%{error:Please set the Go import path in the “goipath” variable 
before calling “gometa”!}")
end
-- Compute and set spec variables
if (forgeurl ~= "") then
  rpm.expand("%forgemeta %{?-v} %{?-i} %{?-s} %{?-p} -u " .. forgeurl .. "\n")
  safeset("gourl", forgeurl)
else
  safeset("gourl", "https://; .. goipath)
  rpm.expand("%forgemeta %{?-v} %{?-i} -s %{?-p} -u %{gourl}\n")
end
if (rpm.expand("%{?forgesource}") ~= "") then
  safeset("gosource", "%{forgesource}")
else
  safeset("gosource", "%{gourl}/%{archivename}.%{archiveext}")
end
safeset("goname", "%gorpmname %{goipath}")
rpm.define("gosetup %forgesetup")
```

I'm currently using the specfile from the latest Fedora koji build of 
[golang-github-jedisct1-clocksmith](https://koji.fedoraproject.org/koji/buildinfo?buildID=1110314).
 

I took a look at your patch for redhat-rpm-config and it would seem to patch it 
against EL7 would need a little work since the patch is primarily against a 
Fedora build (not sure if that's what you meant by your last paragraph). I 
wasn't able to build the package in your copr on a mostly stock EL7 rpmbuild 
environment. But yes, whenever you get the time I'll be happy to test it again 
later.

``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org