[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @jcajka I agree from a theoretical POW. I was just pointing out that from a practical POW, asking all the Go parts we package to adhere strictly to the specs, means dealing with a lot of build failures. internal is known to be (mis)used by some projects. Do we want to ignore this (mis)use and just deal with failing builds whenever exposing internal makes things break? `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
jcajka commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @nim TBH I don't think that we should be creating our own dialect of Go(even from tooling perspective). What you are suggesting is basically it. We should respect upstream specs of the Go with all its warts and possibly work with upstream to clean up or add things that make packaging hard for us. I think that you shouldn't filter dependency list by default on some more or less arbitrary keyword(that is AFAIK not even mentioned in the guidelines). That doesn't mean that there shouldn't be feature that would filter them base on some keyword/regular expression. I can imagine that being useful in certain scenarios. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @obudai a lot of Go projects use internal in the package path to mean the same thing as the internal keyword. Welcome to the wonderful land of underspecified Go behaviour. Therefore, to be safe, golist should filter anything with internal in the path, unless requested explicitly with a specific switch. (and upstreams that use internal to mean something else than internal should probably rename their Go package now that internal as a package name has been used as internal by many Go projects) I know, it's clear as mud. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` That would wreck havoc on all package BRs since internal is a magic keyword that forbids exposing the result to other Go packages. Returning anything internal in `golist` must be isolated with an '--internal' optional switch (and %gocheck should probably use this flag, once it is created. The R and BR part definitely should not) `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
obudai commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` Running ``` golist --provided --tests --package-path github.com/osbuild/osbuild-composer ``` Without fix: ``` github.com/osbuild/osbuild-composer/internal/crypt github.com/osbuild/osbuild-composer/internal/distro github.com/osbuild/osbuild-composer/internal/pipeline ``` With fix: ``` github.com/osbuild/osbuild-composer/internal/crypt github.com/osbuild/osbuild-composer/internal/distro github.com/osbuild/osbuild-composer/internal/distro/fedora30 github.com/osbuild/osbuild-composer/internal/distro/rhel82 github.com/osbuild/osbuild-composer/internal/jobqueue github.com/osbuild/osbuild-composer/internal/pipeline github.com/osbuild/osbuild-composer/internal/weldr ``` `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
qulogic commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` Do you have an example? `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
obudai opened a new pull-request against the project: `golist` that you are following: `` Fix not listing packages with external tests only `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
