[golist] PR #27: Fix not listing packages with external tests only

2020-01-31 Thread Elliott Sales de Andrade

qulogic commented on the pull-request: `Fix not listing packages with external 
tests only` that you are following:
``
> @obudai a lot of Go projects use internal in the package path to mean the 
> same thing as the internal keyword. Welcome to the wonderful land of 
> underspecified Go behaviour.

I don't understand where you get the idea that this is some sort of hack that 
non-standard-library packages are taking advantage of. The use of `internal` 
was described in a [design document](http://golang.org/s/go14internal) that has 
been in use since Go 1.4.

> Therefore, to be safe, golist should filter anything with internal in the 
> path, unless requested explicitly with a specific switch. (and upstreams that 
> use internal to mean something else than internal should probably rename 
> their Go package now that internal as a package name has been used as 
> internal by many Go projects)

There is no other way for `internal` to be interpreted, so I don't know what 
you mean about other upstreams.

I do agree that if `golist` is specifying an internal path as something that 
goes in `Provides`, then that's a bug and it should be fixed.

> I know, it's clear as mud.

It is clear; you're confused.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/27
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org


[golist] PR #26: Handle tests outside packages correctly.

2020-01-31 Thread Elliott Sales de Andrade

qulogic commented on the pull-request: `Handle tests outside packages 
correctly.` that you are following:
``
This will add additional _test_ dependencies for:
* bazil.org/fuse
* github.com/Masterminds/semver
* github.com/boltdb/bolt
* github.com/cosmos72/gomacro
* github.com/denisenkom/go-mssqldb
* github.com/gofrs/flock
* github.com/google/go-github
* github.com/keybase/go-crypto
* github.com/klauspost/compress
* github.com/klauspost/crc32
* github.com/mdlayher/netlink
* github.com/onsi/ginkgo
* github.com/pierrec/lz4
* go4.org
* golang.org/x/build
* golang.org/x/image
* google.golang.org/grpc

but 90% are self-referential, and would be skipped by `--skip-self`. 90% of the 
remaining are to the standard library too, so not of any real effect.

I will try to check the remaining ones.
``

To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/26
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org