[golist] PR #27: Fix not listing packages with external tests only
qulogic commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` This would affect approximately 200 packages. Since this determines which test files to run, it could have some possible consequences for the build, but probably not the final package. I set up a [copr](https://copr.fedorainfracloud.org/coprs/qulogic/golist-pr27/) and more than half of those failed. _However_, many of them may already be failing, and, more importantly, the failures actually seem to be problems on copr. I will have to wait for it to be fixed to retry. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #26: Handle tests outside packages correctly.
eclipseo commented on the pull-request: `Handle tests outside packages correctly.` that you are following: `` Yeah I'm slowly working my way through the FTBFS, will probably need some help with reviews for new dep. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #26: Handle tests outside packages correctly.
qulogic commented on the pull-request: `Handle tests outside packages correctly.` that you are following: `` Everything that was affected was rebuilt in [this copr](https://copr.fedorainfracloud.org/coprs/qulogic/golist-pr26/), and while there were several failures, none of them are new (or not timeouts). `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #26: Handle tests outside packages correctly.
qulogic merged a pull-request against the project: `golist` that you are following. Merged pull-request: `` Handle tests outside packages correctly. `` https://pagure.io/golist/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #26: Handle tests outside packages correctly.
qulogic commented on the pull-request: `Handle tests outside packages correctly.` that you are following: `` I actually had a quite outdated list of packages to check and there are many more that are affected (though still 90% self-references). I set up a copr to do a test rebuild with this change, so we'll see soon whether there's any issues. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
qulogic commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` Coming back to what this PR is actually about, there may be one more case of `TestGoFiles` that you haven't changed to add `XTestGoFiles` in `BuildArtifact`, though I'm not sure we use that for anything. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
