[go-rpm-macros] PR #23: macros: Accept options for %gotest
atodorov commented on the pull-request: `macros: Accept options for %gotest` that you are following: `` @nim I'm not sure what I actually need TBH. This whole area is rather new to me and I'm trying to figure it out and make it work as I go along. Not necessarily in this order. From what `go help test` tells me I think it should support the same flags as `go build` plus some more. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #23: macros: Accept options for %gotest
atodorov commented on the pull-request: `macros: Accept options for %gotest` that you are following: `` @nim you can see the changes I'd like to have here: https://github.com/osbuild/osbuild-composer/pull/282/files#diff-e9f97a745edf48c066fbf93e4aa115c2 The backgroud is that the mentioned `osbuild-dnf-json-tests` binary should be converted to use the syntax of the go testing module and be able to compile that and ship it into the RPM. In `%build` I tried just `go test -c -o ...` but that caused rpmbuild to fail with missing build-id. That's why I wanted to use the `%gotest` macro b/c it configures all flags accordingly but then I bumped into the issue of the macro not supporting the options I need. As you can see I've got an easy workaround to defined another macro in my .spec file and use that instead. But figured this could be something other folks want to do as well. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #23: macros: Accept options for %gotest
atodorov opened a new pull-request against the project: `go-rpm-macros` that you are following: `` macros: Accept options for %gotest `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
