GWT 2.1 M3
Hi to all, any simple example of data presentation widget of GWT 2.1 M3 Best Regards Thanking you, Gopal Dhanjibhai Bhalala -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: [ERROR] [gmn] Unable to find 'gmn.gwt.xml' on your classpath; could be a typo, or maybe you forgot to include a classpath entry for source?
Hi, Seems to me u have compile errors...not eclipse but GWT.. maybe u are using some libs that are not supported by GWT... Check yr imports... On Fri, Sep 17, 2010 at 7:36 PM, ziv zivli...@gmail.com wrote: hey everybody, I am new to gwt programing, and I could really use some help.. I have been writing a GWT application with eclipse. I have a GMN.JAVA that has a class that I created. and I keep getting this error, what is the problem here? a little about my hierchy: GMN/src/com/gmn/ui/client/GMN.java GMN/src/com/gmn/ui/server/GMNworld.java my XML file: GMN/src/com/ui/GMN.gwt.xml ?xml version=1.0 encoding=UTF-8? module rename-to='GMN' !-- Inherit the core Web Toolkit stuff.-- inherits name='com.google.gwt.user.User'/ !-- Inherit the default GWT style sheet. You can change -- !-- the theme of your GWT application by uncommenting -- !-- any one of the following lines.-- inherits name='com.google.gwt.user.theme.standard.Standard'/ !-- inherits name='com.google.gwt.user.theme.chrome.Chrome'/ -- !-- inherits name='com.google.gwt.user.theme.dark.Dark'/ -- !-- Other module inherits -- !-- Specify the app entry point class. -- entry-point class='com.gmn.ui.client.GMN'/ !-- Specify the paths for translatable code-- source path='client'/ source path='server'/ source path='shared'/ /module HELP!! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT 2.1 M3
On Sep 18, 8:21 am, gopal bhalala gopalbhal...@gmail.com wrote: Hi to all, any simple example of data presentation widget of GWT 2.1 M3 Have a look at the Showcase and DynatableRF that come in the M3 zip distribution. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: de-mavenize a project
On Sat, Sep 18, 2010 at 12:10 AM, John nesre...@gmail.com wrote: On Fri, Sep 17, 2010 at 11:06 AM, olivier nouguier olivier.nougu...@gmail.com wrote: Or learn maven ;) There are s many interesting things to learn, rails, groovy, python, and on and on. It's hard to justify taking time to learn something that solves problems you don't have. For sure ... but IMHO It really worth to give a try with maven because a mavenized project is very easy to install / try as soon as maven is bootstraped. In your case,you'll just have to unzip the maven binaries adapth your path and try. As some might found this thread OT with GWT, if you want to try and encounter some issues don't hesitate to contact me on my mail directly. Cheers, Olivier More seriously, you can easy de mavenize aproject, but maven will help you: mvn dependency:copy-dependencies will copy all dependencies in a folder target/dependency Then you'll just have to add those lib in your build classpath. mvn eclipse:clean eclipse:eclipse will build for you the .classpath (among others) file to run in eclipse without m2eclipse. I had to re-install the project (but maven was still installed). So Maven didn't install into my Eclipse workspace--I don't know why, but it did not give me that choice. Normally there is a little checkbox (in non-maven imports) to import into Eclipse workspace. Since it stuck everything arbitrarily into my home directory, I found out that maven wasn't in my path, so I couldn't try what you suggested. But thanks, I do appreciate the reply. I guess I could set paths and whatever, to get the the NEXT problem, but it's probably not worth spending more time on it. I'm happy to use the standard GWT fileuploader widget--I was just curious, because GWTUploader does seem like a nice way to do things. John -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- Computers are useless. They can only give you answers. - Pablo Picasso - -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
HTTP query string when tested in development mode
Hi
I have the following servlet filter and mapped to the URL pattern /*
public void doFilter(ServletRequest request, ServletResponse response,
FilterChain chain) throws IOException, ServletException {
HttpServletRequest req = (HttpServletRequest) request;
// query is null?
String query = req.getQueryString();
}
When I started the GWT application in development mode:
http://127.0.0.1:/Dummy.html?debugparam2gwt.codesvr=127.0.0.1:9997http://127.0.0.1:/Dummy.html?debuggwt.codesvr=127.0.0.1:9997,
the
query string is always empty (null).
Do you know why?
--
Hez
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Re: EventBus and HandlerManager Classes. Difference?
Thanks very much, Thomas. This make a little more sense. I keep looking at the base roo application and it is showing ( I think as of M3 with the ScaffoldFactory) the use of the HandlerManager. So it is good to hear that for certain that we are moving away from HandlerManager and to implementations of the EventBus. Thanks very much! On Sep 17, 4:12 pm, Thomas Broyer t.bro...@gmail.com wrote: On Sep 17, 9:05 pm, Ashton Thomas ash...@acrinta.com wrote: I am confused as to when use the abstract class EventBus class that implements HasHandlers:http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/... and the class HandlerManager that also implements HasHandlers:http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/... I know we have th SimpleEventBus that extends EventBus but I am still a bit confused. Can anyone do a brain dumb or drop some info? Basically, HandlerManager is only to be used within widgets (and it is an internal part of Widget, backing the addHandler and addDomHandler methods; so you shouldn't have to use it directly, probably the reason it's marked @Deprecated). If you need an event bus to make you apps components communicate with each others, then you should use EventBus, which SimpleEventBus is an implementation. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: An Updated GWT Designer Tutorial
Exactly. We have decided to keep that forum open for precisely that reason (until we find a good way to preserve all of that info). We would like to migrate to a set of Google groups in the future. @Chad - thanks for the update tutorial. Great stuff as always! :-) -Eric On Sep 17, 3:34 pm, Jeff Chimene jchim...@gmail.com wrote: Yes. However, there's a lot of stored wisdom at that URL. Thanks for the pointer. 2010/9/17 Jaroslav Záruba jaroslav.zar...@gmail.com Now when GWT Designer is in Google portfolio, wouldn't it make sense to have mailing list for it, as all Google products/services have? I personally find emails way more comfortable compared to forums. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: EventBus and HandlerManager Classes. Difference?
On Sep 18, 3:26 pm, Ashton Thomas ash...@acrinta.com wrote: Thanks very much, Thomas. This make a little more sense. I keep looking at the base roo application and it is showing ( I think as of M3 with the ScaffoldFactory) the use of the HandlerManager. SimpleEventBus didn't yet existed in 2.1M3 and HandlerManager was the only (provided) implementation of EventBus. So it is good to hear that for certain that we are moving away from HandlerManager and to implementations of the EventBus. http://code.google.com/p/google-web-toolkit/source/detail?r=8756 Refactors HandlerManager.HandlerRegistry into a new public class, SimpleEventBus. MultiFire, default source stamping, and event recycling are left as features of HandlerManager. HandlerManager no longer implements EventBus interface, in the interest of less confusing API for EventBus users. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: EventBus and HandlerManager Classes. Difference?
Thanks, I was looking for this info before posting. But I have been away from the gwt world for a bit and got out of sync. Thanks! On Sep 18, 7:21 pm, Thomas Broyer t.bro...@gmail.com wrote: On Sep 18, 3:26 pm, Ashton Thomas ash...@acrinta.com wrote: Thanks very much, Thomas. This make a little more sense. I keep looking at the base roo application and it is showing ( I think as of M3 with the ScaffoldFactory) the use of the HandlerManager. SimpleEventBus didn't yet existed in 2.1M3 and HandlerManager was the only (provided) implementation of EventBus. So it is good to hear that for certain that we are moving away from HandlerManager and to implementations of the EventBus. http://code.google.com/p/google-web-toolkit/source/detail?r=8756 Refactors HandlerManager.HandlerRegistry into a new public class, SimpleEventBus. MultiFire, default source stamping, and event recycling are left as features of HandlerManager. HandlerManager no longer implements EventBus interface, in the interest of less confusing API for EventBus users. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: HTTP query string when tested in development mode
From what you've posted it doesn't look like a valid URL. A query string, as far as I know, is a series of key=value pairs separated by . You posted this: http://127.0.0.1:/Dummy.html?debugparam2gwt.codesvr=127.0.0.1:9997 Which doesn't look correctly formed. Try this: http://127.0.0.1:/Dummy.html?debug=2param=2gwt.codesvr=127.0.0.1:9997 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Receive xml file after authentication
If you're using a desktop application then you really shouldn't be communicating with a GWT server. You can create non-GWT servlets in your web application and I'd recommend using that. Once you have that set up you can use whatever method you want (GET, POST, Basic, Web Services, etc ...). Basically, this isn't a GWT problem so take it out of the equation. On Sep 16, 8:48 am, kkpirri hkakashisharin...@gmail.com wrote: Hi, Need to communicate a desktop application with my GWT site in a tomcat server. The desktop application creates a XML document and the authentication info must be sent to the GWT site. The authentication must be done automatically; the user and the password are stored on the client machine and the file must be send after authentication or with the authentication package. I thought on using digest authentication or send the XML using SOAP, but I don't know how this can be done with GWT. I also thought on combining PHP (for authentication and file receiving) and the GWT site with java back- end, but I don't know how to share the session variables and cookies between the two platforms. I would appreciate your help and any other suggestion you can give me. Thank you very much -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Any metrices on amount of code/data we can put on client side (browser)
This is a tough question because every browser is going to be different, every environment is going to be different, and every physical machine is going to be a little different. Maybe you can tell us where you're at now and where you are having any performance problems? I think I have a rather large app that contains two entry points and they are (obfuscated) about 250K and 400K. I don't seem to have a problem even on modest systems. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT Complier OutOfMemory issue
Chris, I didn't see the OOME before using code splitting. In order to
reduce the application's startup time, I adopt code splitting in the
DynaClassGenerator.java (the implementation of GWT generator on data
deferred binding in our project)
1) Before using code splitting, the code is:
if
(com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr.equals(className))
{
com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr
instance = new
com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr();
}
2) After using code splitting:
if
(com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr.equals(className))
{
GWT.runAsync(new RunAsyncCallbackAdapter() {
public void onSuccess() {
com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr
instance = new
com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr();
callback.onSuccess((T)instance);
}
});
}
In the former one, the complier work fine. However, in the second one,
the complie process was interrupted by the OOME.
P.S. It about 1,000 instances created by this way (e.g.
com.nantian.iwap3.frameworkdev.client.dataitem.DataItemMgr above).
On 9月17日, 下午11时00分, Chris Conroy con...@google.com wrote:
That should be more than enough memory to run your compile. Do you have a
stack trace for the OOME?
FWIW, I have a pending change that should decrease the amount of memory
needed to run a compile or DevMode.
On Fri, Sep 17, 2010 at 7:19 AM, lin.liang birdandfis...@gmail.com wrote:
The OutOfMemory exception always happen when the gwt project was
complied. The gwt project has 7 modules, and about 5,700 java files.
I have a look at gwt docs. It said that when the project became
bigger, the complier using the memory more too. However, I have set
the memory to 1.7G, it still report the OutOfMemory exception. Is this
the bug of gwt complier? How can I do to solve this issue?
I have no clue about this so far. Look forward your response. Thanks!
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubs-cr...@googlegroups.com
.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.- 隐藏被引用文字 -
- 显示引用的文字 -
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Parameters in gwt.xml File?
Hey guys, I have a generator that I'd like to configure with some parameters in the gwt.xml file. Is there any way I can do that? If so, how does one go about defining them in the gwt.xml and then looking up the parameter in the generator? If it isn't possible, is there a good way to do it otherwise? Thanks! Evan -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Parameters in gwt.xml File?
Not sure how to do the gwt.xml parameter stuff but I did come up with a way to vary constants. Check out my stackoverflow posting for a recipe http://stackoverflow.com/questions/1682835/how-to-vary-constants-based-on-deployment-instance On Sat, Sep 18, 2010 at 9:09 PM, Evan Ruff evan.r...@gmail.com wrote: Hey guys, I have a generator that I'd like to configure with some parameters in the gwt.xml file. Is there any way I can do that? If so, how does one go about defining them in the gwt.xml and then looking up the parameter in the generator? If it isn't possible, is there a good way to do it otherwise? Thanks! Evan -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[gwt-contrib] Re: UiBinder. Design time tweaks for @UiField and @UiHandler (issue834802)
LGTM I'll submit it this weekend On 2010/09/07 19:02:03, Konstantin.Scheglov wrote: http://gwt-code-reviews.appspot.com/834802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Don't inline functions with more than 50 statements. (issue895801)
Reviewers: cromwellian, Lex,
Description:
Super large chains of comma operations (like JsInliner can produce) will
blow the stack on some JS engines. Let's just preemptive disable
inlining any function with more than 50 statements. At that point, the
overhead of the function call should be so small as to be irrelevant.
Please review this at http://gwt-code-reviews.appspot.com/895801/show
Affected files:
M dev/core/src/com/google/gwt/dev/js/JsInliner.java
Index: dev/core/src/com/google/gwt/dev/js/JsInliner.java
diff --git a/dev/core/src/com/google/gwt/dev/js/JsInliner.java
b/dev/core/src/com/google/gwt/dev/js/JsInliner.java
index
b6083e4eae7b9a495fce7b50ca6c57a869017704..a927f0c62c5b8395c3ee3fc3f0eb1f383dd3596e
100644
--- a/dev/core/src/com/google/gwt/dev/js/JsInliner.java
+++ b/dev/core/src/com/google/gwt/dev/js/JsInliner.java
@@ -919,6 +919,14 @@ public class JsInliner {
return;
}
+ /*
+ * Don't inline huge functions into huge multi-expressions. Some JS
+ * engines will blow up.
+ */
+ if (invokedFunction.getBody().getStatements().size() 50) {
+return;
+ }
+
// Don't inline blacklisted functions
if (blacklist.contains(invokedFunction)) {
return;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8814 committed - Fixes design time support for @UiField....
Revision: 8814
Author: gwt.mirror...@gmail.com
Date: Sat Sep 18 08:47:32 2010
Log: Fixes design time support for @UiField.
It turns out that previous patch was not enough. In new one instead
of preventing failing when no owner or field found, we disable
assigning to fields and support for event handlers at all. However we
can not disable them globally, for all UiBinder templates, we should
do this only for template under design (because other templates may be
used on it). So, I've changed a little way for choosing
DesignTimeUtils implementation.
http://gwt-code-reviews.appspot.com/834802
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8814
Modified:
/trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java
/trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
/trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsStub.java
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
/trunk/user/test/com/google/gwt/uibinder/rebind/DesignTimeUtilsTest.java
===
--- /trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java Tue
Aug 31 07:18:57 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtils.java Sat
Sep 18 08:47:32 2010
@@ -33,13 +33,6 @@
*/
String getImplName(String implName);
- /**
- * @return the source to check that owner is not codenull/code.
Problem
- * is that at design time we render template without owner, so
can not
- * provide it.
- */
- String getOwnerCheck();
-
/**
* @return the path of given {...@link Element}.
*/
@@ -57,6 +50,13 @@
*/
void handleUIObject(Statements writer, XMLElement elem, String
fieldName);
+ /**
+ * @return codetrue/code if this template is under design now, so
some of
+ * UiBinder features should be disables. This includes assigning
+ * values into @UiField, processing @UiHandler.
+ */
+ boolean isDesignTime();
+
/**
* Remembers value of attribute, for given {...@link XMLElement}.
*/
@@ -73,16 +73,6 @@
*/
void rememberPathForElements(Document doc);
- /**
- * @return codetrue/code if absence of ui:field attribute for
- * corresponding @UiField declaration is OK. Problem is that at
- * design time we create {...@link ClassLoader} only once and can
not
- * refresh Java type. So, when user asks to remove ui:field we
- * update both template and Java, but generator does not know
about
- * Java change.
- */
- boolean shouldIgnoreNoUiFieldAttribute();
-
/**
* Writes remembered values of attributes.
*/
===
--- /trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
Tue Aug 31 07:18:57 2010
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/DesignTimeUtilsImpl.java
Sat Sep 18 08:47:32 2010
@@ -20,6 +20,7 @@
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
+import java.beans.Beans;
import java.util.HashMap;
import java.util.Map;
@@ -27,6 +28,20 @@
* Design time implementation of {...@link DesignTimeUtils}.
*/
public class DesignTimeUtilsImpl implements DesignTimeUtils {
+ /**
+ * @return codetrue/code if given Binder is under design now. We
should
+ * not use design time globally, because while one widget in
under
+ * design, it may use other widgets and we want to execute them
as is,
+ * without design time tweaks.
+ */
+ public static boolean isDesignTime(String fqInterfaceName) {
+if (Beans.isDesignTime()) {
+ String key = gwt.UiBinder.isDesignTime + fqInterfaceName;
+ return System.getProperty(key) != null;
+}
+return false;
+ }
+
private final MapElement, String elementPaths = new HashMapElement,
String();
private final MapString, String attributes = new HashMapString,
String();
@@ -50,10 +65,6 @@
public String getImplName(String implName) {
return implName + _designTime + System.currentTimeMillis();
}
-
- public String getOwnerCheck() {
-return if (owner != null) ;
- }
public String getPath(Element element) {
return elementPaths.get(element);
@@ -69,6 +80,10 @@
if (dtObjectHandler != null) dtObjectHandler.handle(\%s\, %s);,
elem.getDesignTimePath(), fieldName);
}
+
+ public boolean isDesignTime() {
+return true;
+ }
public void putAttribute(XMLElement elem, String name, String value) {
String path = elem.getDesignTimePath();
@@ -95,10 +110,6 @@
public void rememberPathForElements(Document doc) {
rememberPathForElements(doc.getDocumentElement(), 0);
}
-
- public boolean shouldIgnoreNoUiFieldAttribute() {
-return true;
- }
public void writeAttributes(Statements writer) {
for (Map.EntryString, String entry : attributes.entrySet()) {
[gwt-contrib] Re: UiBinder. Design time tweaks for @UiField and @UiHandler (issue834802)
r8814 http://gwt-code-reviews.appspot.com/834802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Introduce RequestFactory#getEventBus, make RFEditorDriver use it, fix (issue896801)
Reviewers: bobv, Description: Introduce RequestFactory#getEventBus, make RFEditorDriver use it, fix some typos. Please review this at http://gwt-code-reviews.appspot.com/896801/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java M user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactoryEditorDriver.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java M user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java M user/src/com/google/gwt/requestfactory/shared/RequestFactory.java M user/test/com/google/gwt/requestfactory/client/EditorTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTestBase.java M user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImplTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
Reviewers: rjrjr, Description: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) ROO-1238: * Remove SyncResults. * Use EntityProxyId and RequestFactory.find(EntityProxyId) instead of the id field of EntityProxy (or a ProxyImpl with just the id and schema fields). ROO-1380: * Removes RequestFactory::getProxy(String), replacing it with getProxyId(String). * Removes the EntityProxy.asString() method, and fixes one incorrect usage of it. * Adds getToken(EntityProxyId). * Renames getToken() to getHistoryToken() in RequestFactory. Please review this at http://gwt-code-reviews.appspot.com/897801/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/FavoritesManager.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesMobile.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseDetails.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseEntry.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileExpenseList.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportEntry.java M samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/MobileReportList.java M user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java M user/src/com/google/gwt/app/place/AbstractProxyListActivity.java M user/src/com/google/gwt/app/place/EntityProxyKeyProvider.java M user/src/com/google/gwt/app/place/ProxyPlace.java M user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java M user/src/com/google/gwt/requestfactory/client/RequestFactoryLogHandler.java D user/src/com/google/gwt/requestfactory/client/SyncResultImpl.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractPrimitiveRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractStringRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java M user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryEditorDelegate.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java M user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java M user/src/com/google/gwt/requestfactory/shared/EntityProxyId.java M user/src/com/google/gwt/requestfactory/shared/Receiver.java M user/src/com/google/gwt/requestfactory/shared/RequestFactory.java D user/src/com/google/gwt/requestfactory/shared/SyncResult.java M user/test/com/google/gwt/requestfactory/client/EditorTest.java M user/test/com/google/gwt/requestfactory/client/FindServiceTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M
[gwt-contrib] Re: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
LGTM with following addressed
http://gwt-code-reviews.appspot.com/897801/diff/1/6
File
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java
(right):
http://gwt-code-reviews.appspot.com/897801/diff/1/6#newcode952
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java:952:
// TODO: use onViolations for checking constraint violations.
No to do, this is a read only view, will never have violations
http://gwt-code-reviews.appspot.com/897801/diff/1/20
File user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java
(right):
http://gwt-code-reviews.appspot.com/897801/diff/1/20#newcode32
user/src/com/google/gwt/app/place/ProxyPlaceToListPlace.java:32: *
{...@link #getProxyId()}.
#proxyListPlaceFor
http://gwt-code-reviews.appspot.com/897801/diff/1/37
File
user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
(right):
http://gwt-code-reviews.appspot.com/897801/diff/1/37#newcode155
user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:155:
handleResult(results.getResult());
Change in order is intentional?
http://gwt-code-reviews.appspot.com/897801/diff/1/44
File
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
(right):
http://gwt-code-reviews.appspot.com/897801/diff/1/44#newcode174
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:174:
* This method cannot use the EntityProxyIdImpl.asString() method until
the
asString() is gone, right?
http://gwt-code-reviews.appspot.com/897801/diff/1/44#newcode177
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java:177:
protected String getHistoryToken(EntityProxyId proxyId, ProxyToTypeMap
recordToTypeMap) {
I don't want to delay this patch any further, but I think I'm going to
do a follow up to make this and getClass(EntityProxyId) instance methods
on EntityProxyId after all. This is just too weird for the caller.
http://gwt-code-reviews.appspot.com/897801/diff/1/53
File
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
(right):
http://gwt-code-reviews.appspot.com/897801/diff/1/53#newcode153
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:153:
// TODO: listen to create events instead.
This TODO should be TODONE, or we're losing test coverage. It can be a
follow up patch, but it should happen quickly.
http://gwt-code-reviews.appspot.com/897801/diff/1/53#newcode179
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:179:
// flakes
Please fix ugly wrapping
http://gwt-code-reviews.appspot.com/897801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
http://gwt-code-reviews.appspot.com/897801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
LGTM http://gwt-code-reviews.appspot.com/897801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
http://gwt-code-reviews.appspot.com/897801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two Roo issues: ROO-1238 (Amit) and ROO-1380 (pdr) (issue897801)
LGTM++ On Sat, Sep 18, 2010 at 12:11 PM, p...@google.com wrote: http://gwt-code-reviews.appspot.com/897801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Don't inline functions with more than 50 statements. (issue895801)
http://gwt-code-reviews.appspot.com/895801/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right): http://gwt-code-reviews.appspot.com/895801/diff/1/2#newcode929 dev/core/src/com/google/gwt/dev/js/JsInliner.java:929: Yeah. But this is holding up me being able to re-roll my RPC generator chance, so I hoped maybe we could get this in as-is and experiment with the exact best number afterwards. http://gwt-code-reviews.appspot.com/895801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Migration from Long IDs to String IDs (issue898801)
Reviewers: rjrjr, Description: Migration from Long IDs to String IDs Please review this at http://gwt-code-reviews.appspot.com/898801/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Address.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/SchoolCalendarService.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactory.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java M user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java M user/src/com/google/gwt/requestfactory/server/Logging.java M user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java M user/src/com/google/gwt/requestfactory/server/UserInformation.java M user/src/com/google/gwt/requestfactory/server/UserInformationSimpleImpl.java M user/src/com/google/gwt/requestfactory/shared/EntityProxy.java M user/test/com/google/gwt/requestfactory/client/EditorTest.java M user/test/com/google/gwt/requestfactory/client/FindServiceTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/EntityProxyIdImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/ProxyJsoImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java M user/test/com/google/gwt/requestfactory/server/ReflectionBasedOperationRegistryTest.java M user/test/com/google/gwt/requestfactory/server/SimpleBar.java M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java M user/test/com/google/gwt/requestfactory/shared/SimpleBarRequest.java M user/test/com/google/gwt/requestfactory/shared/SimpleFooRequest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Migration from Long IDs to String IDs (issue898801)
LGTM On Sat, Sep 18, 2010 at 1:10 PM, rchan...@google.com wrote: Reviewers: rjrjr, Description: Migration from Long IDs to String IDs Please review this at http://gwt-code-reviews.appspot.com/898801/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Address.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/SchoolCalendarService.java M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactory.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java M user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java M user/src/com/google/gwt/requestfactory/server/Logging.java M user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java M user/src/com/google/gwt/requestfactory/server/UserInformation.java M user/src/com/google/gwt/requestfactory/server/UserInformationSimpleImpl.java M user/src/com/google/gwt/requestfactory/shared/EntityProxy.java M user/test/com/google/gwt/requestfactory/client/EditorTest.java M user/test/com/google/gwt/requestfactory/client/FindServiceTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/EntityProxyIdImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/ProxyJsoImplTest.java M user/test/com/google/gwt/requestfactory/client/impl/SimpleFooProxyProperties.java M user/test/com/google/gwt/requestfactory/server/ReflectionBasedOperationRegistryTest.java M user/test/com/google/gwt/requestfactory/server/SimpleBar.java M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java M user/test/com/google/gwt/requestfactory/shared/SimpleBarRequest.java M user/test/com/google/gwt/requestfactory/shared/SimpleFooRequest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Gets the code splitter to be effective even in draft compile mode. (issue875801)
LGTM with comments.
http://gwt-code-reviews.appspot.com/875801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
(right):
http://gwt-code-reviews.appspot.com/875801/diff/1/4#newcode172
dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java:172: */
Very high level question. So we're generating with a looser type, and
using AST transforms to tighten. I'm guessing that various language
reasons (like making overrides work?) prevent you from simply generating
the code with the stronger type to begin with. Or maybe it's that
generating the code that way would break fragmenting entirely. It would
be good to add a short note about why we need to jump through these
hoops.
http://gwt-code-reviews.appspot.com/875801/diff/1/4#newcode319
dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java:319: if
(method.getName().equals(runAsync)) {
If you move the ICE from getMethod() into getOnLoadMethod(), you could
call getMethod() here.
http://gwt-code-reviews.appspot.com/875801/diff/1/5
File
dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java
(right):
http://gwt-code-reviews.appspot.com/875801/diff/1/5#newcode92
dev/core/test/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncsErrorMessagesTest.java:92:
com.google.gwt.lang.asyncloaders.AsyncLoader + sp + __Callback) {
Should __Callback be replaced with
FragmentLoaderCreator.CALLBACK_LIST_SUFFIX? (and below)
http://gwt-code-reviews.appspot.com/875801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] A test I botched in RequestFactoryTest masked that re-using requests (issue899801)
Reviewers: pdr, Description: A test I botched in RequestFactoryTest masked that re-using requests doesn't actually work. It can't be made to work completely due to the need for DeltaValueStore to be stable until a response comes, but we at least don't have to make the clearUsed method public again thanks to some new judicious bullet proofing. Also tweaked some method and class names for consistency and less confusion. Please review this at http://gwt-code-reviews.appspot.com/899801/show Affected files: M user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractPrimitiveRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractStringRequest.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java M user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java M user/src/com/google/gwt/requestfactory/client/impl/JsonResults.java A user/src/com/google/gwt/requestfactory/client/impl/JsonServerException.java M user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java D user/src/com/google/gwt/requestfactory/client/impl/ServerFailureRecord.java M user/src/com/google/gwt/requestfactory/shared/RequestTransport.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: A test I botched in RequestFactoryTest masked that re-using requests (issue899801)
http://gwt-code-reviews.appspot.com/899801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: A test I botched in RequestFactoryTest masked that re-using requests (issue899801)
I think there needs to be a TODO to support reusing successful requests. Other than that, just a few formating issues. http://gwt-code-reviews.appspot.com/899801/diff/1/17 File user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java (right): http://gwt-code-reviews.appspot.com/899801/diff/1/17#newcode79 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:79: spaces http://gwt-code-reviews.appspot.com/899801/diff/1/17#newcode91 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:91: spaces http://gwt-code-reviews.appspot.com/899801/diff/1/27 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/899801/diff/1/27#newcode177 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:177: newFoo); This line is 100 chars http://gwt-code-reviews.appspot.com/899801/diff/1/27#newcode403 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:403: amitBar); This line is 100 chars http://gwt-code-reviews.appspot.com/899801/diff/1/27#newcode412 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:412: persistedRay).with(barField); This line is 100 chars http://gwt-code-reviews.appspot.com/899801/diff/1/27#newcode455 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:455: final RequestObjectSimpleFooProxy persistRequest = req.simpleFooRequest().persistAndReturnSelf( This line is 100 chars http://gwt-code-reviews.appspot.com/899801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Don't inline functions with more than 50 statements. (issue895801)
Agreed, I made the comment more as a TODO, not as a blocker. On Sat, Sep 18, 2010 at 12:55 PM, sco...@google.com wrote: http://gwt-code-reviews.appspot.com/895801/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right): http://gwt-code-reviews.appspot.com/895801/diff/1/2#newcode929 dev/core/src/com/google/gwt/dev/js/JsInliner.java:929: Yeah. But this is holding up me being able to re-roll my RPC generator chance, so I hoped maybe we could get this in as-is and experiment with the exact best number afterwards. http://gwt-code-reviews.appspot.com/895801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8816 committed - A test I botched in RequestFactoryTest masked that re-using requests...
Revision: 8816
Author: rj...@google.com
Date: Sat Sep 18 16:55:23 2010
Log: A test I botched in RequestFactoryTest masked that re-using requests
doesn't actually work. It can't be made to work completely due to the
need for DeltaValueStore to be stable until a response comes, but we
at least don't have to make the clearUsed method public again thanks
to some new judicious bullet proofing.
Also tweaked some method and class names for consistency and less
confusion.
Review at http://gwt-code-reviews.appspot.com/899801
Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8816
Added:
/trunk/user/src/com/google/gwt/requestfactory/client/impl/JsonServerException.java
Deleted:
/trunk/user/src/com/google/gwt/requestfactory/client/impl/ServerFailureRecord.java
Modified:
/trunk/user/src/com/google/gwt/requestfactory/client/DefaultRequestTransport.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigDecimalRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBigIntegerRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractBooleanRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractByteRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractCharacterRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDateRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractEnumRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractFloatRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractPrimitiveRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractShortRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractStringRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/AbstractVoidRequest.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/JsonResults.java
/trunk/user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
/trunk/user/src/com/google/gwt/requestfactory/shared/RequestTransport.java
/trunk/user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java
/trunk/user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
/trunk/user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java
/trunk/user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
===
--- /dev/null
+++
/trunk/user/src/com/google/gwt/requestfactory/client/impl/JsonServerException.java
Sat Sep 18 16:55:23 2010
@@ -0,0 +1,39 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.client.impl;
+
+import com.google.gwt.core.client.JavaScriptObject;
+
+/**
+ * Contains details of a server error.
+ */
+ final class JsonServerException extends JavaScriptObject {
+
+ protected JsonServerException() {
+ }
+
+ public native String getMessage() /*-{
+return this.message || ;
+ }-*/;
+
+ public native String getTrace() /*-{
+return this.trace || ;
+ }-*/;
+
+ public native String getType() /*-{
+return this.type || ;
+ }-*/;
+}
===
---
/trunk/user/src/com/google/gwt/requestfactory/client/impl/ServerFailureRecord.java
Fri Sep 17 05:56:27 2010
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the License); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in
[gwt-contrib] Delete unused classes from samples/expenses (issue897802)
Reviewers: cromwellian, Description: Delete unused classes from samples/expenses Please review this at http://gwt-code-reviews.appspot.com/897802/show Affected files: D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeDetailsView.ui.xml D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeEditView.ui.xml D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeListView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeListView.ui.xml D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/employee/EmployeeRenderer.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportDetailsView.ui.xml D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportEditView.ui.xml D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportListView.java D samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui/report/ReportListView.ui.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Made exception message thrown by RequestFactoryTest obviously harmless (issue885802)
Reviewers: rjrjr, robertvawter,
Description:
Made exception message thrown by RequestFactoryTest obviously harmless
RequestFactoryTest#testServerFailure() and
RequestFactoryExceptionHandlerTest#testServerFailure() cause exceptions
to be logged with level SEVERE. Developers get confused when looking for
causes of failures unrelated to these tests. This changes the message
to quickly let developers to disregard these particular exceptions.
Please review this at http://gwt-code-reviews.appspot.com/885802/show
Affected files:
M
user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java
M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
Index:
user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java
===
---
user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java
(revision 8815)
+++
user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java
(working copy)
@@ -48,7 +48,7 @@
persistRay.fire(new ReceiverSimpleFooProxy() {
@Override
public void onFailure(ServerFailure error) {
-assertEquals(test message, error.getMessage());
+assertEquals(RequestFactoryTest.FAILURE_MESSAGE,
error.getMessage());
assertEquals(java.lang.UnsupportedOperationException,
error.getExceptionType());
assertFalse(error.getStackTraceString().isEmpty());
Index:
user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
===
--- user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
(revision 8815)
+++ user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
(working copy)
@@ -69,6 +69,9 @@
}
}
+ public static final String FAILURE_MESSAGE = THIS IS ONLY A TEST.
+ + EXPECTED EXCEPTION. THIS IS ONLY A TEST;
+
@Override
public String getModuleName() {
return com.google.gwt.requestfactory.RequestFactorySuite;
@@ -439,7 +442,8 @@
persistRay.fire(new ReceiverSimpleFooProxy() {
@Override
public void onFailure(ServerFailure error) {
-assertEquals(Server Error: test message, error.getMessage());
+assertEquals(Server Error: + RequestFactoryTest.FAILURE_MESSAGE,
+error.getMessage());
assertEquals(, error.getExceptionType());
assertEquals(, error.getStackTraceString());
finishTestAndReset();
Index: user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
===
--- user/test/com/google/gwt/requestfactory/server/SimpleFoo.java (revision
8815)
+++ user/test/com/google/gwt/requestfactory/server/SimpleFoo.java (working
copy)
@@ -15,6 +15,7 @@
*/
package com.google.gwt.requestfactory.server;
+import com.google.gwt.requestfactory.client.RequestFactoryTest;
import com.google.gwt.requestfactory.shared.Id;
import com.google.gwt.requestfactory.shared.SimpleEnum;
@@ -368,7 +369,7 @@
public void setPleaseCrash(Integer crashIf42) {
if (crashIf42 == 42) {
- throw new UnsupportedOperationException(test message);
+ throw new
UnsupportedOperationException(RequestFactoryTest.FAILURE_MESSAGE);
}
pleaseCrashField = crashIf42;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Made exception message thrown by RequestFactoryTest obviously harmless (issue885802)
I did the same thing in a patch that has just been submitted... http://gwt-code-reviews.appspot.com/885802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: A test I botched in RequestFactoryTest masked that re-using requests (issue899801)
http://gwt-code-reviews.appspot.com/899801/diff/1/17 File user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java (right): http://gwt-code-reviews.appspot.com/899801/diff/1/17#newcode79 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:79: On 2010/09/18 23:50:49, pdr wrote: spaces Done. http://gwt-code-reviews.appspot.com/899801/diff/1/17#newcode91 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:91: On 2010/09/18 23:50:49, pdr wrote: spaces Done. http://gwt-code-reviews.appspot.com/899801/diff/1/27 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/899801/diff/1/27#newcode455 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:455: final RequestObjectSimpleFooProxy persistRequest = req.simpleFooRequest().persistAndReturnSelf( On 2010/09/18 23:50:49, pdr wrote: This line is 100 chars Done. http://gwt-code-reviews.appspot.com/899801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Made exception message thrown by RequestFactoryTest obviously harmless (issue885802)
On 2010/09/19 03:37:59, rjrjr wrote: I did the same thing in a patch that has just been submitted... Ah! You beat me to it. All is good then. Disregard this. http://gwt-code-reviews.appspot.com/885802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Extract a RequestTransport interface and DefaultRequestTransport implementation from RequestFactory. (issue890802)
Bob, wasn't part of the point of this to allow people to get around the hard code gwtRequest URL? If so, shouldn't RequestFactory#URL be moved to DefaultRequestTransport? On 2010/09/17 21:30:59, rjrjr wrote: LGTM http://gwt-code-reviews.appspot.com/890802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8818 committed - Delete unused classes from samples/expenses...
Revision: 8818 Author: rj...@google.com Date: Sat Sep 18 18:46:13 2010 Log: Delete unused classes from samples/expenses Review at http://gwt-code-reviews.appspot.com/897802 Review by: cromwell...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8818 Deleted: /trunk/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ui -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
