Re: RequestFactory / collections

2011-09-24 Thread Aidan O'Kelly
On Sat, Sep 24, 2011 at 12:36 AM, Magno Machado magn...@gmail.com wrote:

 But only foo got persisted, not it's bars

RequestFactory itself doesn't persist anything, it just synchronizes
the object graph between client  server. How exactly you would
persist a Foo, a list of Bars, and the relationship is dependent on
what data storage you are using, so there needs to be logic inside the
persist() method of Foo, that persists not only the Foo, but any
relationships and their objects.

If you inspect Foo.getItems() inside the Foo's persist() method, a
list of Bars should be there, that's where RequestFactory's part ends.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory / collections

2011-09-24 Thread Aidan O'Kelly
Yeah, realized the diff mechanism takes care of what problems I was
thinking of shortly after posting, doh.
It does mean, you can set a relationship you never retrieved with
with(), but you can not un-set (null) a relationship unless you
retrieved it, of course, who cares..! (and I didn't check this)


On Sat, Sep 24, 2011 at 12:05 AM, Thomas Broyer t.bro...@gmail.com wrote:
 No, RF does a diff between the object you retrieved (unmodifiable, passed to
 context.edit(obj)) and the one you're editing (returned from
 context.edit(obj)) at the time you fire() your context, and sends that diff
 over the wire. If you didn't retrieve a property and fills it on the
 client-side, it'll see that you filled it and will send it to the server.
 The only exception is ValueProxy: every single property in a ValueProxy is
 sent, no diff is made, each ValueProxy instance is a distinct value.

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/szisuiWUylIJ.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: too much code: GWT Development with Activities and Places

2011-09-24 Thread Aidan O'Kelly
On Fri, Sep 23, 2011 at 3:13 PM, magnum p.magnow...@gmail.com wrote:

 view implementations ... but honestly I'd rather have a smart view /
 presenter class that wires everything together. The processing is
 delegated to event bus or other handler that processes the business
 logic.

There's nothing stopping you doing this, you can use a UiBinder
template and backing class as a combined view/presenter. You will of
course lose the decoupling of views/presenters the MVP framework is
bringing to the table, and its advantages.

I havn't read the MVP docs in a while, but it should probably be
better explained that its just *one* way of doing GWT development, not
*the* way, and your free to use part of it, none of it, all of it,
depending on what you actually need. As a newcomer to GWT (and Java!)
I spent a lot of time on it when starting out, as it was the most
prominent documentation on how to do certain things (views and
'pages'/places in particular) for very little net gain. For simple
apps, using UiBinder and attaching the resulting widget to the page
manually lets you actually get to the meat of your application much
faster and with much much less complexity. You can always refactor to
MVP later.. (though that doesn't sound fun) anyway just my 2cents,
maybe with better tooling there would be fewer of these 'MVP is too
complex' threads.

And on tooling, and RequestFactory, the new annotation processor is
great, compile time validation really helps (I am manually writing my
proxies) but I was disappointed to see that the 'RPC tooling' is only
for Android Apps.

Are we expecting to see GPE provide Proxy/RequestContext generation in
the future for non-android apps?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: install problem help me thanks

2011-09-24 Thread Sudhakar Abraham
Download the latest gwt 2.4.0 sdk from the link http://
code.google.com/p/google-web-toolkit/downloads/detail?
name=gwt-2.4.0.zip.  Extract the gwt-2.4.0 zip file to the desired
directory.  In eclipse IDE configure your corresponding gwt sdk. File--
New-- WebApplication Project--configure sdk --Add --Installation
directory using Browse button.

S. Abraham
www.DataStoreGwt.com
Persist objects directly in GAE


On Sep 23, 11:19 am, wisdom white pkmsys...@gmail.com wrote:
 when I install gwt the eclipse shows me a error  like:

 An error occurred while collecting items to be installed
 session context was:(profile=epp.package.jee,
 phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=,
 action=).
 No repository found containing: osgi.bundle,com.springsource.javax.jms,
 1.1.0

 anyone can tell me what should i do thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



RequestFactory Android - handling different app versions

2011-09-24 Thread Sheado
Howdy,

I'm looking into using RequestFactory to backup my game's data to
AppEngine. Is it possible to have different versions of the client
app, with different EntityProxies, safely make requests?

For example:

Version 1:
MyProxy
{
  
  getX()
  getY()
  
}

Version 2:
{

getX();
 // getY() is removed
}

Once the server is updated to version 2, it seems that all clients
running version 1 will no longer be able to make requests (i get
Internal Server Error.

Getting your users to update isn't always easy on Android. Is there
any way around this? Or do I just have to be careful to never remove
methods once I've added them to my entities and their proxies?

Thanks!
Chad

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Split panel

2011-09-24 Thread hadar
Hi,

I want to create a page in GWT that contain 2 parts.One for input and
second with results.

The input part should be device to 3. 2 parts that contain label,text
box and in the middle several checkbox and button.

How can it be done ?

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



show [ERROR] Element may only contain a single child element, GWT Binder error problem in gwt 2.3.0

2011-09-24 Thread Brito
I am having the problem when I compile my project. I send the code
segement. Advance thanks.

ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'
xmlns:g='urn:import:com.google.gwt.user.client.ui'
g:DockLayoutPanel ui:field=dock1
g:north size=25
 g:FlowPanel
   g:Button ui:field=saveSave/ g:Button
 /g:FlowPanel
/g:north
g:center
   g:FlowPanel ui:field=panel1
   g:Button ui:field=button1Mark1/
g:Button
g:Button ui:field=button2Mark2/
g:Button
   /g:FlowPanel
  g:VerticalPanel ui:field=panel2
g:TextArea ui:field=textArea /
  /g:VerticalPanel
/g:center
/g:DockLayoutPanel
/ui:UiBinder

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Edit an object in a List without a ListEditor

2011-09-24 Thread Thomas Broyer
Your editor for ConfigProxy would be a ValueAwareEditor. It'll receive the 
ConfigProxy in setValue so you could push the LanguageProxy to a widget of 
your choice (actually you could even use a sub editor driver). In the flush 
method, you'd manually flush the LanguageProxy to the ConfigProxy.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/x5tG5S8MZvkJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: show [ERROR] Element may only contain a single child element, GWT Binder error problem in gwt 2.3.0

2011-09-24 Thread Aidan O'Kelly
Each section of a DockLayoutPanel may only contain one Widget, you
have two in your center, you'll need to put panel1 and panel2, inside
a container panel, and have that as the widget in center.

On Sat, Sep 24, 2011 at 12:37 PM, Brito britoscho...@gmail.com wrote:
 I am having the problem when I compile my project. I send the code
 segement. Advance thanks.

 ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'
        xmlns:g='urn:import:com.google.gwt.user.client.ui'
        g:DockLayoutPanel ui:field=dock1
                g:north size=25
                     g:FlowPanel
                           g:Button ui:field=saveSave/ g:Button
                     /g:FlowPanel
                /g:north
                g:center
                   g:FlowPanel ui:field=panel1
                               g:Button ui:field=button1Mark1/
 g:Button
                                g:Button ui:field=button2Mark2/
 g:Button
                   /g:FlowPanel
                  g:VerticalPanel ui:field=panel2
                                g:TextArea ui:field=textArea /
                  /g:VerticalPanel
                /g:center
        /g:DockLayoutPanel
 /ui:UiBinder

 --
 You received this message because you are subscribed to the Google Groups 
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to 
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at 
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



RequestFactory Android - handling different app versions

2011-09-24 Thread Thomas Broyer
I think this is exactly what ServiceLayerDecorator is made for.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/WeDE-BZwoN4J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory / collections

2011-09-24 Thread Thomas Broyer
AFAIK, the list is copied when set into the proxy (so that it can be 
proxied itself). You should add to foo.getBars() instead.

(and by foo only got persisted, I suppose you're saying that getBars() 
returns null or an empty list in your persist() method, and/or that 
setBars() is never called?)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/GY5l-Q1DvvAJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: too much code: GWT Development with Activities and Places

2011-09-24 Thread Thomas Broyer


On Saturday, September 24, 2011 12:48:02 PM UTC+2, Aidan OK wrote:

 I havn't read the MVP docs in a while, but it should probably be
 better explained that its just *one* way of doing GWT development, not
 *the* way, and your free to use part of it, none of it, all of it,
 depending on what you actually need.


GWT is a toolkit, not a framework, so it cannot be otherwise.

You're free to not use widgets at all too (I believe most GWT-Query projects 
do not use widgets); and you could, technically, even replace the whole JRE 
emulation with your own (except for Longs probably).

And BTW, MVP is a design pattern, and there's no one single way of 
implementing it (the MVP articles in the GWT doc makes it kind of clear). 
And the fact that Activities and Places (which people sometimes erroneously 
call MVP framework) are quite new makes it clear that it's not the way 
to build GWT apps: there must have been ways to do it before they're 
introduced!

Are we expecting to see GPE provide Proxy/RequestContext generation in

 the future for non-android apps?


See 
https://groups.google.com/d/topic/google-plugin-eclipse/L4rzC5xnzW4/discussion 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/oKfby3zLqUcJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



TextCell in Cell Table

2011-09-24 Thread gangurg gangurg
Can I add Text Cell in Cell Table . I extended TextCellbut later realzied
cant add cellTable.addColumn(MyTextCell,Col Name)

public class MyTextCell extends TextCell
{
public MyTextCell () { super(); }
 public void render(Context context, SafeHtml value, SafeHtmlBuilder sb)
{
if (value != null) {
 //Ren der logic
}
 }

}

I just realized

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Custom cell, not responding to mouse clicks

2011-09-24 Thread Jonas
I have a CellTable with a custom cell that extends AbstractCell and 
overrides the render method for displaying its data. The problem is that I 
can't click inside the actual cell to select it, I have to click somewhere 
outside the cell. The default color change on mouse hover also does not work 
within the actual cell. I am using a SingleSelectionModel to display a popup 
when I select something in the cell table. What do I need to do to make my 
cell respond to clicks and handle the mouse over effect?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/g1Vf-3l_JfUJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



How to override default clean.css styles?

2011-09-24 Thread bbaychev
Hello,
GWT seems to override some of the body tag styling I want to apply,
how can I set styles in a way that they are not overriden or modify
the clean.css file? I can't find the clean.css file anywhere in the
project.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: too much code: GWT Development with Activities and Places

2011-09-24 Thread Sridhar Vennela




On Sep 24, 2011, at 8:53 AM, Thomas Broyer t.bro...@gmail.com wrote:

 
 
 On Saturday, September 24, 2011 12:48:02 PM UTC+2, Aidan OK wrote:
 I havn't read the MVP docs in a while, but it should probably be
 better explained that its just *one* way of doing GWT development, not
 *the* way, and your free to use part of it, none of it, all of it,
 depending on what you actually need.
 
 
 GWT is a toolkit, not a framework, so it cannot be otherwise.
 
 You're free to not use widgets at all too (I believe most GWT-Query projects 
 do not use widgets); and you could, technically, even replace the whole JRE 
 emulation with your own (except for Longs probably).
 
 And BTW, MVP is a design pattern, and there's no one single way of 
 implementing it (the MVP articles in the GWT doc makes it kind of clear). And 
 the fact that Activities and Places (which people sometimes erroneously call 
 MVP framework) are quite new makes it clear that it's not the way to 
 build GWT apps: there must have been ways to do it before they're introduced!
 
 Are we expecting to see GPE provide Proxy/RequestContext generation in
 
 the future for non-android apps?
 
 
 See 
 https://groups.google.com/d/topic/google-plugin-eclipse/L4rzC5xnzW4/discussion
  
 -- 
 You received this message because you are subscribed to the Google Groups 
 Google Web Toolkit group.
 To view this discussion on the web visit 
 https://groups.google.com/d/msg/google-web-toolkit/-/oKfby3zLqUcJ.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to 
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at 
 http://groups.google.com/group/google-web-toolkit?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



CellTable styles incorrectly on IE9

2011-09-24 Thread drtman
If I take the example code directly from the GWT API docs for
CellTable (i.e. the code for an entry point module that creates and
displays a contact table with a manual list), the table that is
displayed has no formatting whatsoever on IE9.  It is just simple left-
justified text with no styling and nothing is selectable.  If I
replace the CellTable with a DataGrid, only the paging control
displays.  On Chrome and Firefox these appear to work.  I have tried
all combinations of styling, tried replacing the CellTable.Resources
with my own styling, etc., etc. and it never works.

Is there a trick to making the new data widgets style properly on IE9?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: CellTable styles incorrectly on IE9

2011-09-24 Thread Juan Pablo Gardella
IE9 is supported sinde GWT 2.3.0, what version of GWT are you use?

2011/9/24 drtman drt...@gmail.com

 If I take the example code directly from the GWT API docs for
 CellTable (i.e. the code for an entry point module that creates and
 displays a contact table with a manual list), the table that is
 displayed has no formatting whatsoever on IE9.  It is just simple left-
 justified text with no styling and nothing is selectable.  If I
 replace the CellTable with a DataGrid, only the paging control
 displays.  On Chrome and Firefox these appear to work.  I have tried
 all combinations of styling, tried replacing the CellTable.Resources
 with my own styling, etc., etc. and it never works.

 Is there a trick to making the new data widgets style properly on IE9?

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: CellTable styles incorrectly on IE9

2011-09-24 Thread drtman
I am using the latest, i.e. 2.4.0, and the latest version of the
eclipse plugin (just updated last night).  Perhaps it's a some setting
in IE9, but I have tried turning compatibility view on/off, putting
the IE=9 meta tag in the html loader file, and a variety of other
things, but it's just broken.  I am using IE 9.0.8112.16421.


On Sep 24, 8:14 pm, Juan Pablo Gardella gardellajuanpa...@gmail.com
wrote:
 IE9 is supported sinde GWT 2.3.0, what version of GWT are you use?

 2011/9/24 drtman drt...@gmail.com



  If I take the example code directly from the GWT API docs for
  CellTable (i.e. the code for an entry point module that creates and
  displays a contact table with a manual list), the table that is
  displayed has no formatting whatsoever on IE9.  It is just simple left-
  justified text with no styling and nothing is selectable.  If I
  replace the CellTable with a DataGrid, only the paging control
  displays.  On Chrome and Firefox these appear to work.  I have tried
  all combinations of styling, tried replacing the CellTable.Resources
  with my own styling, etc., etc. and it never works.

  Is there a trick to making the new data widgets style properly on IE9?

  --
  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-toolkit@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.com.
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.- Hide quoted text -

 - Show quoted text -

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Edit an object in a List without a ListEditor

2011-09-24 Thread -sowdri-
 Your editor for ConfigProxy would be a ValueAwareEditor. It'll receive 
the ConfigProxy in setValue so you could push the LanguageProxy to a 
widget of your choice (actually you could even use a sub editor driver). 
In the flush method, you'd manually flush the LanguageProxy to the 
ConfigProxy.

Thanks, this explains the crux of ValueAwareEditor!

When will ValueAwareEditor#onPropertyChange called?? 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/fhrzebxYT-sJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



[gwt-contrib] Makes sure the RenderablePanel inherits all attributes from the PotentialElement when realizing ... (issue1556805)

2011-09-24 Thread rdcastro

Reviewers: rjrjr,

Description:
Makes sure the RenderablePanel inherits all attributes from the
PotentialElement when realizing the Element.


Please review this at http://gwt-code-reviews.appspot.com/1556805/

Affected files:
  M user/src/com/google/gwt/user/client/ui/PotentialElement.java
  M user/src/com/google/gwt/user/client/ui/RenderablePanel.java


Index: user/src/com/google/gwt/user/client/ui/PotentialElement.java
===
--- user/src/com/google/gwt/user/client/ui/PotentialElement.java	(revision  
10670)
+++ user/src/com/google/gwt/user/client/ui/PotentialElement.java	(working  
copy)

@@ -16,9 +16,11 @@
 package com.google.gwt.user.client.ui;

 import com.google.gwt.core.client.JavaScriptObject;
+import com.google.gwt.dom.builder.client.DomBuilderFactory;
+import com.google.gwt.dom.builder.shared.ElementBuilder;
+import com.google.gwt.dom.builder.shared.HtmlBuilderFactory;
+import com.google.gwt.dom.builder.shared.HtmlElementBuilder;
 import com.google.gwt.dom.client.Element;
-import com.google.gwt.dom.builder.shared.HtmlElementBuilder;
-import com.google.gwt.dom.builder.shared.HtmlBuilderFactory;

 /**
  * EXPERIMENTAL and subject to change. Do not use this in production code.
@@ -78,9 +80,25 @@
* the builder
* @return a propertly configured {@link HtmlElementBuilder} instance
*/
-  public static HtmlElementBuilder createBuilderFor(Element  
potentialElement) {
+  public static HtmlElementBuilder createHtmlBuilderFor(Element  
potentialElement) {

 PotentialElement el = PotentialElement.as(potentialElement);
 HtmlElementBuilder builder = HtmlBuilderFactory.get().trustedCreate(
+el.getTagName());
+el.mergeInto(builder);
+return builder;
+  }
+
+  /**
+   * Creates an {@link ElementBuilder} instance inheriting all attributes
+   * set for the given PotentialElement.
+   *
+   * @param potentialElement assumed to be a PotentialElement, used as  
basis for

+   * the builder
+   * @return a propertly configured {@link ElementBuilder} instance
+   */
+  public static ElementBuilder createDomBuilderFor(Element  
potentialElement) {

+PotentialElement el = PotentialElement.as(potentialElement);
+ElementBuilder builder = DomBuilderFactory.get().trustedCreate(
 el.getTagName());
 el.mergeInto(builder);
 return builder;
@@ -164,7 +182,7 @@
* prototype. Do this by severing the __proto__ link, allowing us to  
iterate

* only on the fields set in this specific instance.
*/
-  private native void mergeInto(HtmlElementBuilder builder) /*-{
+  private native void mergeInto(ElementBuilder builder) /*-{
 var savedProto = this.__proto__;
 var tagName = this.tagName;
 var gwtResolve = this.__gwt_resolve;
Index: user/src/com/google/gwt/user/client/ui/RenderablePanel.java
===
--- user/src/com/google/gwt/user/client/ui/RenderablePanel.java	(revision  
10670)
+++ user/src/com/google/gwt/user/client/ui/RenderablePanel.java	(working  
copy)

@@ -188,7 +188,7 @@

   @Override
   public SafeHtml render(RenderableStamper stamper) {
-HtmlElementBuilder builder =  
PotentialElement.createBuilderFor(getElement());
+HtmlElementBuilder builder =  
PotentialElement.createHtmlBuilderFor(getElement());

 stamper.stamp(builder);
 builder.html(getInnerHtml()).end();

@@ -229,18 +229,8 @@
* that may have been added to the panel.
*/
   private void buildAndInitDivContainer() {
-// TODO(rdcastro): Use the same technique as in render() above.
-
-// Build the div that'll container the panel's HTML.
-Element element = Document.get().createDivElement();
-element.setInnerHTML(getInnerHtml().asString());
-
-// TODO(rdcastro): Implement something like
-// element.mergeFrom(getElement());
-String styleName = getStyleName();
-if (styleName != null) {
-  element.setClassName(styleName);
-}
+Element element = PotentialElement.createDomBuilderFor(getElement())
+.html(getInnerHtml()).finish();

 setElement(element);



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors