A good book to understand GWT 2.4
Hi , Please let me know any good book with all updated features of GWT (i.e. till 2.4) this will make a great help. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/d_II_WLmLC4J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: A good book to understand GWT 2.4
Hi, This is hard to answer because I don't know which version of GWT you reference. But try this one: http://www.manning.com/tacy/ Cheers, Johannes Am 25.06.2012 um 15:04 schrieb Qrunk: Hi , Please let me know any good book with all updated features of GWT (i.e. till 2.4) this will make a great help. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/d_II_WLmLC4J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: A good book to understand GWT 2.4
Frankly, I think the GWT developer docs from Google are the best reference. Any book is just going to be parroting those back to you for a fee. The things that I've not seen covered well, or most times at all, in these books are extensive UiBinder, i18n, code generators, client bundles, and code splitting. Get a book if you want a paper version of the GWT docs, otherwise just read them. Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/sNFtPPZe4XUJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Perfect caching problem
I am trying to implement the GWT perfect caching by using a custom javax
servlet filter. All files containing .nocache. should never be cached, and
files containing .cache. should be cached for a week.
Here is the code for my filter:
public class GWTCacheControlFilter implements Filter
{
@Override
public void destroy()
{
}
@Override
public void init(final FilterConfig config) throws ServletException
{
}
@Override
public final void doFilter(final ServletRequest request, final
ServletResponse response, final FilterChain filterChain)
throws IOException, ServletException
{
final HttpServletRequest httpRequest = (HttpServletRequest) request;
final String requestURI = httpRequest.getRequestURI();
if (requestURI.contains(.nocache.))
{
final Date now = new Date();
final HttpServletResponse httpResponse = (HttpServletResponse)
response;
httpResponse.setDateHeader(Date, now.getTime());
httpResponse.setDateHeader(Expires, now.getTime() -
8640L);
httpResponse.setHeader(Pragma, no-cache); // HTTP 1.0
httpResponse.setHeader(Cache-control, no-cache, no-store,
must-revalidate); // HTTP 1.1
}
else if (requestURI.contains(.cache.))
{
final HttpServletResponse httpResponse = (HttpServletResponse)
response;
httpResponse.setDateHeader(Expires,
System.currentTimeMillis() + 60480L); // 1 week in future.
}
filterChain.doFilter(request, response);
}
}
When I reload the page I see in Firebug a 304 Not Modified status on my
initial myapp.nocache.js file, which sometimes leads to people seeing only
a white page after a new deploy. If I inspect the headers of the nocache
file I don't see any Expires-tag.
The .cache. files seem to be cached correctly however (one week):
Date: Mon, 25 Jun 2012 15:11:57 GMT
Expires: Mon, 02 Jul 2012 15:11:57 GMT
I am using guice so in my servlet module I do:
filter(*).through(GWTCacheControlFilter.class);
However I have also tried adding the following to web.xml:
filter
filter-namegwtCacheControlFilter/filter-name
filter-classmy.package.GWTCacheControlFilter/filter-class
/filter
filter-mapping
filter-namegwtCacheControlFilter/filter-name
url-pattern/*/url-pattern
/filter-mapping
Anyone have some ideas what I am missing? I'm deploying using Glassfish
Open Source edition 3.1.1.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/5wb7eU-M3cUJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Abridged summary of google-web-toolkit@googlegroups.com - 8 Messages in 4 Topics
-- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[no subject]
-- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Perfect caching problem
Can you reproduce in other browsers? We have similar problems only with
Firefox.
2012/6/25 Jonas sark...@gmail.com
I am trying to implement the GWT perfect caching by using a custom javax
servlet filter. All files containing .nocache. should never be cached, and
files containing .cache. should be cached for a week.
Here is the code for my filter:
public class GWTCacheControlFilter implements Filter
{
@Override
public void destroy()
{
}
@Override
public void init(final FilterConfig config) throws ServletException
{
}
@Override
public final void doFilter(final ServletRequest request, final
ServletResponse response, final FilterChain filterChain)
throws IOException, ServletException
{
final HttpServletRequest httpRequest = (HttpServletRequest)
request;
final String requestURI = httpRequest.getRequestURI();
if (requestURI.contains(.nocache.))
{
final Date now = new Date();
final HttpServletResponse httpResponse = (HttpServletResponse)
response;
httpResponse.setDateHeader(Date, now.getTime());
httpResponse.setDateHeader(Expires, now.getTime() -
8640L);
httpResponse.setHeader(Pragma, no-cache); // HTTP 1.0
httpResponse.setHeader(Cache-control, no-cache, no-store,
must-revalidate); // HTTP 1.1
}
else if (requestURI.contains(.cache.))
{
final HttpServletResponse httpResponse = (HttpServletResponse)
response;
httpResponse.setDateHeader(Expires,
System.currentTimeMillis() + 60480L); // 1 week in future.
}
filterChain.doFilter(request, response);
}
}
When I reload the page I see in Firebug a 304 Not Modified status on my
initial myapp.nocache.js file, which sometimes leads to people seeing only
a white page after a new deploy. If I inspect the headers of the nocache
file I don't see any Expires-tag.
The .cache. files seem to be cached correctly however (one week):
Date: Mon, 25 Jun 2012 15:11:57 GMT
Expires: Mon, 02 Jul 2012 15:11:57 GMT
I am using guice so in my servlet module I do:
filter(*).through(GWTCacheControlFilter.class);
However I have also tried adding the following to web.xml:
filter
filter-namegwtCacheControlFilter/filter-name
filter-classmy.package.GWTCacheControlFilter/filter-class
/filter
filter-mapping
filter-namegwtCacheControlFilter/filter-name
url-pattern/*/url-pattern
/filter-mapping
Anyone have some ideas what I am missing? I'm deploying using Glassfish
Open Source edition 3.1.1.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To view this discussion on the web visit
https://groups.google.com/d/msg/google-web-toolkit/-/5wb7eU-M3cUJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
GWT Gannt Charts
Has any one used this http://code.google.com/p/gwtgantt/ ? Where can i download the jar file for this? I dont find it in Download section. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/t98eKYHqiHwJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT Gannt Charts
Or somebody please let me know if there are any other open source packages to draw Gantt charts in GWT. On Monday, June 25, 2012 12:53:24 PM UTC-4, Bharath Kumar wrote: Has any one used this http://code.google.com/p/gwtgantt/ ? Where can i download the jar file for this? I dont find it in Download section. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/iA_6OXH9hIYJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT Gannt Charts
You can browse the source of that project. Also have a look at : http://www.gxt-scheduler.com/gxtgantt.html 2012/6/25 Bharath Kumar bharath1...@gmail.com Or somebody please let me know if there are any other open source packages to draw Gantt charts in GWT. On Monday, June 25, 2012 12:53:24 PM UTC-4, Bharath Kumar wrote: Has any one used this http://code.google.com/p/**gwtgantt/http://code.google.com/p/gwtgantt/ ? Where can i download the jar file for this? I dont find it in Download section. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/iA_6OXH9hIYJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: GWT Gannt Charts
On 6/25/12, Bharath Kumar bharath1...@gmail.com wrote: Has any one used this http://code.google.com/p/gwtgantt/ ? Where can i download the jar file for this? I dont find it in Download section. You probably want to write your own calls to the underlying JS library. ISTR the GWT wrapper was so bad that I wound up writing my own calls the JS routines. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
GWT Plugin for Eclipse 3.8 (Juno 4.2)
Hi everyone, The GWT Plugin update site ( https://developers.google.com/eclipse/docs/download) only have links upto Eclipse 3.7 (Indigo). Is it possible to install the GWT Plugin on Eclipse 3.8 (Juno 4.2)? I've followed the article: https://plus.google.com/110140945975184013033/posts/ePFpQZYhPQq, but no luck. Regards Albert -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/_dDJMxZVi9AJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Using EntityProxyId in a service call
Just to follow up, I more or less did what you suggested. In my situation, I was hoping to have my UI Views be oblivious as to whether they were showing historical data, and needed that revision timestamp, or showing live data where that timestamp was not needed (and find could be called as normal). I was able to abstract my service calls, and override the EntityProxyChange event. When in historical mode, I can cast the EntityProxyChange to my historical version, get the ID (long in this case) and make the modified find call to the service. This let me plow straight ahead, without having to change the views. Thanks! --Rob On Thursday, June 21, 2012 1:07:00 AM UTC-7, Thomas Broyer wrote: On Thursday, June 21, 2012 1:20:28 AM UTC+2, Rob Whiteside wrote: I am using RequestFactory to fetch data from the server and have came across a situation that I can't find an answer to: On the client I have an EntityProxyId for a proxy that I want to fetch. Normally, I'd just do a find and off it goes to the server. Then, my Locator's find gets called, but now this EntityProxyId is actually the ID that I can use to grab it from the database. But, in this particular case, I'm interested in finding a particular revision of that entity. So, I'd like to include a date or timestamp in that find call (at this point, i'd be able to query the db to grab the correct revision of said entity). I can't quite figure out how to do this... Is there a way that I can create a new service call that will still do that *magic* translation of the EntityProxyID into the actual database Id? That way, I can still include that extra timestamp. If you can, replace EntityProxyId with the ID of the entity (Long or String or whatever), that's the simplest and IMO cleanest way of doing what you want. The only alternative is to help finish http://code.google.com/p/google-web-toolkit/issues/detail?id=5525 by providing a patch (looks like the only missing part is support in the GWT generator) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/L6wmQ1y2bRAJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: gwt 2.5
I too would like to know if there is a compiled package. On Friday, June 22, 2012 2:21:39 PM UTC-4, Dennis Haupt wrote: is there a precompiled package? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/ZpaKfHZtiN8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: gwt 2.5
See https://developers.google.com/web-toolkit/makinggwtbetter#compiling to compile from trunk. On Monday, June 25, 2012 10:22:51 PM UTC+2, Yuri C wrote: I too would like to know if there is a compiled package. On Friday, June 22, 2012 2:21:39 PM UTC-4, Dennis Haupt wrote: is there a precompiled package? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/BlD8tV5mUPAJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: A good book to understand GWT 2.4
Hi, The book: Google App Engine Java and GWT Application Development has some good coverage of MVP. EventBus, UI Binder, ClientBundle, Authentication and GAE. - http://www.packtpub.com/google-app-engine-java-and-gwt-application-development/book You should also check out the GWT Dev Guide: - https://developers.google.com/web-toolkit/doc/latest/DevGuide And check out GWT-related blog pots: - http://arcbees.wordpress.com/ - http://turbomanage.wordpress.com/category/google-web-toolkit/ - http://tbroyer.posterous.com/ - http://uptick.com.au/blog Cheers Rob Kiahu.com On Monday, June 25, 2012 11:04:40 PM UTC+10, Qrunk wrote: Hi , Please let me know any good book with all updated features of GWT (i.e. till 2.4) this will make a great help. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/K_94T9dIer0J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Deferred Binding with ClientBundle
Is there an easy way to use different source images with client bundle for different permutations without creating a different implementations and adding a deferred binding property to my gwt.xml? For example, I would like to use SVG images for a lot of my icons, but IE8 and below would need a jpg or png as there is no SVG support. As far as I'm aware, the only way to do this is have two ClientBundle implementations with different sources defined. @Source(home-icon.png) public DataResource homeIcon(); @DataResource.MimeType(image/svg+xml) @Source(home-icon.svg) public DataResource homeIcon(); This is ok for the few amount of icons my application has, but it seems like something that could get out of hand very quickly. Especially if using the same technique to target Apple's retina displays with higher resolution images. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/ejiwPwrTO3UJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Wrapper cannot find servlet class com.google.gwt.dev.shell.GWTShellServlet
Hi , Sorry I haven't get this problem, but according to me class not found exception is causing because of the class * com.google.gwt.dev.shell.GWTShellServlet * which your compiler is looking for , is not avail to your build pathand from this link i can say , this class is present in the jar *google-dev-mac,* what you already used in your lib folder (please refer this link http://www.jarfinder.com/index.php/java/info/com.google.gwt.dev.shell.GWTShellServlet )...which is contradict the above post... so the problem is different ..may be you haven't properly took this lib to your build path even if it is showing to your eclipse project explorer window, just right click and check whether *Add to build path* is showing or not.other reason may be ...even though it is showing just check its presence in *WEB-INF/lib*folder of your deployment directory -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/UUnQVyFnGWUJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
[gwt-contrib] Re: Added 5 missing tests to the TCK test suite coverage. (issue1744804)
http://gwt-code-reviews.appspot.com/1744804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix violations generated by properties with constraints on both getters and fields (issue1746803)
http://gwt-code-reviews.appspot.com/1746803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix violations generated by properties with constraints on both getters and fields (issue1746803)
Some generated code for the bean we have been looking at:
public class _BuildingValidatorImpl extends
com.google.gwt.validation.client.impl.AbstractGwtSpecificValidatororg.hibernate.jsr303.tck.tests.constraints.application.Building
implements _BuildingValidator {
private static final java.util.ListString ALL_PROPERTY_NAMES =
java.util.Collections.StringunmodifiableList(
java.util.Arrays.StringasList(buildingCosts,class));
private final
com.google.gwt.validation.client.impl.ConstraintDescriptorImpljavax.validation.constraints.Max
buildingCosts_c0 =
com.google.gwt.validation.client.impl.ConstraintDescriptorImpl.javax.validation.constraints.Max
builder()
.setAnnotation(
new javax.validation.constraints.Max(){
public Class? extends Annotation annotationType() {
return javax.validation.constraints.Max.class; }
public java.lang.Class[] groups() { return new
java.lang.Class[] {};}
public long value() { return 500L;}
public java.lang.String message() { return Building
costs are max {max} dollars.;}
public java.lang.Class[] payload() { return new
java.lang.Class[] {};}
}
)
.setAttributes(attributeBuilder()
.put(value, 500L)
.put(message, Building costs are max {max} dollars.)
.put(payload, new java.lang.Class[] {})
.put(groups, new java.lang.Class[] {})
.build())
.setConstraintValidatorClasses(new java.lang.Class[]
{org.hibernate.validator.constraints.impl.MaxValidatorForNumber.class,org.hibernate.validator.constraints.impl.MaxValidatorForString.class})
.setGroups(new java.lang.Class[]
{javax.validation.groups.Default.class})
.setPayload(new java.lang.Class[] {})
.setReportAsSingleViolation(false)
.setElementType(java.lang.annotation.ElementType.FIELD)
.build();
private final
com.google.gwt.validation.client.impl.ConstraintDescriptorImpljavax.validation.constraints.Max
buildingCosts_c1 =
com.google.gwt.validation.client.impl.ConstraintDescriptorImpl.javax.validation.constraints.Max
builder()
.setAnnotation(
new javax.validation.constraints.Max(){
public Class? extends Annotation annotationType() {
return javax.validation.constraints.Max.class; }
public java.lang.Class[] groups() { return new
java.lang.Class[] {};}
public long value() { return 500L;}
public java.lang.String message() { return Building
costs are max {max} dollars.;}
public java.lang.Class[] payload() { return new
java.lang.Class[] {};}
}
)
.setAttributes(attributeBuilder()
.put(value, 500L)
.put(message, Building costs are max {max} dollars.)
.put(payload, new java.lang.Class[] {})
.put(groups, new java.lang.Class[] {})
.build())
.setConstraintValidatorClasses(new java.lang.Class[]
{org.hibernate.validator.constraints.impl.MaxValidatorForNumber.class,org.hibernate.validator.constraints.impl.MaxValidatorForString.class})
.setGroups(new java.lang.Class[]
{javax.validation.groups.Default.class})
.setPayload(new java.lang.Class[] {})
.setReportAsSingleViolation(false)
.setElementType(java.lang.annotation.ElementType.METHOD)
.build();
private final javax.validation.metadata.PropertyDescriptor
buildingCosts_pd =
new com.google.gwt.validation.client.impl.PropertyDescriptorImpl(
buildingCosts,
long.class,
false,
buildingCosts_c0,
buildingCosts_c1);
private final
com.google.gwt.validation.client.impl.GwtBeanDescriptororg.hibernate.jsr303.tck.tests.constraints.application.Building
beanDescriptor =
com.google.gwt.validation.client.impl.GwtBeanDescriptorImpl.builder(org.hibernate.jsr303.tck.tests.constraints.application.Building.class)
.setConstrained(true)
.put(buildingCosts, buildingCosts_pd)
.build();
public T SetConstraintViolationT validate(
GwtValidationContextT context,
org.hibernate.jsr303.tck.tests.constraints.application.Building
object,
Class?... groups) {
try {
SetConstraintViolationT violations =
new HashSetConstraintViolationT();
context.addValidatedObject(object);
validateProperty_getbuildingCosts(context, violations, object,
object.getBuildingCosts(), true, groups);
validateProperty_buildingCosts(context, violations, object,
_buildingCosts(object), true, groups);
return violations;
} catch (IllegalArgumentException e) {
throw e;
} catch (ValidationException e) {
throw e;
} catch (Exception e) {
throw new ValidationException(Error validating
[gwt-contrib] Re: Fix violations generated by properties with constraints on both getters and fields (issue1746803)
http://gwt-code-reviews.appspot.com/1746803/diff/25001/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):
http://gwt-code-reviews.appspot.com/1746803/diff/25001/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java#newcode1622
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:1622:
(hasField !hasMatchingAnnotation(p, true, constraint))) {
I don't see who we can get here and not need to write the constraint
validation
remember we already check hasMatchingAnnotation(p,false,constraint)
above.
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix violations generated by properties with constraints on both getters and fields (issue1746803)
lgtm http://gwt-code-reviews.appspot.com/1746803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
LGTM, but take a look at the comments before committing.
http://gwt-code-reviews.appspot.com/1758804/diff/2001/distro-source/core/src/samples/build.xml
File distro-source/core/src/samples/build.xml (right):
http://gwt-code-reviews.appspot.com/1758804/diff/2001/distro-source/core/src/samples/build.xml#newcode4
distro-source/core/src/samples/build.xml:4: ant target=${target}
dir=DynaTable/
not part of your patch, but I think we need to add in simplerpc and
simplexml here as well.
http://gwt-code-reviews.appspot.com/1758804/diff/2001/samples/expenses/build.xml
File samples/expenses/build.xml (right):
http://gwt-code-reviews.appspot.com/1758804/diff/2001/samples/expenses/build.xml#newcode1
samples/expenses/build.xml:1: project name=expenses default=source
basedir=.
I think we need to do the same in the validation sample as well.
http://gwt-code-reviews.appspot.com/1758804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
On 2012/06/25 20:52:50, rchandia wrote: LGTM. http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix DynaTableRf build config (issue1758804)
Submitted as r11136 http://gwt-code-reviews.appspot.com/1758804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add compilation progress logging, visible in dev mode when log level set to TRACE. This is helpf... (issue1749803)
I don't have time to try it out right now, but here are a few things.
http://gwt-code-reviews.appspot.com/1749803/diff/9001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java
File dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java (right):
http://gwt-code-reviews.appspot.com/1749803/diff/9001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode31
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:31: static
interface NanoSource {
Nit: static isn't needed; all interfaces are static. Also, since the
class isn't public, you don't need public on the methods either.
http://gwt-code-reviews.appspot.com/1749803/diff/9001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode41
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:41: // low,
early estimates will be wildly inaccurate.
Should say units: where 1.0 is 100% complete
http://gwt-code-reviews.appspot.com/1749803/diff/9001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode112
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:112: if
(logger.isLoggable(logLevel)) {
style: generally it's better to return early and avoid long nested
blocks.
if (!logger.isLoggable(logLevel)) {
return;
}
Similarly on 121.
http://gwt-code-reviews.appspot.com/1749803/diff/9001/dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java#newcode121
dev/core/src/com/google/gwt/dev/javac/ProgressLogger.java:121: if
(currentPercentage = nextPercentage || progressUnits ==
maxProgressUnits) {
For builds that compile quickly, maybe we don't want to print 20
progress reports? Maybe we should wait until 5 seconds have passed
before we start showing progress.
http://gwt-code-reviews.appspot.com/1749803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixed scrollbar width calculation. In Chrome, for a scrollbar styled (issue1756803)
LGTM Thanks for the patch. I'll try it out and submit it this week. http://gwt-code-reviews.appspot.com/1756803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixed scrollbar width calculation. In Chrome, for a scrollbar styled (issue1756803)
LGTM Thanks for the patch. I'll try it out and submit it this week. http://gwt-code-reviews.appspot.com/1756803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Convert dynatable sample to use GWT-RPC instead of DeRPC. (issue1759803)
Reviewers: rdayal,
Description:
Convert dynatable sample to use GWT-RPC instead of DeRPC.
Workaround for issue 7453.
Please review this at http://gwt-code-reviews.appspot.com/1759803/
Affected files:
M samples/dynatable/src/com/google/gwt/sample/dynatable/DynaTable.gwt.xml
M
samples/dynatable/src/com/google/gwt/sample/dynatable/client/SchoolCalendarService.java
M
samples/dynatable/src/com/google/gwt/sample/dynatable/server/SchoolCalendarServiceImpl.java
Index:
samples/dynatable/src/com/google/gwt/sample/dynatable/DynaTable.gwt.xml
===
--- samples/dynatable/src/com/google/gwt/sample/dynatable/DynaTable.gwt.xml
(revision 11137)
+++ samples/dynatable/src/com/google/gwt/sample/dynatable/DynaTable.gwt.xml
(working copy)
@@ -14,7 +14,6 @@
module rename-to=dynatable
inherits name='com.google.gwt.user.User' /
- inherits name='com.google.gwt.rpc.RPC' /
entry-point class='com.google.gwt.sample.dynatable.client.DynaTable' /
servlet path='/calendar'
class='com.google.gwt.sample.dynatable.server.SchoolCalendarServiceImpl' /
Index:
samples/dynatable/src/com/google/gwt/sample/dynatable/client/SchoolCalendarService.java
===
---
samples/dynatable/src/com/google/gwt/sample/dynatable/client/SchoolCalendarService.java
(revision 11137)
+++
samples/dynatable/src/com/google/gwt/sample/dynatable/client/SchoolCalendarService.java
(working copy)
@@ -15,12 +15,12 @@
*/
package com.google.gwt.sample.dynatable.client;
-import com.google.gwt.rpc.client.RpcService;
+import com.google.gwt.user.client.rpc.RemoteService;
/**
* The interface for the RPC server endpoint to get school calendar
information.
*/
-public interface SchoolCalendarService extends RpcService {
+public interface SchoolCalendarService extends RemoteService {
Person[] getPeople(int startIndex, int maxCount);
Index:
samples/dynatable/src/com/google/gwt/sample/dynatable/server/SchoolCalendarServiceImpl.java
===
---
samples/dynatable/src/com/google/gwt/sample/dynatable/server/SchoolCalendarServiceImpl.java
(revision 11137)
+++
samples/dynatable/src/com/google/gwt/sample/dynatable/server/SchoolCalendarServiceImpl.java
(working copy)
@@ -21,7 +21,7 @@
import com.google.gwt.sample.dynatable.client.SchoolCalendarService;
import com.google.gwt.sample.dynatable.client.Student;
import com.google.gwt.sample.dynatable.client.TimeSlot;
-import com.google.gwt.user.server.rpc.HybridServiceServlet;
+import com.google.gwt.user.server.rpc.RemoteServiceServlet;
import java.util.ArrayList;
import java.util.Arrays;
@@ -31,7 +31,7 @@
/**
* The implemenation of the RPC service which runs on the server.
*/
-public class SchoolCalendarServiceImpl extends HybridServiceServlet
implements
+public class SchoolCalendarServiceImpl extends RemoteServiceServlet
implements
SchoolCalendarService {
private static final String[] FIRST_NAMES = new String[] {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Convert dynatable sample to use GWT-RPC instead of DeRPC. (issue1759803)
LGTM. http://gwt-code-reviews.appspot.com/1759803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
