Re: module source path hell
On Wednesday, April 24, 2013 4:58:56 PM UTC+2, DP wrote: Thomas, Thanks for the reply. Have you used the include or exclude element within the source element? I find that the include element doesn't work at all. It does work well. What problem did you have exactly? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Emulated stack mode not resolving symbols
Hi, I'm trying to get some useful stack trace from the client side but all I get is: java.lang.Throwable: Exception caught: Exception caught: For input string: 59909596809 at Unknown.jk(Unknown Source) at Unknown.gi(Unknown Source) at Unknown.Wu(Unknown Source) at Unknown.Zu(Unknown Source) ... etc, etc. In the gwt.xml file I've got: set-property name=gwt.logging.simpleRemoteHandler value=ENABLED / set-property name=compiler.stackMode value=strip,emulated / set-configuration-property name=compiler.emulatedStack.recordLineNumbers value=true/ I've also got my own implementation of RemoteLoggingServiceImpl which sets the location of the symbol maps directory to: /WEB-INF/debug/symbolMaps (In the index.html file I switch between the two stack modes using meta name=gwt:property content=compiler.stackMode=strip / Can anyone see what I'm doing wrong? Cheers, Dave -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gwt facebook wrapper api
Spring-social is good. I have used it and works good. What api's of Facebook are you trying to integrate ? Leung leung1_2...@yahoo.com wrote: Hi Is there any facebook wrapper api for facebook to recommend? Which one is the most convenient? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gwt facebook wrapper api
I am trying facebook4gwt. I know nothing about spring. Is it a steep learning curve? From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 2:19 AM Subject: Re: Gwt facebook wrapper api Spring-social is good. I have used it and works good. What api's of Facebook are you trying to integrate ? Leung leung1_2...@yahoo.com wrote: Hi Is there any facebook wrapper api for facebook to recommend? Which one is the most convenient? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gwt facebook wrapper api
No. Pretty straight forward. It gives the flexibility to connect with other services like twitter as well. What features are you trying ? Login/ like etc Leung leung1_2...@yahoo.com wrote: I am trying facebook4gwt. I know nothing about spring. Is it a steep learning curve? From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 2:19 AM Subject: Re: Gwt facebook wrapper api Spring-social is good. I have used it and works good. What api's of Facebook are you trying to integrate ? Leung leung1_2...@yahoo.com wrote: Hi Is there any facebook wrapper api for facebook to recommend? Which one is the most convenient? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT callback method whenever textbox.setText() is called
I am using GWT textbox. Whenever textbox.setText() method is called, i want to perform an action in some other class. ValueChangeEvent is not fired whenever setText() is called. Is there any event that will be fired or any ways to achieve this? Please help -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT callback method whenever textbox.setText() is called
Use TextBox.setValue(newValue, true) instead. But keep in mind that if the old text equals the newText, no ValueChangeEvent will be fired -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Upload files using apache DiskFileItemFactory to GAE?
Hi, on my local deployment I use apache file upload streaming like: FileItemFactory fileItemFactory = new DiskFileItemFactory(); ServletFileUpload uploadHandlr = new ServletFileUpload(fileItemFactory); ListFileItem uploadItems = uploadHandlr.parseRequest(req); I don't want to save the uploaded file anyhow. Just upload it and send it back to the client in order so extract some information. Sadly it seems as if GAE does not support DiskFileItemFactory. What's the best way to overcome this limitation, without having to rewrite the whole file upload content? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Upload files using apache DiskFileItemFactory to GAE?
Dont use DiskFileItemFactory. http://commons.apache.org/proper/commons-fileupload/streaming.html (untested but thats probably your only option when using Apache FileUpload) -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Gwt facebook wrapper api
Login at this moment, but certainly I need the others later. It sounds that spring social is the best one. From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 4:13 AM Subject: Re: Gwt facebook wrapper api No. Pretty straight forward. It gives the flexibility to connect with other services like twitter as well. What features are you trying ? Login/ like etc Leung leung1_2...@yahoo.com wrote: I am trying facebook4gwt. I know nothing about spring. Is it a steep learning curve? From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 2:19 AM Subject: Re: Gwt facebook wrapper api Spring-social is good. I have used it and works good. What api's of Facebook are you trying to integrate ? Leung leung1_2...@yahoo.com wrote: Hi Is there any facebook wrapper api for facebook to recommend? Which one is the most convenient? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT designer in Eclipse Juno
What plugins do you have installed? Install New Software - already installed. Can you post a screenshot with the GWT items expanded? On Wednesday, April 24, 2013 11:37:22 AM UTC-4, Robert Kabwogi wrote: im having the same problem... what is the solution to this problem? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT - So terribly slow that makes development hard ... very hard ... extremely hard ...
What version of GWT are you using? Have you done anything with your settings to improve performance of the compiler? There are a lot of documents, slides, and videos that cover this. Have you used SuperDev mode? Your post is lacking of any real content and almost looks like trolling. On Thursday, April 18, 2013 1:22:15 PM UTC-4, Ani wrote: Now that we have been using GWT for a while ... what do you think? Was it the right choice or thinking of migrating to other framework? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: columnSortHandler on a Dynamic CellTable
Thank you very much!
Le mercredi 24 avril 2013 15:54:06 UTC-4, sebastie...@isen-lille.fr a
écrit :
Hi everybody,
I create a dynamic CellTable this way:
for (int column = 0; column arrListFilters.size(); column++) {
IndexedColumn IColumn= new IndexedColumn(column);
IColumn.setSortable(true);
table.addColumn(IColumn, arrListFilters.get(column));
}
final ListDataProviderListString provider = new
ListDataProviderListString(rows);
provider.addDataDisplay(table);
for (String row: rowsArray) {
rows.add(Arrays.asList(row));}
It works well, but I want to add comparator to my table. So I do that, but
it doesn't work:
ListHandlerListString(rows);
i=0;
while(itable.getColumnCount()){
columnSortHandler.setComparator(table.getColumn(i),
new ComparatorListString() {
public int compare(ListString o1,ListString o2) {
if (o1 == o2) {
return 0;
}
* if (o1 != null) {
return (o2 != null) ? o1.get(0).compareTo(o2.get(0)) : 1;
} *
}
});
i=i+1;
}
table.addColumnSortHandler(columnSortHandler);
i=0;
while(itable.getColumnCount()){
table.getColumnSortList().push(table.getColumn(i));
i=i+1;
}
I know that the problem is here, but I don't know how to what I want.
*if (o1 != null) {*
* return (o2 != null) ? o1.get(0).compareTo(o2.get(0)) : 1;
*
* } *
Any ideas?
Thanks a lot!
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Theme GWT, how does it works?
Hi, My web application has serveral widgets like datePicker, dynamicDecorator... If I run my project with eclipse, widgets are ok. I want to build my project on lighthttpd, so I just copy my folder on my server. When I open website with a web broswer, it works but all my widgets have no style. ( for example, there are only the numbers for the datePicker: no color, no background...). I guess that the theme doesn't work without eclipse but in my gwt.xml I have: inherits name='com.google.gwt.user.theme.clean.Clean'/ inherits name='com.google.gwt.user.theme.standard.Standard'/ Do I really need to fill my CSS file to do the same thing with or without eclipse? Can I use the GWT theme without eclipse? I don't really understand the connections between the themes and the CSS.. Thank you in advance! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Entity not persisted, using JDO,RequestFactory.
I am able to persist this entity in a servlet with following code: PersistenceManager pm = PMF.getInstance().getPersistenceManager(); User abcd = new User(); abcd.setEmail(em...@email.com); abcd.setName(name); VerificationToken token1 = new VerificationToken(abcd,VerificationToken.VerificationTokenType.emailVerification,60); if(abcd!=nulltoken1!=null) abcd.addVerificationToken(token1); else System.err.println(Why me!); Poll poll = new Poll(); poll.setQuestion(Hello Good Morning); ListString options = new ArrayListString(); options.add(option 1); options.add(option 2); poll.setOptions(options); poll.setUser(abcd); poll.setCloseTime(new Date()); pm.makePersistent(abcd); pm.makePersistent(poll); pm.close(); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Entity not persisted, using JDO,RequestFactory.
I am still not able to persist poll entity using Requestfactory in GWT.
Please point out if there's anything wrong with following code.
view.setMsg(preparing);
PollRequest pr = requestFactory.pollRequest();
UserRequest ur = requestFactory.userRequest();
final UserProxy[] oldUser=new UserProxy[1];
ur.findUser(Cookies.getCookie(user)).fire(new ReceiverUserProxy(){
@Override
public void onSuccess(UserProxy user){
oldUser[0]=user;
}
});
UserProxy editUser=ur.edit(oldUser[0]);
PollProxy createdPoll = ur.create(PollProxy.class);
createdPoll.setQuestion(view.getQuestion());
createdPoll.setOptions(view.asEditor().getList());
createdPoll.setCloseTime(closeTime);
createdPoll.setUser(oldUser[0]);
editUser.setPolls(createdPoll);
ur.persist().using(editUser).fire(new ReceiverVoid(){
@Override
public void onSuccess(Void arg0){
view.setMsg(POll Created);
}
});
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Gwt facebook wrapper api
For login, you can do client side or server side. For client side, just Facebook js would suffice. In my project, I used client side auth, but subsequent to login I use spring social to read uaer profile etc. Leung leung1_2...@yahoo.com wrote: Login at this moment, but certainly I need the others later. It sounds that spring social is the best one. From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 4:13 AM Subject: Re: Gwt facebook wrapper api No. Pretty straight forward. It gives the flexibility to connect with other services like twitter as well. What features are you trying ? Login/ like etc Leung leung1_2...@yahoo.com wrote: I am trying facebook4gwt. I know nothing about spring. Is it a steep learning curve? From: Ashwin Desikan ashwin.desi...@gmail.com To: google-web-toolkit@googlegroups.com Sent: Thursday, April 25, 2013 2:19 AM Subject: Re: Gwt facebook wrapper api Spring-social is good. I have used it and works good. What api's of Facebook are you trying to integrate ? Leung leung1_2...@yahoo.com wrote: Hi Is there any facebook wrapper api for facebook to recommend? Which one is the most convenient? Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes duplicate method dispatchers generated by GWTTestCase.
Goktug Gokdogan has uploaded a new patch set (#3). Change subject: Removes duplicate method dispatchers generated by GWTTestCase. .. Removes duplicate method dispatchers generated by GWTTestCase. This also adds test cases to verify GWTTestCase correctly handles inheritance. Change-Id: I52fe1d3ee60ec4c289e4055653125253c5639e76 Review-Link: https://gwt-review.googlesource.com/#/c/2590/ --- M user/src/com/google/gwt/junit/rebind/GWTRunnerProxyGenerator.java M user/test/com/google/gwt/junit/JUnitSuite.java M user/test/com/google/gwt/junit/TestSuiteWithOrder.java A user/test/com/google/gwt/junit/client/GWTTestCaseInheritanceTest.java A user/test/com/google/gwt/junit/client/GWTTestCaseInheritanceTestBase.java 5 files changed, 109 insertions(+), 25 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I52fe1d3ee60ec4c289e4055653125253c5639e76 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes duplicate method dispatchers generated by GWTTestCase.
Goktug Gokdogan has posted comments on this change. Change subject: Removes duplicate method dispatchers generated by GWTTestCase. .. Patch Set 3: Verified+1 PTAL. -- To view, visit https://gwt-review.googlesource.com/2590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fe1d3ee60ec4c289e4055653125253c5639e76 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes duplicate method dispatchers generated by GWTTestCase.
Matthew Dempsky has posted comments on this change. Change subject: Removes duplicate method dispatchers generated by GWTTestCase. .. Patch Set 3: Verified-1 Oops, this change failed the build and/or style presubmit. :( More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/37 -- To view, visit https://gwt-review.googlesource.com/2590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fe1d3ee60ec4c289e4055653125253c5639e76 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Genericizing com.google.gwt.user.client.ui.Composite for type safe extends
I would like to get your feedback for fixing following issue: https://code.google.com/p/google-web-toolkit/issues/detail?id=4665 With generic Composite classes we can introduce other type-safe helper composites like FocusComposite or PanelComposite (see the patch). This will reduce boilerplate when people need to add more functionality to their widgets extending composite. For example ValueListBoxhttps://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/client/ui/ValueListBox.javacan provide all FocusWidget API by just extending FocusComposite. Otherwise it would have needed to add delegate for all methods in the FocusWidget API (20+ methods). Similarly, if you are developing widgets using UIBinder then you can use PanelComposite instead of Composite to make the widget work like a real panel in other templates as PanelComposite implements HasWidgets. We cannot introduce these helper classes with current Composite in a type safe way. The reason is initWidget can be called with any parameter and we can't override it to make it more specific. This issue can be easily seen in ResizeCompositehttps://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/client/ui/ResizeComposite.javaclass where the check need to be done in runtime. However with the proposed change, ResizeComposite becomes just a one liner and type is checked in compile time. Another minor advantage is classes extending composite will not necessarily need to keep a reference to the widget passed to the composite as getWidget will retain the type. So what is the gotcha? First of all old code will give warnings due to missing generic type in Composite. Also classes that doesn't need to enhance the type information will still need to provide a type for Composite, this includes most of the Composite uses with the UIBinder. We can get mitigate these problems by introducing a separate 'TypedComposite' and 'TypedResizeComposite' class that uses generics. Of course this means more classes that will potentially cause more confusion. Anyway I uploaded following patch so you can take a look how things will look like with TypedComposite: https://gwt-review.googlesource.com/#/c/2582/ Let me know what you think. Thanks! -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
