[gwt-contrib] Re: Refactor SessionHandler and BrowserChannelClient to allow other OOPHM clients than HtmlUnit
On Sun, Nov 29, 2009 at 4:52 AM, Amit Manjhi wrote: Thanks for the patch. I agree with John that this is way too late for 2.0 at this point. I will get back to this for 2.1. Please file a public issue for this refactoring and attach the patch to that. OK, no problem. Issue filed at http://code.google.com/p/google-web-toolkit/issues/detail?id=4287 -- Thomas Broyer /tɔ.ma.bʁwa.je/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Add support for launching a default browser from Swing interface
Can the default launch URL use the IP instead of localhost? I use VMWare on my OSX machine and often access the dev mode URL from a Windows VM using IE for testing purposes. Currently I need to manually replace localhost with the machine IP in the URL. It's not a big deal but will add a little convenience if there are no downsides to using IP instead of localhost. Thanks, Sanjiv On Wed, Nov 4, 2009 at 12:33 AM, j...@google.com wrote: Reviewers: Ray Ryan, bruce, Description: This patch adds support for launching the user's default browser using several methods. This facility is then used for HelpInfo links in the logger detail messages (falling back to the old method of using the Swing HTML panel if none work), including the launch browser message. This won't launch automatically (there are still too many variables, such as wanting to launch a different browser or a particular profile), but it will make it much easier to launch if the default is what they want. It will also give a much better experience for clicking other HelpInfo links, such as the upgrade message. BrowserLauncher includes a main method that takes one or more URLs, so you can run it with an arg of http://www.google.com, for example, to make sure it works independent of the Swing logger. I have tested it on Linux with JDK 1.5 and 1.6 (which is significant since 1.6 adds a platform-independent way to launch the browser) -- please test on other platforms and make sure it works properly. Please review this at http://gwt-code-reviews.appspot.com/92802 Affected files: dev/core/src/com/google/gwt/core/ext/TreeLogger.java dev/core/src/com/google/gwt/dev/DevModeBase.java dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java dev/core/src/com/google/gwt/dev/util/BrowserLauncher.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on UsingOOPHM in google-web-toolkit
Comment by arunabha.gh: @mark.renouf Atfer the patch and build when the app is started in firefox I get a 'GWT module 'xxx' needs to be (re)compiled, please run a compile or use the Compile/Browse button in hosted mode'. This happens even after compiling the project. Any ideas? For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7195 committed - Change Swing find keybindings to better match expected values: Ctrl-G ...
Revision: 7195
Author: j...@google.com
Date: Sun Nov 29 20:11:12 2009
Log: Change Swing find keybindings to better match expected values: Ctrl-G
for
find next, Ctrl-Shift-G for find previous (Cmd instead of Ctrl on Mac).
Patch by: jat
Review by: amitmanjhi (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=7195
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Mon Nov 23 18:34:09 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
Sun Nov 29 20:11:12 2009
@@ -418,14 +418,14 @@
}
}
logger = bestLogger;
-KeyStroke key = getCommandKeyStroke(KeyEvent.VK_F);
+KeyStroke key = getCommandKeyStroke(KeyEvent.VK_F, false);
getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(key, find);
getActionMap().put(find, new AbstractAction() {
public void actionPerformed(ActionEvent e) {
showFindBox();
}
});
-key = getCommandKeyStroke(KeyEvent.VK_C);
+key = getCommandKeyStroke(KeyEvent.VK_C, false);
tree.getInputMap().put(key, copy);
tree.getActionMap().put(copy, new AbstractAction() {
public void actionPerformed(ActionEvent e) {
@@ -433,14 +433,14 @@
}
});
findBox = new FindBox();
-key = getCommandKeyStroke(KeyEvent.VK_N);
+key = getCommandKeyStroke(KeyEvent.VK_G, false);
tree.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(key, findnext);
tree.getActionMap().put(findnext, new AbstractAction() {
public void actionPerformed(ActionEvent e) {
findBox.nextMatch();
}
});
-key = getCommandKeyStroke(KeyEvent.VK_P);
+key = getCommandKeyStroke(KeyEvent.VK_G, true);
tree.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(key, findprev);
tree.getActionMap().put(findprev, new AbstractAction() {
public void actionPerformed(ActionEvent e) {
@@ -646,11 +646,16 @@
* Returns a keystroke which adds the appropriate modifier for a command
key:
* Command on mac, Ctrl everywhere else.
*
- * @param key
+ * @param key virtual key defined in {...@code KeyEvent#VK_*}
+ * @param shift true if the Ctrl/Command key must be shifted
* @return KeyStroke of the Ctrl/Command-key
*/
- private KeyStroke getCommandKeyStroke(int key) {
-return KeyStroke.getKeyStroke(key, ctrlKeyDown);
+ private KeyStroke getCommandKeyStroke(int key, boolean shift) {
+int mask = ctrlKeyDown;
+if (shift) {
+ mask |= InputEvent.SHIFT_DOWN_MASK;
+}
+return KeyStroke.getKeyStroke(key, mask);
}
private String htmlUnescape(String str) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7196 committed - Merge trunk r7194 into this branch...
Revision: 7196
Author: j...@google.com
Date: Sun Nov 29 20:24:51 2009
Log: Merge trunk r7194 into this branch
Make RunStyle public, improve docs.
svn merge --ignore-ancestry -c7194 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7196
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/junit/JUnitShell.java
/releases/2.0/user/src/com/google/gwt/junit/RunStyle.java
===
--- /releases/2.0/branch-info.txt Wed Nov 25 10:12:27 2009
+++ /releases/2.0/branch-info.txt Sun Nov 29 20:24:51 2009
@@ -1092,3 +1092,7 @@
Removed index.html from distro-source because it is obsolete
svn merge --ignore-ancestry -c7190
https://google-web-toolkit.googlecode.com/svn/trunk .
+tr...@7194 was merged into this branch
+ Make RunStyle public, improve docs.
+svn merge --ignore-ancestry -c7194 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
--- /releases/2.0/user/src/com/google/gwt/junit/JUnitShell.java Tue Nov 24
12:40:22 2009
+++ /releases/2.0/user/src/com/google/gwt/junit/JUnitShell.java Sun Nov 29
20:24:51 2009
@@ -243,7 +243,8 @@
return Selects the runstyle to use for this test. The name is
+ a suffix of com.google.gwt.junit.RunStyle or is a fully
+ qualified class name, and may be followed with a colon
and
- + an argument for this runstyle.;
+ + an argument for this runstyle. The specified class must
+ + extend RunStyle.;
}
@Override
===
--- /releases/2.0/user/src/com/google/gwt/junit/RunStyle.java Mon Nov 16
19:22:20 2009
+++ /releases/2.0/user/src/com/google/gwt/junit/RunStyle.java Sun Nov 29
20:24:51 2009
@@ -24,7 +24,7 @@
/**
* An abstract class that handles the details of launching a browser.
*/
-abstract class RunStyle {
+public abstract class RunStyle {
/**
* The containing shell.
@@ -71,6 +71,8 @@
/**
* Returns the number of times this test should be tried to run. A test
* succeeds if it succeeds even once.
+ *
+ * @return the number of attempts
*/
public int getTries() {
return tries;
@@ -95,6 +97,12 @@
public abstract void launchModule(String moduleName)
throws UnableToCompleteException;
+ /**
+ * Sets the number of times a test should be tried -- it succeeds if any
+ * attempt succeeds.
+ *
+ * @param tries number of attempts
+ */
public void setTries(int tries) {
this.tries = tries;
}
@@ -113,11 +121,13 @@
}
/**
- * Whether the embedded server should ever generate resources. Hosted
mode
- * needs this, but not noserver hosted. TODO(spoon) does web mode get
simpler
- * if this is turned on?
+ * Whether the embedded server should ever generate resources.
Development
+ * mode needs this, but not with -noserver.
+ *
+ * @return true if resources should be automatically generated by the
server.
*/
public boolean shouldAutoGenerateResources() {
+// TODO(spoon) does web mode get simpler if this is turned on?
return true;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on UsingOOPHM in google-web-toolkit
Comment by arunabha.gh: @thomas.matthijs That did the trick, thanks For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
