[gwt-contrib] [google-web-toolkit] r9717 committed - Fixes memory leak in ResourceOracleImpl under GWT Designer....
Revision: 9717
Author: gwt.mirror...@gmail.com
Date: Thu Feb 10 11:10:49 2011
Log: Fixes memory leak in ResourceOracleImpl under GWT Designer.
While using GWT Designer the class path cache in ResourceOracleImpl never
gets cleared of obsolete data.
http://gwt-code-reviews.appspot.com/1308801/show
Patch by: amitin
Review by: me
http://code.google.com/p/google-web-toolkit/source/detail?r=9717
Modified:
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
===
---
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
Fri Jan 7 09:43:50 2011
+++
/trunk/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
Thu Feb 10 11:10:49 2011
@@ -24,6 +24,9 @@
import com.google.gwt.dev.util.msg.Message0;
import com.google.gwt.dev.util.msg.Message1String;
+import org.apache.commons.collections.map.AbstractReferenceMap;
+import org.apache.commons.collections.map.ReferenceMap;
+
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
@@ -141,7 +144,9 @@
}
}
- private static final MapClassLoader, ListClassPathEntry
classPathCache = new HashMapClassLoader, ListClassPathEntry();
+ @SuppressWarnings(unchecked)
+ private static final MapClassLoader, ListClassPathEntry
classPathCache = new ReferenceMap(
+ AbstractReferenceMap.WEAK, AbstractReferenceMap.HARD);
public static ClassPathEntry createEntryForUrl(TreeLogger logger, URL
url)
throws URISyntaxException, IOException {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Contributing widgets back, how should styling be implemented?
I've developed a widget similar to decoratorpanel, except it facilitates drag resizing and uses the layout panel architecture instead of the html table layout of DecoratorPanel. I've got some more javadoc and tests to write before I send it in for review (and possibly additions to showcase). My question is, what is the standard for doing styling with new widgets? Should I continue to use the standard.css standard_rtl.css etc? Or should I implement the styling with CssResource? If I go with CssResource, then the borders of the Resizable won't match the changing theme. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Contributing widgets back, how should styling be implemented?
Sounds cool. Looking forward to seeing it. On Thu, Feb 10, 2011 at 2:23 PM, Jeff Larsen larse...@gmail.com wrote: I've developed a widget similar to decoratorpanel, except it facilitates drag resizing and uses the layout panel architecture instead of the html table layout of DecoratorPanel. I've got some more javadoc and tests to write before I send it in for review (and possibly additions to showcase). My question is, what is the standard for doing styling with new widgets? Should I continue to use the standard.css standard_rtl.css etc? Or should I implement the styling with CssResource? If I go with CssResource, then the borders of the Resizable won't match the changing theme. Please use the CSS resource and match it to the color scheme of the CellTable styles. We're moving away from the older style themes in static CSS files and toward a single theme that we'll keep up to date. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Provides a CachedCompilationUnit class to serialize a CompilationUnit. (issue1357801)
http://gwt-code-reviews.appspot.com/1357801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9718 committed - fix for IE devmode when using specific linker setting....
Revision: 9718
Author: gwt.mirror...@gmail.com
Date: Thu Feb 10 12:12:19 2011
Log: fix for IE devmode when using specific linker setting.
Review at http://gwt-code-reviews.appspot.com/1358801
Review by: unn...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9718
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
===
--- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js Thu
Dec 16 11:33:51 2010
+++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js Thu
Feb 10 08:56:16 2011
@@ -212,7 +212,7 @@
var obj = document.createElement('object');
obj.id = 'pluginObject';
- obj.CLASSID = 'CLSID:1D6156B6-002B-49E7-B5CA-C138FB843B4E';
+ obj.classid = 'clsid:1D6156B6-002B-49E7-B5CA-C138FB843B4E';
document.body.appendChild(embed);
document.body.appendChild(obj);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Provides a CachedCompilationUnit class to serialize a CompilationUnit. (issue1357801)
LGTM + minor nits
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004#newcode41
dev/core/src/com/google/gwt/dev/javac/Dependencies.java:41: class
Dependencies implements Serializable {
80 chars
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2005
File dev/core/src/com/google/gwt/dev/javac/JsniCollector.java (right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2005#newcode71
dev/core/src/com/google/gwt/dev/javac/JsniCollector.java:71:
80 chars
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2005#newcode86
dev/core/src/com/google/gwt/dev/javac/JsniCollector.java:86: }
white space
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2009
File dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java
(right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2009#newcode340
dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java:340:
rebuildCompilationState();
I'm not sure the reformatting on these is better than before?
http://gwt-code-reviews.appspot.com/1357801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Provides a CachedCompilationUnit class to serialize a CompilationUnit. (issue1357801)
Isn't Java serialization fun? Welcome to your Java Serialization
trial-by-fire. :)
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2002
File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2002#newcode43
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:43:
private transient long cacheToken;
Can we break my ill-thought-out pattern and name this sourceToken to
give some semantic idea of what data it represents?
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2002#newcode60
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:60: //
initializing with a null unit is useful for unit testing
I think we should kill this, though, see comment in unit test.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2002#newcode143
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:143:
CategorizedProblem[] getProblems() {
This is actually marginally important... you should run into cases where
you need to re-report compilation errors without actually having
recompiled the unit.
The simplest way to fix this would be:
1) Make GWTProblem Serializable.
2) Trivially subclass JDT's DefaultProblem with a Serializable subclass.
3) For incoming problems that are not serializable, convert them to your
subclass in the constructor.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2002#newcode154
dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:154: //
replace the compilation unit in the CompiledClasses with this one.
I don't think this is what we want. If anything, this should just
assert that each cc.getUnit() == this. But I'm not sure that's
necessary even.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (left):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003#oldcode133
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:133: assert
this.unit == null;
Revert with new impl.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003#newcode41
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:41: private
transient CompilationUnit unit;
I don't think this is the right approach... see below.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003#newcode146
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:146: }
I would remove this, see comment in CompiledClassTest.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2003#newcode148
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:148:
outputStream.writeObject(new CachedCompilationUnit(unit));
This is a major problem, because the class completely loses its
relationship with the original Unit. What actually happens here is, you
start serializing a Unit, and as you go and do the Classes, each Class
turns around and serializes its OWN COPY of the unit. You end up
serializing N+1 distinct copies of the unit.
What you really want to do is implement a protected writeReplace() on
either CompilationUnit or CompilationUnitImpl, and have the units
replace THEMSELVES with a CachedCompilationUnit. Then all of the
CompiledClasses will do the right thing automatically, and you can make
the unit field non-transient.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004#newcode41
dev/core/src/com/google/gwt/dev/javac/Dependencies.java:41: class
Dependencies implements Serializable {
I had a kind of big idea how we could generally do this better.
Basically, you do something like this:
private static abstract class Ref implements Serializable {
}
private static class DirectRef extends Ref {
CompiledClass target;
private Object writeReplace() {
return new SerializedRef(target.getInternalName(),
computeHash(target.getBytes();
}
}
private static class SerializedRef extends Ref {
public SerializedRef(String internalName, String hash) {
}
}
Then, we just update the implementation of validate() to handle either
kind of Ref. If it's a DirectRef, we use the existing logic. If it's a
SerializedRef, instead of using JDT's structurally-same, we hash the
incoming bytes and just look for an exact match. Most of the time, it
will be an exact match. As soon as the validation occurs, we can
replaced the SerializedRef with a DirectRef on the incoming class.
http://gwt-code-reviews.appspot.com/1357801/diff/2001/2004#newcode51
dev/core/src/com/google/gwt/dev/javac/Dependencies.java:51: private
ListString unresolvedSimple;
Looking at what's going on here, I regret how stateful this class is. I
would actually be in favor of killing the 'unresolved' fields and simply
initializing the maps with all 'null' values.
[gwt-contrib] [google-web-toolkit] r9721 committed - Cherry picking r9720 into releases/2.2
Revision: 9721
Author: gwt.mirror...@gmail.com
Date: Thu Feb 10 14:04:06 2011
Log: Cherry picking r9720 into releases/2.2
http://code.google.com/p/google-web-toolkit/source/detail?r=9721
Added:
/releases/2.2/user/test/com/google/gwt/media/public-test
/releases/2.2/user/test/com/google/gwt/media/public-test/poster.jpg
/releases/2.2/user/test/com/google/gwt/media/public-test/smallh264.mp4
/releases/2.2/user/test/com/google/gwt/media/public-test/smallmp3.mp3
/releases/2.2/user/test/com/google/gwt/media/public-test/smallogg.ogg
/releases/2.2/user/test/com/google/gwt/media/public-test/smalltheora.ogv
Deleted:
/releases/2.2/user/test/com/google/gwt/media/public
Modified:
/releases/2.2/user/src/com/google/gwt/media/Media.gwt.xml
/releases/2.2/user/src/com/google/gwt/media/client/Audio.java
/releases/2.2/user/src/com/google/gwt/media/client/Video.java
/releases/2.2/user/test/com/google/gwt/media/MediaSuite.java
/releases/2.2/user/test/com/google/gwt/media/MediaTest.gwt.xml
/releases/2.2/user/test/com/google/gwt/media/client/AudioTest.java
/releases/2.2/user/test/com/google/gwt/media/client/VideoTest.java
===
--- /dev/null
+++ /releases/2.2/user/test/com/google/gwt/media/public-test/poster.jpg Thu
Feb 10 14:04:06 2011
Binary file, no diff available.
===
--- /dev/null
+++ /releases/2.2/user/test/com/google/gwt/media/public-test/smallh264.mp4
Thu Feb 10 14:04:06 2011
File is too large to display a diff.
===
--- /dev/null
+++ /releases/2.2/user/test/com/google/gwt/media/public-test/smallmp3.mp3
Thu Feb 10 10:52:06 2011
Binary file, no diff available.
===
--- /dev/null
+++ /releases/2.2/user/test/com/google/gwt/media/public-test/smallogg.ogg
Thu Feb 10 10:52:06 2011
Binary file, no diff available.
===
--- /dev/null
+++
/releases/2.2/user/test/com/google/gwt/media/public-test/smalltheora.ogv
Thu Feb 10 10:52:06 2011
File is too large to display a diff.
===
--- /releases/2.2/user/src/com/google/gwt/media/Media.gwt.xml Fri Jan 28
11:24:46 2011
+++ /releases/2.2/user/src/com/google/gwt/media/Media.gwt.xml Thu Feb 10
10:52:06 2011
@@ -16,5 +16,50 @@
module
inherits name=com.google.gwt.user.User/
inherits name=com.google.gwt.media.dom.DOM/
+
+ !-- Define the support property for Video and Audio--
+ define-property name=videoElementSupport values=maybe,no /
+ define-property name=audioElementSupport values=maybe,no /
+
+ !-- Give default support value of no --
+ set-property name=videoElementSupport value=no /
+ set-property name=audioElementSupport value=no /
+
+ set-property name=videoElementSupport value=maybe
+any
+ when-property-is name=user.agent value=safari /
+ when-property-is name=user.agent value=gecko1_8 /
+ when-property-is name=user.agent value=opera /
+/any
+ /set-property
+
+ set-property name=audioElementSupport value=maybe
+any
+ when-property-is name=user.agent value=safari /
+ when-property-is name=user.agent value=gecko1_8 /
+ when-property-is name=user.agent value=opera /
+/any
+ /set-property
+
+ replace-with
class=com.google.gwt.media.client.Video.VideoElementSupportDetectedMaybe
+when-type-is
class=com.google.gwt.media.client.Video.VideoElementSupportDetector /
+when-property-is name=videoElementSupport value=maybe /
+ /replace-with
+
+ replace-with
class=com.google.gwt.media.client.Video.VideoElementSupportDetectedNo
+when-type-is
class=com.google.gwt.media.client.Video.VideoElementSupportDetector /
+when-property-is name=videoElementSupport value=no /
+ /replace-with
+
+ replace-with
class=com.google.gwt.media.client.Audio.AudioElementSupportDetectedMaybe
+when-type-is
class=com.google.gwt.media.client.Audio.AudioElementSupportDetector /
+when-property-is name=videoElementSupport value=maybe /
+ /replace-with
+
+ replace-with
class=com.google.gwt.media.client.Audio.AudioElementSupportDetectedNo
+when-type-is
class=com.google.gwt.media.client.Audio.AudioElementSupportDetector /
+when-property-is name=audioElementSupport value=no /
+ /replace-with
+
source path=client/
/module
===
--- /releases/2.2/user/src/com/google/gwt/media/client/Audio.java Fri Jan
28 11:24:46 2011
+++ /releases/2.2/user/src/com/google/gwt/media/client/Audio.java Thu Feb
10 10:52:06 2011
@@ -76,21 +76,12 @@
}
/**
- * Protected constructor. Use {@link #createIfSupported()} to create an
Audio.
+ * Protected constructor. Use {@link #createIfSupported()} to create
+ * an Audio element.
*/
private Audio(AudioElement element) {
setElement(element);
}
-
- /**
- * Creates an Audio widget with a given source URL.
- *
- * @param src a String URL
- */
- public
[gwt-contrib] Re: Proactively gathers more method names for MethodArgNamesLookup. Before this (issue1359801)
Scott and I noticed that the MethodArgNamesLookup did not contain all
the methods we thought it should. This could result in extra parsing
time if the diet parse needs to be called to resolve method argument
names.
http://gwt-code-reviews.appspot.com/1359801/diff/1/4
File dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java
(right):
http://gwt-code-reviews.appspot.com/1359801/diff/1/4#newcode39
dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java:39:
public class CompilationStateTest extends CompilationStateTestBase {
This seemed to me like an odd place to put this test. There's no test
class for MethodParmCollector. The easiest way to test is to build a
compilation state, so I added the test case here. I could go back and
create a separate unit test class if you like.
http://gwt-code-reviews.appspot.com/1359801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9722 committed - tag for the release of GWT 2.2
Revision: 9722 Author: mrruss...@google.com Date: Thu Feb 10 14:55:48 2011 Log: tag for the release of GWT 2.2 http://code.google.com/p/google-web-toolkit/source/detail?r=9722 Added: /tags/2.2.0/2.2 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9723 committed - firest tag was incorrect
Revision: 9723 Author: mrruss...@google.com Date: Thu Feb 10 15:31:37 2011 Log: firest tag was incorrect http://code.google.com/p/google-web-toolkit/source/detail?r=9723 Deleted: /tags/2.2.0 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9724 committed - tag for the release branch
Revision: 9724 Author: mrruss...@google.com Date: Thu Feb 10 15:33:22 2011 Log: tag for the release branch http://code.google.com/p/google-web-toolkit/source/detail?r=9724 Added: /tags/2.2.0 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9725 committed - update the documentation from the latest release build
Revision: 9725 Author: mrruss...@google.com Date: Thu Feb 10 16:43:23 2011 Log: update the documentation from the latest release build http://code.google.com/p/google-web-toolkit/source/detail?r=9725 Modified: /javadoc/2.2/com/google/gwt/media/client/Audio.html /javadoc/2.2/com/google/gwt/media/client/Video.html /javadoc/2.2/index-all.html === --- /javadoc/2.2/com/google/gwt/media/client/Audio.html Tue Feb 8 13:18:23 2011 +++ /javadoc/2.2/com/google/gwt/media/client/Audio.html Thu Feb 10 16:43:23 2011 @@ -74,9 +74,9 @@ /TR TR TD VALIGN=top CLASS=NavBarCell3FONT SIZE=-2 - SUMMARY:nbsp;A HREF=#nested_classes_inherited_from_class_com.google.gwt.user.client.ui.UIObjectNESTED/Anbsp;| nbsp;A HREF=#fields_inherited_from_class_com.google.gwt.user.client.ui.UIObjectFIELD/Anbsp;| nbsp;A HREF=#constructor_summaryCONSTR/Anbsp;|nbsp;A HREF=#method_summaryMETHOD/A/FONT/TD + SUMMARY:nbsp;A HREF=#nested_classes_inherited_from_class_com.google.gwt.user.client.ui.UIObjectNESTED/Anbsp;| nbsp;A HREF=#fields_inherited_from_class_com.google.gwt.user.client.ui.UIObjectFIELD/Anbsp;| nbsp;CONSTRnbsp;|nbsp;A HREF=#method_summaryMETHOD/A/FONT/TD TD VALIGN=top CLASS=NavBarCell3FONT SIZE=-2 -DETAIL:nbsp;FIELDnbsp;|nbsp;A HREF=#constructor_detailCONSTR/Anbsp;|nbsp;A HREF=#method_detailMETHOD/A/FONT/TD +DETAIL:nbsp;FIELDnbsp;|nbsp;CONSTRnbsp;|nbsp;A HREF=#method_detailMETHOD/A/FONT/TD /TR /TABLE A NAME=skip-navbar_top/A @@ -157,22 +157,6 @@ TR BGCOLOR=white CLASS=TableRowColor TDCODEA HREF=../../../../../com/google/gwt/user/client/ui/UIObject.html#DEBUG_ID_PREFIXDEBUG_ID_PREFIX/A/CODE/TD /TR -/TABLE -nbsp; -!-- CONSTRUCTOR SUMMARY -- - -A NAME=constructor_summary!-- --/A -TABLE BORDER=1 WIDTH=100% CELLPADDING=3 CELLSPACING=0 SUMMARY= -TR BGCOLOR=#FF CLASS=TableHeadingColor -TH ALIGN=left COLSPAN=2FONT SIZE=+2 -BConstructor Summary/B/FONT/TH -/TR -TR BGCOLOR=white CLASS=TableRowColor -TDCODEBA HREF=../../../../../com/google/gwt/media/client/Audio.html#Audio(java.lang.String)Audio/A/B(java.lang.Stringnbsp;src)/CODE - -BR -nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;Creates an Audio widget with a given source URL./TD -/TR /TABLE nbsp; !-- == METHOD SUMMARY === -- @@ -256,27 +240,6 @@ nbsp; P -!-- = CONSTRUCTOR DETAIL -- - -A NAME=constructor_detail!-- --/A -TABLE BORDER=1 WIDTH=100% CELLPADDING=3 CELLSPACING=0 SUMMARY= -TR BGCOLOR=#FF CLASS=TableHeadingColor -TH ALIGN=left COLSPAN=1FONT SIZE=+2 -BConstructor Detail/B/FONT/TH -/TR -/TABLE - -A NAME=Audio(java.lang.String)!-- --/AH3 -Audio/H3 -PRE -public BAudio/B(java.lang.Stringnbsp;src)/PRE -DL -DDCreates an Audio widget with a given source URL. -P -DL -DTBParameters:/BDDCODEsrc/CODE - a String URL/DL -/DL - !-- METHOD DETAIL == -- A NAME=method_detail!-- --/A @@ -379,9 +342,9 @@ /TR TR TD VALIGN=top CLASS=NavBarCell3FONT SIZE=-2 - SUMMARY:nbsp;A HREF=#nested_classes_inherited_from_class_com.google.gwt.user.client.ui.UIObjectNESTED/Anbsp;| nbsp;A HREF=#fields_inherited_from_class_com.google.gwt.user.client.ui.UIObjectFIELD/Anbsp;| nbsp;A HREF=#constructor_summaryCONSTR/Anbsp;|nbsp;A HREF=#method_summaryMETHOD/A/FONT/TD + SUMMARY:nbsp;A HREF=#nested_classes_inherited_from_class_com.google.gwt.user.client.ui.UIObjectNESTED/Anbsp;| nbsp;A HREF=#fields_inherited_from_class_com.google.gwt.user.client.ui.UIObjectFIELD/Anbsp;| nbsp;CONSTRnbsp;|nbsp;A HREF=#method_summaryMETHOD/A/FONT/TD TD VALIGN=top CLASS=NavBarCell3FONT SIZE=-2 -DETAIL:nbsp;FIELDnbsp;|nbsp;A HREF=#constructor_detailCONSTR/Anbsp;|nbsp;A HREF=#method_detailMETHOD/A/FONT/TD +DETAIL:nbsp;FIELDnbsp;|nbsp;CONSTRnbsp;|nbsp;A HREF=#method_detailMETHOD/A/FONT/TD /TR /TABLE A NAME=skip-navbar_bottom/A === --- /javadoc/2.2/com/google/gwt/media/client/Video.html Tue Feb 8 13:18:23 2011 +++ /javadoc/2.2/com/google/gwt/media/client/Video.html Thu Feb 10 16:43:23 2011 @@ -167,12 +167,6 @@ TH ALIGN=left COLSPAN=2FONT SIZE=+2 BConstructor Summary/B/FONT/TH /TR -TR BGCOLOR=white CLASS=TableRowColor -TDCODEBA HREF=../../../../../com/google/gwt/media/client/Video.html#Video()Video/A/B()/CODE - -BR -nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;nbsp;Creates a Video widget./TD -/TR TR BGCOLOR=white CLASS=TableRowColor TDCODEBA HREF=../../../../../com/google/gwt/media/client/Video.html#Video(java.lang.String)Video/A/B(java.lang.Stringnbsp;src)/CODE @@ -272,16 +266,6 @@ /TR /TABLE -A NAME=Video()!-- --/AH3 -Video/H3 -PRE -public BVideo/B()/PRE -DL -DDCreates a Video widget. -P -/DL -HR - A NAME=Video(java.lang.String)!-- --/AH3 Video/H3 PRE === --- /javadoc/2.2/index-all.html Tue Feb 8 13:18:23 2011 +++ /javadoc/2.2/index-all.html Thu Feb 10 16:43:23 2011 File is too large to display a diff. --
[gwt-contrib] [google-web-toolkit] r9726 committed - CollectorNull should not set stack traces when stack stripping is enab...
Revision: 9726
Author: cromwell...@google.com
Date: Thu Feb 10 14:05:42 2011
Log: CollectorNull should not set stack traces when stack stripping is
enabled. Throwable.getStackTrace() already handles the case of a null stack
trace and constructs an empty array.
Review at http://gwt-code-reviews.appspot.com/1355801
http://code.google.com/p/google-web-toolkit/source/detail?r=9726
Modified:
/trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
===
--- /trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
Fri Feb 4 08:47:41 2011
+++ /trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
Thu Feb 10 14:05:42 2011
@@ -384,12 +384,12 @@
@Override
public void createStackTrace(JavaScriptException e) {
- e.setStackTrace(new StackTraceElement[0]);
+ // empty, since Throwable.getStackTrace() properly handles null
}
@Override
public void fillInStackTrace(Throwable t) {
- t.setStackTrace(new StackTraceElement[0]);
+ // empty, since Throwable.getStackTrace() properly handles null
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
