[gwt-contrib] Remove final keyword from IsRenderable-overrides in Composite. (issue1504802)
Reviewers: rjrjr,
Description:
Remove final keyword from IsRenderable-overrides in Composite.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1504802/
Affected files:
M user/src/com/google/gwt/user/client/ui/Composite.java
Index: user/src/com/google/gwt/user/client/ui/Composite.java
===
--- user/src/com/google/gwt/user/client/ui/Composite.java (revision 10462)
+++ user/src/com/google/gwt/user/client/ui/Composite.java (working copy)
@@ -38,8 +38,6 @@
* h3Example/h3
* {@example com.google.gwt.examples.CompositeExample}
* /p
- *
- * TODO(rdcastro): Remove the final qualifier from IsRenderable overrides.
*/
public abstract class Composite extends Widget implements IsRenderable {
@@ -50,7 +48,7 @@
private Element elementToWrap;
@Override
- public final void claimElement(Element element) {
+ public void claimElement(Element element) {
if (renderable != null) {
renderable.claimElement(element);
setElement(widget.getElement());
@@ -60,7 +58,7 @@
}
@Override
- public final void initializeClaimedElement() {
+ public void initializeClaimedElement() {
if (renderable != null) {
renderable.initializeClaimedElement();
} else {
@@ -86,7 +84,7 @@
}
@Override
- public final SafeHtml render(RenderableStamper stamper) {
+ public SafeHtml render(RenderableStamper stamper) {
if (renderable != null) {
return renderable.render(stamper);
} else {
@@ -98,7 +96,7 @@
}
@Override
- public final void render(RenderableStamper stamper, SafeHtmlBuilder
builder) {
+ public void render(RenderableStamper stamper, SafeHtmlBuilder builder) {
if (renderable != null) {
renderable.render(stamper, builder);
} else {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove final keyword from IsRenderable-overrides in Composite. (issue1504802)
LGTM http://gwt-code-reviews.appspot.com/1504802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add font-face support to CssResource. (issue1502806)
Reviewers: rjrjr, Message: This is a re-spin of a patch that was written back in October but that got dropped. The original patch is at http://gwt-code-reviews.appspot.com/943802. Description: Add font-face support to CssResource. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1502806/ Affected files: M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java M user/src/com/google/gwt/resources/css/GenerateCssAst.java A user/src/com/google/gwt/resources/css/ast/CssFontFace.java M user/src/com/google/gwt/resources/css/ast/CssNodeCloner.java M user/src/com/google/gwt/resources/css/ast/CssVisitor.java M user/test/com/google/gwt/resources/client/CSSResourceTest.java M user/test/com/google/gwt/resources/client/test.css -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add font-face support to CssResource. (issue1502806)
Unnur, would you be comfortable taking this? On Tue, Jul 26, 2011 at 12:12 PM, b...@google.com wrote: Reviewers: rjrjr, Message: This is a re-spin of a patch that was written back in October but that got dropped. The original patch is at http://gwt-code-reviews.**appspot.com/943802http://gwt-code-reviews.appspot.com/943802 . Description: Add font-face support to CssResource. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.**appspot.com/1502806/http://gwt-code-reviews.appspot.com/1502806/ Affected files: M user/src/com/google/gwt/**resources/css/**CssGenerationVisitor.java M user/src/com/google/gwt/**resources/css/GenerateCssAst.**java A user/src/com/google/gwt/**resources/css/ast/CssFontFace.**java M user/src/com/google/gwt/**resources/css/ast/**CssNodeCloner.java M user/src/com/google/gwt/**resources/css/ast/CssVisitor.**java M user/test/com/google/gwt/**resources/client/**CSSResourceTest.java M user/test/com/google/gwt/**resources/client/test.css -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Include enclosing class in generated class name (issue1499804)
Reviewers: rchandia,
Description:
Include enclosing class in generated class name
Please review this at http://gwt-code-reviews.appspot.com/1499804/
Affected files:
M user/src/com/google/gwt/validation/rebind/AbstractCreator.java
Index: user/src/com/google/gwt/validation/rebind/AbstractCreator.java
===
--- user/src/com/google/gwt/validation/rebind/AbstractCreator.java
(revision 10462)
+++ user/src/com/google/gwt/validation/rebind/AbstractCreator.java (working
copy)
@@ -1,12 +1,12 @@
/*
* Copyright 2010 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -59,7 +59,8 @@
return getQualifiedName();
}
- protected void addImports(ClassSourceFileComposerFactory
composerFactory, Class?... imports) {
+ protected void addImports(ClassSourceFileComposerFactory composerFactory,
+ Class?... imports) {
for (Class? imp : imports) {
composerFactory.addImport(imp.getCanonicalName());
}
@@ -108,11 +109,13 @@
}
private String getSimpleName() {
-return validatorType.getSimpleSourceName() + Impl;
+final int length = getPackage().length();
+final String rawName =
validatorType.getQualifiedSourceName().substring(
+length == 0 ? 0 : length + 1);
+return rawName.replace('.', '_') + Impl;
}
- private SourceWriter getSourceWriter(TreeLogger logger,
- GeneratorContext ctx) {
+ private SourceWriter getSourceWriter(TreeLogger logger, GeneratorContext
ctx) {
String packageName = getPackage();
String simpleName = getSimpleName();
PrintWriter printWriter = ctx.tryCreate(logger, packageName,
simpleName);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
