[gwt-contrib] Fixes and cleanup to expenses sample pom.xml (issue1534805)
Reviewers: rjrjr, drfibonacci, Description: Fixes and cleanup to expenses sample pom.xml - Bumps GWT version - RF verification Please review this at http://gwt-code-reviews.appspot.com/1534805/ Affected files: M samples/expenses/pom.xml -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)
committed as r10597 http://gwt-code-reviews.appspot.com/1533804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes and cleanup to expenses sample pom.xml (issue1534805)
LGTM http://gwt-code-reviews.appspot.com/1534805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10598 committed - Fixes and cleanup to expenses sample pom.xml...
Revision: 10598
Author: rchan...@google.com
Date: Wed Aug 31 05:45:29 2011
Log: Fixes and cleanup to expenses sample pom.xml
- Bumps GWT version
- RF verification
Review at http://gwt-code-reviews.appspot.com/1534805
http://code.google.com/p/google-web-toolkit/source/detail?r=10598
Modified:
/trunk/samples/expenses/pom.xml
===
--- /trunk/samples/expenses/pom.xml Fri May 27 07:47:34 2011
+++ /trunk/samples/expenses/pom.xml Wed Aug 31 05:45:29 2011
@@ -1,5 +1,6 @@
?xml version=1.0 encoding=UTF-8 standalone=no?
-project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
groupIdcom.google.gwt.sample.expenses/groupId
artifactIdexpenses/artifactId
@@ -7,12 +8,12 @@
version0.1.0.BUILD-SNAPSHOT/version
nameexpenses/name
properties
-gwt.version2.3.0/gwt.version
+gwt.version2.4.0/gwt.version
roo.version1.1.0.RELEASE/roo.version
spring.version3.0.3.RELEASE/spring.version
slf4j.version1.6.1/slf4j.version
-gae.version1.5.0.1/gae.version
-gae-test.version1.5.0.1/gae-test.version
+gae.version1.5.3/gae.version
+gae-test.version1.5.3/gae-test.version
gae.home${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}/gae.home
datanucleus.version1.1.5/datanucleus.version
/properties
@@ -404,24 +405,6 @@
artifactIdjson/artifactId
version20090211/version
/dependency
-!-- Uncomment appengine-local-runtime and appengine-tools-api to be
able to run App Engine unit tests --
-!-- With these uncommented, you must run mvn gae:unpack before
importing the project into Eclipse --
-!--
- dependency
- groupIdcom.google.appengine/groupId
- artifactIdappengine-local-runtime/artifactId
- version${gae.version}/version
- scopesystem/scope
-
systemPath${gae.home}/lib/impl/appengine-local-runtime.jar/systemPath
- /dependency
- dependency
- groupIdcom.google.appengine/groupId
- artifactIdappengine-tools-api/artifactId
- version${gae.version}/version
- scopesystem/scope
- systemPath${gae.home}/lib/appengine-tools-api.jar/systemPath
- /dependency
- --
dependency
groupIdnet.sf.jsr107cache/groupId
artifactIdjsr107cache/artifactId
@@ -579,7 +562,7 @@
plugin
groupIdnet.kindleit/groupId
artifactIdmaven-gae-plugin/artifactId
-version0.7.3/version
+version0.8.1/version
configuration
unpackVersion${gae.version}/unpackVersion
/configuration
@@ -676,7 +659,8 @@
module${project.groupId}.Expenses/module
module${project.groupId}.ExpensesMobile/module
module${project.groupId}.LoadExpensesDB/module
- /modules
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
+ /modules
+
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
!--
comment as it failed when running the application
extraJvmArgs-javaagent:${gae.home}/appengine-java-sdk-${gae.version}/lib/agent/appengine-agent.jar
-Xmx1024m
@@ -701,7 +685,92 @@
/execution
/executions
/plugin
+
+ !-- Run the RequestFactory ValidationTool --
+ plugin
+groupIdorg.codehaus.mojo/groupId
+artifactIdexec-maven-plugin/artifactId
+version1.2/version
+executions
+ execution
+phaseprocess-classes/phase
+configuration
+ idVerifyRequestFactoryInterfaces/id
+ executablejava/executable
+ arguments
+argument-cp/argument
+classpath /
+
argumentcom.google.web.bindery.requestfactory.apt.ValidationTool/argument
+argument${project.build.outputDirectory}/argument
+
argumentcom.google.gwt.sample.expenses.shared.ExpensesRequestFactory/argument
+ /arguments
+/configuration
+goals
+ goalexec/goal
+/goals
+ /execution
+/executions
+ /plugin
+
/plugins
+
+pluginManagement
+ plugins
+!--This plugin's configuration is used to store Eclipse m2e
settings only.
+ It has no influence on the Maven build itself. --
+plugin
+ groupIdorg.eclipse.m2e/groupId
+ artifactIdlifecycle-mapping/artifactId
+ version1.0.0/version
+
[gwt-contrib] [google-web-toolkit] r10599 committed - Cherry picking r10598 into releases/2.4
Revision: 10599
Author: rchan...@google.com
Date: Wed Aug 31 06:27:18 2011
Log: Cherry picking r10598 into releases/2.4
http://code.google.com/p/google-web-toolkit/source/detail?r=10599
Modified:
/releases/2.4/samples/expenses/pom.xml
===
--- /releases/2.4/samples/expenses/pom.xml Fri May 27 07:47:34 2011
+++ /releases/2.4/samples/expenses/pom.xml Wed Aug 31 06:27:18 2011
@@ -1,5 +1,6 @@
?xml version=1.0 encoding=UTF-8 standalone=no?
-project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
+project xmlns=http://maven.apache.org/POM/4.0.0;
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation=http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;
modelVersion4.0.0/modelVersion
groupIdcom.google.gwt.sample.expenses/groupId
artifactIdexpenses/artifactId
@@ -7,12 +8,12 @@
version0.1.0.BUILD-SNAPSHOT/version
nameexpenses/name
properties
-gwt.version2.3.0/gwt.version
+gwt.version2.4.0/gwt.version
roo.version1.1.0.RELEASE/roo.version
spring.version3.0.3.RELEASE/spring.version
slf4j.version1.6.1/slf4j.version
-gae.version1.5.0.1/gae.version
-gae-test.version1.5.0.1/gae-test.version
+gae.version1.5.3/gae.version
+gae-test.version1.5.3/gae-test.version
gae.home${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}/gae.home
datanucleus.version1.1.5/datanucleus.version
/properties
@@ -404,24 +405,6 @@
artifactIdjson/artifactId
version20090211/version
/dependency
-!-- Uncomment appengine-local-runtime and appengine-tools-api to be
able to run App Engine unit tests --
-!-- With these uncommented, you must run mvn gae:unpack before
importing the project into Eclipse --
-!--
- dependency
- groupIdcom.google.appengine/groupId
- artifactIdappengine-local-runtime/artifactId
- version${gae.version}/version
- scopesystem/scope
-
systemPath${gae.home}/lib/impl/appengine-local-runtime.jar/systemPath
- /dependency
- dependency
- groupIdcom.google.appengine/groupId
- artifactIdappengine-tools-api/artifactId
- version${gae.version}/version
- scopesystem/scope
- systemPath${gae.home}/lib/appengine-tools-api.jar/systemPath
- /dependency
- --
dependency
groupIdnet.sf.jsr107cache/groupId
artifactIdjsr107cache/artifactId
@@ -579,7 +562,7 @@
plugin
groupIdnet.kindleit/groupId
artifactIdmaven-gae-plugin/artifactId
-version0.7.3/version
+version0.8.1/version
configuration
unpackVersion${gae.version}/unpackVersion
/configuration
@@ -676,7 +659,8 @@
module${project.groupId}.Expenses/module
module${project.groupId}.ExpensesMobile/module
module${project.groupId}.LoadExpensesDB/module
- /modules
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
+ /modules
+
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
!--
comment as it failed when running the application
extraJvmArgs-javaagent:${gae.home}/appengine-java-sdk-${gae.version}/lib/agent/appengine-agent.jar
-Xmx1024m
@@ -701,7 +685,92 @@
/execution
/executions
/plugin
+
+ !-- Run the RequestFactory ValidationTool --
+ plugin
+groupIdorg.codehaus.mojo/groupId
+artifactIdexec-maven-plugin/artifactId
+version1.2/version
+executions
+ execution
+phaseprocess-classes/phase
+configuration
+ idVerifyRequestFactoryInterfaces/id
+ executablejava/executable
+ arguments
+argument-cp/argument
+classpath /
+
argumentcom.google.web.bindery.requestfactory.apt.ValidationTool/argument
+argument${project.build.outputDirectory}/argument
+
argumentcom.google.gwt.sample.expenses.shared.ExpensesRequestFactory/argument
+ /arguments
+/configuration
+goals
+ goalexec/goal
+/goals
+ /execution
+/executions
+ /plugin
+
/plugins
+
+pluginManagement
+ plugins
+!--This plugin's configuration is used to store Eclipse m2e
settings only.
+ It has no influence on the Maven build itself. --
+plugin
+ groupIdorg.eclipse.m2e/groupId
+ artifactIdlifecycle-mapping/artifactId
+ version1.0.0/version
+ configuration
+lifecycleMappingMetadata
+
[gwt-contrib] Re: Fixes DynaTableRF interface validation, and silences quirks mode warning. (issue1534807)
On 2011/08/31 18:52:12, rjrjr wrote: Ready for review. Note that Rietveld ignores the binary file I'm adding: samples/dynatablerf/apt/requestfactory-apt.jar http://gwt-code-reviews.appspot.com/1534807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes DynaTableRF interface validation, and silences quirks mode warning. (issue1534807)
LGTM http://gwt-code-reviews.appspot.com/1534807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10600 committed - Fix a bug where isUnhover is fired with the opposite value....
Revision: 10600
Author: pengzhu...@google.com
Date: Wed Aug 31 08:59:55 2011
Log: Fix a bug where isUnhover is fired with the opposite value.
Review at http://gwt-code-reviews.appspot.com/1535804
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10600
Modified:
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
===
---
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
Wed Aug 31 03:58:11 2011
+++
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
Wed Aug 31 08:59:55 2011
@@ -2414,7 +2414,7 @@
*/
private void setRowHover(TableRowElement tr, boolean isHovering) {
setRowStyleName(tr, style.hoveredRow(), style.hoveredRowCell(),
isHovering);
-RowHoverEvent.fire(this, tr, isHovering);
+RowHoverEvent.fire(this, tr, !isHovering);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] maven source jars
so renaming it without regenerating or stripping the JarIndex (META-INF/INDEX.LIST) generates spurious exceptions in DevMode So that's what been causing that for me--I never would have thought renaming the jar file would be a problem. Thanks for pointing that out! - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10601 committed - Fixes DynaTableRF interface validation, and silences quirks mode warni...
Revision: 10601 Author: rj...@google.com Date: Wed Aug 31 09:17:19 2011 Log: Fixes DynaTableRF interface validation, and silences quirks mode warning. Review at http://gwt-code-reviews.appspot.com/1534807 Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10601 Added: /trunk/samples/dynatablerf/apt /trunk/samples/dynatablerf/apt/requestfactory-apt.jar Modified: /trunk/eclipse/samples/DynaTableRf/.factorypath /trunk/samples/dynatablerf/war/DynaTableRf.html === --- /dev/null +++ /trunk/samples/dynatablerf/apt/requestfactory-apt.jar Wed Aug 31 09:17:19 2011 Binary file, no diff available. === --- /trunk/eclipse/samples/DynaTableRf/.factorypath Fri Jul 1 09:12:59 2011 +++ /trunk/eclipse/samples/DynaTableRf/.factorypath Wed Aug 31 09:17:19 2011 @@ -1,3 +1,3 @@ factorypath -factorypathentry kind=VARJAR id=GWT_TOOLS/lib/requestfactory/requestfactory-apt.jar enabled=true runInBatchMode=false/ +factorypathentry kind=WKSPJAR id=/DynaTableRf/core/apt/requestfactory-apt.jar enabled=true runInBatchMode=false/ /factorypath === --- /trunk/samples/dynatablerf/war/DynaTableRf.html Thu Jul 29 06:36:34 2010 +++ /trunk/samples/dynatablerf/war/DynaTableRf.html Wed Aug 31 09:17:19 2011 @@ -1,4 +1,4 @@ -!DOCTYPE +!DOCTYPE HTML !-- -- !-- Copyright 2008 Google Inc. -- !-- Licensed under the Apache License, Version 2.0 (the License); you-- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixes for MobileWebApp pom.xml (issue1520809)
Reviewers: drfibonacci, rjrjr,
Description:
Fixes for MobileWebApp pom.xml
- Fix RF validation
- Bumps GAE version
- Minor cleanup
Please review this at http://gwt-code-reviews.appspot.com/1520809/
Affected files:
M samples/mobilewebapp/pom.xml
Index: samples/mobilewebapp/pom.xml
===
--- samples/mobilewebapp/pom.xml(revision 10598)
+++ samples/mobilewebapp/pom.xml(working copy)
@@ -18,7 +18,7 @@
maven.compiler.target1.6/maven.compiler.target
!-- GAE properties --
-gae.version1.5.0.1/gae.version
+gae.version1.5.3/gae.version
gae.home${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}/gae.home
gae.application.version1/gae.application.version
@@ -130,12 +130,6 @@
artifactIdappengine-api-labs/artifactId
version${gae.version}/version
/dependency
-!-- uncomment for testing dependency
groupIdcom.google.appengine/groupId
- artifactIdappengine-local-runtime/artifactId
version${gae.version}/version
- scopesystem/scope
systemPath${gae.home}/lib/impl/appengine-local-runtime.jar/systemPath
- /dependency dependency groupIdcom.google.appengine/groupId
artifactIdappengine-tools-api/artifactId
- version${gae.version}/version scopesystem/scope
systemPath${gae.home}/lib/appengine-tools-api.jar/systemPath
- /dependency --
!-- Objectify for persistence. It uses the stock javax.persistence
annotations --
@@ -181,7 +175,7 @@
build
!-- Generate compiled stuff in the folder used for developing mode --
-outputDirectorytarget/www/WEB-INF/classes/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/WEB-INF/classes/outputDirectory
plugins
!-- GWT Maven Plugin--
@@ -220,18 +214,14 @@
configuration
!-- URL that should be automatically opened in the GWT shell
(gwt:run). --
runTargetMobileWebApp.html/runTarget
- !-- Location of the develop-mode web application structure
(gwt:run). --
- hostedWebapptarget/www/hostedWebapp
!-- Ask GWT to create the Story of Your Compile (SOYC)
(gwt:compile) --
compileReporttrue/compileReport
modulecom.google.gwt.sample.mobilewebapp.MobileWebApp/module
-
appEngineVersion${gae.version}/appEngineVersion
appEngineHome${gae.home}/appEngineHome
logLevelINFO/logLevel
style${gwt.style}/style
-
hostedWebapp${project.build.directory}/${project.build.finalName}/hostedWebapp
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
copyWebapptrue/copyWebapp
/configuration
@@ -241,7 +231,7 @@
plugin
groupIdnet.kindleit/groupId
artifactIdmaven-gae-plugin/artifactId
-version0.8.0/version
+version0.8.1/version
executions
execution
id /
@@ -269,7 +259,7 @@
systemProperties
property
namegwt.args/name
- value-out target/www/value
+ value-out
${project.build.directory}/${project.build.finalName}/value
/property
/systemProperties
/configuration
@@ -312,7 +302,7 @@
goalcopy-resources/goal
/goals
configuration
- outputDirectorytarget/www/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/outputDirectory
resources
resource
directorysrc/main/webapp/directory
@@ -379,6 +369,19 @@
execute /
/action
/pluginExecution
+pluginExecution
+ pluginExecutionFilter
+groupIdorg.codehaus.mojo/groupId
+artifactIdexec-maven-plugin/artifactId
+versionRange[1.2,)/versionRange
+goals
+ goalexec/goal
+/goals
+ /pluginExecutionFilter
+ action
+execute /
+ /action
+/pluginExecution
/pluginExecutions
/lifecycleMappingMetadata
/configuration
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes for MobileWebApp pom.xml (issue1520809)
LGTM http://gwt-code-reviews.appspot.com/1520809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10602 committed - Integrates r10598, DynaTableRF fixes
Revision: 10602 Author: rj...@google.com Date: Wed Aug 31 09:36:53 2011 Log: Integrates r10598, DynaTableRF fixes http://code.google.com/p/google-web-toolkit/source/detail?r=10602 Added: /releases/2.4/samples/dynatablerf/apt /releases/2.4/samples/dynatablerf/apt/requestfactory-apt.jar Modified: /releases/2.4/eclipse/samples/DynaTableRf/.factorypath /releases/2.4/samples/dynatablerf/war/DynaTableRf.html === --- /dev/null +++ /releases/2.4/samples/dynatablerf/apt/requestfactory-apt.jar Wed Aug 31 09:36:53 2011 Binary file, no diff available. === --- /releases/2.4/eclipse/samples/DynaTableRf/.factorypath Thu Aug 25 10:06:37 2011 +++ /releases/2.4/eclipse/samples/DynaTableRf/.factorypath Wed Aug 31 09:36:53 2011 @@ -1,3 +1,3 @@ factorypath -factorypathentry kind=VARJAR id=GWT_TOOLS/lib/requestfactory/requestfactory-apt.jar enabled=true runInBatchMode=false/ +factorypathentry kind=WKSPJAR id=/DynaTableRf/core/apt/requestfactory-apt.jar enabled=true runInBatchMode=false/ /factorypath === --- /releases/2.4/samples/dynatablerf/war/DynaTableRf.html Thu Jul 29 06:36:34 2010 +++ /releases/2.4/samples/dynatablerf/war/DynaTableRf.html Wed Aug 31 09:36:53 2011 @@ -1,4 +1,4 @@ -!DOCTYPE +!DOCTYPE HTML !-- -- !-- Copyright 2008 Google Inc. -- !-- Licensed under the Apache License, Version 2.0 (the License); you-- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes for MobileWebApp pom.xml (issue1520809)
LGTM On Wed, Aug 31, 2011 at 1:18 PM, drfibona...@google.com wrote: LGTM http://gwt-code-reviews.**appspot.com/1520809/http://gwt-code-reviews.appspot.com/1520809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10603 committed - Fixes for MobileWebApp pom.xml...
Revision: 10603
Author: rchan...@google.com
Date: Wed Aug 31 10:35:46 2011
Log: Fixes for MobileWebApp pom.xml
- Fix exec-maven-plugin configuration
- Bumps GAE version
- Minor cleanup
Review at http://gwt-code-reviews.appspot.com/1520809
http://code.google.com/p/google-web-toolkit/source/detail?r=10603
Modified:
/trunk/samples/mobilewebapp/pom.xml
===
--- /trunk/samples/mobilewebapp/pom.xml Tue Aug 23 13:07:29 2011
+++ /trunk/samples/mobilewebapp/pom.xml Wed Aug 31 10:35:46 2011
@@ -18,7 +18,7 @@
maven.compiler.target1.6/maven.compiler.target
!-- GAE properties --
-gae.version1.5.0.1/gae.version
+gae.version1.5.3/gae.version
gae.home${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}/gae.home
gae.application.version1/gae.application.version
@@ -130,12 +130,6 @@
artifactIdappengine-api-labs/artifactId
version${gae.version}/version
/dependency
-!-- uncomment for testing dependency
groupIdcom.google.appengine/groupId
- artifactIdappengine-local-runtime/artifactId
version${gae.version}/version
- scopesystem/scope
systemPath${gae.home}/lib/impl/appengine-local-runtime.jar/systemPath
- /dependency dependency groupIdcom.google.appengine/groupId
artifactIdappengine-tools-api/artifactId
- version${gae.version}/version scopesystem/scope
systemPath${gae.home}/lib/appengine-tools-api.jar/systemPath
- /dependency --
!-- Objectify for persistence. It uses the stock javax.persistence
annotations --
@@ -181,7 +175,7 @@
build
!-- Generate compiled stuff in the folder used for developing mode --
-outputDirectorytarget/www/WEB-INF/classes/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/WEB-INF/classes/outputDirectory
plugins
!-- GWT Maven Plugin--
@@ -220,18 +214,14 @@
configuration
!-- URL that should be automatically opened in the GWT shell
(gwt:run). --
runTargetMobileWebApp.html/runTarget
- !-- Location of the develop-mode web application structure
(gwt:run). --
- hostedWebapptarget/www/hostedWebapp
!-- Ask GWT to create the Story of Your Compile (SOYC)
(gwt:compile) --
compileReporttrue/compileReport
modulecom.google.gwt.sample.mobilewebapp.MobileWebApp/module
-
appEngineVersion${gae.version}/appEngineVersion
appEngineHome${gae.home}/appEngineHome
logLevelINFO/logLevel
style${gwt.style}/style
-
hostedWebapp${project.build.directory}/${project.build.finalName}/hostedWebapp
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
copyWebapptrue/copyWebapp
/configuration
@@ -241,7 +231,7 @@
plugin
groupIdnet.kindleit/groupId
artifactIdmaven-gae-plugin/artifactId
-version0.8.0/version
+version0.8.1/version
executions
execution
id /
@@ -269,7 +259,7 @@
systemProperties
property
namegwt.args/name
- value-out target/www/value
+ value-out
${project.build.directory}/${project.build.finalName}/value
/property
/systemProperties
/configuration
@@ -312,7 +302,7 @@
goalcopy-resources/goal
/goals
configuration
- outputDirectorytarget/www/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/outputDirectory
resources
resource
directorysrc/main/webapp/directory
@@ -374,6 +364,19 @@
goals
goalunpack/goal
/goals
+ /pluginExecutionFilter
+ action
+execute /
+ /action
+/pluginExecution
+pluginExecution
+ pluginExecutionFilter
+groupIdorg.codehaus.mojo/groupId
+artifactIdexec-maven-plugin/artifactId
+versionRange[1.2,)/versionRange
+goals
+ goalexec/goal
+/goals
/pluginExecutionFilter
action
execute /
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Scripts and configuration to upload GWT bits to Maven repos (issue1520810)
Reviewers: rjrjr, drfibonacci, Description: Scripts and configuration to upload GWT bits to Maven repos - Removed now redundant maven_script.sh Please review this at http://gwt-code-reviews.appspot.com/1520810/ Affected files: A maven/poms/appengine/appengine-api-1.0-sdk/pom-template.xml A maven/poms/appengine/appengine-api-labs/pom-template.xml A maven/poms/appengine/appengine-api-stubs/pom-template.xml A maven/poms/appengine/appengine-java-sdk/pom-template.xml A maven/poms/appengine/appengine-jsr107cache/pom-template.xml A maven/poms/appengine/appengine-testing/pom-template.xml A maven/poms/appengine/appengine-tools-sdk/pom-template.xml A maven/poms/appengine/orm/datanucleus-appengine/pom-template.xml A maven/poms/appengine/orm/datanucleus-core/pom-template.xml A maven/poms/appengine/orm/datanucleus-jpa/pom-template.xml A maven/poms/appengine/orm/geronimo-jpa_3.0_spec/pom-template.xml A maven/poms/appengine/orm/geronimo-jta_1.1_spec/pom-template.xml A maven/poms/appengine/orm/jdo2-api/pom-template.xml A maven/poms/appengine/orm/pom-template.xml A maven/poms/appengine/pom-template.xml A maven/poms/gwt/gwt-dev/pom-template.xml A maven/poms/gwt/gwt-servlet/pom-template.xml A maven/poms/gwt/gwt-soyc-vis/pom-template.xml A maven/poms/gwt/gwt-user/pom-template.xml A maven/poms/gwt/pom-template.xml A maven/scripts/push-gae.sh A maven/scripts/push-gwt.sh D tools/scripts/maven_script.sh -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r10604 committed - Cherry picking r10603 into releases/2.4
Revision: 10604
Author: rchan...@google.com
Date: Wed Aug 31 10:56:17 2011
Log: Cherry picking r10603 into releases/2.4
http://code.google.com/p/google-web-toolkit/source/detail?r=10604
Modified:
/releases/2.4/samples/mobilewebapp/pom.xml
===
--- /releases/2.4/samples/mobilewebapp/pom.xml Thu Aug 25 10:06:37 2011
+++ /releases/2.4/samples/mobilewebapp/pom.xml Wed Aug 31 10:56:17 2011
@@ -18,7 +18,7 @@
maven.compiler.target1.6/maven.compiler.target
!-- GAE properties --
-gae.version1.5.0.1/gae.version
+gae.version1.5.3/gae.version
gae.home${user.home}/.m2/repository/com/google/appengine/appengine-java-sdk/${gae.version}/appengine-java-sdk-${gae.version}/gae.home
gae.application.version1/gae.application.version
@@ -130,12 +130,6 @@
artifactIdappengine-api-labs/artifactId
version${gae.version}/version
/dependency
-!-- uncomment for testing dependency
groupIdcom.google.appengine/groupId
- artifactIdappengine-local-runtime/artifactId
version${gae.version}/version
- scopesystem/scope
systemPath${gae.home}/lib/impl/appengine-local-runtime.jar/systemPath
- /dependency dependency groupIdcom.google.appengine/groupId
artifactIdappengine-tools-api/artifactId
- version${gae.version}/version scopesystem/scope
systemPath${gae.home}/lib/appengine-tools-api.jar/systemPath
- /dependency --
!-- Objectify for persistence. It uses the stock javax.persistence
annotations --
@@ -181,7 +175,7 @@
build
!-- Generate compiled stuff in the folder used for developing mode --
-outputDirectorytarget/www/WEB-INF/classes/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/WEB-INF/classes/outputDirectory
plugins
!-- GWT Maven Plugin--
@@ -220,18 +214,14 @@
configuration
!-- URL that should be automatically opened in the GWT shell
(gwt:run). --
runTargetMobileWebApp.html/runTarget
- !-- Location of the develop-mode web application structure
(gwt:run). --
- hostedWebapptarget/www/hostedWebapp
!-- Ask GWT to create the Story of Your Compile (SOYC)
(gwt:compile) --
compileReporttrue/compileReport
modulecom.google.gwt.sample.mobilewebapp.MobileWebApp/module
-
appEngineVersion${gae.version}/appEngineVersion
appEngineHome${gae.home}/appEngineHome
logLevelINFO/logLevel
style${gwt.style}/style
-
hostedWebapp${project.build.directory}/${project.build.finalName}/hostedWebapp
servercom.google.appengine.tools.development.gwt.AppEngineLauncher/server
copyWebapptrue/copyWebapp
/configuration
@@ -241,7 +231,7 @@
plugin
groupIdnet.kindleit/groupId
artifactIdmaven-gae-plugin/artifactId
-version0.8.0/version
+version0.8.1/version
executions
execution
id /
@@ -269,7 +259,7 @@
systemProperties
property
namegwt.args/name
- value-out target/www/value
+ value-out
${project.build.directory}/${project.build.finalName}/value
/property
/systemProperties
/configuration
@@ -312,7 +302,7 @@
goalcopy-resources/goal
/goals
configuration
- outputDirectorytarget/www/outputDirectory
+
outputDirectory${project.build.directory}/${project.build.finalName}/outputDirectory
resources
resource
directorysrc/main/webapp/directory
@@ -374,6 +364,19 @@
goals
goalunpack/goal
/goals
+ /pluginExecutionFilter
+ action
+execute /
+ /action
+/pluginExecution
+pluginExecution
+ pluginExecutionFilter
+groupIdorg.codehaus.mojo/groupId
+artifactIdexec-maven-plugin/artifactId
+versionRange[1.2,)/versionRange
+goals
+ goalexec/goal
+/goals
/pluginExecutionFilter
action
execute /
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)
Reviewers: knorton,
Description:
Update the missing plugin page to stop taunting Safari 5.1 users, and
suggest they try out OmniWeb.
Review by: knor...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1536803/
Affected files:
M plugins/MissingPlugin/war/MissingPlugin.html
Index: plugins/MissingPlugin/war/MissingPlugin.html
===
--- plugins/MissingPlugin/war/MissingPlugin.html(revision 10601)
+++ plugins/MissingPlugin/war/MissingPlugin.html(working copy)
@@ -107,6 +107,16 @@
url :
https://dl-ssl.google.com/gwt/plugins/safari/gwt-dev-plugin.dmg;,
platforms : Mac x86/x86_64/PPC,
supported : true
+ },
+
+ safari-mac-late :
+ {
+caption : Sorry, there is currently no GWT Developer Plugin
for Safari 5.1br
+ + or later (due to drastic changes in the Safari plugin
API). brbr
+ + In the meantime, OmniWeb 5.11 is similar to Safari 5.0
and br
+ + known to work,
+url : troubleshootingUrl,
+supported : false
}
}
};
@@ -122,6 +132,11 @@
id = 'chrome';
} else if (ua.indexOf(macintosh) != -1) {
id = 'safari-mac';
+
+ var version = ua.substring(ua.indexOf(applewebkit/)
+ applewebkit/.length).split(.);
+ if (Number(version[0]) 533) {
+id = 'safari-mac-late';
+ }
} else if (ua.indexOf(windows) != -1) {
id = 'safari-win';
}
@@ -153,4 +168,3 @@
/noscript
/body
/html
-
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)
http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update the missing plugin page to stop taunting Safari 5.1 users, and (issue1536803)
http://gwt-code-reviews.appspot.com/1536803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)
http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)
On 2011/09/01 00:10:12, zhuyi wrote: Hi Stephen, I've integrated your changes, also synced the changes. Sorry for the delay. Could you please review it? Thanks. Yi http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml
File user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml#newcode18
user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml:18: --
This comments seems like copy/paste from another gwt.xml file.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFieldsFalseNoWarn.gwt.xml
File
user/src/com/google/gwt/user/RemoteServiceFinalFieldsFalseNoWarn.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFieldsFalseNoWarn.gwt.xml#newcode18
user/src/com/google/gwt/user/RemoteServiceFinalFieldsFalseNoWarn.gwt.xml:18:
--
Another comment that should be removed (or updated).
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode617
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:617:
== Shared.SerializeFinalFieldsOptions.FALSE) {
I was really confused why this was == FALSE instead of != TRUE.
If the setting is FALSE and the field is not returned, then shouldn't
FALSE_NOWARN also mean that the field should be not returned? Seems
like they should be consistent.
It turns on this is broken--because you changed the server-side
signature to always include final fields, final fields always need to be
returned from this method.
(You correctly changed FieldSerializerCreator to re-check this setting
before writing out the field-setting code.)
It would be nice if FALSE|FALSE_NOWARN were set, then fields weren't
ever returned, but since the server-side type signature checker doesn't
have access to the type oracle settings to conditionally build its
signature, I don't see a better way.
Note that I found this by adding a FinalFieldsFalseTest--you add a
FinalFieldsTest and FinalFieldsFalseNoWarn (which worked because the
check above was == FALSE), but if you add a FinalFieldsFalseTest, the ==
FALSE check above kicks in, and then the signature check will fail.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode621
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:621:
* If the type has a custom seriaherelizer, assume the programmer knows
Looks like here got pasted into the middle serializer. :-)
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/Shared.java
File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode60
user/src/com/google/gwt/user/rebind/rpc/Shared.java:60: private static
SerializeFinalFieldsOptions serializeFinalFieldsValue;
This static field should be removed, it's not needed.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode108
user/src/com/google/gwt/user/rebind/rpc/Shared.java:108:
SerializeFinalFieldsOptions.valueOf(serializeFinalFieldsStringValue);
Just return the valueOf result instead of assigning it to the static
field, and then returning the static field.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode250
user/src/com/google/gwt/user/rebind/rpc/Shared.java:250: return propVal;
I would just return prop.getCurrentValue() instead of making an
otherwise unused propVal local variable.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
File
user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
(right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java#newcode405
user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java:405:
static boolean isNotStaticTransientOrEnum(Field field) {
The old isNonStaticTransientOrFinal method isn't called anymore so can
be removed since you added this one.
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java
File
user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java
(right):
http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java#newcode27
user/test/com/google/gwt/user/client/rpc/FinalFieldsTestFalseNoWarn.java:27:
public class
[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)
I've integrated your changes, also synced the changes. Thanks! Could you please review it? Sure. I understand a bit more about how it works now. Previously, the server-side ignored all final fields. You understandably had to change that, but since the server-side doesn't have access to the type oracle's rpc.final.serialize property, it *always* expects final fields. So, final fields are now always in the signatures, payloads, etc., and the FALSE FALSE_NOWARN behavior is implemented merely by skipping the setXxx call in FieldSerializerCreator. However, since that is only for the client-side, the server-side now always sets final fields, regardless of the rpc.final.serialize value. See this failing assertion: https://github.com/stephenh/scalagwt-gwt/commit/41abe191926ba31b7634f529f1ac8d455e729fe9#L3R52 Previously the server-side would have called the no-arg cstr (which assigns 5) and then done nothing else. So technically this is a breaking change. Is this intentional? That finals are always sent over the wire? It seems like making the server-side aware of the rpc.final.serialize value would be better, perhaps by putting it in the serialization policy file? Then it could know when it should/should not use final fields. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
