[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 5: Matthew: can I go ahead and merge? Any blocker on Google's side? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
Can someone move that patch over to Gerrit? Would you prefer that I do it? (BTW, any reason this hadn't been reviewed yet?) http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add HasPaths interface.
Jens Nehlmeier has posted comments on this change. Change subject: Add HasPaths interface. .. Patch Set 2: LGTM, although I don't get why all these feature interfaces like HasRequestContext, HasEditorErrors and now HasPaths need to extend Editor. It gets more awkward the more you have of them. Whats the point of PersonEditor extends Widget implements HasRequestContextPersonProxy, HasEditorErrorsPersonProxy, HasPathsPersonProxy Thats not very DRY (sure the example is the worst case), given the fact that the feature interfaces do not depend on PersonProxy. I would always prefer: PersonEditor implements EditorPersonProxy, HasRequestContext, HasEditorErrors, HasPaths. So maybe we should not follow this concept and make HasPath do not extend Editor. -- To view, visit https://gwt-review.googlesource.com/3185 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f259552d945bf22592c4395e3c7b2ad45bfe93c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
..
Patch Set 9:
(4 comments)
File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
I don't think its a good idea, since with this we would have to do
something like:
if(!isNaN(x) !isNaN(y)) {
// do normal stuff
}else{
//test again
}
If we want to change this, we should also change this in Double.compare
(its implemented the same way)
File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
I dont really understand what the difference would be between prod vs. dev
if we do not use x-y. Correct me if I am wrong but one should never rely on
the exact value returned from compare.
File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81: }
In JavaScript something like this passes:
assertEquals(0, Float.compare(0.0f, -0.0f));
While it does not pass in Java. Do we want to make sure we cover this
corner case (as well as others) and take the performance hit?
Not sure here. Could we just cover this in the docs of the JRE Emulation?
File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
We actually look terrible at the Borders:
This will just fail:
Integer.compare(Integer.MAX_VALUE, Integer.MIN_VALUE) 0
since we do not got overflow for ints in javascript.
I am not sure how to handle such corner cases, do we want to handle them,
any input?
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has uploaded a new change for review. https://gwt-review.googlesource.com/3210 Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. This patch adds Map support to RequestFactory (see https://code.google.com/p/google-web-toolkit/issues/detail?id=5524) There's a lot of existing discussion on the patch at https://codereview.appspot.com/6132056/. From looking back over that discussion the main user facing design decision to call out which isn't just what someone might expect from Map support is that referencing child complex types in keys and values is done using .with(someMap.keys.property, someMap.values.property ) Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b --- M user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java M user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java M user/src/com/google/web/bindery/requestfactory/server/Resolver.java A user/src/com/google/web/bindery/requestfactory/server/Resolver.java.orig M user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java A user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java.orig M user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java A user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java.orig M user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.orig A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.rej M user/src/com/google/web/bindery/requestfactory/shared/impl/EntityCodex.java M user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java M user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java M user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.orig A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.rej A user/test/com/google/web/bindery/requestfactory/server/MapKey.java A user/test/com/google/web/bindery/requestfactory/server/MapValue.java M user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java A user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java.orig M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyRequest.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueRequest.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleBarProxy.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleRequestFactory.java 28 files changed, 7,973 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: James could you submit a new patch set without files *.rej and *.orig -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Ick sorry. Will submit a new patch. Should just discard this one or update it? -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Map support to RequestFactory (see https://code.google....
James Horsley has uploaded a new change for review.
https://gwt-review.googlesource.com/3186
Change subject: Adds Map support to RequestFactory (see
https://code.google.com/p/google-web-toolkit/issues/detail?id=5524)
..
Adds Map support to RequestFactory (see
https://code.google.com/p/google-web-toolkit/issues/detail?id=5524)
This is a port of an existing svn patch
https://codereview.appspot.com/6132056/
onto the new git repo to work with gerrit.
There's a lot of existing discussion on the patch at
https://codereview.appspot.com/6132056/. From looking back over that
discussion
the main user facing design decision to call out which isn't just what
someone
might expect from Map support is that referencing child complex types in
keys
and values is done using .with(someMap.keys.property,
someMap.values.property )
Change-Id: I6dd3c8a9862473954a72ccee96212c20d9198b22
---
M
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
M
user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
M user/src/com/google/web/bindery/requestfactory/server/Resolver.java
M
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
M
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/EntityCodex.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
A user/test/com/google/web/bindery/requestfactory/server/MapKey.java
A user/test/com/google/web/bindery/requestfactory/server/MapValue.java
M user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java
M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java
A user/test/com/google/web/bindery/requestfactory/shared/MapKeyProxy.java
A user/test/com/google/web/bindery/requestfactory/shared/MapKeyRequest.java
A user/test/com/google/web/bindery/requestfactory/shared/MapValueProxy.java
A
user/test/com/google/web/bindery/requestfactory/shared/MapValueRequest.java
M user/test/com/google/web/bindery/requestfactory/shared/SimpleBarProxy.java
M
user/test/com/google/web/bindery/requestfactory/shared/SimpleRequestFactory.java
20 files changed, 897 insertions(+), 46 deletions(-)
diff --git
a/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
b/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
index dd1f28c..2eac320 100644
---
a/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
+++
b/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
@@ -17,6 +17,7 @@
import java.util.Collection;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import javax.lang.model.element.ElementKind;
@@ -99,6 +100,12 @@
TypeMirror param = convertSingleParamType(x,
state.findType(Collection.class), 0, state);
return state.types.getDeclaredType((TypeElement)
state.types.asElement(x), param);
}
+if (state.types.isAssignable(x, state.findType(Map.class))) {
+ // Convert MapString,FooProxy to MapString,FooDomain
+ TypeMirror keyParam = convertSingleParamType(x,
state.findType(Map.class), 0, state);
+ TypeMirror valueParam = convertSingleParamType(x,
state.findType(Map.class), 1, state);
+ return state.types.getDeclaredType((TypeElement)
state.types.asElement(x), keyParam, valueParam);
+}
return defaultAction(x, state);
}
diff --git
a/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
b/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
index 9d47dd1..8663ad5 100644
---
a/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
+++
b/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
@@ -17,6 +17,7 @@
import java.util.Collection;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import javax.lang.model.element.ElementKind;
@@ -77,6 +78,19 @@
}
return t.getTypeArguments().get(0).accept(this, state);
}
+if (state.types.isAssignable(t, state.findType(Map.class))) {
+ if (!allowNestedParameterization) {
+return false;
+ }
+ allowNestedParameterization = false;
+ DeclaredType asMap =
+ (DeclaredType) State.viewAs(state.findType(Map.class), t, state);
+ if (asMap.getTypeArguments().isEmpty()) {
+return false;
+ }
+ return t.getTypeArguments().get(0).accept(this, state)
+ t.getTypeArguments().get(1).accept(this,
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has abandoned this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Abandoned Contains unintended .orig and .rej files. Resubmitted with https://gwt-review.googlesource.com/#/c/3186/ -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Actually you could have submitted a new patch set to this issue instead of abandoning it and opening a new one. git commit --amend -a git push origin HEAD:refs/for/master But it's ok a new one as well. -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Will remember for next time. Thanks! -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT style: Trailing spaces
Hi All, This thread is to continue a conversation in gerrit [1] about trailing spaces at the end of lines. GWT convention is not to leave spaces at the end of lines, but some IDEs add them by default like Eclipse in empty javadoc lines. Maybe we want to relax this rule, or perhaps we could remove this warning from gerrit, I think it's a bit upsetting seeing those spaces in red. - Manolo [1] https://gwt-review.googlesource.com/#/c/1031/1/dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
..
Patch Set 9:
(4 comments)
File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
Why do you need to do something like that?
Following should work fine:
// All these checks should be false if x or y isNaN
if(x y) return -1;
if(x y) return 1;
if(x == y) return 0;
// below same isNaN check as before
if( isNaN(x) )
File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
One should never rely on it for sure, but if somehow they rely on it, it
will work or fail consistently in both production and dev mode (i.e. less
surprises).
In general, it is best to not diverge prod vs dev if there is no good
reason to do so (like a big performance hit).
File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81: }
I guess there is no -0 in js and in that case there is not much to do,
On the other hand, I'm not very familiar how we handle numerical difference
in js vs java. Thomas? John?
File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
I think we need to but we can create a bug and defer it to another time.
John Thomas, any input here?
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
On 2013/06/04 09:01:51, tbroyer wrote: Can someone move that patch over to Gerrit? Would you prefer that I do it? (BTW, any reason this hadn't been reviewed yet?) No particular reason other than it dropping off the radar with other stuff going on. Of course we will want unit tests for this. http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
Please go ahead and move it, but with a couple of team members away we probably won't get to it this week. http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] GWT style: Trailing spaces
In Eclipse, I use auto-format on save for edited lines. If it is a javadoc, it forces you to use correct javadoc tags however for regular multiine comments if you do some ascii art, then auto-format can mess it up. In those cases, I simply press Ctrl+Z which just reverts the last auto-format. It is not ideal but it is reasonable to work with for me. On Tue, Jun 4, 2013 at 11:23 AM, Manuel Carrasco Moñino man...@apache.orgwrote: Hi All, This thread is to continue a conversation in gerrit [1] about trailing spaces at the end of lines. GWT convention is not to leave spaces at the end of lines, but some IDEs add them by default like Eclipse in empty javadoc lines. Maybe we want to relax this rule, or perhaps we could remove this warning from gerrit, I think it's a bit upsetting seeing those spaces in red. - Manolo [1] https://gwt-review.googlesource.com/#/c/1031/1/dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Hello John A. Tamplin, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3184 to look at the new patch set (#7). Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 --- M user/super/com/google/gwt/emul/java/util/Arrays.java A user/super/com/google/gwt/emul/java/util/Objects.java M user/test/com/google/gwt/emultest/EmulSuite.java A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java 4 files changed, 213 insertions(+), 58 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(2 comments)
File user/super/com/google/gwt/emul/java/util/Arrays.java
Line 414: static boolean deepEquals0(Object obj1, Object obj2) {
Done
Line 414: static boolean deepEquals0(Object obj1, Object obj2) {
Done
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
John A. Tamplin has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 7: (2 comments) LGTM with a couple of nits. File user/super/com/google/gwt/emul/java/util/Objects.java Line 2: * Copyright 2008 Google Inc. Copyright date is wrong again. File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java Line 2: * Copyright 2008 Google Inc. Copyright date. -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has posted comments on this change.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Patch Set 2:
(1 comment)
File user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
Line 375: public void testKeyDownEvent() {
Done. (added a reference to the issue)
--
To view, visit https://gwt-review.googlesource.com/3141
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Hello Leeroy Jenkins, Thomas Broyer, Patrick Tucker, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3141 to look at the new patch set (#3). Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Removes delegation of event from TextBox event handler inside SuggestBox. The events are already fired in SuggestBox as it is a composite, additional delegation was causing events to be fired twice. Bug: Issue 3533 Original author: Patrick Tucker Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Review-Link: https://gwt-review.googlesource.com/#/c/3141/ --- M user/src/com/google/gwt/user/client/ui/SuggestBox.java M user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java 2 files changed, 44 insertions(+), 10 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3141 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert Adds onEnsureDebugId delegation to Composite.
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Revert Adds onEnsureDebugId delegation to Composite.
..
Revert Adds onEnsureDebugId delegation to Composite.
This reverts commit ff027f069482154b94c5b17434824992017d0f23
Change-Id: Id162c4e9b553a5981f09d26a3d1112dbf085825e
---
M user/src/com/google/gwt/user/client/ui/Composite.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/Composite.java
b/user/src/com/google/gwt/user/client/ui/Composite.java
index 8faab75..257832d 100644
--- a/user/src/com/google/gwt/user/client/ui/Composite.java
+++ b/user/src/com/google/gwt/user/client/ui/Composite.java
@@ -184,11 +184,6 @@
widget.onDetach();
}
}
-
- @Override
- protected void onEnsureDebugId(String baseID) {
-widget.onEnsureDebugId(baseID);
- }
@Override
protected Element resolvePotentialElement() {
--
To view, visit https://gwt-review.googlesource.com/3151
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id162c4e9b553a5981f09d26a3d1112dbf085825e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Removes delegation of event from TextBox event handler inside SuggestBox.
The events are already fired in SuggestBox as it is a composite, additional
delegation was causing events to be fired twice.
Bug: Issue 3533
Original author: Patrick Tucker
Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8
Review-Link: https://gwt-review.googlesource.com/#/c/3141/
---
M user/src/com/google/gwt/user/client/ui/SuggestBox.java
M user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
2 files changed, 44 insertions(+), 10 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/SuggestBox.java
b/user/src/com/google/gwt/user/client/ui/SuggestBox.java
index 818e9b2..7d87fb2 100644
--- a/user/src/com/google/gwt/user/client/ui/SuggestBox.java
+++ b/user/src/com/google/gwt/user/client/ui/SuggestBox.java
@@ -21,7 +21,6 @@
import com.google.gwt.editor.client.IsEditor;
import com.google.gwt.editor.client.LeafValueEditor;
import com.google.gwt.editor.client.adapters.TakesValueEditor;
-import com.google.gwt.event.dom.client.HandlesAllKeyEvents;
import com.google.gwt.event.dom.client.HasAllKeyHandlers;
import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyDownEvent;
@@ -1119,8 +1118,7 @@
}
private void addEventsToTextBox() {
-class TextBoxEvents extends HandlesAllKeyEvents implements
-ValueChangeHandlerString {
+class TextBoxEvents implements KeyDownHandler, KeyUpHandler,
ValueChangeHandlerString {
public void onKeyDown(KeyDownEvent event) {
switch (event.getNativeKeyCode()) {
@@ -1140,17 +1138,11 @@
}
break;
}
-delegateEvent(SuggestBox.this, event);
- }
-
- public void onKeyPress(KeyPressEvent event) {
-delegateEvent(SuggestBox.this, event);
}
public void onKeyUp(KeyUpEvent event) {
// After every user key input, refresh the popup's suggestions.
refreshSuggestions();
-delegateEvent(SuggestBox.this, event);
}
public void onValueChange(ValueChangeEventString event) {
@@ -1159,7 +1151,8 @@
}
TextBoxEvents events = new TextBoxEvents();
-events.addKeyHandlersTo(box);
+box.addKeyDownHandler(events);
+box.addKeyUpHandler(events);
box.addValueChangeHandler(events);
}
diff --git a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
index 503c96e..cbb0e1b 100644
--- a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
@@ -17,6 +17,11 @@
import com.google.gwt.dom.client.Document;
import com.google.gwt.dom.client.Element;
+import com.google.gwt.dom.client.NativeEvent;
+import com.google.gwt.event.dom.client.KeyDownEvent;
+import com.google.gwt.event.dom.client.KeyDownHandler;
+import com.google.gwt.event.dom.client.KeyUpEvent;
+import com.google.gwt.event.dom.client.KeyUpHandler;
import
com.google.gwt.user.client.ui.MultiWordSuggestOracle.MultiWordSuggestion;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
import com.google.gwt.user.client.ui.SuggestBox.SuggestionCallback;
@@ -367,6 +372,42 @@
assertTrue(b.getParent() == box);
}
+ /**
+ * See https://code.google.com/p/google-web-toolkit/issues/detail?id=3533
+ */
+ public void testKeyDownEvent() {
+final int[] eventFireCount = {0};
+SuggestBox box = new SuggestBox();
+RootPanel.get().add(box);
+box.addKeyDownHandler(new KeyDownHandler() {
+ @Override
+ public void onKeyDown(KeyDownEvent event) {
+eventFireCount[0]++;
+ }
+});
+NativeEvent e = Document.get().createKeyDownEvent(false, false, false,
false, 'g');
+box.getElement().dispatchEvent(e);
+assertEquals(1, eventFireCount[0]);
+ }
+
+ /**
+ * See https://code.google.com/p/google-web-toolkit/issues/detail?id=3533
+ */
+ public void testKeyUpEvent() {
+final int[] eventFireCount = {0};
+SuggestBox box = new SuggestBox();
+RootPanel.get().add(box);
+box.addKeyUpHandler(new KeyUpHandler() {
+ @Override
+ public void onKeyUp(KeyUpEvent event) {
+eventFireCount[0]++;
+ }
+});
+NativeEvent e = Document.get().createKeyUpEvent(false, false, false,
false, 'g');
+box.getElement().dispatchEvent(e);
+assertEquals(1, eventFireCount[0]);
+ }
+
protected SuggestBox createSuggestBox() {
MultiWordSuggestOracle oracle = createOracle();
return new SuggestBox(oracle, new TextBox(), new
TestSuggestionDisplay());
--
To view, visit
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has posted comments on this change. Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Patch Set 3: Code-Review+2 (Just added a reference to issue after last patch) -- To view, visit https://gwt-review.googlesource.com/3141 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes JRawType#getImplementedMethods to return correct signa...
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3230
Change subject: Fixes JRawType#getImplementedMethods to return correct
signature for inherited methods
..
Fixes JRawType#getImplementedMethods to return correct signature for
inherited methods
Original author forgot to override some methods which was causing
getImplementedMethods
to not erase the types for the methods inherited from superclasses.
Bugs: Issue 8177
Change-Id: I7e2c4cf3d2d0bc1e50ecab1e257a6ac1d0e496d0
---
M dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
M dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
M dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
A dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
4 files changed, 53 insertions(+), 3 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
b/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
index 83700ef..bdbe1a0 100644
--- a/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
+++ b/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
@@ -22,5 +22,10 @@
JParameterizedType asParameterizedByWildcards();
+ /**
+ * Returns the raw type for this generic type. The raw type removes
all 'generics' information
+ * from the class. i.e. {@code void a1(ListT)} {@code void
a2(ListString)} becomes
+ * {@code void a1(List)} {@code void a2(List))} respectively.
+ */
JRawType getRawType();
}
diff --git a/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
b/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
index 477..585cb7f 100644
--- a/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
+++ b/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
@@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.List;
+import java.util.Map;
/**
* Represents a raw type; that is a generic type with no type arguments.
@@ -104,6 +105,18 @@
}
@Override
+ protected void getInheritableMethodsOnSuperclassesAndThisClass(
+ MapString, JMethod methodsBySignature) {
+
members.getInheritableMethodsOnSuperclassesAndThisClass(methodsBySignature);
+ }
+
+ @Override
+ protected void
getInheritableMethodsOnSuperinterfacesAndMaybeThisInterface(
+ MapString, JMethod methodsBySignature) {
+
members.getInheritableMethodsOnSuperinterfacesAndMaybeThisInterface(methodsBySignature);
+ }
+
+ @Override
public JMethod[] getInheritableMethods() {
return members.getInheritableMethods();
}
diff --git
a/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
b/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
index 919ee08..072e64e 100644
--- a/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
+++ b/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
@@ -18,6 +18,7 @@
import com.google.gwt.core.ext.TreeLogger;
import com.google.gwt.core.ext.UnableToCompleteException;
import com.google.gwt.core.ext.typeinfo.NotFoundException;
+import com.google.gwt.dev.javac.typemodel.test.MyArrayList;
import com.google.gwt.dev.javac.typemodel.test.MyCustomList;
import com.google.gwt.dev.javac.typemodel.test.MyIntegerList;
import com.google.gwt.dev.javac.typemodel.test.MyList;
@@ -49,8 +50,25 @@
}
@Override
- public void testGetInheritableMethods() {
-// TODO Auto-generated method stub
+ public void testGetInheritableMethods() throws NotFoundException {
+JMethod addMethod = null;
+JMethod indexedAddMethod = null;
+for (JMethod jMethod : getTestType().getInheritableMethods()) {
+ if (jMethod.getName().equals(add)) {
+if (jMethod.getParameters().length == 1) {
+ assertNull(addMethod);
+ addMethod = jMethod;
+} else {
+ assertEquals(2, jMethod.getParameters().length);
+ assertNull(indexedAddMethod);
+ indexedAddMethod = jMethod;
+}
+ }
+}
+
+JClassType javaLangObject =
moduleContext.getOracle().getJavaLangObject();
+assertEquals(javaLangObject, addMethod.getParameters()[0].getType());
+assertEquals(javaLangObject,
indexedAddMethod.getParameters()[1].getType());
}
@Override
@@ -111,7 +129,7 @@
@Override
protected JRawType getTestType() throws NotFoundException {
TypeOracle oracle = moduleContext.getOracle();
-JClassType testType = oracle.getType(ArrayList.class.getName());
+JClassType testType = oracle.getType(MyArrayList.class.getName());
return testType.isGenericType().getRawType();
}
}
diff --git
a/dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
b/dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
new file mode 100644
index 000..26a5756
--- /dev/null
+++
